From unknown Sat Jun 21 03:25:45 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70338 <70338@debbugs.gnu.org> To: bug#70338 <70338@debbugs.gnu.org> Subject: Status: message-fcc-externalize-attachments has no effect Reply-To: bug#70338 <70338@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:25:45 +0000 retitle 70338 message-fcc-externalize-attachments has no effect reassign 70338 emacs submitter 70338 Nicolas Graner severity 70338 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 08:39:37 2024 Received: (at submit) by debbugs.gnu.org; 11 Apr 2024 12:39:37 +0000 Received: from localhost ([127.0.0.1]:55181 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rutiL-0004NZ-H8 for submit@debbugs.gnu.org; Thu, 11 Apr 2024 08:39:37 -0400 Received: from lists.gnu.org ([2001:470:142::17]:34356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rutiF-0004Lk-MB for submit@debbugs.gnu.org; Thu, 11 Apr 2024 08:39:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruti0-0004tC-RV for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2024 08:39:16 -0400 Received: from ns1.ouvaton.coop ([194.36.166.20] helo=smtp.ouvaton.coop) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruthy-0003Wu-O3 for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2024 08:39:16 -0400 Received: from hypra-graner (unknown [193.55.29.174]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ouvalternc.octopuce.fr (Postfix) with ESMTPSA id A60FE23D38 for ; Thu, 11 Apr 2024 14:39:10 +0200 (CEST) From: Nicolas Graner To: bug-gnu-emacs@gnu.org Subject: message-fcc-externalize-attachments has no effect Date: Thu, 11 Apr 2024 14:39:12 +0200 Message-ID: <8634rs6plb.fsf@graner.name> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=194.36.166.20; envelope-from=nicolas@graner.name; helo=smtp.ouvaton.coop X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) The variable message-fcc-externalize-attachments seems to have no effect (tested in emacs 30.0.50). Whether I set it to t or nil, whenever I send a mail message with a file attached, the file is included as an internal message part in the FCC mailbox. I am not sure if this is a bug or if I am missing something, such as another variable that interferes with this one. Nicolas From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 18 06:13:50 2024 Received: (at 70338) by debbugs.gnu.org; 18 Apr 2024 10:13:52 +0000 Received: from localhost ([127.0.0.1]:51498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxOlp-00076v-Nh for submit@debbugs.gnu.org; Thu, 18 Apr 2024 06:13:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxOkh-0006zK-VK for 70338@debbugs.gnu.org; Thu, 18 Apr 2024 06:12:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxOkL-0004xT-LY; Thu, 18 Apr 2024 06:12:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Wb06qq2rQx/Rk48GJGuMmX4cFOUK9XBLz/tUlC0nC3Y=; b=omiVDVxz9+Vq AqwYZgTumabk4tOBgTWKGZtkhteEoR3PNmPXPoIDohYOREVCEuzVUAPlZ/edX6x6YDHaqQXOWMB+h OKxWbV6ksvIYSH6Rgp8UpUPkryH631IRWBtfwvCarlET17R1qCvuDqug8WG3y3ILDJDPg1oh8GvjZ YYKzz05iPL2N1LmrBa4MNsO57dX1ImCo7/qmCLfEbQ+BQkQwGAVB+zxxyPd+Hq+cBhtCCNELQrUeE QsgvaMOdTvvvnf22wISY2W3VbJ6jslxx3AHCs9RFiIIHWuKIzifkwZ2nwgH8vISoxGamnCqEBLmKl 6l6Qe9icxBGmH3yjhXdRjQ==; Date: Thu, 18 Apr 2024 13:11:57 +0300 Message-Id: <86y19bdloy.fsf@gnu.org> From: Eli Zaretskii To: Nicolas Graner , eric@ericabrahamsen.net In-Reply-To: <8634rs6plb.fsf@graner.name> (message from Nicolas Graner on Thu, 11 Apr 2024 14:39:12 +0200) Subject: Re: bug#70338: message-fcc-externalize-attachments has no effect References: <8634rs6plb.fsf@graner.name> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70338 Cc: 70338@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Nicolas Graner > Date: Thu, 11 Apr 2024 14:39:12 +0200 > > The variable message-fcc-externalize-attachments seems to have no effect > (tested in emacs 30.0.50). Whether I set it to t or nil, whenever I send > a mail message with a file attached, the file is included as an internal > message part in the FCC mailbox. > > I am not sure if this is a bug or if I am missing something, such as > another variable that interferes with this one. Eric, can you please look into this? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 11:37:05 2024 Received: (at 70338) by debbugs.gnu.org; 20 Apr 2024 15:37:05 +0000 Received: from localhost ([127.0.0.1]:36869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryCm1-0004sd-Au for submit@debbugs.gnu.org; Sat, 20 Apr 2024 11:37:05 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:39814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryClz-0004rS-M3 for 70338@debbugs.gnu.org; Sat, 20 Apr 2024 11:37:04 -0400 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id BC42EFA059; Sat, 20 Apr 2024 15:36:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1713627402; bh=03Bevmi9j/dHMswt4jQ+fFwpKGsEsexk6dzu4KgtO9U=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=wRjz5ICzkYzSjZ0Txtg4aTmzaRnmtS9IChtLqkbQnBENz6Fap1XBipycxI9aQievD CotrEfDhUHQF/k8ZsY2obw/Di8B9nEmcuv3V4lwYKqPaNiwFnuvRGeU7Cwp3e0kzOq bpy2ZdViLOV4F1oL3Y6pxDx/ZgYPenO7qh4uPxwg= From: Eric Abrahamsen To: Eli Zaretskii Subject: Re: bug#70338: message-fcc-externalize-attachments has no effect In-Reply-To: <86y19bdloy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Apr 2024 13:11:57 +0300") References: <8634rs6plb.fsf@graner.name> <86y19bdloy.fsf@gnu.org> Date: Sat, 20 Apr 2024 08:36:40 -0700 Message-ID: <87y198hwqf.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70338 Cc: 70338@debbugs.gnu.org, Nicolas Graner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 04/18/24 13:11 PM, Eli Zaretskii wrote: >> From: Nicolas Graner >> Date: Thu, 11 Apr 2024 14:39:12 +0200 >> >> The variable message-fcc-externalize-attachments seems to have no effect >> (tested in emacs 30.0.50). Whether I set it to t or nil, whenever I send >> a mail message with a file attached, the file is included as an internal >> message part in the FCC mailbox. >> >> I am not sure if this is a bug or if I am missing something, such as >> another variable that interferes with this one. > > Eric, can you please look into this? I'm trying to figure out what "externalization" is actually supposed to do. So far I don't see that this option would actually do anything in an FCC context. `message-fcc-externalize-attachments' is only used in `message-do-fcc`, where its value is let-bound to `mml-externalize-attachments'. But `mml-externalize-attachments' is only consulted in `gnus-inews-do-gcc', which already doesn't sound very promising. That function first let-binds `mml-externalize-attachments' to nil, before doing its own setting, so any dynamic value is getting overridden anyway. I tried starting with `gnus-gcc-externalize-attachments' and sending a message with an attachment, just to see how it's supposed to work. Nothing seemed to happen. Can you tell me what the desired effect is supposed to be? Does the "gcc" version of this option work for you? Eric From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 12:20:52 2024 Received: (at 70338) by debbugs.gnu.org; 20 Apr 2024 16:20:53 +0000 Received: from localhost ([127.0.0.1]:37054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryDSN-0000wH-Vj for submit@debbugs.gnu.org; Sat, 20 Apr 2024 12:20:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryDSB-0000ti-DO for 70338@debbugs.gnu.org; Sat, 20 Apr 2024 12:20:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryDRn-0001UF-TF; Sat, 20 Apr 2024 12:20:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YOWs7hddzAidYeVbm03KEM4W8zOtESUy6pCTdS4q6Qg=; b=gUAKMla7xwMT sv3laZUnfPr6G/sk3pAPbBy4mUiynPQ0RkyKsijXJGfOyKGYVt/ceZZ4MsCMmORdy7cQST0A4A8PF 0wt92gUHidDzOpI8JEqk5+fpC3PqEEdwERGpL+YpLAda4FH8ga0hZ04/+IpP8zC085vAiLjW4Nmhw urDzp5tiKtgEt/BKurIHjpVExvtHqmuWzHklZEr1Ql/hpO2RCDawnknLKcCsjm2HxURYVEAKMOfVd 3Kngrs7M1OHxeLMDGhDw/wE0wJCcbiOohEgjgWLbi615v8Luq4MphQcIpFOwd/YYNEdp1B0TuFWf2 M16s1CzKNpSa4ekIQ3DJ7A==; Date: Sat, 20 Apr 2024 19:20:09 +0300 Message-Id: <86le5880qu.fsf@gnu.org> From: Eli Zaretskii To: nicolas@graner.name, Eric Abrahamsen In-Reply-To: <87y198hwqf.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Sat, 20 Apr 2024 08:36:40 -0700) Subject: Re: bug#70338: message-fcc-externalize-attachments has no effect References: <8634rs6plb.fsf@graner.name> <86y19bdloy.fsf@gnu.org> <87y198hwqf.fsf@ericabrahamsen.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70338 Cc: 70338@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Eric Abrahamsen > Cc: Nicolas Graner , 70338@debbugs.gnu.org > Date: Sat, 20 Apr 2024 08:36:40 -0700 > > Can you tell me what the desired effect is supposed to be? Does the > "gcc" version of this option work for you? I guess you are asking Nicolas, not me? Because I don't use these features (and don't use message.el at all). Nicolas, can you please answer Eric's question? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 12:22:59 2024 Received: (at 70338) by debbugs.gnu.org; 20 Apr 2024 16:22:59 +0000 Received: from localhost ([127.0.0.1]:37069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryDUR-0001B2-3x for submit@debbugs.gnu.org; Sat, 20 Apr 2024 12:22:59 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:51770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryDUP-0001Ag-2Q for 70338@debbugs.gnu.org; Sat, 20 Apr 2024 12:22:58 -0400 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 74A02FA059; Sat, 20 Apr 2024 16:22:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1713630156; bh=2J7VW4szJ5yqG2AhljuTQvINMaFFU7f444BVyabfOlM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tv8miYBmktiZwisSRgIDT9nQZMcstYsYgsjQhlmr0J/am/9lqMnT3wWmyfTG2NTIC QGpGGupThRLbc9CCoy6vja02xBkvVm3zHOK2mymlGr7ssv7kN8dpfqBH2o9FVVz6yG d0Ty4IIAoehIZ599UDridxrInXjb2IYovN7a6SyE= From: Eric Abrahamsen To: Eli Zaretskii Subject: Re: bug#70338: message-fcc-externalize-attachments has no effect In-Reply-To: <86le5880qu.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 20 Apr 2024 19:20:09 +0300") References: <8634rs6plb.fsf@graner.name> <86y19bdloy.fsf@gnu.org> <87y198hwqf.fsf@ericabrahamsen.net> <86le5880qu.fsf@gnu.org> Date: Sat, 20 Apr 2024 09:22:34 -0700 Message-ID: <87h6fwhulx.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70338 Cc: 70338@debbugs.gnu.org, nicolas@graner.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Eric Abrahamsen >> Cc: Nicolas Graner , 70338@debbugs.gnu.org >> Date: Sat, 20 Apr 2024 08:36:40 -0700 >> >> Can you tell me what the desired effect is supposed to be? Does the >> "gcc" version of this option work for you? > > I guess you are asking Nicolas, not me? Because I don't use these > features (and don't use message.el at all). > > Nicolas, can you please answer Eric's question? Yes, sorry, that was aimed at Nicolas. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 13:29:47 2024 Received: (at 70338) by debbugs.gnu.org; 20 Apr 2024 17:29:47 +0000 Received: from localhost ([127.0.0.1]:37323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryEX5-0000Y7-A2 for submit@debbugs.gnu.org; Sat, 20 Apr 2024 13:29:47 -0400 Received: from ns1.ouvaton.coop ([194.36.166.20]:40989 helo=smtp.ouvaton.coop) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryEX0-0000XC-S5 for 70338@debbugs.gnu.org; Sat, 20 Apr 2024 13:29:46 -0400 Received: from hypra-graner (lfbn-idf2-1-328-90.w82-123.abo.wanadoo.fr [82.123.48.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ouvalternc.octopuce.fr (Postfix) with ESMTPSA id 0A10D562E2; Sat, 20 Apr 2024 19:29:25 +0200 (CEST) From: Nicolas Graner To: Eric Abrahamsen Subject: Re: bug#70338: message-fcc-externalize-attachments has no effect In-Reply-To: <87y198hwqf.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Sat, 20 Apr 2024 08:36:40 -0700) Date: Sat, 20 Apr 2024 19:29:25 +0200 Message-ID: <878r18t022.fsf@graner.name> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70338 Cc: eliz@gnu.org, 70338@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eric Abrahamsen wrote on 2024-04-20 08:36: > So far I don't see that this option would actually do anything in an FCC > context. `message-fcc-externalize-attachments' is only used in > `message-do-fcc`, where its value is let-bound to > `mml-externalize-attachments'. > > But `mml-externalize-attachments' is only consulted in > `gnus-inews-do-gcc', which already doesn't sound very promising. That > function first let-binds `mml-externalize-attachments' to nil, before > doing its own setting, so any dynamic value is getting overridden > anyway. > > I tried starting with `gnus-gcc-externalize-attachments' and sending a > message with an attachment, just to see how it's supposed to work. > Nothing seemed to happen. > > Can you tell me what the desired effect is supposed to be? Does the > "gcc" version of this option work for you? > > Eric When you attach a file to a mail message you are writing, only an anchor with the file name is inserted in the message buffer. When the message is sent, the anchor is replaced with the actual MIME-encoded contents of the attached file. The copy of the message that is written to the FCC file also includes the MIME-encoded attached file. I was expecting that externalization would mean that the copy in the FCC file would only include an anchor rather than the attachment, which would be extremely useful. I must admit this was only a guess (wishful thinking?) since the documentation is not explicit at all. I don't use gnus. To test the gnus version of the variable, I guess I would need access to a free, public NNTP server, which I don't know where to find. Can you help? Nicolas From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 20:29:26 2024 Received: (at 70338) by debbugs.gnu.org; 21 Apr 2024 00:29:26 +0000 Received: from localhost ([127.0.0.1]:39469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryL5B-0007tp-TC for submit@debbugs.gnu.org; Sat, 20 Apr 2024 20:29:26 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:37852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryL57-0007sH-Lh for 70338@debbugs.gnu.org; Sat, 20 Apr 2024 20:29:24 -0400 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 9634DFA183; Sun, 21 Apr 2024 00:28:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1713659339; bh=UCrxQb28rvqCA9IQVt+2E8CnBRR6DM3jRwsyJlHz3/4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=QtGeDo+sW7wyxD6IwnwsChxTU0ouaBg2VYOpLIySwLpTThmPfsVnHlXY1rotGqZHr ZX70QLLYswZj424WPIjXCSLhTB/gJ12a3SU/no15Acq6mxuX9QvElok2pnfxHM0oT+ w4yMIffp9+6jlhOOOeKJVbxoJhDjxfQN84pj2/Yg= From: Eric Abrahamsen To: Nicolas Graner Subject: Re: bug#70338: message-fcc-externalize-attachments has no effect In-Reply-To: <878r18t022.fsf@graner.name> (Nicolas Graner's message of "Sat, 20 Apr 2024 19:29:25 +0200") References: <878r18t022.fsf@graner.name> Date: Sat, 20 Apr 2024 17:28:58 -0700 Message-ID: <878r17h839.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70338 Cc: 70338@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain On 04/20/24 19:29 PM, Nicolas Graner wrote: > Eric Abrahamsen wrote on 2024-04-20 08:36: >> So far I don't see that this option would actually do anything in an FCC >> context. `message-fcc-externalize-attachments' is only used in >> `message-do-fcc`, where its value is let-bound to >> `mml-externalize-attachments'. >> >> But `mml-externalize-attachments' is only consulted in >> `gnus-inews-do-gcc', which already doesn't sound very promising. That >> function first let-binds `mml-externalize-attachments' to nil, before >> doing its own setting, so any dynamic value is getting overridden >> anyway. >> >> I tried starting with `gnus-gcc-externalize-attachments' and sending a >> message with an attachment, just to see how it's supposed to work. >> Nothing seemed to happen. >> >> Can you tell me what the desired effect is supposed to be? Does the >> "gcc" version of this option work for you? >> >> Eric > > When you attach a file to a mail message you are writing, only an anchor > with the file name is inserted in the message buffer. When the message > is sent, the anchor is replaced with the actual MIME-encoded contents of > the attached file. The copy of the message that is written to the FCC > file also includes the MIME-encoded attached file. > > I was expecting that externalization would mean that the copy in the FCC > file would only include an anchor rather than the attachment, which > would be extremely useful. I must admit this was only a guess (wishful > thinking?) since the documentation is not explicit at all. Oh, that sounds very useful, I've often wanted that. > I don't use gnus. To test the gnus version of the variable, I guess I > would need access to a free, public NNTP server, which I don't know > where to find. Can you help? I think most of us use news.gmane.io I tested the GCC version again (now that I know what it's supposed to do), and it did work -- the version of the message in my Sent folder had a mime part of "message/external-body". Long story short, the encoded body of the message is cached during sending, and the cached version is re-used during GCC/FCC handling. If the user has requested the externalization of attachments, the GCC version of the code knows to use that as a flag to dump the cache and re-generate it with externalized attachments; the FCC code doesn't do the equivalent. I've pushed a change that fixes this issue in my testing -- are you using Emacs master? If not, I've attached the commit here, I hope you'll be able to test it. Thanks, Eric --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Re-encode-message-bodies-with-externalized-attachmen.patch >From 3dfca6f9c7f4da512fff48cf6957c6492e2c0449 Mon Sep 17 00:00:00 2001 From: Eric Abrahamsen Date: Sat, 20 Apr 2024 17:25:20 -0700 Subject: [PATCH] Re-encode message bodies with externalized attachments during FCC Bug#70338 * lisp/gnus/message.el (message-do-fcc): If the user has requested to externalize attachments, we can't use the cached version of the message body from sending. This mirrors an equivalent check for GCC in `gnus-inews-do-gcc'. --- lisp/gnus/message.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/gnus/message.el b/lisp/gnus/message.el index 979d2fecf56..b2805774162 100644 --- a/lisp/gnus/message.el +++ b/lisp/gnus/message.el @@ -5768,8 +5768,10 @@ message-do-fcc (with-temp-buffer (insert-buffer-substring buf) (message-clone-locals buf) - ;; Avoid re-doing things like GPG-encoding secret parts. - (if (not encoded-cache) + ;; Avoid re-doing things like GPG-encoding secret parts, unless + ;; the user has requested that attachments be externalized, in + ;; which case we have to re-encode the message body. + (if (or mml-externalize-attachments (not encoded-cache)) (message-encode-message-body) (erase-buffer) (insert encoded-cache)) -- 2.44.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 00:19:58 2024 Received: (at 70338) by debbugs.gnu.org; 22 Apr 2024 04:19:58 +0000 Received: from localhost ([127.0.0.1]:45351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryl9q-0005Lh-0B for submit@debbugs.gnu.org; Mon, 22 Apr 2024 00:19:58 -0400 Received: from ns1.ouvaton.coop ([194.36.166.20]:50869 helo=smtp.ouvaton.coop) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryl9k-0005Kp-QA for 70338@debbugs.gnu.org; Mon, 22 Apr 2024 00:19:57 -0400 Received: from hypra-graner (175.21.205.77.rev.sfr.net [77.205.21.175]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ouvalternc.octopuce.fr (Postfix) with ESMTPSA id C1CE826190; Mon, 22 Apr 2024 06:19:34 +0200 (CEST) From: Nicolas Graner To: Eric Abrahamsen Subject: Re: bug#70338: message-fcc-externalize-attachments has no effect In-Reply-To: <878r17h839.fsf@ericabrahamsen.net> (message from Eric Abrahamsen on Sat, 20 Apr 2024 17:28:58 -0700) Date: Mon, 22 Apr 2024 06:19:30 +0200 Message-ID: <87frve9gh9.fsf@graner.name> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70338 Cc: 70338@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Yes, your patch works for me. Great, thanks! Nicolas Eric Abrahamsen wrote on 2024-04-20 17:28: > On 04/20/24 19:29 PM, Nicolas Graner wrote: >> Eric Abrahamsen wrote on 2024-04-20 08:36: >>> So far I don't see that this option would actually do anything in an FCC >>> context. `message-fcc-externalize-attachments' is only used in >>> `message-do-fcc`, where its value is let-bound to >>> `mml-externalize-attachments'. >>> >>> But `mml-externalize-attachments' is only consulted in >>> `gnus-inews-do-gcc', which already doesn't sound very promising. That >>> function first let-binds `mml-externalize-attachments' to nil, before >>> doing its own setting, so any dynamic value is getting overridden >>> anyway. >>> >>> I tried starting with `gnus-gcc-externalize-attachments' and sending a >>> message with an attachment, just to see how it's supposed to work. >>> Nothing seemed to happen. >>> >>> Can you tell me what the desired effect is supposed to be? Does the >>> "gcc" version of this option work for you? >>> >>> Eric >> >> When you attach a file to a mail message you are writing, only an anchor >> with the file name is inserted in the message buffer. When the message >> is sent, the anchor is replaced with the actual MIME-encoded contents of >> the attached file. The copy of the message that is written to the FCC >> file also includes the MIME-encoded attached file. >> >> I was expecting that externalization would mean that the copy in the FCC >> file would only include an anchor rather than the attachment, which >> would be extremely useful. I must admit this was only a guess (wishful >> thinking?) since the documentation is not explicit at all. > > Oh, that sounds very useful, I've often wanted that. > >> I don't use gnus. To test the gnus version of the variable, I guess I >> would need access to a free, public NNTP server, which I don't know >> where to find. Can you help? > > I think most of us use news.gmane.io > > I tested the GCC version again (now that I know what it's supposed to > do), and it did work -- the version of the message in my Sent folder had > a mime part of "message/external-body". > > Long story short, the encoded body of the message is cached during > sending, and the cached version is re-used during GCC/FCC handling. If > the user has requested the externalization of attachments, the GCC > version of the code knows to use that as a flag to dump the cache and > re-generate it with externalized attachments; the FCC code doesn't do > the equivalent. > > I've pushed a change that fixes this issue in my testing -- are you > using Emacs master? If not, I've attached the commit here, I hope you'll > be able to test it. > > Thanks, > Eric From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 22 00:28:29 2024 Received: (at 70338-done) by debbugs.gnu.org; 22 Apr 2024 04:28:29 +0000 Received: from localhost ([127.0.0.1]:45355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rylI5-0006Eu-3L for submit@debbugs.gnu.org; Mon, 22 Apr 2024 00:28:29 -0400 Received: from mail.ericabrahamsen.net ([52.70.2.18]:49776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rylI0-0006EB-7s for 70338-done@debbugs.gnu.org; Mon, 22 Apr 2024 00:28:27 -0400 Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 27182FA059; Mon, 22 Apr 2024 04:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1713760082; bh=+Qiy3BKmI1F3CPPKcFITRbRp9iEbdcB74m0l7DkSYic=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hoTm4sqkI4dEaPt/zg1DIE69kyTkrqdoZl8dr8OD/U9j/ZvGePQ2qKWMq9CBpRWyU sWFY2zl5TChHPXsxo3TMp55IAncSmMXw9o2qq4UPhfqdlaTsGY2QlUTvTpYaq9gOhU RptHf6EJAV84nAJTXvfc4lcd5kAQjsLGPbak9jW8= From: Eric Abrahamsen To: Nicolas Graner Subject: Re: bug#70338: message-fcc-externalize-attachments has no effect In-Reply-To: <87frve9gh9.fsf@graner.name> (Nicolas Graner's message of "Mon, 22 Apr 2024 06:19:30 +0200") References: <8634rs6plb.fsf@graner.name> <87frve9gh9.fsf@graner.name> Date: Sun, 21 Apr 2024 21:27:59 -0700 Message-ID: <87a5lmja28.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70338-done Cc: 70338-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Nicolas Graner writes: > Yes, your patch works for me. > Great, thanks! Excellent! I'll close the bug report now. From unknown Sat Jun 21 03:25:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 May 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator