GNU bug report logs - #70331
[PATCH] Call custom folding functions with consistent point

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Arash Esbati <arash <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70331: closed ([PATCH] Call custom folding functions with
 consistent point)
Date: Mon, 15 Apr 2024 08:15:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 15 Apr 2024 10:13:56 +0200
with message-id <m27cgzgi0r.fsf <at> macmutant.fritz.box>
and subject line Re: bug#70331: [PATCH] Call custom folding functions with consistent point
has caused the debbugs.gnu.org bug report #70331,
regarding [PATCH] Call custom folding functions with consistent point
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70331: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70331
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Paul Nelson <ultrono <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: [PATCH] Call custom folding functions with consistent point
Date: Thu, 11 Apr 2024 07:47:33 +0200

[Message part 3 (text/plain, inline)]

Hello,

As you know, one way to customize TeX-fold-mode is to supply functions
to the variables TeX-fold-*-spec-list, which are then called by
TeX-fold-hide-item.  This patch introduces the convention that such
functions are called with point positioned at the beginning of the
item to be folded.  This already happens "by accident" when the
folding occurs via TeX-fold-region, but not via TeX-fold-post-command,
for instance.

The motivation for having a consistent convention is that it makes it
possible (or at least simpler) to introduce more advanced folding
specs that depend on more than just the provided argument list.  For
example, in https://github.com/ultronozm/czm-tex-fold.el, I have used
similar functionality, implemented via :override advice, to fold
\begin{theorem} as "Theorem 1.1", with the correct equation number.
The patch would allow me to excise the advice.

Thanks, best,

Paul

[0001-Call-custom-folding-functions-with-consistent-point.patch (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70331-done <at> debbugs.gnu.org
Subject: Re: bug#70331: [PATCH] Call custom folding functions with
 consistent point
Date: Mon, 15 Apr 2024 10:13:56 +0200

Paul Nelson <ultrono <at> gmail.com> writes:

> Just to be clear: bug or devel?

If you want to send a patch, then bug, if you want to discuss the point,
devel, I'd say.

> There's some discussion on the magit repo at
> https://github.com/magit/magit/issues/2848 (but no solution there,
> from what I can tell).

I can hardly imagine that Magit doesn't cater for `fill-column' when
composing commit messages, but again, I don't use Magit.

I think we're done with this report, so I'm closing this.

Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.