From unknown Fri Sep 19 21:28:17 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70329 <70329@debbugs.gnu.org> To: bug#70329 <70329@debbugs.gnu.org> Subject: Status: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements Reply-To: bug#70329 <70329@debbugs.gnu.org> Date: Sat, 20 Sep 2025 04:28:17 +0000 retitle 70329 29.3; etags-regen-mode fails in projects that have spaces in = their root path elements reassign 70329 emacs submitter 70329 Magiel Bruntink severity 70329 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 00:53:42 2024 Received: (at submit) by debbugs.gnu.org; 11 Apr 2024 04:53:42 +0000 Received: from localhost ([127.0.0.1]:54722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rumRP-000377-6T for submit@debbugs.gnu.org; Thu, 11 Apr 2024 00:53:42 -0400 Received: from lists.gnu.org ([2001:470:142::17]:33496) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rudhA-0001Ei-BV for submit@debbugs.gnu.org; Wed, 10 Apr 2024 15:33:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rudgv-0006ff-Vh for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 15:33:06 -0400 Received: from qs51p00im-qukt01072102.me.com ([17.57.155.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rudgt-0002OF-JU for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2024 15:33:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1712777580; bh=Hf4SJwRqc7aPtZTnXAGnZtOUpcviwQuox5PRtnFCp0E=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=ZSOwolHOnIkkbA6v3zcGmzb5Y9X6F4BxA3ks5V6lNr7ZPv9faVXrA21uz2YUN0CKv txe3hwWm4Pro8OJx98GGuRDTjz6f+4fJO/6qCA7mieEiw47nXhPGDnmE+cIwIGGXg3 wxz0q6ApdqtDNAeuhwu+cWG2rtr+/y525FlH5BffV5ltWW1mSsbGI0xzIcB/tfQ/24 CUS4fQcwJIGELnzdcORvo3S00KXZA7inR2Ji7r9/XBjtxBokIjOLJerGscnjw0YrYJ 7pSjA7QS4YJfMoG3c4DwenavACn1Z2ynCOwfj+SxH/zxfbv1Zd2ensCc2EegxBIV0C JL7l+sIeBVS2Q== Received: from Carnivoor (qs51p00im-dlb-asmtp-mailmevip.me.com [17.57.155.28]) by qs51p00im-qukt01072102.me.com (Postfix) with ESMTPSA id 8820634025E for ; Wed, 10 Apr 2024 19:32:59 +0000 (UTC) From: Magiel Bruntink To: bug-gnu-emacs@gnu.org Subject: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements Date: Wed, 10 Apr 2024 21:32:57 +0200 Message-ID: <7yv84p3tee.fsf@icloud.com> MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-GUID: DCO93rl4SieKWa-JYLVDt3ka1u1pj-US X-Proofpoint-ORIG-GUID: DCO93rl4SieKWa-JYLVDt3ka1u1pj-US X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-10_04,2024-04-09_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 clxscore=1011 suspectscore=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2308100000 definitions=main-2404100144 Received-SPF: pass client-ip=17.57.155.11; envelope-from=magiel.bruntink@icloud.com; helo=qs51p00im-qukt01072102.me.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 11 Apr 2024 00:53:35 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Dear maintainers, I wanted to try to the new etags-regen-mode and loaded its lisp manually. There is an issue with how the new mode deals with paths containing spaces, however. Running the etags--xref-backend through eg. xref-find-definitions within a file in a project that has spaces in its path elements, eg. "c:/temp/test project/test.c" will cause an error. Messages seen are: Generating new tags table... (Shell command failed with code 1 and some error output) visit-tags-table-buffer: File c:/temp/test project/TAGS does not exist Error message in the etags-regen-tags-errors* buffer: c:/temp/test: Permission denied Thank you, Magiel Bruntink ------------------------------------------------------------------------------ In GNU Emacs 29.3 (build 2, x86_64-w64-mingw32) of 2024-03-26 built on fv-az653-233 Windowing system distributor 'Microsoft Corp.', version 10.0.22631 System Description: Microsoft Windows 10 Home (v10.0.2009.22631.3447) Configured using: 'configure --prefix=/ucrt64 --host=x86_64-w64-mingw32 --build=x86_64-w64-mingw32 --with-modules --without-dbus --without-compress-install --with-tree-sitter --with-native-compilation=aot 'CFLAGS=-march=nocona -msahf -mtune=generic -O2 -pipe -fstack-protector-strong -fno-optimize-sibling-calls' CPPFLAGS=-D__USE_MINGW_ANSI_STDIO=1 'LDFLAGS=-pipe -lpthread'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LIBXML2 MODULES NATIVE_COMP NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB Important settings: value of $LANG: NLD locale-coding-system: cp1252 Major mode: Helpful Minor modes in effect: etags-regen-mode: t global-git-commit-mode: t magit-auto-revert-mode: t shell-dirtrack-mode: t server-mode: t doom-modeline-mode: t TeX-PDF-mode: t global-java-ide-mode: t global-treesit-auto-mode: t winner-mode: t global-so-long-mode: t recentf-mode: t nerd-icons-completion-mode: t marginalia-mode: t corfu-popupinfo-mode: t savehist-mode: t corfu-history-mode: t global-corfu-mode: t corfu-mode: t vertico-mode: t global-completion-preview-mode: t display-time-mode: t pixel-scroll-precision-mode: t override-global-mode: t auto-compile-on-load-mode: t auto-compile-on-save-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t buffer-read-only: t size-indication-mode: t column-number-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: c:/Users/Magiel Bruntink/.emacs.d/elpa/transient-20240311.1638/transient hides c:/Tools/MSYS2/ucrt64/share/emacs/29.3/lisp/transient c:/Users/Magiel Bruntink/.emacs.d/elpa/modus-themes-20240317.1619/theme-loaddefs hides c:/Tools/MSYS2/ucrt64/share/emacs/29.3/lisp/theme-loaddefs c:/Users/Magiel Bruntink/.emacs.d/site-lisp/loaddefs hides c:/Tools/MSYS2/ucrt64/share/emacs/29.3/lisp/loaddefs c:/Users/Magiel Bruntink/.emacs.d/elpa/jsonrpc-1.0.25/jsonrpc hides c:/Tools/MSYS2/ucrt64/share/emacs/29.3/lisp/jsonrpc c:/Users/Magiel Bruntink/.emacs.d/elpa/eglot-1.17/eglot hides c:/Tools/MSYS2/ucrt64/share/emacs/29.3/lisp/progmodes/eglot c:/Users/Magiel Bruntink/.emacs.d/elpa/eldoc-1.15.0/eldoc hides c:/Tools/MSYS2/ucrt64/share/emacs/29.3/lisp/emacs-lisp/eldoc Features: (shadow sort mail-extr emacsbug magit-patch magit-subtree magit-gitignore magit-ediff ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util etags fileloop helpful cc-langs trace edebug info-look elisp-refs consult-xref c++-ts-mode c-ts-mode c-ts-common smartparens-c cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs cl-print shortdoc help-fns embark-org embark-consult embark ffap etags-regen loaddefs-gen lisp-mnt radix-tree autoconf autoconf-mode sh-script smie executable magit-extras pcmpl-unix magit-bookmark magit-submodule magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func magit-diff smerge-mode git-commit log-edit add-log magit-core magit-autorevert autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section tramp-cmds em-unix em-term term ehelp em-script em-prompt em-hist em-pred em-glob em-extpipe em-cmpl em-basic em-banner em-alias eshell-prompt-extras tramp tramp-loaddefs trampver tramp-integration tramp-compat shell em-dirs esh-var esh-mode em-ls eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util ace-window avy org-modern org-indent image-file image-converter oc-basic ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-async nntp gnus-sum shr pixel-fill kinsoku url-file gnus-group gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa derived mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex iso8601 ol-bbdb ol-w3m ol-doi org-link-doi smartparens-org org-calendar-smart-time-grid org-agenda org-element org-persist xdg org-id avl-tree generator org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete org-list org-footnote org-faces org-entities noutline outline ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs cal-menu calendar cal-loaddefs org-version org-compat org-macs format-spec misearch multi-isearch dired-aux vc-hg vc-bzr vc-src vc-sccs vc-svn vc-cvs vc-rcs nerd-icons-dired diff-hl-dired time-date mule-util cursor-sensor consult bookmark pulse color visual-fill-column svg dom xml gtags-mode files-x server ligature diff-hl log-view pcvs-util vc-dir vc cus-start doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core shrink-path f preview-dvisvgm face-remap preview auctex-latexmk smartparens-latex latex latex-flymake tex-ispell tex-style tex crm texmathp java-ide eglot external-completion jsonrpc flymake-proc flymake diff ert ewoc debug backtrace find-func filenotify compile text-property-search comint ansi-osc imenu smartparens-config smartparens-text smartparens advice loadhist thingatpt treesit-auto treesit ansi-color dumb-jump popup dash s xref project winner ibuf-macs so-long recentf tree-widget dired dired-loaddefs nerd-icons-completion marginalia cape corfu-popupinfo savehist corfu-history nerd-icons-corfu corfu orderless vertico compat completion-preview edmacro kmacro modus-vivendi-tritanopia-theme modus-operandi-tritanopia-theme modus-vivendi-deuteranopia-theme modus-operandi-deuteranopia-theme modus-vivendi-tinted-theme modus-operandi-tinted-theme modus-vivendi-theme modus-operandi-theme modus-themes nerd-icons nerd-icons-faces nerd-icons-data nerd-icons-data-mdicon nerd-icons-data-flicon nerd-icons-data-codicon nerd-icons-data-devicon nerd-icons-data-sucicon nerd-icons-data-wicon nerd-icons-data-faicon nerd-icons-data-powerline nerd-icons-data-octicon nerd-icons-data-pomicon nerd-icons-data-ipsicon time pixel-scroll cua-base ring display-line-numbers auctex-latexmk-autoloads blamer-autoloads async-autoloads cape-autoloads consult-eglot-autoloads copilot-autoloads corfu-autoloads csv-mode-autoloads dape-autoloads diff-hl-autoloads dired-collapse-autoloads dired-narrow-autoloads dired-ranger-autoloads dired-subtree-autoloads dired-hacks-utils-autoloads disk-usage-autoloads docker-autoloads aio-autoloads dockerfile-mode-autoloads doom-modeline-autoloads dumb-jump-autoloads ebdb-autoloads editorconfig-autoloads eglot-autoloads eldoc-autoloads embark-consult-autoloads consult-autoloads embark-autoloads eshell-prompt-extras-autoloads ess-autoloads gnu-elpa-keyring-update-autoloads epg rfc6068 epg-config gnu-elpa-keyring-update gptel-autoloads gtags-mode-autoloads helpful-autoloads elisp-refs-autoloads ibuffer-project-autoloads interaction-log-autoloads jsonrpc-autoloads kotlin-ts-mode-autoloads kubernetes-autoloads ligature-autoloads lua-mode-autoloads magit-autoloads pcase git-commit-autoloads magit-popup-autoloads magit-section-autoloads marginalia-autoloads modus-themes-autoloads nerd-icons-completion-autoloads nerd-icons-corfu-autoloads nerd-icons-dired-autoloads nerd-icons-ibuffer-autoloads orderless-autoloads org-modern-autoloads osm-autoloads pdf-tools-autoloads poly-R-autoloads poly-noweb-autoloads pomidor-autoloads alert-autoloads log4e-autoloads gntp-autoloads popup-autoloads preview-dvisvgm-autoloads auctex-autoloads tex-site pytest-autoloads pyvenv-autoloads qrencode-autoloads quarto-mode-autoloads poly-markdown-autoloads markdown-mode-autoloads polymode-autoloads rainbow-mode-autoloads request-autoloads rust-mode-autoloads shrink-path-autoloads f-autoloads smartparens-autoloads tablist-autoloads transient-autoloads treemacs-nerd-icons-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads ht-autoloads hydra-autoloads lv-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads s-autoloads dash-autoloads nerd-icons-autoloads treesit-auto-autoloads unfill-autoloads vertico-autoloads visual-regexp-autoloads wgrep-autoloads with-editor-autoloads compat-autoloads info writeroom-mode-autoloads visual-fill-column-autoloads yaml-mode-autoloads vc-git diff-mode vc-dispatcher use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source eieio eieio-core password-cache json map byte-opt url-vars auto-compile comp comp-cstr warnings subr-x rx cl-macs gv cl-extra help-mode cl-seq bytecomp byte-compile cus-edit pp cus-load icons wid-edit cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads w32notify w32 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 1066771 54399) (symbols 48 51400 0) (strings 32 230776 12295) (string-bytes 1 8110103) (vectors 16 107827) (vector-slots 8 2288876 93154) (floats 8 2132 451) (intervals 56 8437 1030) (buffers 984 40)) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 03:30:07 2024 Received: (at 70329) by debbugs.gnu.org; 11 Apr 2024 07:30:07 +0000 Received: from localhost ([127.0.0.1]:54800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruosn-0003hw-Dx for submit@debbugs.gnu.org; Thu, 11 Apr 2024 03:30:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruosi-0003fl-E2 for 70329@debbugs.gnu.org; Thu, 11 Apr 2024 03:30:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruosT-0005aY-VN; Thu, 11 Apr 2024 03:29:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=E3XF1BioMi0PLvIM63DqOkWE1W2VyGvsA00ay9waTLI=; b=WJ7GLWVJJIzA Ll9gTblXnatqIkPcaAEPiRtlJe0ir1kqnz6iXAI603N6z0ekSEJAkbxYe6Djw40SMmEbJwFVeMtEb LzQj3FgG0OMvSatOQoPD7NHFrPpIsjJH3SlvulVXEaAiGrw5q5PpJVxnyhBEwdAssQN/piJfKTJvY BGk5y5iIqR8LpTcWwezAc8ZoaeC581eBWwn7if8paTCJwT1zykI8GnjLVNddMjBcYov9w6c7n3fbV wOdu4DRgL3reZlRqqPARGYyBqsNAfJdlQtbwhx7oqp27c+iUOK27B+jeANzMy+eX4/x9MjPy/VERs WHTzfBJrkNfE4i0yqjfuHw==; Date: Thu, 11 Apr 2024 10:29:43 +0300 Message-Id: <861q7cuzko.fsf@gnu.org> From: Eli Zaretskii To: Magiel Bruntink In-Reply-To: <7yv84p3tee.fsf@icloud.com> (bug-gnu-emacs@gnu.org) Subject: Re: bug#70329: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements References: <7yv84p3tee.fsf@icloud.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70329 Cc: 70329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 10 Apr 2024 21:32:57 +0200 > From: Magiel Bruntink via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > I wanted to try to the new etags-regen-mode and loaded its lisp manually. > > There is an issue with how the new mode deals with paths containing spaces, > however. > > Running the etags--xref-backend through eg. xref-find-definitions > within a file in a project that has spaces in its path elements, > eg. "c:/temp/test project/test.c" will cause an error. > > Messages seen are: > Generating new tags table... > (Shell command failed with code 1 and some error output) > visit-tags-table-buffer: File c:/temp/test project/TAGS does not exist > > Error message in the etags-regen-tags-errors* buffer: > c:/temp/test: Permission denied Stab in the dark: does the patch below fix the problem? If not, please repeat your recipe with debug-on-error non-nil, and post the backtrace here. diff --git a/lisp/progmodes/etags-regen.el b/lisp/progmodes/etags-regen.el index 6cd78d3..02d666c 100644 --- a/lisp/progmodes/etags-regen.el +++ b/lisp/progmodes/etags-regen.el @@ -279,7 +279,7 @@ etags-regen--tags-generate " ") ;; ctags's etags requires '-L' for stdin input. (if ctags-p "-L" "") - tags-file))) + (shell-quote-argument tags-file)))) (with-temp-buffer (mapc (lambda (f) (insert f "\n")) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 10:48:51 2024 Received: (at 70329) by debbugs.gnu.org; 11 Apr 2024 14:48:52 +0000 Received: from localhost ([127.0.0.1]:57112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruvjK-0007Vg-Qy for submit@debbugs.gnu.org; Thu, 11 Apr 2024 10:48:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruvjB-0007TT-Fq for 70329@debbugs.gnu.org; Thu, 11 Apr 2024 10:48:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ruviw-0004jk-Mv; Thu, 11 Apr 2024 10:48:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DyRUPBi7qRnAme7bleX+lCsoApdqILIpS/6rAFOYBTE=; b=AB9/bWio0x/3 kewrXwaXrQrh2uTLL404xQffaENculOJHz0pcerhwMKjxS9x/o5tuc0J2nNU6QAcwlQwP0U67rvuU 96uNpqipAxOheYebAQGxFzbG1PzcCbJp7yVXFdiWDy6CNaRE1y1bNl87qNdiDF5Pv2oiekuFjS2IN 3w5i87xTUFPc881SHyUqoZWXhmHAC9r2dg+z809IzVmKUK7RxIEmndxRVS+ZUQK1+du5YVIuDIVdq cqX5NJPMbHSe5BEIB3wsGIeZqom1YjfqR/c3574Jhg6Abirz6UA7irCalMLL5TKR8BLYDSLEgyTM2 WSGxwKXKtxgpcf672l6gpw==; Date: Thu, 11 Apr 2024 17:48:19 +0300 Message-Id: <86o7agt0p8.fsf@gnu.org> From: Eli Zaretskii To: Magiel Bruntink , Dmitry Gutov In-Reply-To: <7ysezsc6q6.fsf@icloud.com> (message from Magiel Bruntink on Thu, 11 Apr 2024 16:30:09 +0200) Subject: Re: bug#70329: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements References: <7yv84p3tee.fsf@icloud.com> <861q7cuzko.fsf@gnu.org> <7ysezsc6q6.fsf@icloud.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70329 Cc: 70329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Magiel Bruntink > Date: Thu, 11 Apr 2024 16:30:09 +0200 > > Yes, problem fixed with your patch. Nice! Thanks for testing it. I will wait for Dmitry to chime in before installing this. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 12:17:54 2024 Received: (at 70329) by debbugs.gnu.org; 11 Apr 2024 16:17:54 +0000 Received: from localhost ([127.0.0.1]:57219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rux7Y-0002ki-Kv for submit@debbugs.gnu.org; Thu, 11 Apr 2024 12:17:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55294) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rux7W-0002jQ-Ke for 70329@debbugs.gnu.org; Thu, 11 Apr 2024 12:17:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rux7H-0003WU-GS; Thu, 11 Apr 2024 12:17:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=x1Cn583QmxAeJoiqcysQK2hJcq8ucCwQtRNobkDiyXk=; b=pYDMXW9X7atq r+dcw9b8TKb4hf5ikyycFufYQom92dRFpaYifj5rhPqIevVRRG17aKiXeJ5Hp6/yOu/2b/sCVO/TG LrSheMEKo+oR1ShMz+rWNlcSRDVn8J/hltQNEpD2LvFotAco6UvAuX80fSEoAPHgieBCyD1NMp7ug 5GmZnDzd/rsu5I9sTjyj2Nhi6cC1sz8l1D4Ly8/Qhi+GiKrsY9oA3UKmoFhPJzqifBmef3AnH6lrQ 0bPfIJ0GztdOIaeIsofw27nFHvSaEpEk9sRN8Ryg2e6ikLWA7mqQlciuJSCfuA+98v0aFRJKEvj2/ 9pjGSuX7OfJ8VZQleeHZAg==; Date: Thu, 11 Apr 2024 19:17:32 +0300 Message-Id: <86le5jub4z.fsf@gnu.org> From: Eli Zaretskii To: Magiel Bruntink In-Reply-To: <7yh6g7dhw7.fsf@icloud.com> (message from Magiel Bruntink on Thu, 11 Apr 2024 17:43:36 +0200) Subject: Re: bug#70329: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements References: <7yv84p3tee.fsf@icloud.com> <861q7cuzko.fsf@gnu.org> <7ysezsc6q6.fsf@icloud.com> <86o7agt0p8.fsf@gnu.org> <7yh6g7dhw7.fsf@icloud.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70329 Cc: 70329@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) [Please use Reply All to reply, to keep the bug tracker CC'ed.] > From: Magiel Bruntink > Date: Thu, 11 Apr 2024 17:43:36 +0200 > > No problem, thanks for the fix. > > While applying your patch I found a similar issue with ediff-ptch.el though. It > won't find the to-be-patched file if there are spaces involved in the path. > > Here is the patch for it :-) Thanks. I installed a slightly more radical change instead: diff --git a/lisp/vc/ediff-ptch.el b/lisp/vc/ediff-ptch.el index f8d4c1c..2d5d460 100644 --- a/lisp/vc/ediff-ptch.el +++ b/lisp/vc/ediff-ptch.el @@ -721,10 +721,11 @@ ediff-patch-file-internal nil ; don't redisplay shell-command-switch ; usually -c (format "%s %s %s %s" - ediff-patch-program + (shell-quote-argument ediff-patch-program) ediff-patch-options ediff-backup-specs - (ediff--buffer-file-name buf-to-patch)) + (shell-quote-argument + (ediff--buffer-file-name buf-to-patch))) )) ;; restore environment for gnu patch From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 13:11:21 2024 Received: (at 70329-done) by debbugs.gnu.org; 11 Apr 2024 17:11:21 +0000 Received: from localhost ([127.0.0.1]:57244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruxxI-000156-R2 for submit@debbugs.gnu.org; Thu, 11 Apr 2024 13:11:21 -0400 Received: from fout2-smtp.messagingengine.com ([103.168.172.145]:43281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruxxD-00013B-Gu for 70329-done@debbugs.gnu.org; Thu, 11 Apr 2024 13:11:18 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfout.nyi.internal (Postfix) with ESMTP id 4DB151380158; Thu, 11 Apr 2024 13:11:00 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 11 Apr 2024 13:11:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1712855460; x=1712941860; bh=W9Yvd2NAclq1NImVpMEqSKf/BuEJl7Gc+A+CTYEX/U0=; b= cnnI/Yn7UJkcN696PLPxpAjT7M7He9jalTlbX1xHCHaeXxVuKKFA/w7m4EcIlTXy 1dGY+see9R5FK+b0T74RLoHlLeqDj35kbzwm+hdHPsdGGJp/nb9Chw/KkzDjl7nB v8rGXhefvttIHF25MR75tLlIqZNAGt+CsgvKIDUhxboYcICYj9zJd4nVNb5SgLfZ MKjf+Nv5EGG/OUSWLI8nFmxmiAuIZUVtYWXhEotiFd1UFKOwyWiE7L/+IDf59APb lKLNGZcGy8AF0gxHxGizf5flJ0+9xBi8uleBFeS2BDz/Hh/41Y8s/XxtL4OPORsb 6gPjJ/59A2XvPpoJNIfl/Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712855460; x= 1712941860; bh=W9Yvd2NAclq1NImVpMEqSKf/BuEJl7Gc+A+CTYEX/U0=; b=D 8DfkPqbs1NLC3Vad+CMShoSxZR8VfseX+XCaSDbX5MIgQt6+f1N5225tWArPsuf/ xbUt9fS2UkRzHogXt585a4xUesD4uh2mxBxpDFmdj2r2VIM7gl4K3hXNeFnno+J8 dBwe9cTUpDAhcs/6P7kuRMzRBttj55Je+ze++rZxv5pEEBR434UxvtVjixJ2pbmZ 9iAMCjxUml9xPqvuSOvEyqyQIWbKv93RtEW5HXeqP1PJCgC+lNZVT7CN7loLBT9W axq8t1kfXqu3obteNcMB12wXJ4etYUP4eWOUp0Drl3bmZtTCT1VplRGE2woA9Nhd N0xkGhGGcC+Kb56TUK+fA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudehkedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeetudeljeegheetgfehgeejkeeuhedvveeikeeufedtvddtveefhfdvveeg udejheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Apr 2024 13:10:58 -0400 (EDT) Message-ID: Date: Thu, 11 Apr 2024 20:10:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70329: 29.3; etags-regen-mode fails in projects that have spaces in their root path elements Content-Language: en-US To: Eli Zaretskii , Magiel Bruntink References: <7yv84p3tee.fsf@icloud.com> <861q7cuzko.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <861q7cuzko.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70329-done Cc: 70329-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Eli and Magiel, On 11/04/2024 10:29, Eli Zaretskii wrote: >> Date: Wed, 10 Apr 2024 21:32:57 +0200 >> From: Magiel Bruntink via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> I wanted to try to the new etags-regen-mode and loaded its lisp manually. >> >> There is an issue with how the new mode deals with paths containing spaces, >> however. >> >> Running the etags--xref-backend through eg. xref-find-definitions >> within a file in a project that has spaces in its path elements, >> eg. "c:/temp/test project/test.c" will cause an error. >> >> Messages seen are: >> Generating new tags table... >> (Shell command failed with code 1 and some error output) >> visit-tags-table-buffer: File c:/temp/test project/TAGS does not exist >> >> Error message in the etags-regen-tags-errors* buffer: >> c:/temp/test: Permission denied > Stab in the dark: does the patch below fix the problem? > > If not, please repeat your recipe with debug-on-error non-nil, and > post the backtrace here. > > diff --git a/lisp/progmodes/etags-regen.el b/lisp/progmodes/etags-regen.el > index 6cd78d3..02d666c 100644 > --- a/lisp/progmodes/etags-regen.el > +++ b/lisp/progmodes/etags-regen.el > @@ -279,7 +279,7 @@ etags-regen--tags-generate > " ") > ;; ctags's etags requires '-L' for stdin input. > (if ctags-p "-L" "") > - tags-file))) > + (shell-quote-argument tags-file)))) > (with-temp-buffer > (mapc (lambda (f) > (insert f "\n")) Thank you, looks good, pushed to master. From unknown Fri Sep 19 21:28:17 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 10 May 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator