GNU bug report logs -
#70318
[PATCH] Fix unitentional creation of greeter's home directory
Previous Next
Reported by: lgcoelho <at> disroot.org
Date: Tue, 9 Apr 2024 23:59:01 UTC
Severity: normal
Tags: patch
Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Nicolas Graves <ngraves <at> ngraves.fr> writes:
> On 2025-01-03 21:05, muradm wrote:
>
>> This may break greeters which are more complex than agreety.
>> For
>> instance, gtkgreet/wlgreet run under sway. One of
>> subdependencies
>> is mesa, which will want to write shader caches somewhere.
>> Another
>> one is fontconfig, doing similar thing for fonts. There may be
>> others, which hard to track and tune. Some could be impossible
>> to
>> tune at all.
>
> Then maybe we can make it conditional on agreety?
>
> If all greetd-configuration-terminals have their
> greet-default-session-command being an greetd-agreety-session?,
> we could
> set it to #f.
>
> Something like this could work:
> (create-home-directory? (not (every greetd-agreety-session? (map
> greetd-default-session-command (greetd-configuration-terminals
> config)))))
>
> WDYT?
2 of 3 greeters needs home. With improvements implemented by 75270
`greetd-terminal-configuration` is detached from details of its
`default-session-command`. By this, any user can workout its
greeter. If we hardcode implementation of greeter in terminal user
may loose such flexibility. Also once you implement such
condition, you will have to maintain with any other greeter added
in the future.
One way would be to carry this flag into `greetd-configuration`,
IMHO will uneccessarily complicate the things. Is there any good
reason for doing that?
What is the problem with having home directory for greeter user?
[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 161 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.