GNU bug report logs - #70311
Crash when dnd-indicate-insertion-point is non-nil

Previous Next

Full log

Message #23 received at 70311 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70311 <at> debbugs.gnu.org, gregsexton <at> gmail.com
Subject: Re: bug#70311: Crash when dnd-indicate-insertion-point is non-nil
Date: Sun, 14 Apr 2024 17:24:12 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Po Lu <luangruo <at> yahoo.com>
>> Cc: gregsexton <at> gmail.com,  70311 <at> debbugs.gnu.org
>> Date: Sat, 13 Apr 2024 20:28:14 +0800
>> 
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>> 
>> > So you think the suggested band-aid is the best we can currently do to
>> > prevent crashes in those cases?
>> 
>> Yes, unfortunately.
>
> Does the band-aid below look OK to you?
>
> diff --git a/lisp/dnd.el b/lisp/dnd.el
> index 89652d3..de1c58a 100644
> --- a/lisp/dnd.el
> +++ b/lisp/dnd.el
> @@ -149,8 +149,13 @@ dnd-handle-movement
>                  (with-selected-window window
>                    (scroll-down 1))))))))
>        (when dnd-indicate-insertion-point
> -        (ignore-errors
> -          (goto-char (posn-point posn)))))))
> +        (let ((pos (posn-point posn)))
> +          ;; We avoid errors here, since on some systems this runs
> +          ;; when waiting_for_input is non-zero, and that aborts on
> +          ;; error.
> +          (if (and pos (<= (point-min) pos (point-max)))
> +              (goto-char pos)
> +            pos))))))

Yes, please install.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.