From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 10:59:54 2024 Received: (at submit) by debbugs.gnu.org; 9 Apr 2024 14:59:54 +0000 Received: from localhost ([127.0.0.1]:51222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruCwz-0002yK-MC for submit@debbugs.gnu.org; Tue, 09 Apr 2024 10:59:54 -0400 Received: from lists.gnu.org ([2001:470:142::17]:36484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8h3-0002DO-VY for submit@debbugs.gnu.org; Tue, 09 Apr 2024 06:27:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru8gq-0002vU-Jd for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 06:26:56 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ru8gp-0006MN-3o for bug-gnu-emacs@gnu.org; Tue, 09 Apr 2024 06:26:56 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-516ab4b3251so6042916e87.0 for ; Tue, 09 Apr 2024 03:26:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712658412; x=1713263212; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=xdkXiLED4WSEuSrFBZUiHmpJoWU39qhXpLJJTipYE14=; b=BA3KyAR1zYx4Ed/j/65X6CVQsPZGRY+QFpZ+vESwm5r/tN3SqcmyMqJFlJkPycZr4z oY8EQOGVInwvy7gEWZy2ZXYqN7myrXAHSXkfmCmFacohiQ1LscQbXtaxbF9u3LEM5tfn WhZNMriOMpLGiVWZyP5en03vme/P3cPWFVlKH3IsLf2yzSWC8I9LnsLv3Anmna7wA1Yx wvSolDjJuoMAg2UiVeK2Zh19I+pIpQxuCor/oYB1EDMnuO9NWf/AUj68Klmw7D/6KLP+ qPiPmspVjiAa4EcQ2bMlwfou/SZUCvrtq8yAUZicyTthMROP1s6g8ufVgD4T56m084bS Qquw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712658412; x=1713263212; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xdkXiLED4WSEuSrFBZUiHmpJoWU39qhXpLJJTipYE14=; b=mTwQFivEnt3zC1dti+ptkJHHOD8nOkCMDr0MhbTKj8ZCxgJJ1Pdmz64crzduNwS2sB IZE8q9YkVrKpW5QgXlPcqQm5e/AEBI7PxzRKGTrA4k0T/ffJLqiUHIkwaCLgnT5mIY47 IrckIU/l8pFbHtovNmhWIxEQKcENZ/QWixR49UUyzaL3vq44lDdMuSTcmMOOaqTsiNzp RUFe8+V8YH8dA3oxcF1bmGgr/a5oooyZ/mues2UR1NKH2CtIr3wF1T2oEFdOrCW8DD9U 7tni8hHHkaKU+M+3C41JLgE9qStt39CRYd3DuNWYr4zigzinlnt7FZzG5SoxUSUl1jey W8ww== X-Gm-Message-State: AOJu0Yy/Tjpa7eCvmuEuKRgIYqETNi1jBueBsIYiHGLNzsbIf3EUrOYQ 3wB2frmDRFswnuzjqfXhWXLWl1xs4tJDGPF4Ex4igUBuImvp38O5I0wlFpYbS2TnZuEkorSooc8 SeI4RH03qkRiGsKLoSFiXqWQQmgyOyxDCsQM= X-Google-Smtp-Source: AGHT+IE/CG0FWum+nP3uQsop8JP7oUmlO84cbassUPDuWxzo29MT39dHLAbp1BWylxT5/EtnwjpS6E9+qZ5reZ7u/MY= X-Received: by 2002:a05:6512:23a2:b0:516:d538:d558 with SMTP id c34-20020a05651223a200b00516d538d558mr11482628lfv.29.1712658412481; Tue, 09 Apr 2024 03:26:52 -0700 (PDT) MIME-Version: 1.0 From: Greg Sexton Date: Tue, 9 Apr 2024 11:26:41 +0100 Message-ID: Subject: Crash when dnd-indicate-insertion-point is non-nil To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=gregsexton@gmail.com; helo=mail-lf1-x136.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 09 Apr 2024 10:59:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Emacs (29.1.90) can crash on Mac OS X when dnd-indicate-insertion-point is non-nil. I'm not able to deterministically reproduce this, but I have a high success rate dragging a file over the window and just randomly moving it around without releasing the click. This said, I attached a debugger and found the root cause. There is code that looks like this in dnd-handle-movement: (when dnd-indicate-insertion-point (ignore-errors (goto-char (posn-point posn)))) posn-point can return nil, which causes goto-char to call wrong_type_argument, this reaches signal_or_quit (eval.c), which calls emacs_abort as waiting_for_input is true. A quick fix might be to when-let the result of posn-point, but I'm unsure if waiting_for_input being true points to a deeper issue. -- Greg From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 05:21:10 2024 Received: (at 70311) by debbugs.gnu.org; 13 Apr 2024 09:21:11 +0000 Received: from localhost ([127.0.0.1]:60135 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZZO-00059E-1R for submit@debbugs.gnu.org; Sat, 13 Apr 2024 05:21:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZZL-00057h-V8 for 70311@debbugs.gnu.org; Sat, 13 Apr 2024 05:21:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvZZ6-0005TJ-8h; Sat, 13 Apr 2024 05:20:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7cdL48ifKpBQXy+er2covEed3AFFuGMDXzXDR9vlQCY=; b=oQVde4YmuoTe KDdz9zeFVuxM9IwTtqKNb4xuTnFnEqcPLhEsnul1fPdbANVAZbNRii6Mqv9IGkYd1M4qEYvNpldHE J6UroFspX/mcZg4bwQukw80iS8oRX8uc606cJLJFOFUQspQvyeYDlNi1w3elgxVXPWyNbdl1Q/2cD hy4ADB1fQfL268KB6TAajRQFWIhjZ5gseg0Fy3Dp9tlUc3k9CjGQ4LC579n49mYS1dFNVF9nSOCPM T+k2yFPf7YjDihavynX0dXpPuDxDyQBd3Rb3ciwr1uI/YHFUMWtQy92sXZ8rRQX5LcfJcDOF1NucZ tPzMxZPdTMF72WpA+oNwmg==; Date: Sat, 13 Apr 2024 12:20:48 +0300 Message-Id: <86wmp1pqj3.fsf@gnu.org> From: Eli Zaretskii To: Greg Sexton , Po Lu In-Reply-To: (message from Greg Sexton on Tue, 9 Apr 2024 11:26:41 +0100) Subject: Re: bug#70311: Crash when dnd-indicate-insertion-point is non-nil References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70311 Cc: 70311@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Greg Sexton > Date: Tue, 9 Apr 2024 11:26:41 +0100 > > Emacs (29.1.90) can crash on Mac OS X when dnd-indicate-insertion-point > is non-nil. > > I'm not able to deterministically reproduce this, but I have a high > success rate dragging a file over the window and just randomly moving > it around without releasing the click. > > This said, I attached a debugger and found the root cause. > > There is code that looks like this in dnd-handle-movement: > > (when dnd-indicate-insertion-point > (ignore-errors > (goto-char (posn-point posn)))) > > posn-point can return nil, which causes goto-char to call > wrong_type_argument, this reaches signal_or_quit (eval.c), which calls > emacs_abort as waiting_for_input is true. > > A quick fix might be to when-let the result of posn-point, but I'm > unsure if waiting_for_input being true points to a deeper issue. Po Lu, any comments or suggestions? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 07:58:56 2024 Received: (at 70311) by debbugs.gnu.org; 13 Apr 2024 11:58:56 +0000 Received: from localhost ([127.0.0.1]:60245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvc23-0000Z9-Vr for submit@debbugs.gnu.org; Sat, 13 Apr 2024 07:58:56 -0400 Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:42494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvc22-0000YH-GZ for 70311@debbugs.gnu.org; Sat, 13 Apr 2024 07:58:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713009518; bh=dfi6Y+SU2vgjuT+cRVgC0hwp1JMrMWYpSE779Y0mNLw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=T/0eYrDqhCm9l1Ov3li4J3BFeJRd8quIKa0YWl6evaJp6tRslB0e/tVLDfa5k+IdAVnq+2LjhoJYMOicjgJsGFElbtLm1lSBeRLwR8lGDYxOHfCrza5N9P0sIecgTAkk1egOClrajLboAJjgY6SLzLvUGCbBKsirYDM06iq2RDwzsP4a/+YbedE1w4oDIrsR+IzWKKMqhaGh/gWBhTxIhQefvl3CeWFdQgJ4kQ3dygMKdaiQNdXFyZSElzX+2QLJbok58l+g233GgCXnAmwmoQ3BCWoCWqLxjHuUCasv8qGIvjCPDxp7+mL+YUHklMEekpB9nsUt6a6BYdX9iUvQwg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713009518; bh=t/RLCW/qtMDmMWQM5ShU1do8eGwoMik7hma6Tw+pnAu=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=FSKzl3W1WLgL83JFcvzCjjXap8aNLGcYoh30QAei4A1xgLZchLtf/HNVeovKLlpNbthMV5yXBSB35fnEY8Bx1/HrQeoU0QtG3iKyqKs4Ob5q+kvINUxS/wyJ2YRvjR3ZoV4BBERi4St4ZwJ5VVdRE9sxLrZgp9CtVjRCLTTkHjFvyTqe49kYhLZskUvgvKH+qT7knecSvYyialGnn4gsxrsVDmmKlVJ04mmhZmKpQWvCDGpMANNydX1w7oHU4eAKcZsLoUeZjqhzFhOtT4QGgZLnHHPcjUJiXsnsEBzyBiOfKO9HTmuVlhi0h5dCKlop8UpanCbsj6oAU7e+jWhU/A== X-YMail-OSG: 7D4N3xIVM1mjvphbgk54CmHMjCk3fhkznDgOIjSNaPTxWFmjPRMMmL1d9t4p9_D 71Y2dAfLTcA3hvpY__5uusSrTSVnhCdgJiWmHvn5gMAKOwmetyGBTgV9260aIZXZeec7lXTN4wok 7oQQecHA2sCBKPaZctrAXlt4FWLmb2JYjEJ.qO2utJh_WgXr_90mjZFJMW8u31lEH3iMpL5HN0TH YxeQNbTRjsMjkB2QVyum5vF4m7QyyoCL37zOVn6OPWJyF8qw7V1ak9Gp_I4QOgV5fdDxU.71TOYY YQ2YlnyGLFdvk_NePOvJJLv_doWy3SZJmKUFx0YFxKHANIhARliZYiuqv_kGf.bW_UyTjGGzIsbi NqIp6NTPXOpkAGyyiioM8S8XJSBgh6g8TB_dRJUm5LBU5LSxRMqVbQxdM1z25DX86crXpOkOnYfl rta3jbBbBvngMEpcnu4DCQuA9O4VgipkjzLm9uIeknrXOGTZrI9a68QzscSYBIhKPgD95ovxGQDr epMhhqQOhrw3GalnDm80knLle_zv1l3RgZweJn5eELysMflLy_CPMW2hJ7ohjEw7vsUI8FevNEUT cOt0gZsmDXGAGBvg_qQ_ecwvXJ0dh8TDcI7lRrxzhDJGnsxeE7ahv_zq.7YEoyNyOMy_fbnJBI0o bWzVvPznMzUy8pjVDtpIqixPAkYqfRxknnO97LAuYku0Ep90yzS5su1brxDhpZWn06MMpsMCV4Xc bs0cmpoNcq0f0GAk672ucUVJa7djx6tU7o3uetLg3yOmwnQNS9CA.sqeibEmewoeczvPSW1kNlbb mFjf48zWj5H4BJBrB7VYhnekPHxAQ46I17ujLCioLuByVFVWuEZkRbk1xMNldooJBRlPwosLqz73 .deTNzkwc8GySVTF3TbhVh_etRFfbH0nv7ZgBWNp7ZcdXJGGT0Kh3ncxQrJMPb6d.5QczqnCFbP9 SyZGKXfP1gI9oNZsEO.1jnYFLTWLK4x2veKthr6yHiDhzYmCLxzzheunml8V40S__25WVXuPAZ0I M8tiiVpG.TXzU4dDTG6qhy3gJJQL5Fho4o_SJXk9SPkfbv_VdRvVQkIGKzd_aniFSIaniqzp8t29 MHn0Rjmh3gZDRNuDebseWLT8GEXxQh_M6wYrBEfm_6Fs3dzfabo68h__UGJj1nFffzXIGQCEQdWN kSKRTkUYEA2t4qD3q0ITqLPqfkh3ZndFDLnz5Sa7T.fmnqGLyBvPldWhxR0A_W4tGBFOH8npUMjE BYzcCqpGaVAeTdHQNFCYJgmdhQAqHoKjwgnGhyixz5lP7ySTGGSZ.YWWgDaUjaIqKg3FipDaYkWS RZr7y7eCN0n.q1Ar5F2YCh0HFc1tNN4ilGAwbzaVeefQidq5Xts3f4tOfnx4hR0C3_gAXIHFu7xa lG9SrkJeo8S815rOERL1OYvTGFuyIm.7ypagz7Of4Javlr6i914y.uBgV3yDpob.ZEkqG_hj6KO1 hh5q_0z73zC9_Io4iXucNfWZ.P8IV.6Y1izKMbs2Tv7F5_NRP6Ry5A3OOavnhUvmrs02MbYwHVXt pzGug7YZDd9gP2UKU4Rl0NP93h.NpdDHt_85zq8LIuWIgxdvhB6qaIRX3Y1F6AKD2ibtwWOGk8yY 7MFAq9XtP16cEJs4vrGJfxYWB3stUqclCyAiY5Zjv4yw5dWckvAgd_A.AFWMSjz0288RJBLw0ERV LW0ZihdBzkbABATeNEQLxVQEA0q.q_4YEKwPEADTesVkqjweurL53UpKW_DFSoGhVJpx28l6sDcE WpY9pzKEFZXGckCkE3N.Fx3Vxox1YS8smVh_PIJdM2pK9ml.jdH_GnYIGQvZpIokinuCPSjfQ012 UhX1i1D8q_Oso65iJdQkRY3brKV_DIWT1.JOyuHX.vVHOS7LWt67t6XdGwuOZCV.iQazT75T0zbO g9TWN_0kzWGExz6Y2RvQ_wSaItRLRqQ6gjeUOJpnC.Z9BxP0PwT7FHHiX_BXKsKKfucTZ0MhsBWc ZeT1jGdZzumBy_AMaCIyitTKHcz_sEVhVBMPUozUpXTM22q1q4O_ATKwlc6HNfGM4NnZcIpbWaAQ YXT25fNYBL.gq_Xq4mWG0MVmRqz8B.dQ27_yzsT.tuZUrGMiYMftQPLZXTEDDKsALy4Y01x1cGSP RB2Skj2K4rg2iJcMlPqHvfRp7mahYuPIswxAGR5pV8zi4QGP1p3YEn.tygmg8T7qP6Z0ZAvLVo8b etTZc7RtUOD7l9LqpchPY3fpYDDjjLrRJ8tey6FHGknIGmiX1z..cTmMAe9xXtcbaVT9idw-- X-Sonic-MF: X-Sonic-ID: 1d7e857e-7213-436f-9e58-9d4b17470889 Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Sat, 13 Apr 2024 11:58:38 +0000 Received: by hermes--production-sg3-6f9f87bd85-d9mmq (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b20cb209323dbeebafebb5c2109b4f97; Sat, 13 Apr 2024 11:58:35 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#70311: Crash when dnd-indicate-insertion-point is non-nil In-Reply-To: <86wmp1pqj3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Apr 2024 12:20:48 +0300") References: <86wmp1pqj3.fsf@gnu.org> Date: Sat, 13 Apr 2024 19:58:25 +0800 Message-ID: <87il0l325a.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.22205 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1616 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70311 Cc: 70311@debbugs.gnu.org, Greg Sexton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Greg Sexton >> Date: Tue, 9 Apr 2024 11:26:41 +0100 >> >> Emacs (29.1.90) can crash on Mac OS X when dnd-indicate-insertion-point >> is non-nil. >> >> I'm not able to deterministically reproduce this, but I have a high >> success rate dragging a file over the window and just randomly moving >> it around without releasing the click. >> >> This said, I attached a debugger and found the root cause. >> >> There is code that looks like this in dnd-handle-movement: >> >> (when dnd-indicate-insertion-point >> (ignore-errors >> (goto-char (posn-point posn)))) >> >> posn-point can return nil, which causes goto-char to call >> wrong_type_argument, this reaches signal_or_quit (eval.c), which calls >> emacs_abort as waiting_for_input is true. >> >> A quick fix might be to when-let the result of posn-point, but I'm >> unsure if waiting_for_input being true points to a deeper issue. > > Po Lu, any comments or suggestions? As regards suggestions, none at present. It's not clear to me why waiting_for_input should continue to exist, but neither am I especially satisfied with the present arrangements for calling drag-and-drop callbacks in nsterm.m: some means should be devised of returning to the event loop during a DND session, rather than calling Lisp and parts of redisplay from non-reentrant input handlers that the toolkit can call at will. Come to think of it, at the time this kludge was written, I never quite understood why DND events were never received on Mac OS, when the same was smooth sailing on GNUstep. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 08:07:03 2024 Received: (at 70311) by debbugs.gnu.org; 13 Apr 2024 12:07:03 +0000 Received: from localhost ([127.0.0.1]:60282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvc9t-0001lU-Fc for submit@debbugs.gnu.org; Sat, 13 Apr 2024 08:07:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvc9s-0001kH-5O for 70311@debbugs.gnu.org; Sat, 13 Apr 2024 08:07:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvc9c-0008Ak-4N; Sat, 13 Apr 2024 08:06:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=l5zl+XSGJW4jT89Q0mUPeEUsvPFEr8aBUtrkBXx6YEg=; b=C56JBmJHZkmU h8CsLN+fjF7gPmv7QBKyyr5f3t4innnbk8QiLeIYnO4TYdj9h8Ztz+a325ziWiM+8NeLQWDYkY5j6 0EAwuhcwWk7LmKwpVQn4IdzXOIdx0ZxrLG6hPA1yU2ZWREk4ytcnKQXEpvlUZOh7ZgQooP7117j8Z touisYXWc2oy0evK7s8fGkq6m8KraTZILfJQFNPZa6xMDbmokqbzgUbBZUK3sGz3VV2ic9zL7PXB6 0Y2XycSXW3WU/79c/QW6qXuZwveJgcPqaJ1uXNf+2bJtSCKbZ5/m9Jh3a8X8pfhLh0OmDMaAgtZlk KSK4+1jFXan+hkIOxRqM9g==; Date: Sat, 13 Apr 2024 15:06:41 +0300 Message-Id: <867ch1pium.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87il0l325a.fsf@yahoo.com> (message from Po Lu on Sat, 13 Apr 2024 19:58:25 +0800) Subject: Re: bug#70311: Crash when dnd-indicate-insertion-point is non-nil References: <86wmp1pqj3.fsf@gnu.org> <87il0l325a.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70311 Cc: 70311@debbugs.gnu.org, gregsexton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: Greg Sexton , 70311@debbugs.gnu.org > Date: Sat, 13 Apr 2024 19:58:25 +0800 > > Eli Zaretskii writes: > > >> From: Greg Sexton > >> Date: Tue, 9 Apr 2024 11:26:41 +0100 > >> > >> Emacs (29.1.90) can crash on Mac OS X when dnd-indicate-insertion-point > >> is non-nil. > >> > >> I'm not able to deterministically reproduce this, but I have a high > >> success rate dragging a file over the window and just randomly moving > >> it around without releasing the click. > >> > >> This said, I attached a debugger and found the root cause. > >> > >> There is code that looks like this in dnd-handle-movement: > >> > >> (when dnd-indicate-insertion-point > >> (ignore-errors > >> (goto-char (posn-point posn)))) > >> > >> posn-point can return nil, which causes goto-char to call > >> wrong_type_argument, this reaches signal_or_quit (eval.c), which calls > >> emacs_abort as waiting_for_input is true. > >> > >> A quick fix might be to when-let the result of posn-point, but I'm > >> unsure if waiting_for_input being true points to a deeper issue. > > > > Po Lu, any comments or suggestions? > > As regards suggestions, none at present. It's not clear to me why > waiting_for_input should continue to exist, but neither am I especially > satisfied with the present arrangements for calling drag-and-drop > callbacks in nsterm.m: some means should be devised of returning to the > event loop during a DND session, rather than calling Lisp and parts of > redisplay from non-reentrant input handlers that the toolkit can call at > will. > > Come to think of it, at the time this kludge was written, I never quite > understood why DND events were never received on Mac OS, when the same > was smooth sailing on GNUstep. So you think the suggested bad-aid is the best we can currently do to prevent crashes in those cases? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 08:28:43 2024 Received: (at 70311) by debbugs.gnu.org; 13 Apr 2024 12:28:43 +0000 Received: from localhost ([127.0.0.1]:60292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvcUt-0004w7-3e for submit@debbugs.gnu.org; Sat, 13 Apr 2024 08:28:43 -0400 Received: from sonic310-23.consmr.mail.ne1.yahoo.com ([66.163.186.204]:37044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvcUp-0004vN-Kj for 70311@debbugs.gnu.org; Sat, 13 Apr 2024 08:28:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713011303; bh=SYlTlx0zm53jp/z2rhn64neTdGmtvQBA0YUE0yzSKag=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=V1GN4Gp15U7ATYHHc2rs87v5VO4zhHbP6WIXKRQBbDGFjUhLMPfz0QiJIAKm2SqeKNwJXw5LF9v4J77smCCSeI0pqgWobQhQ2d/k4fXv1wKrpEQAkEaGebKle1JctiFSiX9yEm+Tu679r0dwPE6WqBg7pb5qO2JLM9GsNlmAoX926G9sgVzA5akvA5XXRepRkv6J+LBxBgbviku6ihHLqbSDRpRGnvFJGUAsBoPlRORWXzqsFpxCNkI3PsixHXhzJfHLFn+fvkufxEQq2JR+UEDBmYNmxkZwqTNR46MLKX7Bjba8d56DEZKMhTIm1DZAvcRc6bV/0FnFzPsHh++vHA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713011303; bh=5pFkPeGAu/aizVIfhYmp/2GOlWikkoB8tYGl7wWwBH2=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=QlN+xXAx6moPVLYM+syD3HvAmAmMlglcigFjSxUPommq8BgGqKU8Q1UOvqCSEMiYm/XYE396wRx47RVgM5UXGzPMhu1gTWVRCoAPXrl82ELtBQTf8QOnUa7ZmBzZvk7MFR+VsJ+7eul9eczCenL+KdUMiFEekPvst/WopwFZ7GNVWKb4zUtcz6fNHpDbT4hAwggI356NKYequ+CjoYUr9NHVIMS0bqZJO3+Anfj95I5Dkp6sKyqTi0y/ltc+ZnKXj3rQdri7NCLfTgU55aOcAZr3BjqZ5f6lrU/XyRPFSwcoEhdeKzwdBHupH8IU3ongJUQX1DHRH3j8ArlBpqv4tA== X-YMail-OSG: zAsBucAVM1lRe3mf20iXQ5DysjHY3qsS3c9aPNsb.GFIDHvURw4B59PrWvKaNSi NziigX5vnyi8FZtI.DwpkgbrTcdgnkCM6i8F6qpiqeeNk.2GbhEuf0UtDjdRICbMb_fv5.YqrBez eQ2IBJ1FLn1k0VqMYIiDQyJYeSqlVoewF.s_aFHdTAqQqlMt2EMy8QaDxZtmmh20KvbMJ1vlChVu 7jTOFVhryzUb3_qfnEFR.jr7ZeMcSVfhRWHTkutSJL4MdiD1500adbOvgYXnbCjZMV2DLZtbXw4q sVZzKC1qF2zDlJV3cpCVjIgyg4aWH.UuwRoxo6MHEUN0RaAgC06J5DsldaOL6P7uP6IMLBHjjDIP UyPob8ulYwvvVkQFO94sqi.EC24lHwE9whEPoCmEauiBIB5WZsbaiFRvatARKncpwVdUxGuGaC.F pAVbQEzhzv7yVsXPF5xtFL4i2uoB6ZUgyQyWEswjh9CVuMU13gjD3erRJk4nYaO4HcIQi1_Z_FSW Tb.SB9X_bhxZj.8p8CjlA7UI3bUDBD_l_S7O15JaMgRUY3y8iGI2fH92Ftn6HKBrUZl3hlc4lRgf rth9US5vhCFrRziXWQWLeYGqm_JI439EkhU71DvipceiRq5U6NVfZccJWXbdXKaZTxNRF7ptVFIK LbMWzqFnQnQXuZGDyIIFq91Xwq5tC1J3pZsn7EXcY0xZABkl94iiPHcbNwainuLnTZmPO6F4gUVQ PZxQfM4p.BdKUbTeh2LGDH4SAUbAMErSAS73YPguNZ6n4kRZ_wnxxQtxX7eQlhx4cHJamRKEXcmK zbLKV3b8Nvg83DBOMdF5F.hTvJsZ8KRseMhtLk1uRVcG__dCVI09IGEQcSVyxmktJqNd_1eMqHgx kJOX.D_XhZvHTuc9ii4jpaSyfKuY.a4YBmxjdDCrjQK9Zl3nkqIsWd71WwX983n.1HxAzQihJrmI Pi5HXboaQasmncAiAIBL0WHiUut_sx4VfmHidYMvQuKwSb.FECmiIGJBWGOM4DC3WTLInU1ij1iL J56cUQN0vb9aTake.nUfYN9dNtfuCRfI1IxhoAIsSCn64n0xCprXT8gA6dvlFIhKnyCsOMGm1.uf KQLHHyvqqG5bx.X0LLysfHmJLBtSm7Z6rRevFCC8ri978oVDm2iD.V6cZgMM_3g5fqYGvTtKfqCB JJqU69c0HTS5zwdBPTRmr5bPyPrVuiqt3QQgMXE80CA2IhoxwOUhDkG0vRtTGWXb2qLHZhKJKMyo nDbBLzIDl5jSMsGUQzh.I5jxaET131OQbT1CJKslEoXRAlTOHSJCMygMUrauZ2kI2_mxX8BzwNRJ PpxaqjfbdOoXgr3J7lTorU7q9DepHBZ4NiCB8EMKAOxwdzXEOYRyUq9fwwPLuftG3xGTsXcjQTwh kqxqC6EfUZFf7gu_yVHZhc9nof20Y2IHl6y.tV3aWlnoZzHOyDJ3khGujNOs0M70DonMwFGHYdyV o3ysQNO8..vQSFr5pBfokkCfsRbsDM41WUTi67gC__Q0q3zv1EnpIAb8feWp_zPu3ljgXu7xl6zx 5Pp1dAXqL0VGnLaOsj2w63UlmXTszhQEhngsgoEQveZ2HOzehiAoROOf2r2gap15o2oafViJFWxl yxdeDtgcy5mFFDMS1nrBk8fseX1nJ.lSmGULrMVDBS7rEVL3frJBMPDJ_5YeJhVZbAKSH0ypWOI8 R5ep8CqNq0URw8nbLZutt314Spzpf6_WCc.wI9S8sDoKhot8Wkz67JyKceb85R23M9E0ayFL6hex HJVpYpQT9d_URbfnJATa3QA514_WnvzTOrlFBrDFrn65KWLkvHupR24Dv7Seac5NI1e0BJWNNU.r MyuCTGk8AsmthDEe1Pu56HxmqjbJCKkKgiuytXhaSSzSFiyfEz0_P.xBwD3ubTZLF1va9t6IA6Pj flIUot8jgoSRlVoBjECKPhmhYy50Zxr6ZJPu89jlE2bcKUpMsfYLOXmANyGZtd311mWwWwBEySzm sraVTUzlxaBOjYzXV4dryH6YP0rxXjBlRM5MLyjIbuhR2TS9pkT7DPA6golJv7cdmeUmQ0ZLObB8 n50Dm5Pf.E8Mp95McvqZC4OL1sgGgmrMuTqco.qNXT0Io001IvgoZOmGzF0XM0ByaVr9DadwF2ln pAmA6_LsRaXD9o6w5PoBWMeagD.uoPNMg2IbPKlqS.5XlVHThTnYyeD361P6iDl0AHIq3lHv8A.l H_wMR_FwRtV.qp4wOgjf714m8qmDshlCgNlHAUqKzt1VYlKu9t2T7p3vhy1xNFuJkDXIlug-- X-Sonic-MF: X-Sonic-ID: 74ce80eb-9bcc-40c1-9dd9-58a7911ca4f9 Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.ne1.yahoo.com with HTTP; Sat, 13 Apr 2024 12:28:23 +0000 Received: by hermes--production-sg3-6f9f87bd85-fwdz2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 92351c9f478f72e4371cec7731822b11; Sat, 13 Apr 2024 12:28:20 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#70311: Crash when dnd-indicate-insertion-point is non-nil In-Reply-To: <867ch1pium.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Apr 2024 15:06:41 +0300") References: <86wmp1pqj3.fsf@gnu.org> <87il0l325a.fsf@yahoo.com> <867ch1pium.fsf@gnu.org> Date: Sat, 13 Apr 2024 20:28:14 +0800 Message-ID: <878r1h30rl.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.22205 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 165 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70311 Cc: 70311@debbugs.gnu.org, gregsexton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > So you think the suggested bad-aid is the best we can currently do to > prevent crashes in those cases? Yes, unfortunately. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 12:01:22 2024 Received: (at 70311) by debbugs.gnu.org; 13 Apr 2024 16:01:22 +0000 Received: from localhost ([127.0.0.1]:33693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvfog-0001C7-07 for submit@debbugs.gnu.org; Sat, 13 Apr 2024 12:01:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvfoc-0001Bc-MS for 70311@debbugs.gnu.org; Sat, 13 Apr 2024 12:01:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvfoL-0002MM-Kt; Sat, 13 Apr 2024 12:01:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=83iU4u0imuV63p70yyvP1tCTP/LsuyEUgaaETW9jVC8=; b=qEh6Q4prt6YG wu9ZvAW8g+/ZXDNScKXDgirJf8wgclata5DoQe+Od+ywkV9W7lvdkVju3OK5r57ClIqwFaNycC1+x yR5xcE55W/rDoV9DhDzYprUL9GKjjDZWQQ9V6A5H37qGN0YayG9/fhdM+ZqA3UGOzX904KM7ychpG N9uGIYyPQ7Si+yQvAL776B2Lnin+JZabNdVxvWPqVMtgnzrtIdLPq55qFXG+RvifG6OzkQhHBzuzH Gmrw5gmJHAkMXLEKMS8saqtjvmfaC5D2OKmt1ZULUQbDzyLn3/94jTLV/RLiLHzOI0/x7VRSecYC+ dRmMITu4g+MrvZbNHBPloA==; Date: Sat, 13 Apr 2024 19:00:57 +0300 Message-Id: <86ttk5ntfq.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <878r1h30rl.fsf@yahoo.com> (message from Po Lu on Sat, 13 Apr 2024 20:28:14 +0800) Subject: Re: bug#70311: Crash when dnd-indicate-insertion-point is non-nil References: <86wmp1pqj3.fsf@gnu.org> <87il0l325a.fsf@yahoo.com> <867ch1pium.fsf@gnu.org> <878r1h30rl.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70311 Cc: 70311@debbugs.gnu.org, gregsexton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: gregsexton@gmail.com, 70311@debbugs.gnu.org > Date: Sat, 13 Apr 2024 20:28:14 +0800 > > Eli Zaretskii writes: > > > So you think the suggested band-aid is the best we can currently do to > > prevent crashes in those cases? > > Yes, unfortunately. Does the band-aid below look OK to you? diff --git a/lisp/dnd.el b/lisp/dnd.el index 89652d3..de1c58a 100644 --- a/lisp/dnd.el +++ b/lisp/dnd.el @@ -149,8 +149,13 @@ dnd-handle-movement (with-selected-window window (scroll-down 1)))))))) (when dnd-indicate-insertion-point - (ignore-errors - (goto-char (posn-point posn))))))) + (let ((pos (posn-point posn))) + ;; We avoid errors here, since on some systems this runs + ;; when waiting_for_input is non-zero, and that aborts on + ;; error. + (if (and pos (<= (point-min) pos (point-max))) + (goto-char pos) + pos)))))) (defun dnd-handle-one-url (window action url) "Handle one dropped url by calling the appropriate handler. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 05:24:46 2024 Received: (at 70311) by debbugs.gnu.org; 14 Apr 2024 09:24:47 +0000 Received: from localhost ([127.0.0.1]:34297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvw6P-00063u-6Z for submit@debbugs.gnu.org; Sun, 14 Apr 2024 05:24:46 -0400 Received: from sonic307-56.consmr.mail.ne1.yahoo.com ([66.163.190.31]:36703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvw6M-00062X-6w for 70311@debbugs.gnu.org; Sun, 14 Apr 2024 05:24:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713086665; bh=SYt9190WG096Az3ZezpNbNhJpuIPadqU+FnXwqPdM3o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=qT0TUN5x1uTcaawXLcvDM0EW5BvPR4+KDjUHNE1mYuhtY6+htTpvleYY4c+9JLIS0bTvFtI7pQuT6nbxdtTvbwmaj6tHwLtv1Q4GSAaWVP0FDlu1XiHCpjx+NAh+Bfjzi7yWNHQIm5wVJodkDuiQn08ul0+Pk/BOeWt2cHjUL9H+UJzqkb35EAn03Mmac0I1O2rQzQbsp0bzTZBuFpEhYxQAI5K8Yy12DiBXIemHx2wSzhUtFudzre38BexilGbTo5osNsb+kDnRglqKcn6Y2vnYe2OS4pKgWGcOfFvvHNHh/y59UjaHNxwzb7yQDLrqpavPYd2pB+Og2xVB6+yTZg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713086665; bh=9/vcfIyBxMadnbvJQJBVHfg/FASGVEsvfE489DuGIqj=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=XlHXFtspnh41VG2xBmQVHPdjOhQixVhQr/yt6/PiczhwbVgNYrp2puqlYqwYFGjOTCkqt6X78FPcyuxT4hqsy3nNQtVhkg4Ar/8oYoo6rfj81DISRUIB8L7IkQ2LqzxqsrJask/aGjHKzleQ6VAJLSzXwOXLcVpVDVVgUGvgAr1c6k7BPgf3dWRb0ffYGm5DeWyAv5qX0brHvkbvlkoRH+ZAieIE7Dac/Xh9dDC8+P7fs2e/nixhh2EsjCyK8k8m2QbeciV6HOknbf0mvh2kswoo6NI/ZLfW4Ss85yEzh+Wrr4gfjILT4a8yE75aClsWNcc8VQ0a+NpqEVeNhtfpGg== X-YMail-OSG: C9mim44VM1kUoSZPqpqMl5XjrM55qcHr4_shmnwrcga9lrejKYmMTKtDQFn3yzy fgiN4WAavwAeKh8yng4v2niNLpCxIk6m1z2FKEqKCBEBJI6zNN2vqakPvWCQ8dnmLLEpPYWxZju4 s.bZzWFgvLmeFfpOfJ4rchDz0bFPF2.ZpOgxr2mgK14NNKLFFRZ7VMX8yq7M2bbOgP_HQQbEMDKF e1ApD1_7SPEY4z5W5lnoQrI9XPVNYz5Hdsu8rN4eJCXpRUsMHEnBhdzfo8ZD2d3Gw6a8UQezO5uU EIYlo8IDXYzdDxnYqAUOdqscdlsOjhLb27_kbmXcBb.ae7zQeUKXNvdRbMUbQ.sFefM.Nqm.ItEa En8tk8vLxIw3oDPd42.vsHmMxoSCm0Z4eS.HUjVWPS2RLT.qVWpW2Fa8mWCfuzBgYlqzIhQ3jonv XIdWBWpUI3k8Er7I014efaTSqXUCgxhp6ttYOubFsVc5okA5k9Ue3juQV.CUXPE9sQiZimx0.yd0 KuaaBz4G60HSNY5Hs4aVBOuNixl_.EpLDT156cF.fJ5qvbFU280Lqpsp7ptgsiGoiKPRZ9YU5gSF gSuY4Qwm4cmkSto42boYFEYkCBVlhWg458Tk6L7FxtaNpf.6WyuDgW5HUAGSau.A94y1Kbty8A7w D67KZNmOxmvFAH5C_dsTe0QSJNwL41HB4T.5WXZqwuLeEw81NK76lZwaCWgfKDFdOsMssu1nU6IU s1THLORVvlzweNvAaJAXpqilEMCo1mHnbD3sM9Vxp3LT62IlyQPifVBpmMpO_F5ll2XH8OYZ8oUS oHrbFDWM3ntu0BlVuCNsvxHt70BHYcUJLrHh1I5APnStd7MdENibDmzHEQgTBmVRYsRUmiWT.l8z lDOECPox822jSB_UzFqZSxH5.umj7fXzhjWi.FthseBHubV4LpwGdMOxA0IPRWRDm0fdcwkWdtrV X8DUg1aDgmsivtgtb8.u1Nv65dl2Tu19y34j82Mqp4qXhq_TO.UUjdZwufIaiVtgHXT5kkbj6Rdb vtzjg_jojowXNf3MZYsTr.PQanblet2MI_OeofkAW6QCrSnMjJVX04zvkedGhtpqHmeDF6Pk48I9 K7cxuOLM3JKwsNvPD5RMsRx4h7vzPGgz_z3BsG4iipLAKU3dnzIokspOHei7GC.KfQDecCEnwnY6 tNkFKFUSZt8WJJukQbpANtC4ofwUw5DSxAlPJFIjBE0cjV9MV0hF9.wdv5_9hRsTg5AK9dYXxpPs gDlHjvYCGbcNTrZDTMbBbQxYYKcq.5aIbsag6BFtmz.cAMoFG2GlAp2dVYdkjBgOuE8VrAby.fLL SsqosLJ9fdkiyXc3OIR9PXc5VegyyCUUmvQ_bo_MnH2mXRdHKyjXhnzcIEIT6jrwT7BCGE0jaT11 iP8Ajt8X6gEIKIt.Kkj4QLCGcIG3_YgcZttYIEA2.QPu40yl_GCMpy6SxscF0RQdXQFJw83Gv447 sGR5YlhODLvpogIbnOSmqz_apktbUqo48AsiwkyxzFwVlPavcUNZfpYSj15f6AJEOB0MKnYSCKAw 4Cyk6lgZ6DfcdiV1EszmRcz2jPKIXb1lmCrFJbEN6hzMrff4fu4zEC3fn1f1H9DbuBfsn6pHmQNs akOoAJuZrcQqesmW0uzDB9rWI5VzFe6RcGJfGjOZLvXuZSgezAwlDr.CkvYbflBx4kTTV9v5u3V6 AzxREFTrwrG2oj4dhuy4iGroOxgojJEpKb8tMsG6VRlzqeWp3sSzWLqhZGtIyEhHzq.gvcb4WuHC 0bHGyiT4.DtPQzlM5ourUWNpBXH8bSqFp73Fkn_1AwSjA03sID2Sxqz7macp69YyYmtHLuu4OXeo epibo2saKW.t7HLWZAs8pPwDwk.qIxEiqrCOM8VdfI4Z6UopPIjQWLviqBmigCnSREAMC1AdiX8e oT8D4SCbp1nXwQ7UzbNB56ATAlHLMY4Sxj9wwhMjIrDJPTFGCVfS3fX2LuHHUSHjGThp92LyB_fL yN0n6qxZ2JbP1wjC2qdug2Xomivz8TNu6kuy5CQ3qscvbs4E_QmBq3DgKgHOnc_bD1rUEM0Dv3jR aZpZKORGtmXb.3afnuwHiUzpthGQUMK_YjNQ3IM9lo7UVTBWDYGBP_XXo7hGUIYeEegFSDFh8PAd CIgBYRza184oIhdWLAL3_o6ArjpqJ7l5expafFLJXNRsQr5nF71ctaqycFY25m.ykTz.vWBHeUKH u9FbmKXcbLp7ZhJEfFDSRB_tujJENF5gDBcSTcNyf2Y6Ua8QuPhGWiRCPE9DTahzlZCc- X-Sonic-MF: X-Sonic-ID: 5e606f9e-f441-42c2-8be9-431deb802ff7 Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.ne1.yahoo.com with HTTP; Sun, 14 Apr 2024 09:24:25 +0000 Received: by hermes--production-sg3-6f9f87bd85-t6lxr (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID eda24d5cc5ca3f089b84487c71cbc09d; Sun, 14 Apr 2024 09:24:18 +0000 (UTC) From: Po Lu To: Eli Zaretskii Subject: Re: bug#70311: Crash when dnd-indicate-insertion-point is non-nil In-Reply-To: <86ttk5ntfq.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Apr 2024 19:00:57 +0300") References: <86wmp1pqj3.fsf@gnu.org> <87il0l325a.fsf@yahoo.com> <867ch1pium.fsf@gnu.org> <878r1h30rl.fsf@yahoo.com> <86ttk5ntfq.fsf@gnu.org> Date: Sun, 14 Apr 2024 17:24:12 +0800 Message-ID: <87o7ac1emb.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.22205 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 1122 X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 70311 Cc: 70311@debbugs.gnu.org, gregsexton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Po Lu >> Cc: gregsexton@gmail.com, 70311@debbugs.gnu.org >> Date: Sat, 13 Apr 2024 20:28:14 +0800 >> >> Eli Zaretskii writes: >> >> > So you think the suggested band-aid is the best we can currently do to >> > prevent crashes in those cases? >> >> Yes, unfortunately. > > Does the band-aid below look OK to you? > > diff --git a/lisp/dnd.el b/lisp/dnd.el > index 89652d3..de1c58a 100644 > --- a/lisp/dnd.el > +++ b/lisp/dnd.el > @@ -149,8 +149,13 @@ dnd-handle-movement > (with-selected-window window > (scroll-down 1)))))))) > (when dnd-indicate-insertion-point > - (ignore-errors > - (goto-char (posn-point posn))))))) > + (let ((pos (posn-point posn))) > + ;; We avoid errors here, since on some systems this runs > + ;; when waiting_for_input is non-zero, and that aborts on > + ;; error. > + (if (and pos (<= (point-min) pos (point-max))) > + (goto-char pos) > + pos)))))) Yes, please install. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 06:18:07 2024 Received: (at 70311-done) by debbugs.gnu.org; 14 Apr 2024 10:18:08 +0000 Received: from localhost ([127.0.0.1]:34375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvww0-0005kp-5A for submit@debbugs.gnu.org; Sun, 14 Apr 2024 06:18:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvwvu-0005jg-Od for 70311-done@debbugs.gnu.org; Sun, 14 Apr 2024 06:18:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvwvd-0007Sr-42; Sun, 14 Apr 2024 06:17:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Cjum1L8f7AWEsEN0hT189QEuXYvK3KUd9DSmX1Jtv+w=; b=Q3/Vp0kR1XmT peNJVMevVtxSLDui4fYXQdAmW1q5b38AFzJUvlVUniKNMh97jI2Sp+bV4WmykIEOMk+8XQsbHQaFS qSmafJ5i5xsRvh49Z2fQbi/vPOUQoUAPhMI5N/zynxTlDvhr//DoGf90lsiVWSND4rVARL6W0NyW5 0dZNDXCn00m6H6XSLexbrs2g71ggpYw2BWBJrRQKbgchoWfG7YKCMJFoJMkw6QqDnES/Fr59MAIRP ih1in8eQ44D8jXrd9m2q1ZQtYyqQNAda95Ki75Kt51yYYTdkzNJ48nWrLlv0qtVH1czfRdrKlHj5N JYEBFDeqRzDcC4UPjqG8WQ==; Date: Sun, 14 Apr 2024 13:17:37 +0300 Message-Id: <86wmp0meny.fsf@gnu.org> From: Eli Zaretskii To: Po Lu In-Reply-To: <87o7ac1emb.fsf@yahoo.com> (message from Po Lu on Sun, 14 Apr 2024 17:24:12 +0800) Subject: Re: bug#70311: Crash when dnd-indicate-insertion-point is non-nil References: <86wmp1pqj3.fsf@gnu.org> <87il0l325a.fsf@yahoo.com> <867ch1pium.fsf@gnu.org> <878r1h30rl.fsf@yahoo.com> <86ttk5ntfq.fsf@gnu.org> <87o7ac1emb.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70311-done Cc: 70311-done@debbugs.gnu.org, gregsexton@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Po Lu > Cc: gregsexton@gmail.com, 70311@debbugs.gnu.org > Date: Sun, 14 Apr 2024 17:24:12 +0800 > > Eli Zaretskii writes: > > >> From: Po Lu > >> Cc: gregsexton@gmail.com, 70311@debbugs.gnu.org > >> Date: Sat, 13 Apr 2024 20:28:14 +0800 > >> > >> Eli Zaretskii writes: > >> > >> > So you think the suggested band-aid is the best we can currently do to > >> > prevent crashes in those cases? > >> > >> Yes, unfortunately. > > > > Does the band-aid below look OK to you? > > > > diff --git a/lisp/dnd.el b/lisp/dnd.el > > index 89652d3..de1c58a 100644 > > --- a/lisp/dnd.el > > +++ b/lisp/dnd.el > > @@ -149,8 +149,13 @@ dnd-handle-movement > > (with-selected-window window > > (scroll-down 1)))))))) > > (when dnd-indicate-insertion-point > > - (ignore-errors > > - (goto-char (posn-point posn))))))) > > + (let ((pos (posn-point posn))) > > + ;; We avoid errors here, since on some systems this runs > > + ;; when waiting_for_input is non-zero, and that aborts on > > + ;; error. > > + (if (and pos (<= (point-min) pos (point-max))) > > + (goto-char pos) > > + pos)))))) > > Yes, please install. Thanks. Thanks, installed on the emacs-29 branch, and closing the bug. From unknown Fri Aug 15 20:55:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 12 May 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator