From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 06:04:41 2024 Received: (at submit) by debbugs.gnu.org; 9 Apr 2024 10:04:42 +0000 Received: from localhost ([127.0.0.1]:48315 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8LF-0007sx-Uz for submit@debbugs.gnu.org; Tue, 09 Apr 2024 06:04:41 -0400 Received: from lists.gnu.org ([2001:470:142::17]:37340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8LB-0007rN-79 for submit@debbugs.gnu.org; Tue, 09 Apr 2024 06:04:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ru8Kv-0005ii-FW for guix-patches@gnu.org; Tue, 09 Apr 2024 06:04:17 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ru8Kt-0002Kg-FZ for guix-patches@gnu.org; Tue, 09 Apr 2024 06:04:17 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-416b606f3e3so958155e9.1 for ; Tue, 09 Apr 2024 03:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712657051; x=1713261851; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=CNvf12J4hH25EeC8eKVEbo5JR5RL4QcJsf0YU2AAMlw=; b=EA8xghWwcMGElpBdwJDVI0CDflvSJwmxp1z0uhmkl0VmmrjiHzh28eSDtZ60P/Vudv JdlOevZdXx8nEnIxZxjZVuIo+0cvE1NoZsbfQ9c3Sygir1Sauje8NRRpEJQeEavL7D8h vO/clVhFi71XY5YG4KerNkmRc1F6YcjA6jHQLei7ZFQx3HbxV8bl51wTlIw7bQB51ri1 pWw9M31AY/ncp8n2TBwrCzUKQpCUKWKOEBaBeAbEkVT/zljrfcusLAZ5CuiOfgpuh2c9 02EnaT8x0ZPOD5y2XYzDOLYhiReMw+yYIlQJh1J7hBjr30/A+br3DwuqxHm8567tzwbl eS0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712657051; x=1713261851; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CNvf12J4hH25EeC8eKVEbo5JR5RL4QcJsf0YU2AAMlw=; b=JEYDTDLaI2gM3rW1dairGMwDtwcyAcf0ZXwVSStc3984r8Iv9PRTrs11aDNZXQvsPP LO2kGmrm/BDbibinXTzYQeifiyP/gCS1hJAO9RhRG/yrnqatsOckjMbM246LhxoqC0Uv roYtONFoqzgLeTcDIkDVASYz6wzmUuEeBl7hjU615y5PryOJt6ikFNg1iBqUzVZkzZas OanOWwbcdrYtC32c4Ss46qcC99KnE5Zw5Ee5YqGyZBcQXy+akhcoh5N8Vf7n4gjGNv+9 Z8ieNMmjXQgydHeWFgWg2m1gxVv/l25crTXBJebk+nCXbSh7OEIHgLlzpvC1fJFSqrMn sNlA== X-Gm-Message-State: AOJu0YysacGlPn6cFrqhl3R5M0nirnharSGYjsUaekVj6bSjpHJ366ax hWEc5UVFR5VP/HgMLrpAkDqvrlg151TymqoR8jmD9LU+fWoKJtso7pWXF+laKZY= X-Google-Smtp-Source: AGHT+IH3EHojIR9NVytYdi/MVdoYLB0IjLn8TobEHJy1LOFjWxuMM6j3STZE5AKOcYvFqIoOHWoPMw== X-Received: by 2002:a05:600c:c89:b0:416:b91c:f310 with SMTP id fj9-20020a05600c0c8900b00416b91cf310mr58424wmb.22.1712657051121; Tue, 09 Apr 2024 03:04:11 -0700 (PDT) Received: from localhost ([141.226.11.200]) by smtp.gmail.com with ESMTPSA id p14-20020a05600c358e00b0041674bf7d4csm6647892wmq.48.2024.04.09.03.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:04:10 -0700 (PDT) From: Efraim Flashner To: guix-patches@gnu.org Subject: [PATCH 0/2] Use guile-final for grafting. Date: Tue, 9 Apr 2024 13:03:58 +0300 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=efraim.flashner@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Over the years the grafting code has changed bit by bit, with various attempts to speed it up. By switching the grafts to not use parallelism in rewriting the leaves we can finally switch the guile-fo [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (efraim.flashner[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-Debbugs-Envelope-To: submit Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) Over the years the grafting code has changed bit by bit, with various attempts to speed it up. By switching the grafts to not use parallelism in rewriting the leaves we can finally switch the guile-for-grafts to be guile-final. The segfault is still there if we perform the grafts in parallel, but I believe it is fast enough that it should be fine to do them sequentially. There's probably room in replace-store-references in (guix build graft) for changes if we're not going to use guile-2.0 here anymore. There are also a number of default guiles in (guix grafts) which should maybe be %guile-for-grafts instead of %guile-for-build. Efraim Flashner (2): graft: Remove work-around for old guile. graft: Perform grafts with guile-final. guix/build/graft.scm | 55 +++++--------------------------------------- guix/packages.scm | 6 ++--- 2 files changed, 8 insertions(+), 53 deletions(-) base-commit: 51de844a0ff6ea224367a384092896bce6848b9f prerequisite-patch-id: ea387a4f9d860397a26c840c11c8742f0ac70fc3 -- Efraim Flashner רנשלפ םירפא GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 06:07:25 2024 Received: (at 70303) by debbugs.gnu.org; 9 Apr 2024 10:07:25 +0000 Received: from localhost ([127.0.0.1]:48332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8Nv-0008Ec-Cs for submit@debbugs.gnu.org; Tue, 09 Apr 2024 06:07:25 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]:51442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8Nt-0008DV-2U for 70303@debbugs.gnu.org; Tue, 09 Apr 2024 06:07:22 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-41663330f9dso13828255e9.2 for <70303@debbugs.gnu.org>; Tue, 09 Apr 2024 03:07:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712657227; x=1713262027; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=iYeo193M09XZw9GmqZfnDBoHwx8WW3qktRYAh8/kTlA=; b=EIzEJLy3V4FzxsTrVzf83vbzPJfQ8nvigxkwld97RYyRIWSuaVaVJ1bJBNGHhoIbUu 8D0tAo3Umv95rBYzKrwgrEEeorE7y4VNxsQZn40eHw95RJ9yKPPkSD9eJ08YO51ELyMx LBQGohmUApEX1U7IrMY1fQ3y9h4wnvZkY1/WXlsUAnV9E1hiiWLuajFo4qz5RqgVwDJL /Ugw5244fZU+fbRe0asvbg1kAFCE+AS8N/YbutuHw0g+fBnhlVwRIEcihQcbKq8xH/G3 H1/TLrwXUs4rqGdN7Ffthi9zmQi6kjuaE9Ji2xoEivHGqS9UKV/VmYAiJx6B4rb37Mt6 u11A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712657227; x=1713262027; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iYeo193M09XZw9GmqZfnDBoHwx8WW3qktRYAh8/kTlA=; b=XRjalShi5eMcexfYDu5a4baRt1x8karYm7ElztuA55HGCejjmtFRhPY83KfZPTJyzV YJhhgbmNg/F6DZnikA137dQWtxnjMh35/FezCWI6cxoHJQUpTZlF72uxbHpb/MMKBzw0 20SBcTQKiqwNYf9mFZ3byT3Ha+GSV/FewwwUMwPKCo7/UIwQFlA1nOXU2DC02vmxJNGs a/sJJsPuYVveSTl/TonIhyGuP1ePSulEtUH8v0Wm8qv0rElTcPPGNmtqr7H2sEV6AjYI 5EKM6/QJa3Cr0UFkFDegg0AiZIe7GyNUSUbtsOKQ4T3iskihY/Vqx2iy9j6/7s/vvPk/ 6fGg== X-Gm-Message-State: AOJu0YwX6PWF6iVCXgKrfsk4EaXEwRW58ih8aEjoqZ/7FBQlTlDULkEJ vNXuRH/DaX8taYOwhfJJVZOx5Yds78D8gvuvkkW92qDsBPsugx8dkLXjZhFzNHg= X-Google-Smtp-Source: AGHT+IHpjKRnPV2eI7HZfpSjSVxhx8JJNlKn/40L+C49Pj8y13GT47OVs0yb7POmKnr6X18GoFFJLQ== X-Received: by 2002:a05:600c:5253:b0:416:7396:6b14 with SMTP id fc19-20020a05600c525300b0041673966b14mr2980476wmb.5.1712657226717; Tue, 09 Apr 2024 03:07:06 -0700 (PDT) Received: from localhost ([141.226.11.200]) by smtp.gmail.com with ESMTPSA id o13-20020a5d58cd000000b00341b7d5054bsm11133842wrf.72.2024.04.09.03.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:07:06 -0700 (PDT) From: Efraim Flashner To: 70303@debbugs.gnu.org Subject: [PATCH 1/2] graft: Remove work-around for old guile. Date: Tue, 9 Apr 2024 13:06:55 +0300 Message-ID: <3d8f8f3135f69cc88a7d0575ce533d489239ede8.1712656502.git.efraim@flashner.co.il> X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70303 Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * guix/build/graft.scm (mkdir-p*): Remove function. (rewrite-directory): Switch from mkdir-p* to mkdir-p. Change-Id: Ib6a80648d271c19093c05af84acb967e069ccc19 --- guix/build/graft.scm | 31 ++----------------------------- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/guix/build/graft.scm b/guix/build/graft.scm index 281dbaba6f..c8c7e33ab2 100644 --- a/guix/build/graft.scm +++ b/guix/build/graft.scm @@ -312,33 +312,6 @@ (define (exit-on-exception proc) (print-exception port #f key args) (primitive-exit 1)))))) -;; We need this as long as we support Guile < 2.0.13. -(define* (mkdir-p* dir #:optional (mode #o755)) - "This is a variant of 'mkdir-p' that works around - by passing MODE explicitly in each 'mkdir' call." - (define absolute? - (string-prefix? "/" dir)) - - (define not-slash - (char-set-complement (char-set #\/))) - - (let loop ((components (string-tokenize dir not-slash)) - (root (if absolute? - "" - "."))) - (match components - ((head tail ...) - (let ((path (string-append root "/" head))) - (catch 'system-error - (lambda () - (mkdir path mode) - (loop tail path)) - (lambda args - (if (= EEXIST (system-error-errno args)) - (loop tail path) - (apply throw args)))))) - (() #t)))) - (define* (rewrite-directory directory output mapping #:optional (store (%store-directory))) "Copy DIRECTORY to OUTPUT, replacing strings according to MAPPING, a list of @@ -387,7 +360,7 @@ (define* (rewrite-directory directory output mapping (define (rewrite-leaf file) (let ((stat (lstat file)) (dest (destination file))) - (mkdir-p* (dirname dest)) + (mkdir-p (dirname dest)) (case (stat:type stat) ((symlink) (let ((target (readlink file))) @@ -406,7 +379,7 @@ (define* (rewrite-directory directory output mapping store) (chmod output (stat:perms stat))))))) ((directory) - (mkdir-p* dest)) + (mkdir-p dest)) (else (error "unsupported file type" stat))))) -- Efraim Flashner רנשלפ םירפא GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 06:07:29 2024 Received: (at 70303) by debbugs.gnu.org; 9 Apr 2024 10:07:29 +0000 Received: from localhost ([127.0.0.1]:48334 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8O0-0008FX-GR for submit@debbugs.gnu.org; Tue, 09 Apr 2024 06:07:29 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]:61508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ru8Nu-0008Dm-K5 for 70303@debbugs.gnu.org; Tue, 09 Apr 2024 06:07:23 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-343c2f5b50fso3591137f8f.2 for <70303@debbugs.gnu.org>; Tue, 09 Apr 2024 03:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712657229; x=1713262029; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=t+PeYFE4Q3SHAojuyM0mZQr+09nvn9cStfNPy0LcHZM=; b=YBCifrybZWxm9f7o8W7b2e4Cu6wgFn6b3YSSBXJu8VeiKRv8SZYHrMkvybFe0HiA7i oVhnBo3pw0RuFMDuRMq+KTTyVkuqD8cKA17sNIXomu0vPualVh6K0Pzb4eNquAmexpf7 Z6QrzczzTog8jlvVAlxU77NsaCxVPLUR6u0D0hf1o4ZjRVcBewUmQSYNXA/NOpMfvcCI vy1Qe6u1Zhi0rW67ps5vOa3PHwzXCrbR6065aE1QRP5CEcCZRpjMdD5lxE5sbV5sAnD3 ULpojOLMXe5Yu8su6Rqa8pqjG03mgKewdvxU2BVbrDkzLmYyv3fXIzYPB9mdKU0T64zj /3tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712657229; x=1713262029; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=t+PeYFE4Q3SHAojuyM0mZQr+09nvn9cStfNPy0LcHZM=; b=Q5bvIDvWTU+bw46Fqqloe451CT+aZDLuPWPo74nXrLpc6JWObS3oS+S/TBBNT4prM8 hXbypqciEiMARH/tKNw4Bwr2+Rr9LS0lZm5RQnj8ZFSvvEoZjLss3qCOv3qG44qb/aia yNQJV8nu9SPQHI5Ay3zs9lg6fi9jWahWFrfqgOt+2kJkkjv1wJv01cuvBENDz9IzhXZi D6iZ4VC9y954Hg3EE7syW8Boe0xMPQ71DoG2BCwGetlERarGyxVv05ZugViHfvdJ2Fl7 PVWp6ahHqhB8+focuAyJN0ySJJwIRqpt3Xt36y+akAherZmEHchcmqPLHipOX8LNIdUy BF2g== X-Gm-Message-State: AOJu0YxX2ipVVZXS5wOTjSeFVsjfg4rBVAAFtPnBZobj6XBdX5/1PHqj 1IrbThVGmA4dUYWOE4VeRvoQ9LiwtPeOLnQmNMcAb2N1NXbbactnjl/+X/0QlHU= X-Google-Smtp-Source: AGHT+IEHtRSN0/sjZZf5zIfnMiKEzkkqYotAkj9+xuoS1qaNzf3uxAS/azgVJXodRaPQHJ4USERPRA== X-Received: by 2002:adf:e4c9:0:b0:341:9db8:6269 with SMTP id v9-20020adfe4c9000000b003419db86269mr8768871wrm.48.1712657228528; Tue, 09 Apr 2024 03:07:08 -0700 (PDT) Received: from localhost ([141.226.11.200]) by smtp.gmail.com with ESMTPSA id h2-20020adff182000000b00343e6bec771sm10715019wro.94.2024.04.09.03.07.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 03:07:08 -0700 (PDT) From: Efraim Flashner To: 70303@debbugs.gnu.org Subject: [PATCH 2/2] graft: Perform grafts with guile-final. Date: Tue, 9 Apr 2024 13:06:56 +0300 Message-ID: X-Mailer: git-send-email 2.41.0 In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 70303 Cc: Efraim Flashner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * guix/build/graft.scm (rewrite-directory): Rewrite store directories in individual files sequentially. (exit-on-exception): Remove procedure. * guix/packages.scm (guile-for-grafts): Switch to guile-final. Change-Id: I50f7b23a3ceff8bb1495dc1f4bc772746147d924 --- guix/build/graft.scm | 24 ++++-------------------- guix/packages.scm | 6 ++---- 2 files changed, 6 insertions(+), 24 deletions(-) diff --git a/guix/build/graft.scm b/guix/build/graft.scm index c8c7e33ab2..7fc5ecba99 100644 --- a/guix/build/graft.scm +++ b/guix/build/graft.scm @@ -299,19 +299,6 @@ (define (rename-matching-files directory mapping) (string-append (dirname file) "/" target)))) matches))) -(define (exit-on-exception proc) - "Return a procedure that wraps PROC so that 'primitive-exit' is called when -an exception is caught." - (lambda (arg) - (catch #t - (lambda () - (proc arg)) - (lambda (key . args) - ;; Since ports are not thread-safe as of Guile 2.0, reopen stderr. - (let ((port (fdopen 2 "w0"))) - (print-exception port #f key args) - (primitive-exit 1)))))) - (define* (rewrite-directory directory output mapping #:optional (store (%store-directory))) "Copy DIRECTORY to OUTPUT, replacing strings according to MAPPING, a list of @@ -383,13 +370,10 @@ (define* (rewrite-directory directory output mapping (else (error "unsupported file type" stat))))) - ;; Use 'exit-on-exception' to force an exit upon I/O errors, given that - ;; 'n-par-for-each' silently swallows exceptions. - ;; See . - (n-par-for-each (parallel-job-count) - (exit-on-exception rewrite-leaf) - (find-files directory (const #t) - #:directories? #t)) + ;; n-par-for-each can lead to segfaults in the grafting code. + (for-each rewrite-leaf + (find-files directory (const #t) + #:directories? #t)) (rename-matching-files output mapping)) (define %graft-hooks diff --git a/guix/packages.scm b/guix/packages.scm index 930b1a3b0e..80642eb049 100644 --- a/guix/packages.scm +++ b/guix/packages.scm @@ -882,10 +882,8 @@ (define (default-guile) (define (guile-for-grafts) "Return the Guile package used to build grafting derivations." - ;; Guile 2.2 would not work due to when - ;; grafting packages. - (let ((distro (resolve-interface '(gnu packages guile)))) - (module-ref distro 'guile-2.0))) + (let ((distro (resolve-interface '(gnu packages commencement)))) + (module-ref distro 'guile-final))) (define* (default-guile-derivation #:optional (system (%current-system))) "Return the derivation for SYSTEM of the default Guile package used to run -- Efraim Flashner רנשלפ םירפא GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 15 16:29:16 2024 Received: (at 70303) by debbugs.gnu.org; 15 Apr 2024 20:29:16 +0000 Received: from localhost ([127.0.0.1]:39434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwSx0-0005xq-Hx for submit@debbugs.gnu.org; Mon, 15 Apr 2024 16:29:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwSwx-0005wY-Kv for 70303@debbugs.gnu.org; Mon, 15 Apr 2024 16:29:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwSwf-000237-2S; Mon, 15 Apr 2024 16:28:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Uo1GsaFBc/Lef6aWXeE6oZRjdl30gCxB12lP1If/uxY=; b=bo6WudJ42p9HXMo8rBGw gP7G+uY73sWnSNWDxWWAWC+WpDKwnJPZniq6wXh7O603YuL1LzdjDx/AiUM6h26c/cCfrrRyKwx85 g1ERuXDaARlp61mhjSckdE9gYNjSAkE0e0i5hQW/9jvOEiVR4qZoxl74YDW9srAUQtXwzmepHrcsW OQBQkv17KPiKzSW04IyqYGQUkeElE4VceDXeOfQAlbSt8KlmD1OlKkYfL2N6ahMT/BYW9iu5P4+4k s6ULOQ6Eo2qqkoupsenpfwjg9yrEP3KfX0ulhRds1yILrNvgVsnES2leOdGKDe/bJIefSdtNKEQDn PBgRvzwHQchvEg==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Efraim Flashner Subject: Re: [bug#70303] [PATCH 0/2] Use guile-final for grafting. In-Reply-To: (Efraim Flashner's message of "Tue, 9 Apr 2024 13:03:58 +0300") References: Date: Mon, 15 Apr 2024 22:28:17 +0200 Message-ID: <87cyqqz7z2.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70303 Cc: Ricardo Wurmus , Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 70303@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Howdy! Efraim Flashner skribis: > Over the years the grafting code has changed bit by bit, with various > attempts to speed it up. By switching the grafts to not use parallelism > in rewriting the leaves we can finally switch the guile-for-grafts to be > guile-final. The segfault is still there if we perform the grafts in > parallel, but I believe it is fast enough that it should be fine to do > them sequentially. Could you time the grafting derivation of, say, libreoffice or ungoogled-chromium? Typically I=E2=80=99d do it along these lines: --8<---------------cut here---------------start------------->8--- $ guix build libreoffice /gnu/store/24is7ypdx6sm56mkclxdx4hyj7yg4smb-libreoffice-7.6.3.1 $ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches' $ time guix build libreoffice --check The following graft will be made: /gnu/store/wdjqpxm2kbdvq7qlrzyjxb244zn3s3bv-libreoffice-7.6.3.1.drv applying 137 grafts for libreoffice-7.6.3.1 ... grafting '/gnu/store/5flppg3h8y235di2ilr3sx878gfl82db-libreoffice-7.6.3.1' = -> '/gnu/store/24is7ypdx6sm56mkclxdx4hyj7yg4smb-libreoffice-7.6.3.1'... successfully built /gnu/store/wdjqpxm2kbdvq7qlrzyjxb244zn3s3bv-libreoffice-= 7.6.3.1.drv successfully built /gnu/store/wdjqpxm2kbdvq7qlrzyjxb244zn3s3bv-libreoffice-= 7.6.3.1.drv /gnu/store/24is7ypdx6sm56mkclxdx4hyj7yg4smb-libreoffice-7.6.3.1 real 0m14.921s user 0m7.588s sys 0m0.389s --8<---------------cut here---------------end--------------->8--- (That=E2=80=99s on my 4-core i7.) It=E2=80=99s a bummer that the segfault is still there. I remember week-lo= ng =E2=80=98rr=E2=80=99 debugging sessions in the past, where I did find a few= issues; I should try again but uh=E2=80=A6 > There's probably room in replace-store-references in (guix build graft) > for changes if we're not going to use guile-2.0 here anymore. I believe =E2=80=98tests/grafts.scm=E2=80=99 may run some of this code unde= r Guile 2.0 (using the =E2=80=98guile-bootstrap=E2=80=99 tarball provided for the tests= ). Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 16 10:56:30 2024 Received: (at 70303) by debbugs.gnu.org; 16 Apr 2024 14:56:30 +0000 Received: from localhost ([127.0.0.1]:44349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwkEX-0000ES-Q9 for submit@debbugs.gnu.org; Tue, 16 Apr 2024 10:56:30 -0400 Received: from mail-ot1-x332.google.com ([2607:f8b0:4864:20::332]:59418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwkET-0000Cz-5t for 70303@debbugs.gnu.org; Tue, 16 Apr 2024 10:56:27 -0400 Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6ea2f95ec67so2334949a34.2 for <70303@debbugs.gnu.org>; Tue, 16 Apr 2024 07:56:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713279367; x=1713884167; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=t90L+OB5BISyRKfR9v0ywCk/IVZQGkBOEyhdcFpKAjA=; b=cGGnglsfgMT4MaLf1tBhYUgW9teBONkis4p9GZHqHbg2bgOMGGQP8+rLyz7WWbB7bG y7m785JqnXMym9Ip1FgCeqbEmSVfuvtr4ZqqbO7RrY3OdzilOnwoss1A8WFOVK8jyWe2 aIGJqcdS52L0oJvu5KJ/oeCy87fgWfIbqiaQ86zoKlTB6pEmYzG6PFXg4xNv82BzRKj7 CUpjOCOLCb5sxbtua9RKdbspt4SmUKqqlvGrru5FmdII/Wl5TB08Dn2vW5P2t0re+Snr z49zJRc2Gsw3K70V9/3qs7tzxBK2xZTcTQg/BefBEwT/GN5RDXKkEVrzOV/mU8oEcxZU Sa5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713279367; x=1713884167; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t90L+OB5BISyRKfR9v0ywCk/IVZQGkBOEyhdcFpKAjA=; b=lDbK3UsVuKf8+vzu7mZKFz5maI2Az4K0P3Cq6oljc84C22Lj2wOURZlJxcQU6daCRA I+41p1Ibq/OxEqaLGdzf4VjqO8CCBZXaOEIGPM6FDuaZh+N/NlBOAn0xhK7U2kULbYWV /RXGWVZa5pVK32gZ7SyCUIOMuGVmGv1Sk6MtPUZWet4bPQqx/rdZfitzcMvhfKYwOHqF jXWV4CY9x9WQPdalmucovl1NgxsR74qcdb1vjgwTwPnFeVCj747bHHWrbik2wYSL21BI VMjzianjbv5tH8sjhDcdGS1qxD9zRrZLrkVuzppqD9CVz44Iq7l/L1wLukNI/5JEZhH5 ib2A== X-Gm-Message-State: AOJu0Yx31+2dWot10gHO68Fb4969HF+N/uPIRxzTFOknGpOb+mp1itA8 t/4D1iZshmAseqSTz04Eze0Hv9WokVGtX/EhzfK0BmBTyg0zBTTJ X-Google-Smtp-Source: AGHT+IH2k/tiBeAKaZF+nd/NgTXfWg+RE9Pnl4Disme7Ww5UyraR8YyqLApSCKwG/rG2eCMTDkj3qw== X-Received: by 2002:a05:6830:1484:b0:6ea:186d:3795 with SMTP id s4-20020a056830148400b006ea186d3795mr16071357otq.12.1713279366712; Tue, 16 Apr 2024 07:56:06 -0700 (PDT) Received: from localhost (ool-ad039216.dyn.optonline.net. [173.3.146.22]) by smtp.gmail.com with ESMTPSA id i22-20020a05620a0a1600b0078d75b9fb37sm7607159qka.32.2024.04.16.07.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Apr 2024 07:56:05 -0700 (PDT) Date: Tue, 16 Apr 2024 17:56:04 +0300 From: Efraim Flashner To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#70303] [PATCH 0/2] Use guile-final for grafting. Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?utf-8?Q?Court=C3=A8s?= , 70303@debbugs.gnu.org, Christopher Baines , Josselin Poiret , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice References: <87cyqqz7z2.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3iV5gRDojkoIgieN" Content-Disposition: inline In-Reply-To: <87cyqqz7z2.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 1.7 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Mon, Apr 15, 2024 at 10:28:17PM +0200, Ludovic Courtès wrote: > Howdy! > > Efraim Flashner skribis: > > > Over the years the grafting code has changed bit by bit, with vari [...] Content analysis details: (1.7 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:332 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (efraim.flashner[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 1.0 PDS_BTC_MSGID Bitcoin ID with T_MSGID_NOFQDN2 0.5 PDS_BTC_ID FP reduced Bitcoin ID X-Debbugs-Envelope-To: 70303 Cc: Ricardo Wurmus , Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 70303@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --3iV5gRDojkoIgieN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 15, 2024 at 10:28:17PM +0200, Ludovic Court=C3=A8s wrote: > Howdy! >=20 > Efraim Flashner skribis: >=20 > > Over the years the grafting code has changed bit by bit, with various > > attempts to speed it up. By switching the grafts to not use parallelism > > in rewriting the leaves we can finally switch the guile-for-grafts to be > > guile-final. The segfault is still there if we perform the grafts in > > parallel, but I believe it is fast enough that it should be fine to do > > them sequentially. >=20 > Could you time the grafting derivation of, say, libreoffice or > ungoogled-chromium? >=20 > Typically I=E2=80=99d do it along these lines: >=20 > --8<---------------cut here---------------start------------->8--- > $ guix build libreoffice > /gnu/store/24is7ypdx6sm56mkclxdx4hyj7yg4smb-libreoffice-7.6.3.1 > $ sudo sh -c 'echo 3 > /proc/sys/vm/drop_caches' > $ time guix build libreoffice --check > The following graft will be made: > /gnu/store/wdjqpxm2kbdvq7qlrzyjxb244zn3s3bv-libreoffice-7.6.3.1.drv > applying 137 grafts for libreoffice-7.6.3.1 ... > grafting '/gnu/store/5flppg3h8y235di2ilr3sx878gfl82db-libreoffice-7.6.3.1= ' -> '/gnu/store/24is7ypdx6sm56mkclxdx4hyj7yg4smb-libreoffice-7.6.3.1'... > successfully built /gnu/store/wdjqpxm2kbdvq7qlrzyjxb244zn3s3bv-libreoffic= e-7.6.3.1.drv > successfully built /gnu/store/wdjqpxm2kbdvq7qlrzyjxb244zn3s3bv-libreoffic= e-7.6.3.1.drv > /gnu/store/24is7ypdx6sm56mkclxdx4hyj7yg4smb-libreoffice-7.6.3.1 >=20 > real 0m14.921s > user 0m7.588s > sys 0m0.389s > --8<---------------cut here---------------end--------------->8--- >=20 > (That=E2=80=99s on my 4-core i7.) I'm currently vising my parents for a few weeks during the Passover break, and I've already lost connection to my desktop at home, so I'm currently running the tests on my pinebook pro. The first one is with the patches applied, the second one is without the patches. I have the guix-daemon on my pinebook pro to use 3 cores, but I'm not sure how much that would be honored by the grafting code. (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_ca= ches' Password: (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build libreoffic= e --check The following graft will be made: /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-7.6.3.1.drv applying 137 grafts for libreoffice-7.6.3.1 ... grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.3.1' = -> '/gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1'... successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-= 7.6.3.1.drv successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-= 7.6.3.1.drv /gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1 real 1m35.537s user 0m32.328s sys 0m2.521s (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_ca= ches' (ins)efraim@pbp ~/workspace/guix$ time guix build libreoffice --check The following graft will be made: /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-7.6.3.1.drv applying 137 grafts for libreoffice-7.6.3.1 ... grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.3.1' = -> '/gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1'... successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-= 7.6.3.1.drv successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-= 7.6.3.1.drv /gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1 real 1m20.573s user 0m29.688s sys 0m2.346s --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --3iV5gRDojkoIgieN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmYekXkACgkQQarn3Mo9 g1FKOA/6AkYCy6tWSGSq2MmVL8VMTv1bwPYUJ/TaRlHklkFxAIHv9D5oBmyCdmgP b64CGUT063HZNWcpzMTIkhuCIDXvAc8tKCcvl0y+pSMLHerbd2HHBZ1avxvJrdmO jmnAIazHlTt2WnJfMpZZbi6nC7uKjvSMRbtMzp5at06JpCEu2kwsxwwIFECZrrkb +q1H+Wh2HdbWXw/xVESkpv9htwcb4eFwsFXyQb16TewDEmame572xIRr8LzLAuhl CWBlWwKvShCC2VY3gDJwm9wI25zDPibko8FUeAX/BfDAXHlzdlu1j/FkN/aYM6AC Y368PVWV4zQaOnBNb7eVahY/ow7zJzYvh79aD1IMKnmleFxIFC6rBNB0BrBIlC9N dnLFXltlesHduD2AuQq+DMkR4Uvbf6l6uz6sTj3jkPm94hADFY0UtGGRhUlR9KX8 l3zE6dsTnv+uDw7I1LnW4g/psOsr7yl8cTckmZmH3HX0JGcga4aXMMV1mGCdnWa8 wEseLVlZMmqiKPNUhvD+eZAahEliSIK1UluPBRXzQ4XQu2j/1ol2IbzTx33hi8g2 04wJBUaLRDKkATjNbPO4iWk+FXltEkG/u9oDwPVQHew50qHHKLCOAiHY3wFkKAqx rt/XqxwbIOY8JvmLJlgo8cf8zbLLzExDh+Cw323PPY6Ft7xT2gM= =vluJ -----END PGP SIGNATURE----- --3iV5gRDojkoIgieN-- From debbugs-submit-bounces@debbugs.gnu.org Sat May 04 11:04:13 2024 Received: (at 70303) by debbugs.gnu.org; 4 May 2024 15:04:13 +0000 Received: from localhost ([127.0.0.1]:54160 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Gvt-0001n4-8c for submit@debbugs.gnu.org; Sat, 04 May 2024 11:04:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3Gvo-0001mw-V4 for 70303@debbugs.gnu.org; Sat, 04 May 2024 11:04:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3GvJ-0000Wa-Gu; Sat, 04 May 2024 11:03:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=P+cRQCyYkA3fGV295o/I/ujjY4ILST2RHtuQtFDGjSs=; b=PQe26vbjAY06r7I/VtLM ADP5qVIBMYLpTMGQJNe1vpmVkhuTA/YRDpf+rUbrcbFPLN+8NPaSK1xDCpqvp8Q0gwC0+dTcY1R1j aiZr07l3WDcnu84SAJDQUSb4xouKr/UHAzWIzFBlxfff7U7jhMTVKzierCS1f2qLt+H3v7NZ/0s5m sY5W6pX2NiX864ZoAOUTe1LroeJHmnsSxZJLOnBGdldKSgAmpBVAgGm3tJq3gXpvc+rBsquscFeZE myDjaC2Oo1e9V0q9JEygCwVO8OrOsn8F9wocmtXs3/QsBpYOrlFva/9jsrAp6KreljereC/4pAy4O w3CkcamZ4P8sUQ==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Efraim Flashner Subject: Re: [bug#70303] [PATCH 0/2] Use guile-final for grafting. In-Reply-To: (Efraim Flashner's message of "Tue, 16 Apr 2024 17:56:04 +0300") References: <87cyqqz7z2.fsf@gnu.org> Date: Sat, 04 May 2024 17:03:33 +0200 Message-ID: <87ttjdty9m.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 70303 Cc: Ricardo Wurmus , Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 70303@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Hi! Efraim Flashner skribis: > The first one is with the patches applied, the second one is without the > patches. I have the guix-daemon on my pinebook pro to use 3 cores, but > I'm not sure how much that would be honored by the grafting code. > > (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_= caches' > Password: > (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build libreoff= ice --check > The following graft will be made: > /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-7.6.3.1.drv > applying 137 grafts for libreoffice-7.6.3.1 ... > grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.3.1= ' -> '/gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1'... > successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffic= e-7.6.3.1.drv > successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffic= e-7.6.3.1.drv > /gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1 > > real 1m35.537s > user 0m32.328s > sys 0m2.521s > (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_= caches' > (ins)efraim@pbp ~/workspace/guix$ time guix build libreoffice --check > The following graft will be made: > /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-7.6.3.1.drv > applying 137 grafts for libreoffice-7.6.3.1 ... > grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.3.1= ' -> '/gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1'... > successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffic= e-7.6.3.1.drv > successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffic= e-7.6.3.1.drv > /gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1 > > real 1m20.573s > user 0m29.688s > sys 0m2.346s That=E2=80=99s an 18% slowdown. Could you make several runs to see how sta= ble that is? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 18 11:14:43 2024 Received: (at 70303) by debbugs.gnu.org; 18 Jul 2024 15:14:43 +0000 Received: from localhost ([127.0.0.1]:37861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUSqA-0005O5-JC for submit@debbugs.gnu.org; Thu, 18 Jul 2024 11:14:43 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sUSq8-0005Nq-Hk for 70303@debbugs.gnu.org; Thu, 18 Jul 2024 11:14:41 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sUSpz-0005mE-9U; Thu, 18 Jul 2024 11:14:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=T0kHcFutgC0TyWzbZ9K1tjNlrjIXOIn0fkkHQ3DScCg=; b=dlMGo1CGJoRMPU42JFT4 0BSeE6lQoh+M1NKImbvEPszmEWLRz4P/CMiWY/d3a9fc8dKQ66ymC9VJ3mBJoWHmy8o3uXCxg/2JY JQDgyfkI9BApFYXDGU70rcznbpk2XtCi3o2gP1R5WpN0vEGhZjTWVvpdWiqwzHB6Rbcpig4T9O4f9 iRpir6t2NHLkDg96o7HUqoie7e6ggZEu22tR6m0hHWDx/SFDVZG+J/4zhqPygR3+KAPCxvzg9AE3r jdpZJnZOQ1d+KCW5M65qxQc2qTFboT83Sxd2YizXwt8HT7cOikw+iARkZ5MWfvbmABlLffc8JM++w DYbi2LdKi2Wnow==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Efraim Flashner Subject: Re: [bug#70303] [PATCH 0/2] Use guile-final for grafting. In-Reply-To: <87ttjdty9m.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sat, 04 May 2024 17:03:33 +0200") References: <87cyqqz7z2.fsf@gnu.org> <87ttjdty9m.fsf@gnu.org> Date: Thu, 18 Jul 2024 17:14:27 +0200 Message-ID: <87sew6vijw.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70303 Cc: 70303@debbugs.gnu.org, Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Efraim, Ludovic Court=C3=A8s skribis: > Efraim Flashner skribis: > >> The first one is with the patches applied, the second one is without the >> patches. I have the guix-daemon on my pinebook pro to use 3 cores, but >> I'm not sure how much that would be honored by the grafting code. >> >> (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop= _caches' >> Password: >> (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build libreof= fice --check >> The following graft will be made: >> /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-7.6.3.1.drv >> applying 137 grafts for libreoffice-7.6.3.1 ... >> grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.3.= 1' -> '/gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1'... >> successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffi= ce-7.6.3.1.drv >> successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffi= ce-7.6.3.1.drv >> /gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1 >> >> real 1m35.537s >> user 0m32.328s >> sys 0m2.521s >> (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop= _caches' >> (ins)efraim@pbp ~/workspace/guix$ time guix build libreoffice --check >> The following graft will be made: >> /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-7.6.3.1.drv >> applying 137 grafts for libreoffice-7.6.3.1 ... >> grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.3.= 1' -> '/gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1'... >> successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffi= ce-7.6.3.1.drv >> successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffi= ce-7.6.3.1.drv >> /gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1 >> >> real 1m20.573s >> user 0m29.688s >> sys 0m2.346s > > That=E2=80=99s an 18% slowdown. Could you make several runs to see how s= table > that is? Looks like this patch fell through the cracks. Maybe we should just go ahead and apply it. Depending on Guile 2.0 for this isn=E2=80=99t viable in the long term anyway. WDYT? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 22 17:56:03 2024 Received: (at 70303) by debbugs.gnu.org; 22 Jul 2024 21:56:03 +0000 Received: from localhost ([127.0.0.1]:58677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sW10k-0007cS-Mc for submit@debbugs.gnu.org; Mon, 22 Jul 2024 17:56:03 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]:42237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sW10g-0007bv-Ow for 70303@debbugs.gnu.org; Mon, 22 Jul 2024 17:56:01 -0400 Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-447e2d719afso32795821cf.0 for <70303@debbugs.gnu.org>; Mon, 22 Jul 2024 14:55:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721685289; x=1722290089; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=rm31EgOYOYaLCwssbH4MVr00Oa9+j3JbM/qrgA+PEtY=; b=VY6mdiiJ6EPw9sTp0IrUUvWssLLAuI/zPySzA/oqq1/Pn/y59uqxHSFwCxIXfAGpgr bZRUIww2FUBwLuQNOxFVgdqs42lllcocbtp2F/fP9UALXM25sATW8+KonXUp4meMK+Ng vVhHMkFVlkNzTkmMuDtmNDDnbdxhjfJzZsDyWkQ4RCKzOwkgLXwZEhaN9KzJ7+29Wjd+ NIw4wXB9lHv8XbdgQlvNKGGy+YxQ+JxWBoh7EHRWLV16JpMRyDn8CWTsrAjTVBo/GeS/ FwnqfZsy3FFar8b/wiXyG82pvjfyy/AaqDSf944GRkNnHCKivoPwgIra+gMCdZehPEnV 8RXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721685289; x=1722290089; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rm31EgOYOYaLCwssbH4MVr00Oa9+j3JbM/qrgA+PEtY=; b=aLQw9C4jwh/B/5sPCzDSDFFe+SeV7QNpE4Ot0c68DYay0GWPbyQpWGXyJnFc6hZUrs /RneEB5onesFa2sq+0NxmxWPB5ijhyEvXIYXVhhPyWnDAK76vK2BEYbXV5qbxgOnes2+ bX5biwV373ZiEuwlCBgjuAs9IGlafV2RS1mvOoyoBTJlTmRxJfuP3xLttcnwzo9JAMhy clqihpMCJx6TSPjrk8knjSQbIxzRCQLFkXutbDTqdJsp4zNxLFd0PKmwJ0Kbq1mF+KDg MDw8IrisIB13eVj7Xp4Nod7xT9sLb0qvF6efcyui7hmI/ZW6dK8Z6Aao4jmcPkVpTkVE CTsg== X-Forwarded-Encrypted: i=1; AJvYcCWgFiG5HCF4eB4nRah3V6WBkIDLuAIaF2kIdSGA6HUpiRZ+8cgeXK+OCMkWfOEBRnt2Y1ad4MHFNUo6eifjcxSwbe5NiP8= X-Gm-Message-State: AOJu0YwrpSg99mdqFPJ9/byLgSEIu5a//XKxdJNUMrgtjsgBOhFn/gF+ CqGjY5mZe6QchARljdey0Japkr4bIBk6qavVqyWFXFy3BAxzV3xB X-Google-Smtp-Source: AGHT+IEESJkyXCB+W12eIZSS6e+F1O6bsrc4KaKdqzk950DcuuMjflfFCzUjyG+5hPrX4QlH7DbCOA== X-Received: by 2002:a05:622a:28a:b0:446:63a6:5e22 with SMTP id d75a77b69052e-44fc7f3591fmr3546471cf.2.1721685289291; Mon, 22 Jul 2024 14:54:49 -0700 (PDT) Received: from localhost (ool-ad039216.dyn.optonline.net. [173.3.146.22]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-44f9cd34dc0sm37522191cf.43.2024.07.22.14.54.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jul 2024 14:54:48 -0700 (PDT) Date: Tue, 23 Jul 2024 00:54:47 +0300 From: Efraim Flashner To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#70303] [PATCH 0/2] Use guile-final for grafting. Message-ID: Mail-Followup-To: Efraim Flashner , Ludovic =?utf-8?Q?Court=C3=A8s?= , Ricardo Wurmus , Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , 70303@debbugs.gnu.org, Christopher Baines References: <87cyqqz7z2.fsf@gnu.org> <87ttjdty9m.fsf@gnu.org> <87sew6vijw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="prFGZd5EN3qF6DMe" Content-Disposition: inline In-Reply-To: <87sew6vijw.fsf@gnu.org> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 70303 Cc: 70303@debbugs.gnu.org, Josselin Poiret , Simon Tournier , Mathieu Othacehe , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.9 (/) --prFGZd5EN3qF6DMe Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 18, 2024 at 05:14:27PM +0200, Ludovic Court=C3=A8s wrote: > Hi Efraim, >=20 > Ludovic Court=C3=A8s skribis: >=20 > > Efraim Flashner skribis: > > > >> The first one is with the patches applied, the second one is without t= he > >> patches. I have the guix-daemon on my pinebook pro to use 3 cores, but > >> I'm not sure how much that would be honored by the grafting code. > >> > >> (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/dr= op_caches' > >> Password: > >> (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build libre= office --check > >> The following graft will be made: > >> /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreoffice-7.6.3.1.drv > >> applying 137 grafts for libreoffice-7.6.3.1 ... > >> grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.= 3.1' -> '/gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1'... > >> successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreof= fice-7.6.3.1.drv > >> successfully built /gnu/store/i2aml4p5yg7h090bdzjpaqmds47g26d8-libreof= fice-7.6.3.1.drv > >> /gnu/store/1cfjx934czp641v4fmwsz2js7158ivgm-libreoffice-7.6.3.1 > >> > >> real 1m35.537s > >> user 0m32.328s > >> sys 0m2.521s > >> (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/dr= op_caches' > >> (ins)efraim@pbp ~/workspace/guix$ time guix build libreoffice --check > >> The following graft will be made: > >> /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreoffice-7.6.3.1.drv > >> applying 137 grafts for libreoffice-7.6.3.1 ... > >> grafting '/gnu/store/yd9slkfhdl8lzhhmhm40airimwb6yhj5-libreoffice-7.6.= 3.1' -> '/gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1'... > >> successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreof= fice-7.6.3.1.drv > >> successfully built /gnu/store/2f6i7r77z8msbjlspsp0aq5vlpjqnifp-libreof= fice-7.6.3.1.drv > >> /gnu/store/xm3q8qsns8qqybq47zvv70n0y0qs4r65-libreoffice-7.6.3.1 > >> > >> real 1m20.573s > >> user 0m29.688s > >> sys 0m2.346s > > > > That=E2=80=99s an 18% slowdown. Could you make several runs to see how= stable > > that is? >=20 > Looks like this patch fell through the cracks. >=20 > Maybe we should just go ahead and apply it. Depending on Guile 2.0 for > this isn=E2=80=99t viable in the long term anyway. >=20 > WDYT? Since your email I've been playing with it a bit more. I switched from libreoffice to python since libreoffice isn't built yet for aarch64. Before the patches (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_ca= ches' (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build python --c= heck The following graft will be made: /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.7.drv applying 16 grafts for python-3.10.7 ... grafting '/gnu/store/qc7n1mflwv12prx185w5wqd95nry5jl1-python-3.10.7-idle' -= > '/gnu/store/g3lna24jdg6giddy79kij35kqv9fyr0r-python-3.10.7-idle'... grafting '/gnu/store/vsy0hfgcvrw6fnz53qqqk8ss3c67x2qi-python-3.10.7' -> '/g= nu/store/697bsvp9vzj4h6zn3gpgg04h8w36mprl-python-3.10.7'... grafting '/gnu/store/8nj5cwhbfbwb3lf33wsa51rg0v2qbwjb-python-3.10.7-tk' -> = '/gnu/store/f051i1aa74z5js30fm4vg4mccsf070w9-python-3.10.7-tk'... successfully built /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.= 7.drv successfully built /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.= 7.drv successfully built /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.= 7.drv successfully built /gnu/store/b460sh7szir8rf13rjci9cpcbnwgsr04-python-3.10.= 7.drv /gnu/store/g3lna24jdg6giddy79kij35kqv9fyr0r-python-3.10.7-idle /gnu/store/697bsvp9vzj4h6zn3gpgg04h8w36mprl-python-3.10.7 /gnu/store/f051i1aa74z5js30fm4vg4mccsf070w9-python-3.10.7-tk real 0m52.734s user 0m8.821s sys 0m1.489s After the patches (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_ca= ches' (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build python --c= heck The following graft will be made: /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.7.drv applying 16 grafts for python-3.10.7 ... grafting '/gnu/store/qc7n1mflwv12prx185w5wqd95nry5jl1-python-3.10.7-idle' -= > '/gnu/store/s6gh2f9fnpsrjhb9arcwvk7ydr2yynd0-python-3.10.7-idle'... grafting '/gnu/store/vsy0hfgcvrw6fnz53qqqk8ss3c67x2qi-python-3.10.7' -> '/g= nu/store/w1nk4b8zadnrzd8m8dgfiyhfpm4d2s89-python-3.10.7'... grafting '/gnu/store/8nj5cwhbfbwb3lf33wsa51rg0v2qbwjb-python-3.10.7-tk' -> = '/gnu/store/na5an7jrlwvv4ykl5dvmw303dlsavznq-python-3.10.7-tk'... successfully built /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.= 7.drv successfully built /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.= 7.drv successfully built /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.= 7.drv successfully built /gnu/store/ny03k54s1f0dffn9rywsmf7rd2znsnn5-python-3.10.= 7.drv /gnu/store/s6gh2f9fnpsrjhb9arcwvk7ydr2yynd0-python-3.10.7-idle /gnu/store/w1nk4b8zadnrzd8m8dgfiyhfpm4d2s89-python-3.10.7 /gnu/store/na5an7jrlwvv4ykl5dvmw303dlsavznq-python-3.10.7-tk real 1m22.324s user 0m8.758s sys 0m1.621s There was an unconditional mkdir-p in the graft code that I made check for the directory first (ins)efraim@pbp ~/workspace/guix$ sudo sh -c 'echo 3 > /proc/sys/vm/drop_ca= ches' (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build python --c= heck The following graft will be made: /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.7.drv applying 16 grafts for python-3.10.7 ... grafting '/gnu/store/qc7n1mflwv12prx185w5wqd95nry5jl1-python-3.10.7-idle' -= > '/gnu/store/z5zw3f31x7xp71lw9rihkvcf7pmsyz0k-python-3.10.7-idle'... grafting '/gnu/store/vsy0hfgcvrw6fnz53qqqk8ss3c67x2qi-python-3.10.7' -> '/g= nu/store/k6kvr48gcjn9z4q3gd51wyddinyxxcw2-python-3.10.7'... grafting '/gnu/store/8nj5cwhbfbwb3lf33wsa51rg0v2qbwjb-python-3.10.7-tk' -> = '/gnu/store/gwync0539a5ixgds3k97440zg7miqiq1-python-3.10.7-tk'... successfully built /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.= 7.drv successfully built /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.= 7.drv successfully built /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.= 7.drv successfully built /gnu/store/jryp0i86fll06swc856d5njyf4knzw7z-python-3.10.= 7.drv /gnu/store/z5zw3f31x7xp71lw9rihkvcf7pmsyz0k-python-3.10.7-idle /gnu/store/k6kvr48gcjn9z4q3gd51wyddinyxxcw2-python-3.10.7 /gnu/store/gwync0539a5ixgds3k97440zg7miqiq1-python-3.10.7-tk real 1m7.380s user 0m8.990s sys 0m1.617s Then I re-enabled n-par-for-each (without exit-on-exception) (ins)efraim@pbp ~/workspace/guix$ time ./pre-inst-env guix build python --c= heck The following graft will be made: /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.7.drv applying 16 grafts for python-3.10.7 ... grafting '/gnu/store/qc7n1mflwv12prx185w5wqd95nry5jl1-python-3.10.7-idle' -= > '/gnu/store/r9dw90ijwyrzl39yind3iza5bpbcvys2-python-3.10.7-idle'... grafting '/gnu/store/vsy0hfgcvrw6fnz53qqqk8ss3c67x2qi-python-3.10.7' -> '/g= nu/store/0zzck57k9321h7lhzlfw5wr87jyqpiv3-python-3.10.7'... grafting '/gnu/store/8nj5cwhbfbwb3lf33wsa51rg0v2qbwjb-python-3.10.7-tk' -> = '/gnu/store/v4wg35f62r546hy8f2lbsf51vb8rh0jz-python-3.10.7-tk'... successfully built /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.= 7.drv successfully built /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.= 7.drv successfully built /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.= 7.drv successfully built /gnu/store/3kr7477zfivxxan5r6ljl81cq3p1j9m8-python-3.10.= 7.drv /gnu/store/r9dw90ijwyrzl39yind3iza5bpbcvys2-python-3.10.7-idle /gnu/store/0zzck57k9321h7lhzlfw5wr87jyqpiv3-python-3.10.7 /gnu/store/v4wg35f62r546hy8f2lbsf51vb8rh0jz-python-3.10.7-tk real 0m55.129s user 0m9.082s sys 0m1.612s I only have 3 cores enabled on my pinebook pro so I can't really comment on weather n-par-for-each does in fact still trigger segfaults in the grafting code, but I haven't seen any. --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --prFGZd5EN3qF6DMe Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmae1R4ACgkQQarn3Mo9 g1EaAg//a7yLpfncFzBRd9pQMpwOVWYS5Wl7myi9CgoC0qFY3Wb2if+mG3Fm4APH aaB/LL1B/FL9MT+xso1FA8XmGnZt2jJ5U5I6hZeLN2OMqtVJgaHWiPLTsY4eib9d XlzwFxN49t6mgzqF7S5y6ydqZhCfJf9bhc+1NjQJTOIV8WzjT1zBxyrQiRR72Wl2 lLNQL/ek6OBn3St7QL9nBxBKw9lRVA4o386ie6lYs7FpYymKUPOxzJq4diXp4zAJ NFDEXl5cUasSsBAJDhejBGseJTkJBVK7zjBwYS8y75bB2Km1bic853p9pXluKBuw qmE/9NJ39uNHOJHtbDwfae5KxessrOuWG0pHb6irAdb7osYcNTwLzMm54OfhtKaO 3ZvIU0/ROgEalQS+1BAqTqTnia2DBy7sufWgN4vyB05xbRzk49bxBvM0sxUOVrcb WTq706MDJqTZ0D5Q/yFUbRRO15YInSTMKivonMe4qZnyrf+a9cNDylWgmLjXByKK F62Xys4g2HMv4REHm8HFb+rlPTFKRMqeErJC8EjxnrSZ+08obz4MaCoPsRz2hNT0 g2eNWasOXra1+5HAW2h6n/UEiHLXBtFaSasI9Q0HPtRNa7LY78yH60eZmC+g1NE/ j/oew4hdmTs3Z3R110EzE+4TN3qLgSGLTV+53xWltkmRUsSpS70= =M3An -----END PGP SIGNATURE----- --prFGZd5EN3qF6DMe-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 11 10:47:11 2024 Received: (at 70303-done) by debbugs.gnu.org; 11 Sep 2024 14:47:11 +0000 Received: from localhost ([127.0.0.1]:39362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soOch-0006V7-Fg for submit@debbugs.gnu.org; Wed, 11 Sep 2024 10:47:11 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:48533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1soOce-0006Uq-8j for 70303-done@debbugs.gnu.org; Wed, 11 Sep 2024 10:47:09 -0400 Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-42cb0f28bfbso19324395e9.1 for <70303-done@debbugs.gnu.org>; Wed, 11 Sep 2024 07:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726065956; x=1726670756; darn=debbugs.gnu.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to; bh=WRKEKrn5UGkGY089GC38ISTUb2AYgxBYz4vQ5ohAVdc=; b=gCv5Ax9RsrcvahKDOOoACJ4q9/QC446C7tIF9Rbt8Q5A3GA62iaPnTbGYRYUFMks+J 9YlDqy3Os//H2Cd0lj8EOJBNWGl1KLh2qp1ANOnrSwcRUVXAMFd81gV68EhQIA916CQ5 Q60HQZzkpD3pWANgi0LncFgszmPsNxpg8ZfpR730Ad5/2KH+B56u/CuLzBigrgRCTLXD ewtVzTPMpVNOk7djaOkjfPvOvCVj3K7+dZ+CNh/Zyaca3aeA7+ugI271KUxGYrMGCEzc yIOHOP1K1QDXErnuDaMF7pdjuzyqn5Kd0zMlNouCP/w8AldGpuSM6xMtYddLR8Ia9K3p dKKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726065956; x=1726670756; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WRKEKrn5UGkGY089GC38ISTUb2AYgxBYz4vQ5ohAVdc=; b=NCgCYg6l5ZyF+omLfJVnp6/aCi/0u8kysrEkBha5a4rTcC3sj7D+pvOenC/H0rcoLR zbHBi1bJjw+lgxiCEgh5lEeXHsn0qp8Y0gXSezwhe7zt+NRSutSWNhKa10ORbzKMgPng xYVXzi4CYGdJVxkWeTyOE2wTkowFyYWIIw7bheaDFWvKfCYFDEtMERn8hm/eHZZApTGK FsSZ5lqi3agNWfsNPhvoZpipeJEfIIIuDGxPrYX8GpjqtM5IOvxMYXAqUpdLNZRL6xgH VDCSwIoA8O8f1C0GbvTVPmClAgv5GFOWxO1MHdjyqR1OJBQE3bI9ltwbh8FPtgctZ23L 40jA== X-Gm-Message-State: AOJu0YxTkVolo4rizpX2XzabGjqlolYEFdvsvbXd3LfRxAs5mUY+djwT mYPTMpu65apmkPS7R46GQfJJFFJ33l1dCq1vG7ci6rUIcIiIHno6YQZm8gZ7 X-Google-Smtp-Source: AGHT+IFirGqzhaT0U6jwSUM2Xs+Ain5S9B1LUaadhbJ03z21xFrh9V1P382Q8UabH0B2LkP0bVwhYw== X-Received: by 2002:a05:600c:3b09:b0:42b:a9b4:3f59 with SMTP id 5b1f17b1804b1-42ccd3280a9mr26989255e9.14.1726065955767; Wed, 11 Sep 2024 07:45:55 -0700 (PDT) Received: from localhost ([141.226.162.35]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-378956d3687sm11761304f8f.71.2024.09.11.07.45.54 for <70303-done@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Sep 2024 07:45:55 -0700 (PDT) Date: Wed, 11 Sep 2024 17:45:53 +0300 From: Efraim Flashner To: 70303-done@debbugs.gnu.org Subject: Re: [PATCH 1/2] graft: Remove work-around for old guile. Message-ID: Mail-Followup-To: Efraim Flashner , 70303-done@debbugs.gnu.org References: <3d8f8f3135f69cc88a7d0575ce533d489239ede8.1712656502.git.efraim@flashner.co.il> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AUbnlwdToObhcHEH" Content-Disposition: inline In-Reply-To: <3d8f8f3135f69cc88a7d0575ce533d489239ede8.1712656502.git.efraim@flashner.co.il> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 70303-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --AUbnlwdToObhcHEH Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Patches pushed --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --AUbnlwdToObhcHEH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmbhrSEACgkQQarn3Mo9 g1ETyQ//cUGya6Eq80E7z0ai6DuNcPSqC7bZzlMMRgHh2kw/oZ9/U2gFZMhJIMbe xrgzq4TvQT4E70V1lVBiF4ZUE9QqHCRc4k2xX8F7bFSm/hDzcckmHPF6OH6O8q93 zBSkIU8gcEzeXf7UNkwvJ0npr6qy59HCnR8A2rJDaR6YaJI0T4zPVG40gASjLyeN vuSQaEE9EY24xRdESkyzek9Lt+l9BR38EGfH/I7x/g1Hnmzr24li60axGMe/JmaP eaobS9dg7p31wg2tFiPvDcS114IpVOkO0YLC8ofgJWEujWPQxynSjkdT79oZeCZn oZuAjOHlK8lPrMigALIvL+nR3ZlzJUPDH0o8H2JTTYy9WQhh9CHlBF8ks9b7oIvt wNsF72eJ2+S1/0m5Gb6NXT6Z7mrws58q0a22XB7zSwbIaiMGeQB896JBGF+7fOxA DLVkIDX1Mp+1sif8fZcQEWs2Nd3bVmCc4cBuPqgPzgEeTXfFZP1XEJe/cMLGg9T8 0w5vk8s1gVVUz8z5bx4JQmwtfMLXnKjVEskPRVxmegsxlVA6Ik4Uuq3jo8NIYz/f IiUn65vEcE9CdfLWp2zS0uEiKp6vFHlD3fRsRyqvVc5hlQVBBHJzZpyKMpM5hRSn d/t7VhesaVaQ67SdU6a3NDhehy1lShYJr/nuoHYHjQpx99fw0rs= =wtbK -----END PGP SIGNATURE----- --AUbnlwdToObhcHEH-- From unknown Fri Aug 15 20:57:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Oct 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator