GNU bug report logs - #70295
[PATCH] Allow preprocessing of previews

Previous Next

Full log

Message #14 received at 70295 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Paul Nelson <ultrono <at> gmail.com>
Cc: 70295 <at> debbugs.gnu.org
Subject: Re: bug#70295: [PATCH] Allow preprocessing of previews
Date: Tue, 09 Apr 2024 12:04:20 +0200

Hi Paul,

Paul Nelson <ultrono <at> gmail.com> writes:

> Yes, your suggestion sounds good.

Thanks.

> One other quick thought: maybe it'd be bad design to have an external
> variable like this that can only really be used by one package at a
> time?  Would something like the following be preferred?
>
> (defvar preview-preprocess-functions nil
>   "List of functions used to preprocess region before previewing.
> The functions in this list will be called inside `preview-region' with
> one argument which is a string.")
>
> Then (dolist ...) inside preview-region.  Happy to adjust it either
> way, let me know.

Yes, that might become necessary once more libraries need this feature.
Since currently you're the only customer, I suggest we start without a
list and install your first change, we can adjust later.

Do you like to prepare a new patch?

TIA.  Best, Arash

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.