Subject: bug#70290: closed (Re: [bug#70288] [PATCH 1/3] gnu: Add phonon-backend-vlc.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 30 Apr 2024 16:32:03 +0000

Your bug report

#70288: [PATCH 2/3] gnu: dragon: Switch to Phonon-VLC backend.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
70288: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70288
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#70288] [PATCH 1/3] gnu: Add phonon-backend-vlc.
From: Z572 <[email-masked]>
To: Sughosha via Guix-patches via <[email-masked]>
Cc: [email-masked], Sughosha <[email-masked]>
Date: Wed, 01 May 2024 00:30:59 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Sughosha via Guix-patches via <[email-masked]> writes:

> * gnu/packages/kde-frameworks.scm (phonon-plugin-vlc): New variable.
>
> Change-Id: I5a680d55782cbfcd6349efc64cce36457f456377
> ---
>  gnu/packages/kde-frameworks.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index f487ac9a30..8135cfa544 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -288,6 +288,33 @@ (define-public phonon-backend-gstreamer
>      ;; license: source files mention "either version 2.1 or 3"
>      (license (list license:lgpl2.1 license:lgpl3))))
>  
> +(define-public phonon-backend-vlc
> +  (package
> +    (name "phonon-backend-vlc")
> +    (version "0.12.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://kde/stable/phonon/"
> +                    name "/" version "/"
> +                    name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "19f9wzff4nr36ryq18i6qvsq5kqxfkpqsmsvrarr8jqy8pf7k11k"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     (list #:configure-flags
> +           #~(list "-DPHONON_BUILD_QT6=OFF")))
> +    (native-inputs
> +     (list extra-cmake-modules qttools-5))
> +    (inputs
> +     (list phonon qtbase-5 vlc))
> +    (home-page "https://community.kde.org/Phonon")
> +    (synopsis "Phonon backend which uses VLC")
> +    (description "Phonon makes use of backend libraries to provide sound.
> +Phonon-VLC is a backend based on the VLC multimedia library.")
> +    (license license:lgpl2.1)))
> +
>  
>  ;; Tier 1
>  ;;

apply, see

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=40cf627160f14b7077094e1999de189309e41058
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=418a75b15733affac92254f03b9e74a0ba271fd9
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=29987db3809bbda16762ecb349142be6cf71a0af

Subject: [PATCH 2/3] gnu: dragon: Switch to Phonon-VLC backend.
From: Sughosha <[email-masked]>
To: [email-masked]
Cc: Sughosha <[email-masked]>
Date: Tue, 9 Apr 2024 00:48:52 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/kde-multimedia.scm (dragon):
Delete [arguments].
[inputs]: Remove phonon-plugin-gstreamer, gst-plugins-base and
gst-plugins-good. Add phonon-plugin-vlc.

Change-Id: I162717269085cfc025b03a3cc24b5f99346ce0be
---
 gnu/packages/kde-multimedia.scm | 14 +-------------
 1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/gnu/packages/kde-multimedia.scm b/gnu/packages/kde-multimedia.scm
index 655ae39277..77cafb6090 100644
--- a/gnu/packages/kde-multimedia.scm
+++ b/gnu/packages/kde-multimedia.scm
@@ -126,21 +126,9 @@ (define-public dragon
            kxmlgui
            breeze-icons ; default icon set
            phonon
-           phonon-backend-gstreamer
-           gst-plugins-base
-           gst-plugins-good
+           phonon-backend-vlc
            qtbase-5
            solid))
-    (arguments
-     `(#:phases
-       (modify-phases %standard-phases
-         (add-after 'qt-wrap 'gst-wrap
-           (lambda* (#:key inputs outputs #:allow-other-keys)
-             (let ((out             (assoc-ref outputs "out"))
-                   (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")))
-               (wrap-program (string-append out "/bin/dragon")
-                 `("GST_PLUGIN_SYSTEM_PATH" ":" prefix (,gst-plugin-path)))
-               #t))))))
     (home-page "https://apps.kde.org/dragonplayer/")
     (synopsis "Simple video player")
     (description "Dragon Player is a multimedia player where the focus is on
-- 
2.41.0