GNU bug report logs - #70285
[PATCH 0/3] Cuirass service config options work

Previous Next

Full log

View this message in rfc822 format

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70285 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [bug#70285] [PATCH 3/3] services: cuirass: Remove use-substitutes? configuration option.
Date: Mon,  8 Apr 2024 21:54:14 +0400

As of Cuirass commit 9a1452ee021c9f773424961cfeef47ca0b7c5c5a, this option
seems to be unused and kept for back compatibility there.

* gnu/services/cuirass.scm (<cuirass-configuration>): Remove use-substitutes?
field.
(cuirass-shepherd-service): Remove the option.
* doc/guix.texi (Continuous Integration): Remove option documentation.

Change-Id: I933550ce76eecdf918b07891aa8212fd30a7c87e
---
 doc/guix.texi            | 4 ----
 gnu/services/cuirass.scm | 4 ----
 2 files changed, 8 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 90a6135882..cc55f48aea 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -34400,10 +34400,6 @@ Continuous Integration
 specifications records.  The specification record is described in the
 Cuirass manual (@pxref{Specifications,,, cuirass, Cuirass}).
 
-@item @code{use-substitutes?} (default: @code{#f})
-This allows using substitutes to avoid building every dependencies of a job
-from source.
-
 @item @code{one-shot?} (default: @code{#f})
 Only evaluate specifications and build derivations once.
 
diff --git a/gnu/services/cuirass.scm b/gnu/services/cuirass.scm
index ac086dedb9..0684c149c1 100644
--- a/gnu/services/cuirass.scm
+++ b/gnu/services/cuirass.scm
@@ -117,8 +117,6 @@ (define-record-type* <cuirass-configuration>
                     (default "localhost"))
   (specifications   cuirass-configuration-specifications)
                                   ;gexp that evaluates to specification-alist
-  (use-substitutes? cuirass-configuration-use-substitutes? ;boolean
-                    (default #f))
   (one-shot?        cuirass-configuration-one-shot? ;boolean
                     (default #f))
   (fallback?        cuirass-configuration-fallback? ;boolean
@@ -147,7 +145,6 @@ (define (cuirass-shepherd-service config)
         (config-file      (scheme-file
                            "cuirass-specs.scm"
                            (cuirass-configuration-specifications config)))
-        (use-substitutes? (cuirass-configuration-use-substitutes? config))
         (one-shot?        (cuirass-configuration-one-shot? config))
         (fallback?        (cuirass-configuration-fallback? config))
         (extra-options    (cuirass-configuration-extra-options config))
@@ -177,7 +174,6 @@ (define (cuirass-shepherd-service config)
                                       parameters))
                                '())
                         #$@(if remote-server '("--build-remote") '())
-                        #$@(if use-substitutes? '("--use-substitutes") '())
                         #$@(if one-shot? '("--one-shot") '())
                         #$@(if fallback? '("--fallback") '())
                         #$@extra-options)
-- 
2.41.0

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.