From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 11:49:55 2024 Received: (at submit) by debbugs.gnu.org; 8 Apr 2024 15:49:55 +0000 Received: from localhost ([127.0.0.1]:47428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtrFq-00086X-M6 for submit@debbugs.gnu.org; Mon, 08 Apr 2024 11:49:55 -0400 Received: from lists.gnu.org ([2001:470:142::17]:51752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtrFo-00085T-25 for submit@debbugs.gnu.org; Mon, 08 Apr 2024 11:49:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtrFW-0008QT-2g for guix-patches@gnu.org; Mon, 08 Apr 2024 11:49:34 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtrFT-000188-82 for guix-patches@gnu.org; Mon, 08 Apr 2024 11:49:33 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 05D19240029 for ; Mon, 8 Apr 2024 17:49:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712591368; bh=PWVyXAC4hcL4+MKc+uYdFdeOIvO6b/UZBqEbnLGXQA4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=SJLQwYAaLI7hEWNqv1dCF8HQoLhLgorLsT6nyik9E5F0UBIqX90MtqaURrhioiXZs kBDqhBnNOjRy6BDU1iBGKQSHUJPteVAlRKKwzzdN2sSMUStKSbqpbzqXV1pGps1DiC VTtfKCbYHWU2x45Fsp+t5Nsq7vMHiZQDb0rEUKud8YEB5+ZW6dxFznJWrbGKr/8NLW c8pSgU4j6XRNrCbv4u3avkImIQie4483+WsStPFH32lDCJsMUTo4qFjgjHygL/ru3S xAowZXD3RikoIHhPJZKuG6rUThLDkDSWffmBwfxbLr9+VAImql0wGO6oLBLUHxkAvx 6o6nsIX+/xpfA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VCtnL6sx4z6txh; Mon, 8 Apr 2024 17:49:26 +0200 (CEST) From: Dariqq To: guix-patches@gnu.org Subject: [PATCH 0/2] Fix gnome-shell screenrecorder Date: Mon, 8 Apr 2024 15:39:06 +0000 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , Maxim Cournoyer , Raghav Gururajan , Vivien Kraus Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=dariqq@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit Cc: rekado@elephly.net, Dariqq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello Guix, Last week a user in the irc chat remarked that the built in Gnome screenrecorder is not available which rekado and me then investigated afterwards. This functionality is provided by the org.gnome.Shell.Screencast dbus service which currently fails to start (if for example you try to investigate it with d-spy you get the not really helpful error: GDBus.Error:org.freedesktop.DBus.Error.Spawn.ChildExited: Process org.gnome.Shell.Screencast exited with status 1) We later figured that this error happens because the required typelib files cannot be found. As a fix I imported a patch from NixOS [1] from their gnome-shell 42/44 package and wrapped the relevant files with GI_TYPELIB_PATH. This seems to be strictly necessary only for the screencast service however I wrapped all of the dbus services listed in the js/dbusServices/meson.build file, same as what is done in NixOS. In order for Screencast to work you'll also need pipewire available (I think for the gstreamer plug-in) which is why I added it to gnome-essential-extras in the second patch. You'll also need pipewire running (i.e the home-service) which makes this a bit unintuitive for users. I don't think it is currently possible to enable user level shepherd services from the system configuration, but correct me if I am wrong. Without pipewire running the screen recording stops immediately. As usual i am not sure if the formating/wording of my commit messages and the name I gave the patch are fine. Also thanks to rekado for helping to make sense of this. [1] https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/desktops/gnome/core/gnome-shell/wrap-services.patch Dariqq (2): gnu: gnome-shell: Wrap d-bus services. gnu: gnome-essential-extras: Propagate pipewire. gnu/local.mk | 1 + gnu/packages/gnome.scm | 14 ++++- .../gnome-shell-wrappable-dbus-services.patch | 59 +++++++++++++++++++ 3 files changed, 72 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/gnome-shell-wrappable-dbus-services.patch base-commit: cd45294d576975a3bff2f755764a3f46f09ea6f9 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 11:54:56 2024 Received: (at 70282) by debbugs.gnu.org; 8 Apr 2024 15:54:56 +0000 Received: from localhost ([127.0.0.1]:47456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtrKi-0008Vt-4P for submit@debbugs.gnu.org; Mon, 08 Apr 2024 11:54:56 -0400 Received: from mout01.posteo.de ([185.67.36.65]:45409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtrKe-0008VQ-Tb for 70282@debbugs.gnu.org; Mon, 08 Apr 2024 11:54:54 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 03EE3240028 for <70282@debbugs.gnu.org>; Mon, 8 Apr 2024 17:54:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712591678; bh=vxUwEHTCbTWKF+ngxE08mJ41a5MCb2ZzYQ7IzLsAzgM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=iH45p7GNrgc9Ca9B/7MdvuJmv+fTuy64dPAYQMqYMzWy3G5xpYs0IF4qeIzN3SpL+ G9UYlBjsZYZVv5idopbg5WBjfu4NzMjBVMMyU/jXB6j9Mew1fI/GHgfNfL/WJNFK/t mCYg63ytAzYxLc1JVK9w7XzYXXQZvFyJPrOsoQ6IYFBTCminZFX30gKrH92iywmaJ+ XY0LurzPL9mvLeOBeD34Zn4A3Sz2SbD08snpgq6vbK5MWFE3Pu/sWTtkNikYaBGAww sBLZAv/yiOghX7uxZkGTZk38gY5E/rriYvq9YlrtzbeithFaBv2p381FIDXAIffe8H Ogsr/m/8o+5Pg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VCtvK1pZ7z6tyG; Mon, 8 Apr 2024 17:54:37 +0200 (CEST) From: Dariqq To: 70282@debbugs.gnu.org Subject: [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services. Date: Mon, 8 Apr 2024 15:53:51 +0000 Message-ID: In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , Maxim Cournoyer , Raghav Gururajan , Vivien Kraus Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Dariqq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Some of the dbus services can't find typelibs. * gnu/packages/patches/gnome-shell-wrappable-dbus-services.patch: New file * gnu/lokal.mk: Register it. * gnu/packages/gnome.scm (gnome-shell)[arguments]<#:phases>{'wrap}: Also wrap dbus-services. Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 --- gnu/local.mk | 1 + gnu/packages/gnome.scm | 13 +++- .../gnome-shell-wrappable-dbus-services.patch | 59 +++++++++++++++++++ 3 files changed, 71 insertions(+), 2 deletions(-) create mode 100644 gnu/packages/patches/gnome-shell-wrappable-dbus-services.patch diff --git a/gnu/local.mk b/gnu/local.mk index 255bb870e9..21826c9ec7 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1376,6 +1376,7 @@ dist_patch_DATA = \ %D%/packages/patches/gnome-online-miners-tracker-3.patch \ %D%/packages/patches/gnome-settings-daemon-gc.patch \ %D%/packages/patches/gnome-session-support-elogind.patch \ + %D%/packages/patches/gnome-shell-wrappable-dbus-services.patch\ %D%/packages/patches/gnome-tweaks-search-paths.patch \ %D%/packages/patches/gnumach-support-noide.patch \ %D%/packages/patches/gnupg-default-pinentry.patch \ diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 4934ade3dd..e752232f78 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -9311,7 +9311,9 @@ (define-public gnome-shell name "-" version ".tar.xz")) (sha256 (base32 - "01pw9qnnvh64x56z1gqh0qk6vfn0ihh4zijq23f4bpz9wszlbpwf")))) + "01pw9qnnvh64x56z1gqh0qk6vfn0ihh4zijq23f4bpz9wszlbpwf")) + (patches + (search-patches "gnome-shell-wrappable-dbus-services.patch")))) (build-system meson-build-system) (arguments (let ((disallowed-references @@ -9405,7 +9407,14 @@ (define-public gnome-shell (wrap-program (string-append #$output "/bin/" prog) `("GUIX_PYTHONPATH" ":" prefix (,python-path)) `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))) - '("gnome-shell-perf-tool"))))) + '("gnome-shell-perf-tool")) + ;; Make sure the dbus services can find typelibs + (for-each + (lambda (service) + (wrap-program (string-append #$output "/share/gnome-shell/" service) + `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))) + '("org.gnome.ScreenSaver" "org.gnome.Shell.Extensions" + "org.gnome.Shell.Notifications" "org.gnome.Shell.Screencast"))))) (add-after 'install 'rewire (lambda* (#:key inputs #:allow-other-keys) (for-each diff --git a/gnu/packages/patches/gnome-shell-wrappable-dbus-services.patch b/gnu/packages/patches/gnome-shell-wrappable-dbus-services.patch new file mode 100644 index 0000000000..67ed6beadb --- /dev/null +++ b/gnu/packages/patches/gnome-shell-wrappable-dbus-services.patch @@ -0,0 +1,59 @@ +Retrieved from NixOS: https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/desktops/gnome/core/gnome-shell/wrap-services.patch +--- +diff --git a/js/dbusServices/dbus-service.in b/js/dbusServices/dbus-service.in +old mode 100644 +new mode 100755 +index 524166102..6d0722a1c +--- a/js/dbusServices/dbus-service.in ++++ b/js/dbusServices/dbus-service.in +@@ -1,3 +1,9 @@ ++#!@gjs@ ++ ++// gjs determines the package name from argv[0], which is .*-wrapped ++// so we need to override it to the original one. ++imports.package._findEffectiveEntryPointName = () => '@service@' ++ + imports.package.start({ + name: '@PACKAGE_NAME@', + prefix: '@prefix@', +diff --git a/js/dbusServices/dbus-service.service.in b/js/dbusServices/dbus-service.service.in +index 3b0d09abe..4fd4bb66d 100644 +--- a/js/dbusServices/dbus-service.service.in ++++ b/js/dbusServices/dbus-service.service.in +@@ -1,3 +1,3 @@ + [D-BUS Service] + Name=@service@ +-Exec=@gjs@ @pkgdatadir@/@service@ ++Exec=@pkgdatadir@/@service@ +diff --git a/js/dbusServices/meson.build b/js/dbusServices/meson.build +index eb941ed90..552051e5a 100644 +--- a/js/dbusServices/meson.build ++++ b/js/dbusServices/meson.build +@@ -2,6 +2,7 @@ launcherconf = configuration_data() + launcherconf.set('PACKAGE_NAME', meson.project_name()) + launcherconf.set('prefix', prefix) + launcherconf.set('libdir', libdir) ++launcherconf.set('gjs', gjs.full_path()) + + dbus_services = { + 'org.gnome.Shell.Extensions': 'extensions', +@@ -18,16 +19,17 @@ endif + config_dir = '@0@/..'.format(meson.current_build_dir()) + + foreach service, dir : dbus_services ++ svc_launcherconf = launcherconf ++ svc_launcherconf.set('service', service) + configure_file( + input: 'dbus-service.in', + output: service, +- configuration: launcherconf, ++ configuration: svc_launcherconf, + install_dir: pkgdatadir, + ) + + serviceconf = configuration_data() + serviceconf.set('service', service) +- serviceconf.set('gjs', gjs.full_path()) + serviceconf.set('pkgdatadir', pkgdatadir) + + configure_file( -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 11:54:58 2024 Received: (at 70282) by debbugs.gnu.org; 8 Apr 2024 15:54:58 +0000 Received: from localhost ([127.0.0.1]:47460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtrKj-0008W8-Md for submit@debbugs.gnu.org; Mon, 08 Apr 2024 11:54:57 -0400 Received: from mout01.posteo.de ([185.67.36.65]:40379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtrKi-0008Vi-N1 for 70282@debbugs.gnu.org; Mon, 08 Apr 2024 11:54:57 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5EE0B24002A for <70282@debbugs.gnu.org>; Mon, 8 Apr 2024 17:54:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712591683; bh=hXWHM79gxGT6hC33/7gNkwJw9i8CHd7be/ylrDISTxc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=E0ZzHu+XmGe6N7Xt27eEU8DZM+jM07wFnLOiswaQP6cTnSTt+CweU+4n/Hy3FuBzO tgYYR5XuV3390zKGQLPUqIohtjLUfCOmQeeXIQMN5d7wFNez8nlj4mDmDCoNd2g9OG +/Ak+3+WbJxD3cvICun62hr2FnXByG1wgWhJRqOqXIgO5LBPs/8xYeR8Xl/JRlxRST wcPMuq1dUCa9h/9iDjis5PWK+pUtXNTfBSHjAe0GBsP2mTJzQjRx3BkP4kItCoaidh IEHyto0Y9N9+wqHtfGaznyQ4aXEBaGyGCpO2nf6S4OXvWWClwbVXPE5kxCqyHumxfY UTaoR22oJw7+w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VCtvQ61tJz6tm8; Mon, 8 Apr 2024 17:54:42 +0200 (CEST) From: Dariqq To: 70282@debbugs.gnu.org Subject: [PATCH 2/2] gnu: gnome-essential-extras: Propagate pipewire. Date: Mon, 8 Apr 2024 15:53:52 +0000 Message-ID: <7fd6b30ef26c33ae6e83c930b202124f723b21fc.1712590252.git.dariqq@posteo.net> In-Reply-To: References: MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , Maxim Cournoyer , Raghav Gururajan , Vivien Kraus Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Dariqq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The built-in gnome-shell screencast requries pipewire. * gnu/packages/gnome.scm (gnome-essential-extras): Add pipewire. Change-Id: I6ca5d309f1e6a5f3396b35cfda6d2d470d5b62be --- gnu/packages/gnome.scm | 1 + 1 file changed, 1 insertion(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index e752232f78..f6e3c2f03b 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -10329,6 +10329,7 @@ (define-public gnome-essential-extras gst-plugins-good gucharmap hicolor-icon-theme + pipewire pinentry-gnome3 pulseaudio shared-mime-info -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 12:49:22 2024 Received: (at 70282) by debbugs.gnu.org; 8 Apr 2024 16:49:22 +0000 Received: from localhost ([127.0.0.1]:47514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtsBN-0004RH-1i for submit@debbugs.gnu.org; Mon, 08 Apr 2024 12:49:21 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:51505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtsBJ-0004QB-Hv for 70282@debbugs.gnu.org; Mon, 08 Apr 2024 12:49:19 -0400 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-a44ad785a44so553531966b.3 for <70282@debbugs.gnu.org>; Mon, 08 Apr 2024 09:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712594944; x=1713199744; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=MKlNitkVRNwttS4z+P/Q312TLs/QHbC8oOVgbhj7k80=; b=HKMZ4ZC4rM8d7uRspPq/rhDMCla/B35CuO31cgP8OTB3C6dxB6h+DPoddSUw9nS+C6 WLWYRVKHVWxfTJT11zrUkZxJdA/kkQX+RWggNRi6laVWCQuCvUS4Eum99Qxqu88QX2dg raCX9v0H5UbjiYhyL9y9gUbkc54dT2qWFwi463BCKvLpGKG4B9Nx2LTmB85LguRp341d XmfN1Jrcdnb+hVDNakEeZGUXBDe4UhtEFmGpKRy9GQ6mMWDbEi7WzZD0YCic+fpQzp0I WLpZW06j023yytdBNcVByj8d+WsqUvogt2SWka+DtgDM7MiC+3snuLfKAG7kdFug7opB kAOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712594944; x=1713199744; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=MKlNitkVRNwttS4z+P/Q312TLs/QHbC8oOVgbhj7k80=; b=ahJZZc40LiDQTc+fnu6WkdwfpuRTF/oAPDQx/H38dlHqkDE81xffEJLiVovQ0ACmpZ mQWpqGA+ew9R2ruFIDxEMTA3cWJQbt+pzb8zKSepJ7hLJFrAxIlJ1YfVQI40blWHjVv+ 7qb4RyoKbpJR8p+Rm4aNimrEtHihQdQ+pXPtTNWRi1Wcz7ROkE7Zju6KZjADctu73i3u FguDLKsxA7inulFkpH9KCXqrbxDkJ6nTlJOpQVKZujQcDRzXXKmRALYxcyhD11d2Kd/I RO2my3LMKtGnU1sgYIXnHAgKuwJfZdwQbRXRGw1acyAR+JJBqKEy2TsaK21sz6KYEgp7 eykw== X-Forwarded-Encrypted: i=1; AJvYcCVqNuc6xrHkBx+wCJG16+rojcpEPH4Od59Y6pJ956qom/sGK4ltfsmRlJUZEVbFUX8T1RLkI0wW9rVdYbaX6fW51JvSXOE= X-Gm-Message-State: AOJu0YwT3l+9KY6gM0rs06U3JeBeJidsz1DhleLzhBUqjEKi1xudElhi TDSlfqlqkEepfTVz/FBUgCERRtCM2oJyuGwMiMttFFQjD4W7Dt1R X-Google-Smtp-Source: AGHT+IFhYl0QajfslqXFszVS4CNWo9qeFkKM5EKDVoHFq2vNkDvBYyJt8bqcbPlDzlR3FZwHONyPlQ== X-Received: by 2002:a17:906:2291:b0:a51:9438:af01 with SMTP id p17-20020a170906229100b00a519438af01mr5856524eja.76.1712594943897; Mon, 08 Apr 2024 09:49:03 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id c22-20020a170906529600b00a51bbee7e55sm3277899ejm.53.2024.04.08.09.49.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 09:49:03 -0700 (PDT) Message-ID: <2f609eb58628aa60fdf2fa181852250ef35e9ee5.camel@gmail.com> Subject: Re: [bug#70282] [PATCH 2/2] gnu: gnome-essential-extras: Propagate pipewire. From: Liliana Marie Prikler To: Dariqq , 70282@debbugs.gnu.org Date: Mon, 08 Apr 2024 18:49:02 +0200 In-Reply-To: <7fd6b30ef26c33ae6e83c930b202124f723b21fc.1712590252.git.dariqq@posteo.net> References: <7fd6b30ef26c33ae6e83c930b202124f723b21fc.1712590252.git.dariqq@posteo.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Raghav Gururajan , Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gTW9udGFnLCBkZW0gMDguMDQuMjAyNCB1bSAxNTo1MyArMDAwMCBzY2hyaWViIERhcmlxcToK PiBUaGUgYnVpbHQtaW4gZ25vbWUtc2hlbGwgc2NyZWVuY2FzdCByZXF1cmllcyBwaXBld2lyZS4K PiAKPiAqIGdudS9wYWNrYWdlcy9nbm9tZS5zY20gKGdub21lLWVzc2VudGlhbC1leHRyYXMpOiBB ZGQgcGlwZXdpcmUuCj4gCj4gQ2hhbmdlLUlkOiBJNmNhNWQzMDlmMWU2YTVmMzM5NmIzNWNmZGE2 ZDJkNDcwZDViNjJiZQo+IC0tLQo+IMKgZ251L3BhY2thZ2VzL2dub21lLnNjbSB8IDEgKwo+IMKg MSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4gCj4gZGlmZiAtLWdpdCBhL2dudS9wYWNr YWdlcy9nbm9tZS5zY20gYi9nbnUvcGFja2FnZXMvZ25vbWUuc2NtCj4gaW5kZXggZTc1MjIzMmY3 OC4uZjZlM2MyZjAzYiAxMDA2NDQKPiAtLS0gYS9nbnUvcGFja2FnZXMvZ25vbWUuc2NtCj4gKysr IGIvZ251L3BhY2thZ2VzL2dub21lLnNjbQo+IEBAIC0xMDMyOSw2ICsxMDMyOSw3IEBAIChkZWZp bmUtcHVibGljIGdub21lLWVzc2VudGlhbC1leHRyYXMKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBnc3QtcGx1Z2lucy1nb29kCj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ3Vj aGFybWFwCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgaGljb2xvci1pY29uLXRoZW1lCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBwaXBld2lyZQo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBpbmVudHJ5LWdub21lMwo+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IHB1bHNlYXVkaW8KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCBzaGFyZWQtbWltZS1pbmZvClNob3VsZCBwaXBld2lyZSBub3QgZ28gaW50 byBnbm9tZS1zaGVsbCBvciBzb21ldGhpbmcgZWxzZT8gIFByb3BhZ2F0aW5nCml0IGhlcmUgc2Vl bXMgd2VpcmQuCg== From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 08 12:54:51 2024 Received: (at 70282) by debbugs.gnu.org; 8 Apr 2024 16:54:52 +0000 Received: from localhost ([127.0.0.1]:47518 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtsGe-0004op-GO for submit@debbugs.gnu.org; Mon, 08 Apr 2024 12:54:51 -0400 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:54761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtsGa-0004oA-FE for 70282@debbugs.gnu.org; Mon, 08 Apr 2024 12:54:46 -0400 Received: by mail-lf1-x144.google.com with SMTP id 2adb3069b0e04-516dc51bb72so2633190e87.1 for <70282@debbugs.gnu.org>; Mon, 08 Apr 2024 09:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712595271; x=1713200071; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=7WcR4prioRviF4YzHcblF+BNv/xCJ7OyYKIyOYFhnG0=; b=Ft/cI+aBN/lHEVE5WVxq7k6luTXAaRbe/8y4Uj0Y9n7WP5CpQ/KN60FJxGbJrP/iPj tYKi/C9FX0nPqRGqh5qfdtMXK53sma9n72kp2B+Vn/H7yh/nrNYwAYu7ZjPtOEV27HC1 tbFbPecUVAWpdF1Osu7tbjGT+nk7FzMP6uIoI50pajvIwyNabawr7mznO7774jiGryJr n86jVmyb+3UXf7xRUiogsCx4PsX9jBuXLlq0GFsTkJXAEv4EAG49kLk5xSoOGNMl85Vw hLc2ES5OuZI1H32tRzghRY+VVCS57pb5bXN+XwEOgu3QUVqYEHN0YNLoh254ukVrtJ8U hplQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712595271; x=1713200071; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7WcR4prioRviF4YzHcblF+BNv/xCJ7OyYKIyOYFhnG0=; b=FsrwAbq3AAZTwBmqfr0ftfLMjJoq+V58hxWmq83VZlrZOdSVj1Q6LMmCSAvVKnyxun MuuE+UBYIgJQW28KdQcLDsts0g/YP/p8u2Aw2XhepgJuzNJEzSxVBeW8BcwOY3GAVvpi Qh3/M6PTYO6zPxBs/KW7Esuv3rl/y/PJxUZqyePi37M2tiMavxYGTHvtYz3idUJErVlW wCj7NAPon2oDoPN/pSnQSTAKrMFf4LAZSr0WQ9IkvwkQdEK4ZWHwLkCf38v0clsc9dBv uyyLKB6v9Zhmm6jrNNpOXnCcMG8Aro93/fmz4Ru8WSiGDBvsPrl9gYeOT07J1fSUI/AR JI3w== X-Forwarded-Encrypted: i=1; AJvYcCUjvK9LgirBak17PIdA+xtXA3c4z4ONz4FE7MfL5FGqj7jqn3sPKQyPQQQ2853lQuC15Mo38iD1zwCAN0jQmqo5VaYf5EE= X-Gm-Message-State: AOJu0Yy6JGc3R4vECf0Gs0Bm2wmbMu8RN4er6dcamaxnY0cgs+iLMSOp K0XQpbUnPTRPRtLsFtByvPDlL/1cchKDumV4OP9YjlM00DN1Kyuy X-Google-Smtp-Source: AGHT+IGv/KW1hidIZIKeeOjNIM6M0BJVdvsXjTW4aZuvEoxF+cPimnSSpiA5Kwvz6r9h6SUDmNUqLw== X-Received: by 2002:ac2:5215:0:b0:513:84b6:6915 with SMTP id a21-20020ac25215000000b0051384b66915mr5506713lfl.20.1712595270501; Mon, 08 Apr 2024 09:54:30 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id sd15-20020a170906ce2f00b00a518debfd49sm4640475ejb.116.2024.04.08.09.54.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Apr 2024 09:54:30 -0700 (PDT) Message-ID: <76b3569290ac70f823228916f8f102c1c5c94d7b.camel@gmail.com> Subject: Re: [bug#70282] [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services. From: Liliana Marie Prikler To: Dariqq , 70282@debbugs.gnu.org Date: Mon, 08 Apr 2024 18:54:29 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Raghav Gururajan , Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gTW9udGFnLCBkZW0gMDguMDQuMjAyNCB1bSAxNTo1MyArMDAwMCBzY2hyaWViIERhcmlxcToK PiBTb21lIG9mIHRoZSBkYnVzIHNlcnZpY2VzIGNhbid0IGZpbmQgdHlwZWxpYnMuCj4gCj4gKiBn bnUvcGFja2FnZXMvcGF0Y2hlcy9nbm9tZS1zaGVsbC13cmFwcGFibGUtZGJ1cy1zZXJ2aWNlcy5w YXRjaDogTmV3Cj4gZmlsZQo+ICogZ251L2xva2FsLm1rOiBSZWdpc3RlciBpdC4KPiAqIGdudS9w YWNrYWdlcy9nbm9tZS5zY20gKGdub21lLXNoZWxsKVthcmd1bWVudHNdPCM6cGhhc2VzPnsnd3Jh cH06Cj4gQWxzbyB3cmFwIGRidXMtc2VydmljZXMuCllvdSBjYW4gc2tpcCBbYXJndW1lbnRzXSBh bmQganVzdCB3cml0ZSBbIzpwaGFzZXNdLgoKPiAKPiBDaGFuZ2UtSWQ6IEkyYzMxYmYxYmQ5MmUy ODFiODZjNTdiMDY5ODhjNmEzNzkzYTU4ZDQwCj4gLS0tCj4gwqBnbnUvbG9jYWwubWvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgfMKgIDEgKwo+IMKgZ251L3BhY2thZ2VzL2dub21lLnNjbcKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCAxMyArKystCj4gwqAuLi4vZ25vbWUtc2hlbGwt d3JhcHBhYmxlLWRidXMtc2VydmljZXMucGF0Y2ggfCA1OQo+ICsrKysrKysrKysrKysrKysrKysK PiDCoDMgZmlsZXMgY2hhbmdlZCwgNzEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiDC oGNyZWF0ZSBtb2RlIDEwMDY0NCBnbnUvcGFja2FnZXMvcGF0Y2hlcy9nbm9tZS1zaGVsbC13cmFw cGFibGUtZGJ1cy0KPiBzZXJ2aWNlcy5wYXRjaAo+IAo+IGRpZmYgLS1naXQgYS9nbnUvbG9jYWwu bWsgYi9nbnUvbG9jYWwubWsKPiBpbmRleCAyNTViYjg3MGU5Li4yMTgyNmM5ZWM3IDEwMDY0NAo+ IC0tLSBhL2dudS9sb2NhbC5tawo+ICsrKyBiL2dudS9sb2NhbC5tawo+IEBAIC0xMzc2LDYgKzEz NzYsNyBAQCBkaXN0X3BhdGNoX0RBVEEKPiA9wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoFwKPiDC oMKgICVEJS9wYWNrYWdlcy9wYXRjaGVzL2dub21lLW9ubGluZS1taW5lcnMtdHJhY2tlci0zLnBh dGNowqDCoMKgwqDCoFwKPiDCoMKgICVEJS9wYWNrYWdlcy9wYXRjaGVzL2dub21lLXNldHRpbmdz LWRhZW1vbi1nYy5wYXRjaMKgwqDCoMKgwqDCoMKgwqDCoMKgXAo+IMKgwqAgJUQlL3BhY2thZ2Vz L3BhdGNoZXMvZ25vbWUtc2Vzc2lvbi1zdXBwb3J0LWVsb2dpbmQucGF0Y2jCoMKgwqDCoMKgXAo+ ICvCoCAlRCUvcGFja2FnZXMvcGF0Y2hlcy9nbm9tZS1zaGVsbC13cmFwcGFibGUtZGJ1cy1zZXJ2 aWNlcy5wYXRjaFwKPiDCoMKgICVEJS9wYWNrYWdlcy9wYXRjaGVzL2dub21lLXR3ZWFrcy1zZWFy Y2gtcGF0aHMucGF0Y2jCoMKgwqDCoMKgwqDCoMKgwqBcCj4gwqDCoCAlRCUvcGFja2FnZXMvcGF0 Y2hlcy9nbnVtYWNoLXN1cHBvcnQtbm9pZGUucGF0Y2jCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oFwKPiDCoMKgICVEJS9wYWNrYWdlcy9wYXRjaGVzL2dudXBnLWRlZmF1bHQtcGluZW50cnkucGF0 Y2jCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBcCj4gZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9n bm9tZS5zY20gYi9nbnUvcGFja2FnZXMvZ25vbWUuc2NtCj4gaW5kZXggNDkzNGFkZTNkZC4uZTc1 MjIzMmY3OCAxMDA2NDQKPiAtLS0gYS9nbnUvcGFja2FnZXMvZ25vbWUuc2NtCj4gKysrIGIvZ251 L3BhY2thZ2VzL2dub21lLnNjbQo+IEBAIC05MzExLDcgKzkzMTEsOSBAQCAoZGVmaW5lLXB1Ymxp YyBnbm9tZS1zaGVsbAo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIG5hbWUgIi0iIHZlcnNpb24gIi50YXIueHoiKSkK PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChzaGEyNTYKPiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgKGJhc2UzMgo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAK PiAiMDFwdzlxbm52aDY0eDU2ejFncWgwcWs2dmZuMGloaDR6aWpxMjNmNGJwejl3c3psYnB3ZiIp KSkpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ICIwMXB3OXFubnZoNjR4NTZ6 MWdxaDBxazZ2Zm4waWhoNHppanEyM2Y0YnB6OXdzemxicHdmIikpCj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIChwYXRjaGVzCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHNl YXJjaC1wYXRjaGVzICJnbm9tZS1zaGVsbC13cmFwcGFibGUtZGJ1cy0KPiBzZXJ2aWNlcy5wYXRj aCIpKSkpCj4gwqDCoMKgwqAgKGJ1aWxkLXN5c3RlbSBtZXNvbi1idWlsZC1zeXN0ZW0pCj4gwqDC oMKgwqAgKGFyZ3VtZW50cwo+IMKgwqDCoMKgwqAgKGxldCAoKGRpc2FsbG93ZWQtcmVmZXJlbmNl cwo+IEBAIC05NDA1LDcgKzk0MDcsMTQgQEAgKGRlZmluZS1wdWJsaWMgZ25vbWUtc2hlbGwKPiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHdyYXAtcHJvZ3JhbSAo c3RyaW5nLWFwcGVuZCAjJG91dHB1dCAiL2Jpbi8iCj4gcHJvZykKPiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGAoIkdVSVhfUFlUSE9OUEFUSCLCoMKgwqDC oMKgICI6IiBwcmVmaXggKCxweXRob24tCj4gcGF0aCkpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBgKCJHSV9UWVBFTElCX1BBVEgiICI6IiBwcmVmaXgg KCxnaS10eXBlbGliLQo+IHBhdGgpKSkpCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAnKCJnbm9tZS1zaGVsbC1wZXJmLXRvb2wiKSkpKSkKPiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgICcoImdub21lLXNoZWxsLXBlcmYtdG9vbCIpKQo+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IE1ha2Ugc3VyZSB0aGUgZGJ1cyBzZXJ2 aWNlcyBjYW4gZmluZCB0eXBlbGlicwo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIChmb3ItZWFjaAo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxh bWJkYSAoc2VydmljZSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5kICMkb3V0cHV0Cj4gIi9zaGFyZS9nbm9tZS1z aGVsbC8iIHNlcnZpY2UpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIGAoIkdJX1RZUEVMSUJfUEFUSCIgIjoiIHByZWZpeCAoLGdpLXR5cGVsaWItCj4gcGF0 aCkpKSkKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICcoIm9yZy5nbm9t ZS5TY3JlZW5TYXZlciIKPiAib3JnLmdub21lLlNoZWxsLkV4dGVuc2lvbnMiCj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIm9yZy5nbm9tZS5TaGVsbC5Ob3RpZmlj YXRpb25zIgo+ICJvcmcuZ25vbWUuU2hlbGwuU2NyZWVuY2FzdCIpKSkpKQpMR1RNCj4gwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ3Jld2lyZQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKGxhbWJkYSogKCM6a2V5IGlucHV0cyAjOmFsbG93LW90aGVy LWtleXMpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGZvci1lYWNoCj4gZGlm ZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9wYXRjaGVzL2dub21lLXNoZWxsLXdyYXBwYWJsZS1kYnVz LQo+IHNlcnZpY2VzLnBhdGNoIGIvZ251L3BhY2thZ2VzL3BhdGNoZXMvZ25vbWUtc2hlbGwtd3Jh cHBhYmxlLWRidXMtCj4gc2VydmljZXMucGF0Y2gKPiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+IGlu ZGV4IDAwMDAwMDAwMDAuLjY3ZWQ2YmVhZGIKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvZ251L3Bh Y2thZ2VzL3BhdGNoZXMvZ25vbWUtc2hlbGwtd3JhcHBhYmxlLWRidXMtc2VydmljZXMucGF0Y2gK PiBAQCAtMCwwICsxLDU5IEBACj4gK1JldHJpZXZlZCBmcm9tIE5peE9TOgo+IGh0dHBzOi8vZ2l0 aHViLmNvbS9OaXhPUy9uaXhwa2dzL2Jsb2Ivbml4b3MtMjMuMDUvcGtncy9kZXNrdG9wcy9nbm9t ZS9jb3JlL2dub21lLXNoZWxsL3dyYXAtc2VydmljZXMucGF0Y2gKPiArLS0tCj4gK2RpZmYgLS1n aXQgYS9qcy9kYnVzU2VydmljZXMvZGJ1cy1zZXJ2aWNlLmluIGIvanMvZGJ1c1NlcnZpY2VzL2Ri dXMtCj4gc2VydmljZS5pbgo+ICtvbGQgbW9kZSAxMDA2NDQKPiArbmV3IG1vZGUgMTAwNzU1Cj4g K2luZGV4IDUyNDE2NjEwMi4uNmQwNzIyYTFjCj4gKy0tLSBhL2pzL2RidXNTZXJ2aWNlcy9kYnVz LXNlcnZpY2UuaW4KPiArKysrIGIvanMvZGJ1c1NlcnZpY2VzL2RidXMtc2VydmljZS5pbgo+ICtA QCAtMSwzICsxLDkgQEAKPiArKyMhQGdqc0AKPiArKwo+ICsrLy8gZ2pzIGRldGVybWluZXMgdGhl IHBhY2thZ2UgbmFtZSBmcm9tIGFyZ3ZbMF0sIHdoaWNoIGlzIC4qLQo+IHdyYXBwZWQKPiArKy8v IHNvIHdlIG5lZWQgdG8gb3ZlcnJpZGUgaXQgdG8gdGhlIG9yaWdpbmFsIG9uZS4KPiArK2ltcG9y dHMucGFja2FnZS5fZmluZEVmZmVjdGl2ZUVudHJ5UG9pbnROYW1lID0gKCkgPT4gJ0BzZXJ2aWNl QCcKPiArKwpJcyB0aGVyZSBubyBvdGhlciB3YXkgdG8gc3BlY2lmeSB0aGUgZW50cnkgcG9pbnQ/ Cj4gKyBpbXBvcnRzLnBhY2thZ2Uuc3RhcnQoewo+ICvCoMKgwqDCoCBuYW1lOiAnQFBBQ0tBR0Vf TkFNRUAnLAo+ICvCoMKgwqDCoCBwcmVmaXg6ICdAcHJlZml4QCcsCj4gK2RpZmYgLS1naXQgYS9q cy9kYnVzU2VydmljZXMvZGJ1cy1zZXJ2aWNlLnNlcnZpY2UuaW4KPiBiL2pzL2RidXNTZXJ2aWNl cy9kYnVzLXNlcnZpY2Uuc2VydmljZS5pbgo+ICtpbmRleCAzYjBkMDlhYmUuLjRmZDRiYjY2ZCAx MDA2NDQKPiArLS0tIGEvanMvZGJ1c1NlcnZpY2VzL2RidXMtc2VydmljZS5zZXJ2aWNlLmluCj4g KysrKyBiL2pzL2RidXNTZXJ2aWNlcy9kYnVzLXNlcnZpY2Uuc2VydmljZS5pbgo+ICtAQCAtMSwz ICsxLDMgQEAKPiArIFtELUJVUyBTZXJ2aWNlXQo+ICsgTmFtZT1Ac2VydmljZUAKPiArLUV4ZWM9 QGdqc0AgQHBrZ2RhdGFkaXJAL0BzZXJ2aWNlQAo+ICsrRXhlYz1AcGtnZGF0YWRpckAvQHNlcnZp Y2VACj4gK2RpZmYgLS1naXQgYS9qcy9kYnVzU2VydmljZXMvbWVzb24uYnVpbGQKPiBiL2pzL2Ri dXNTZXJ2aWNlcy9tZXNvbi5idWlsZAo+ICtpbmRleCBlYjk0MWVkOTAuLjU1MjA1MWU1YSAxMDA2 NDQKPiArLS0tIGEvanMvZGJ1c1NlcnZpY2VzL21lc29uLmJ1aWxkCj4gKysrKyBiL2pzL2RidXNT ZXJ2aWNlcy9tZXNvbi5idWlsZAo+ICtAQCAtMiw2ICsyLDcgQEAgbGF1bmNoZXJjb25mID0gY29u ZmlndXJhdGlvbl9kYXRhKCkKPiArIGxhdW5jaGVyY29uZi5zZXQoJ1BBQ0tBR0VfTkFNRScsIG1l c29uLnByb2plY3RfbmFtZSgpKQo+ICsgbGF1bmNoZXJjb25mLnNldCgncHJlZml4JywgcHJlZml4 KQo+ICsgbGF1bmNoZXJjb25mLnNldCgnbGliZGlyJywgbGliZGlyKQo+ICsrbGF1bmNoZXJjb25m LnNldCgnZ2pzJywgZ2pzLmZ1bGxfcGF0aCgpKQo+ICsgCj4gKyBkYnVzX3NlcnZpY2VzID0gewo+ ICvCoMKgICdvcmcuZ25vbWUuU2hlbGwuRXh0ZW5zaW9ucyc6ICdleHRlbnNpb25zJywKPiArQEAg LTE4LDE2ICsxOSwxNyBAQCBlbmRpZgo+ICsgY29uZmlnX2RpciA9ICdAMEAvLi4nLmZvcm1hdCht ZXNvbi5jdXJyZW50X2J1aWxkX2RpcigpKQo+ICsgCj4gKyBmb3JlYWNoIHNlcnZpY2UsIGRpciA6 IGRidXNfc2VydmljZXMKPiArK8KgIHN2Y19sYXVuY2hlcmNvbmYgPSBsYXVuY2hlcmNvbmYKPiAr K8KgIHN2Y19sYXVuY2hlcmNvbmYuc2V0KCdzZXJ2aWNlJywgc2VydmljZSkKPiArwqDCoCBjb25m aWd1cmVfZmlsZSgKPiArwqDCoMKgwqAgaW5wdXQ6ICdkYnVzLXNlcnZpY2UuaW4nLAo+ICvCoMKg wqDCoCBvdXRwdXQ6IHNlcnZpY2UsCj4gKy3CoMKgwqAgY29uZmlndXJhdGlvbjogbGF1bmNoZXJj b25mLAo+ICsrwqDCoMKgIGNvbmZpZ3VyYXRpb246IHN2Y19sYXVuY2hlcmNvbmYsCj4gK8KgwqDC oMKgIGluc3RhbGxfZGlyOiBwa2dkYXRhZGlyLAo+ICvCoMKgICkKPiArIAo+ICvCoMKgIHNlcnZp Y2Vjb25mID0gY29uZmlndXJhdGlvbl9kYXRhKCkKPiArwqDCoCBzZXJ2aWNlY29uZi5zZXQoJ3Nl cnZpY2UnLCBzZXJ2aWNlKQo+ICstwqAgc2VydmljZWNvbmYuc2V0KCdnanMnLCBnanMuZnVsbF9w YXRoKCkpCj4gK8KgwqAgc2VydmljZWNvbmYuc2V0KCdwa2dkYXRhZGlyJywgcGtnZGF0YWRpcikK PiArIAo+ICvCoMKgIGNvbmZpZ3VyZV9maWxlKApDaGVlcnMK From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 10:05:47 2024 Received: (at 70282) by debbugs.gnu.org; 9 Apr 2024 14:05:48 +0000 Received: from localhost ([127.0.0.1]:51172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruC6b-0004j3-SY for submit@debbugs.gnu.org; Tue, 09 Apr 2024 10:05:47 -0400 Received: from mout02.posteo.de ([185.67.36.66]:40669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruC6U-0004hC-1m for 70282@debbugs.gnu.org; Tue, 09 Apr 2024 10:05:43 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id EA647240101 for <70282@debbugs.gnu.org>; Tue, 9 Apr 2024 16:05:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712671522; bh=LKOLbxfMoLYuj7pOMzaoSeMPbxWYg58Jm5uh429GLW0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=U9ZT0mpzudqMNdVJhyBwf6v/Hd7lUTsjexQX4Qij5hYOEf1Eaf9o9vqGy34pFEGUn 8URPyNyZsqv+nt6Qri+8CGeyBr7PZvJsjHOyW9+cGlgj7xtpn8HhsaUNb8oNwz6lfb Topad+oOvXR2qC/kNvUvvEmywfulXc/12UPGN+4oSxmBcgNYfPy8Ub+WT9xKVqAc98 UTdik96/CWBKcALvmV5SYxsI9uXJsGT5Sl1MHZlWsLzrm3f/tn3P73/2vhv3A/BZJ/ ZnWLG/MZAqw4RG9mxAet45pCGxlFqsE0lVA71/ypfF3d+vK0qSAu/k2CZ4i3rHEuib SVpso8H0caX+A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VDSQm6NDDz6txl; Tue, 9 Apr 2024 16:05:20 +0200 (CEST) Message-ID: Date: Tue, 9 Apr 2024 14:05:17 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH 2/2] gnu: gnome-essential-extras: Propagate pipewire. To: Liliana Marie Prikler , 70282@debbugs.gnu.org References: <7fd6b30ef26c33ae6e83c930b202124f723b21fc.1712590252.git.dariqq@posteo.net> <2f609eb58628aa60fdf2fa181852250ef35e9ee5.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <2f609eb58628aa60fdf2fa181852250ef35e9ee5.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Raghav Gururajan , Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 08.04.24 18:49, Liliana Marie Prikler wrote: > Am Montag, dem 08.04.2024 um 15:53 +0000 schrieb Dariqq: >> The built-in gnome-shell screencast requries pipewire. >> >> * gnu/packages/gnome.scm (gnome-essential-extras): Add pipewire. >> >> Change-Id: I6ca5d309f1e6a5f3396b35cfda6d2d470d5b62be >> --- >>  gnu/packages/gnome.scm | 1 + >>  1 file changed, 1 insertion(+) >> >> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm >> index e752232f78..f6e3c2f03b 100644 >> --- a/gnu/packages/gnome.scm >> +++ b/gnu/packages/gnome.scm >> @@ -10329,6 +10329,7 @@ (define-public gnome-essential-extras >>                              gst-plugins-good >>                              gucharmap >>                              hicolor-icon-theme >> +                            pipewire >>                              pinentry-gnome3 >>                              pulseaudio >>                              shared-mime-info > Should pipewire not go into gnome-shell or something else? Propagating > it here seems weird. I wasn't sure if only the gstreamer plugin of pipewire are required or something else from the pipewire package too and that was the easy solution. I just tested adding pipewire to gnome-shell and adding GST_PLUGIN_SYSTEM_PATH to the wrapper seems to be enough. While working on this I also found that also gst-plugins-good are also required for the Screencast service which will get found using the system profile as it is propagated by gnome-essential-extras. Should that also be added to gnome-shell? From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 11:35:36 2024 Received: (at 70282) by debbugs.gnu.org; 9 Apr 2024 15:35:36 +0000 Received: from localhost ([127.0.0.1]:51274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruDVW-0001rL-1j for submit@debbugs.gnu.org; Tue, 09 Apr 2024 11:35:35 -0400 Received: from mout02.posteo.de ([185.67.36.66]:46365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruDVS-0001po-LM for 70282@debbugs.gnu.org; Tue, 09 Apr 2024 11:35:32 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id CD261240103 for <70282@debbugs.gnu.org>; Tue, 9 Apr 2024 17:35:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712676915; bh=M3O/FkmVNUVK8JumAxSPBzf10dssUZl3Fko/B3H1eZc=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:Content-Type: Content-Transfer-Encoding:From; b=IQoA/Z3HkwsAfFa5cRsax2eYNZ85tCaqaFMQ53nQ3iReNj2p3KTjbXo+oycYCLH6a odEp2jYmZbpYa+J1rZDs767Jx/Hb5ETQQOSw3xKFv50txhooomcawP+vNdApNvvkVx /SdfGoviR971NuxfF/gjfrF+HYEXKtmWnRvhEfHUaZ8jsX4D2knXrdeRpVQWUasESk Tgwv87vKrypeXNw+AWZRq1NZadK8vsn0nzqkSEuqeTTBHCXsjw2LcloaLwssMf3XNB ZmL5MW/NyKr3PycTb8wrdUeIY2yNYfSNfeDpssXtBvmJpF/Z8XB3iefWFjSHcKBjEK WXVviRvRmjEZA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VDVQV0SVqz6txd; Tue, 9 Apr 2024 17:35:14 +0200 (CEST) Message-ID: <0704fbb9-91f7-4868-9d45-8236be7a84d6@posteo.net> Date: Tue, 9 Apr 2024 15:35:11 +0000 MIME-Version: 1.0 From: Dariqq Subject: Re: [bug#70282] [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services. To: Liliana Marie Prikler , 70282@debbugs.gnu.org References: <76b3569290ac70f823228916f8f102c1c5c94d7b.camel@gmail.com> Content-Language: en-US In-Reply-To: <76b3569290ac70f823228916f8f102c1c5c94d7b.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Raghav Gururajan , Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, On 08.04.24 18:54, Liliana Marie Prikler wrote: >> new file mode 100644 index 0000000000..67ed6beadb --- /dev/null +++ >> b/gnu/packages/patches/gnome-shell-wrappable-dbus-services.patch @@ >> -0,0 +1,59 @@ +Retrieved from NixOS: >> https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/desktops/gnome/core/gnome-shell/wrap-services.patch >> >> +--- >> +diff --git a/js/dbusServices/dbus-service.in >> b/js/dbusServices/dbus- service.in +old mode 100644 +new mode >> 100755 +index 524166102..6d0722a1c +--- >> a/js/dbusServices/dbus-service.in ++++ >> b/js/dbusServices/dbus-service.in +@@ -1,3 +1,9 @@ ++#!@gjs@ ++ >> ++// gjs determines the package name from argv[0], which is .*- >> wrapped ++// so we need to override it to the original one. >> ++imports.package._findEffectiveEntryPointName = () => '@service@' >> ++ > Is there no other way to specify the entry point? If it is just about the name in argv[0] what about creating a *-wrapper instead and leaving the original file untouched rather than the wrapper replacing the original file? One quick way would be to rename the wrapper script and original file after wrap-program is called, fix the path in the wrapper script and adjust the dbus service file to call the *-wrapper instead. Have a nice day. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 09 13:04:37 2024 Received: (at 70282) by debbugs.gnu.org; 9 Apr 2024 17:04:37 +0000 Received: from localhost ([127.0.0.1]:51345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruEtg-0002Gq-TA for submit@debbugs.gnu.org; Tue, 09 Apr 2024 13:04:37 -0400 Received: from mail-ed1-x544.google.com ([2a00:1450:4864:20::544]:60563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruEtd-0002GC-BD for 70282@debbugs.gnu.org; Tue, 09 Apr 2024 13:04:35 -0400 Received: by mail-ed1-x544.google.com with SMTP id 4fb4d7f45d1cf-56c5d05128dso6590816a12.0 for <70282@debbugs.gnu.org>; Tue, 09 Apr 2024 10:04:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712682259; x=1713287059; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Wc3pztz54aKn/F3ovCzTIs+z3DPQx7rKAn3nxoMxDj8=; b=UKtWgls9l+FAoGnQw/xfnk9j6E6UsNsYHOZk4ytts2+5idigefnDZD8HNPLPGezYGq G9RNleGyaJPEkX8I1NclXi8qajc9aMG9MCh1Ag3qZEo8Nqk2RN0LUdeimITkb7PZeQ6Z GrrrdJX900Hj2uISYVlsj4fFB6iF9IeIhRjAc95N82SiFs1A1WgMkG9A04/IS4qI4XHq 5ZeiCGYCN4TMrynyhUNeMh6JUof8eIxNpyVS50hY2et0ql8cbUrLnsIfBzmrCy1Kd50s V0ernVLHdPT9dUCETMkHjQMbKpahBi7zW3wbxe4WoU3vxo/61AvJH9v9Kst6isO9Uznf FnRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712682259; x=1713287059; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Wc3pztz54aKn/F3ovCzTIs+z3DPQx7rKAn3nxoMxDj8=; b=w8FWTy2EJv84jPjqRC2Puk9WLCNx4Tx4gZf3HFk9QjcxdX1cpoW1prUj0NK3TPTVs6 aU/XAvFwZYvhGwnY0zCvM0HSyN0DSe9WB4dJrB/v9iTxOXlGlkn5Vk/PB5rfZ+xOEt+Y QBJnQGieBxWT7t96R8+iPMjInaHg1IYXOsGdbmYBZGjvaq+hS7HvK+fV+nKKD8HF8J7F WPf793BH6eB1QMqArmkxbXtJnlMLuaqW4SN/8/BhwtO9U5fz4QMcs3P3+a8yo6RqIi6n ql/w8NTY8Arm9Nf8As4fBJMrV9SbbTzY7xunHICje5sfRbp94ES/hz4CG7NRRsJr79ZD eCXw== X-Forwarded-Encrypted: i=1; AJvYcCXvHzcECE+rttVJlaY5+vBqcNs4dN94sZW2nFkLUbBZbJ5ajBLf9oDJUOFICy6uE4AnF1svzpVQLqMBxnv7+MGeKoWRfWo= X-Gm-Message-State: AOJu0YxwehdzdhW+Ab1eydJ/CMNwoNPEcqmiBO849TIngZcW6DY8iuj0 41hGjsbrZaYdJ9m6phEE4yVn/Ml+tnyciqW35dNUTnhM3Ui7Da9x X-Google-Smtp-Source: AGHT+IHf1+4ww6eh2cM6uQBxjNDLRPnzrMdie3MLv7HSz+FJYi3mXLXIWE9gZ5JQjDhesDLwoOPwGQ== X-Received: by 2002:a50:d554:0:b0:56e:23db:3e87 with SMTP id f20-20020a50d554000000b0056e23db3e87mr91584edj.11.1712682258882; Tue, 09 Apr 2024 10:04:18 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id t29-20020a056402241d00b0056e2495f92esm5493197eda.59.2024.04.09.10.04.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Apr 2024 10:04:17 -0700 (PDT) Message-ID: Subject: Re: [bug#70282] [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services. From: Liliana Marie Prikler To: Dariqq , 70282@debbugs.gnu.org Date: Tue, 09 Apr 2024 19:04:16 +0200 In-Reply-To: <0704fbb9-91f7-4868-9d45-8236be7a84d6@posteo.net> References: <76b3569290ac70f823228916f8f102c1c5c94d7b.camel@gmail.com> <0704fbb9-91f7-4868-9d45-8236be7a84d6@posteo.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Raghav Gururajan , Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Dienstag, dem 09.04.2024 um 15:35 +0000 schrieb Dariqq: > Hi, >=20 >=20 > On 08.04.24 18:54, Liliana Marie Prikler wrote: >=20 > > > new file mode 100644 index 0000000000..67ed6beadb --- /dev/null > > > +++ > > > b/gnu/packages/patches/gnome-shell-wrappable-dbus-services.patch > > > @@ > > > -0,0 +1,59 @@ +Retrieved from NixOS:=20 > > > https://github.com/NixOS/nixpkgs/blob/nixos-23.05/pkgs/desktops/gnome= /core/gnome-shell/wrap-services.patch > > >=20 > > >=20 > +--- > > > +diff --git a/js/dbusServices/dbus-service.in > > > b/js/dbusServices/dbus- service.in +old mode 100644 +new mode > > > 100755 +index 524166102..6d0722a1c +--- > > > a/js/dbusServices/dbus-service.in ++++ > > > b/js/dbusServices/dbus-service.in +@@ -1,3 +1,9 @@ ++#!@gjs@ ++=20 > > > ++// gjs determines the package name from argv[0], which is .*-=20 > > > wrapped ++// so we need to override it to the original one.=20 > > > ++imports.package._findEffectiveEntryPointName =3D () =3D> > > > '@service@'=20 > > > ++ > > Is there no other way to specify the entry point? >=20 > If it is just about the name in argv[0] what about creating a *- > wrapper instead and leaving the original file untouched rather than > the wrapper replacing the original file? >=20 > One quick way would be to rename the wrapper script and original file > after wrap-program is called, fix the path in the wrapper script and=20 > adjust the dbus service file to call the *-wrapper instead. >=20 > Have a nice day. You can possibly use wrap-script instead of wrap-program, so that you only need a single file. I've also written Javascript code to expand GI_TYPELIB_PATH in other packages already, perhaps you want to copy that? Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 04:07:32 2024 Received: (at 70282) by debbugs.gnu.org; 10 Apr 2024 08:07:32 +0000 Received: from localhost ([127.0.0.1]:52004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruSzT-0003XP-NM for submit@debbugs.gnu.org; Wed, 10 Apr 2024 04:07:31 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruSzQ-0003Wl-Lk for 70282@debbugs.gnu.org; Wed, 10 Apr 2024 04:07:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id D49F0240101 for <70282@debbugs.gnu.org>; Wed, 10 Apr 2024 10:07:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712736433; bh=dGyalkjB4XvPry9kVdPAVP5gM+EbthmbhlDuBUG6Ss0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=XqDdjqn/pRHrJ05XlmDVSsk1Q8lY7ECqwfUjYLWc0XtrzLW+N7DoRwovOkCYOk+wt J8MYUtajG0ReH8jw9/BjBMZq7jaFpFVVvC1xdFV4kuQ0unNEhflggYpshNNIQf8t1j OAhaKyil57DJ2/fhJRj1MiFcXX8HX1PAcDHbGmfQ5b97L3lEJ+x/8aa+FZTzRZ+aaO 8Xu1MEgaFa06pQxT4cs2sF7SftZz2VTHa/mZmFekuJ6xWzFpqJtBujkS9WlsMkLi1m gNwNiZ+ZMD0PjVKi1idx6+4Um/wIcUqgU7AAe5rpKcH8xwaAG8oOUJ/wH+zIgDVeex pnsnBTyH1Gv8w== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VDwR34rmdz9rxQ; Wed, 10 Apr 2024 10:07:11 +0200 (CEST) Message-ID: <0004900a-2846-4f02-9c76-bf01ab21e11e@posteo.net> Date: Wed, 10 Apr 2024 08:07:08 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services. To: Liliana Marie Prikler , 70282@debbugs.gnu.org References: <76b3569290ac70f823228916f8f102c1c5c94d7b.camel@gmail.com> <0704fbb9-91f7-4868-9d45-8236be7a84d6@posteo.net> Content-Language: en-US From: Dariqq In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Raghav Gururajan , Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 09.04.24 19:04, Liliana Marie Prikler wrote: > You can possibly use wrap-script instead of wrap-program, so that you > only need a single file. I've also written Javascript code to expand > GI_TYPELIB_PATH in other packages already, perhaps you want to copy > that? > > Cheers Thanks for the hint with the javascript code. This makes the fix even easier as the extra patch is no longer required. But then what to do with pipewire/GST_PLUGIN_SYSTEM_PATH? We would be back at propagating it somewhere. Also do you have an idea how to communicate to users to enable the pipewire home service if they want the screenrecorder to work? Have a nice day. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 14:20:30 2024 Received: (at 70282) by debbugs.gnu.org; 10 Apr 2024 18:20:31 +0000 Received: from localhost ([127.0.0.1]:54360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rucYf-0004Jh-44 for submit@debbugs.gnu.org; Wed, 10 Apr 2024 14:20:30 -0400 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:42443) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rucYZ-0004Hi-MP for 70282@debbugs.gnu.org; Wed, 10 Apr 2024 14:20:26 -0400 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-a46ea03c2a5so18275566b.1 for <70282@debbugs.gnu.org>; Wed, 10 Apr 2024 11:20:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712773209; x=1713378009; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=YRT1hO5raSodIOK+hthVUe8cdPw6UxiPjM4EQ5pYXcQ=; b=EhCXNkFGO5Z3bXe1aX9p9nTiAj9ExoCrXPwNZyWJxclHaHji8hWtoeJ8lc/ijOJKv4 HScwz+LkawprU7zwcgv5G38006mQEbp2d9DRtVTuGdLj0YjVOFAmOllP85UPAFpVSoGd s3QEn9tHbQEOWmieu+5meA3rNXCRMCa0q6ryjOq8M8mc9I8i4Xbg5p7KT+SltDBRFbiy GuUDhN6yOJQ+12c0YrHnBY1H424HcMSkTzGnL20EnsMPRH/M2JTraK3i3lQ4TaYIN1qE +WyBTcFl5amKIttWjgXfyItHxFfjuzluPU6AlE8wofjoi2mqFspEVc3izTBg/yTaMPQT Gs4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712773209; x=1713378009; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YRT1hO5raSodIOK+hthVUe8cdPw6UxiPjM4EQ5pYXcQ=; b=CUWqTbdFlLACK9SxDrlda67OFJ0BeOTTQWMdBJEXqYMo9Ms1XJc4vYbCrjAQ3ifizi P2Rx6S7pc3HBmYkdkX0zj4ezCKFHHLdZYG1zG6qMJt7A0AYzWmmC43YTzSV9ilQ1A7IZ XMJi7u/Wtemp5spCcCmO2UQvu5qiG4ZHvy7alUh57O5UKoXRGn69u40B/Fl09iScGr+Y EmsImtXLbkFoczrBBz4OxkgYS8LeZa6wxanKy8ilJLj+anh/Np6BUobXAbv4oXPa0Jvh 2kndyH6GO1yCneMEYe0GGqO+F33v3ZCZJKd3NfvGyZgIJMzzEeqsb+Uxb5aBfdyb+yrc 74Tw== X-Forwarded-Encrypted: i=1; AJvYcCUTFs1xI9d0vV860gakZRT8bgIT+dYn68h7p9qPhPi5fNdGIRAFQp7y/sPIlU57ZuvpwapnRKuRtxxzAbU4SDSBxvKeTv4= X-Gm-Message-State: AOJu0YyWTHMy5Ati5tJbb/udM8KRvJ0AjKRRL4METOwDA20p24iVsVsK lY3b4EkxZwknt2aV6YqDKdFRHrW1WTUX5WbqrbYGdIGedgnXVDE8 X-Google-Smtp-Source: AGHT+IE6/taYcD0toSBID8+ufi9senkn4AoYoxfLXyXe/SPa5umznjKifjlodUCG5DewxROr9gNeTg== X-Received: by 2002:a17:907:2ce6:b0:a52:a25:2077 with SMTP id hz6-20020a1709072ce600b00a520a252077mr304268ejc.14.1712773208556; Wed, 10 Apr 2024 11:20:08 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b10-20020a170906194a00b00a51b3c951b6sm6190773eje.191.2024.04.10.11.20.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 11:20:07 -0700 (PDT) Message-ID: Subject: Re: [bug#70282] [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services. From: Liliana Marie Prikler To: Dariqq , 70282@debbugs.gnu.org Date: Wed, 10 Apr 2024 20:20:06 +0200 In-Reply-To: <0004900a-2846-4f02-9c76-bf01ab21e11e@posteo.net> References: <76b3569290ac70f823228916f8f102c1c5c94d7b.camel@gmail.com> <0704fbb9-91f7-4868-9d45-8236be7a84d6@posteo.net> <0004900a-2846-4f02-9c76-bf01ab21e11e@posteo.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Raghav Gururajan , Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Mittwoch, dem 10.04.2024 um 08:07 +0000 schrieb Dariqq: >=20 >=20 > On 09.04.24 19:04, Liliana Marie Prikler wrote: > > You can possibly use wrap-script instead of wrap-program, so that > > you only need a single file.=C2=A0 I've also written Javascript code to > > expand GI_TYPELIB_PATH in other packages already, perhaps you want > > to copy that? > >=20 > > Cheers >=20 > Thanks for the hint with the javascript code. This makes the fix even > easier as the extra patch is no longer required. >=20 > But then what to do with pipewire/GST_PLUGIN_SYSTEM_PATH? We would be > back at propagating it somewhere. >=20 > Also do you have an idea how to communicate to users to enable the=20 > pipewire home service if they want the screenrecorder to work? For pipewire I'm not sure what the problem is, really. For GST_PLUGIN_SYSTEM_PATH you can add a wrapper that amends the environment variable or possibly call some Gst function =E2=80=93 either in Guile with wrap-script or possibly in Javascript. Cheers From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 05:05:13 2024 Received: (at 70282) by debbugs.gnu.org; 11 Apr 2024 09:05:13 +0000 Received: from localhost ([127.0.0.1]:54904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruqMq-0007bo-LP for submit@debbugs.gnu.org; Thu, 11 Apr 2024 05:05:13 -0400 Received: from mout01.posteo.de ([185.67.36.65]:32855) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ruqMn-0007aR-Gh for 70282@debbugs.gnu.org; Thu, 11 Apr 2024 05:05:10 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8BB9D240027 for <70282@debbugs.gnu.org>; Thu, 11 Apr 2024 11:04:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712826293; bh=xC44/sm/jJPLhF2r2iS8FG53I+FGZwI6Ikh/hqryt2w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=dXLatMDoonMsBPj7ZjJdI/bH8D7ShsRSXzU/V2ujcAQrqWElRjAXc6gpxFYu6qvNg DePapmKV6hIfjF5NY3WQ10dTb1CuL7zuMzfasBbTybKFCfxBqLCExVC4r3Vn3v4EsI rohzQQi3cBaykvaTyngvKoY0D843SIB0vl82lPtr3EI7ci0vawtdttERzcyl2lZwz3 olTSMWqCHIvZB6w2jANn8Oac2jkSAmO0EX8vur5xJ11XVl7dTmcCjCtElHx/24vjFg IRzLuEufEEQPaJNx8HdzW+uIF19XgvH0KETC+zumh1T88U/lgHRBodiNtk4fiZt4Ql 5ZIqquDUv0AIA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VFYg64J7kz9rwn; Thu, 11 Apr 2024 11:04:50 +0200 (CEST) Message-ID: Date: Thu, 11 Apr 2024 09:04:46 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH 1/2] gnu: gnome-shell: Wrap d-bus services. To: Liliana Marie Prikler , 70282@debbugs.gnu.org References: <76b3569290ac70f823228916f8f102c1c5c94d7b.camel@gmail.com> <0704fbb9-91f7-4868-9d45-8236be7a84d6@posteo.net> <0004900a-2846-4f02-9c76-bf01ab21e11e@posteo.net> Content-Language: en-US From: Dariqq In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: rekado@elephly.net, Raghav Gururajan , Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, On 10.04.24 20:20, Liliana Marie Prikler wrote: > Am Mittwoch, dem 10.04.2024 um 08:07 +0000 schrieb Dariqq: >> >> >> On 09.04.24 19:04, Liliana Marie Prikler wrote: >>> You can possibly use wrap-script instead of wrap-program, so that >>> you only need a single file.  I've also written Javascript code to >>> expand GI_TYPELIB_PATH in other packages already, perhaps you want >>> to copy that? >>> >>> Cheers >> >> Thanks for the hint with the javascript code. This makes the fix even >> easier as the extra patch is no longer required. >> >> But then what to do with pipewire/GST_PLUGIN_SYSTEM_PATH? We would be >> back at propagating it somewhere. >> >> Also do you have an idea how to communicate to users to enable the >> pipewire home service if they want the screenrecorder to work? > For pipewire I'm not sure what the problem is, really. For > GST_PLUGIN_SYSTEM_PATH you can add a wrapper that amends the > environment variable or possibly call some Gst function – either in > Guile with wrap-script or possibly in Javascript. Unfortunately wrap-script does not work as the file #$gnome-shell/share/gnome-shell/org.gnome.Shell.Screencast has no shebang line set and even if it would ( enabled by the extra patch) gjs is not a valid interpreter for wrap_script and trying to change that rebuilds everything. I am currently trying to find out if it is possible to do a similiar thing as the GI_TYPELIB_PATH with javascript. Or change the environment variable before through another way. My limited javascript knowledge is not helping here either. > Cheers Have a nice day From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 13:47:56 2024 Received: (at 70282) by debbugs.gnu.org; 12 Apr 2024 17:47:56 +0000 Received: from localhost ([127.0.0.1]:59536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvL0E-0007WJ-1e for submit@debbugs.gnu.org; Fri, 12 Apr 2024 13:47:56 -0400 Received: from mout01.posteo.de ([185.67.36.65]:45029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvL09-0007UC-5s for 70282@debbugs.gnu.org; Fri, 12 Apr 2024 13:47:51 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D1FF5240027 for <70282@debbugs.gnu.org>; Fri, 12 Apr 2024 19:47:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1712944052; bh=X2oid8sEb/Fk4KzGWLK2HSxty+Sad10oPwbPpPM7h7g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=Xa8aJgBo10/lKVuN8IXd26T0EL1K72svdW27a28MDbzWbDZ3o3UVxWmqMCX5oXBej zxCM4p0SaEVjtcl+7z4tV1TfV4hBCxEYkRuAhVwDNHyWKR+uDoSn23RH0ydyr29+Rb y7CvOSDZj/VMOrnjTQnjMgOXbZmqPEkYoHnO5KeFkyepG+3sh0X82t97NJMOdQThrQ 20XSKX93H7TOf1pX5RfO1sx5R90dNX9yfWy+ciynstObB7dfTcqzB211j/Qh8x10Ca h/PWgG/ZYa9l58WEYaps96Tvrkm8damhNZtlNOUsYUji/tZcQ9uGi1cOFCsBSGH0Fe oWz3isieXwJQg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VGPCm2Bvbz9rxG; Fri, 12 Apr 2024 19:47:32 +0200 (CEST) From: Dariqq To: 70282@debbugs.gnu.org Subject: [PATCH v2] gnu: gnome-shell: Wrap screencast service. Date: Fri, 12 Apr 2024 17:26:48 +0000 Message-ID: MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , Maxim Cournoyer , Vivien Kraus Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: Dariqq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) The screencast service can now find typelibs and gstreamer plugins. * gnu/packages/linux.scm (gnome-shell) [inputs]: Add gst-plugins-good and pipewire. [#:phases]<'wrap-programs>: Create a wrapper for screencast service and use it. Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 --- Hi, Here is v2 of the patch. The wrapper is now created manually as I was unable to find a way to manipulate the gstreamer plugin load path from within javascript. Importantly this leaves the original javascript file untouched and therefore circumvents the argv[0] problem in v1. All the required gstreamer plugins (pipewire and gst-plugins-good) are now inputs and are in the wrapper via GST_PLUGIN_SYSTEM_PATH. I've also left a comment for the required home-pipewire-service. In gnome-shell 45+ the invocation has changed to 'gjs -m service'. Should this also be a comment somewhere? gnu/packages/gnome.scm | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 4934ade3dd..d68624344f 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -9381,6 +9381,7 @@ (define-public gnome-shell (add-after 'install 'wrap-programs (lambda* (#:key inputs #:allow-other-keys) (let ((gi-typelib-path (getenv "GI_TYPELIB_PATH")) + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) (python-path (string-join (filter (lambda (item) @@ -9405,7 +9406,39 @@ (define-public gnome-shell (wrap-program (string-append #$output "/bin/" prog) `("GUIX_PYTHONPATH" ":" prefix (,python-path)) `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))) - '("gnome-shell-perf-tool"))))) + '("gnome-shell-perf-tool")) + ;; Make a wrapper for the screencast service + ;; Requires a pipewire service running + ;; (i.e. as provided by home-pipewire-service-type) + (let* ((screencast "org.gnome.Shell.Screencast") + (dir (string-append #$output "/share/gnome-shell/")) + (dbus-service-dir (string-append #$output + "/share/dbus-1/" + "services/")) + (wrapper (string-append dir screencast "-wrapper"))) + (call-with-output-file wrapper + (lambda (port) + (format port + (string-append + "#!~a~%" + "export GI_TYPELIB_PATH=~a~%" + "export GST_PLUGIN_SYSTEM_PATH=~a~%" + "exec \"~a\" \"~a\" \"$@\"~%") + (which "bash") + (format #f "\"~a${~a:+:}$~a\"" + gi-typelib-path + "GI_TYPELIB_PATH" "GI_TYPELIB_PATH") + (format #f "\"~a${~a:+:}$~a\"" + gst-plugin-path + "GST_PLUGIN_SYSTEM_PATH" + "GST_PLUGIN_SYSTEM_PATH") + (string-append #$(this-package-input "gjs") + "/bin/gjs") + (string-append dir screencast)))) + (chmod wrapper #o555) + (substitute* (string-append dbus-service-dir screencast + ".service") + (("Exec=.*") (string-append "Exec=" wrapper "\n"))))))) (add-after 'install 'rewire (lambda* (#:key inputs #:allow-other-keys) (for-each @@ -9465,6 +9498,7 @@ (define-public gnome-shell gnome-settings-daemon graphene gst-plugins-base + gst-plugins-good ibus libcanberra libcroco @@ -9475,6 +9509,7 @@ (define-public gnome-shell mesa-headers mutter network-manager-applet + pipewire polkit pulseaudio python-pygobject base-commit: 3dc26b4eaed448cbc02a80bafb2ebb6d908f2b4e -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 14:52:00 2024 Received: (at 70282) by debbugs.gnu.org; 19 Apr 2024 18:52:01 +0000 Received: from localhost ([127.0.0.1]:59762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxtL6-0005UC-JJ for submit@debbugs.gnu.org; Fri, 19 Apr 2024 14:52:00 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:51693) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxtL4-0005TK-9K for 70282@debbugs.gnu.org; Fri, 19 Apr 2024 14:51:59 -0400 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-a44ad785a44so239976466b.3 for <70282@debbugs.gnu.org>; Fri, 19 Apr 2024 11:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713552698; x=1714157498; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=WrQDdjc23J9WeJOnueOUrf+ISTEV8nIVfSSrjl36gS0=; b=eYQQYFnBOWyDv32IT+P+/NZqBLfKI2FkTeZLhMWwy97/tX8J9IwSQ9EzcFrGPLjX1J ffxGSuUGlvjQE0ARpY0l2lixstbgSnUCcD9gTJDPRa9TzaFfZO7BqQBvRnQvymeR6OR6 oS3bBSbui2bz0IqP0Zfd7Jxqz5hw6+RxqNOg2zw7tDXyMFyQaZuaBJRrhkiM7AG0HpD9 1JTNbfO7sUL2P4iqIyzXiBSo+Vc3W5vpA3oHULcJAB5udLkEzyciSrkkCj19hV4ezllc NXaFzhsnjSW49EZS247EcebW8Vd5s+J80TePmzNl29MMKGm0jdjC4cOMxzCpyY1v4BD5 cjgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713552698; x=1714157498; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=WrQDdjc23J9WeJOnueOUrf+ISTEV8nIVfSSrjl36gS0=; b=R94QSDY8H9SVevveId8GzOB+3l4ILOodY+DvDld8PVZ+xTkHEE/+xWWGrWT2pkgT4A 6B0lFgEJY0dbtoZLp1es3V98FJdvkAiozdeVRRS6S2dSQxFZNLhc9goBapcl6JR/200+ fzqdmTFcJkKR/7cFJU9rmnVI32bP3RnmPpfUYp4LcqBvWWOLY4jRsHqCpFniqSfTDcqV Gry/BvCHGZ2n0PTFCJJ9odusRtEtnpGBIHRgLCRKN3pkAX8qjfh3NedJCIf/mKNhh0vn yHlSdKpHP1+QTFRdExBroH3P3ccAAOWQ9vT2wg84U5wEw53KrXU0gKZSkvpnNLJs9FdY pNjA== X-Forwarded-Encrypted: i=1; AJvYcCUBrAcDzFm/qSbes3BQeegvSAbtQdCiqeMMpFVhrrHIlnu7F/1173oVfqXe6BGGtmgdvZScUphdGZY+KlTDJwxpfQwkdFc= X-Gm-Message-State: AOJu0YyuLWkzaBAt4pMy/XaQF1Qm23PawLBH4RmemQKt+gFNqwh5dHsx 9LMgtjawqkjSHqRacMagQPL1/wC+dB/dnzhu8ok6wNPzo8RU66vc X-Google-Smtp-Source: AGHT+IGN3HlNww7DdZlSNuch32/9jOlcaX9fMbai9VN5mpZbWi/eLJGhA0c59gb9z8gRV8YvKskE1g== X-Received: by 2002:a17:906:a1ce:b0:a52:5277:3aa7 with SMTP id bx14-20020a170906a1ce00b00a5252773aa7mr2093765ejb.22.1713552697974; Fri, 19 Apr 2024 11:51:37 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id hz13-20020a1709072ced00b00a5592eeac79sm231543ejc.13.2024.04.19.11.51.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Apr 2024 11:51:37 -0700 (PDT) Message-ID: <0497984af8f383af8e8b981d78dc9baf23869e30.camel@gmail.com> Subject: Re: [bug#70282] [PATCH v2] gnu: gnome-shell: Wrap screencast service. From: Liliana Marie Prikler To: Dariqq , 70282@debbugs.gnu.org Date: Fri, 19 Apr 2024 20:51:36 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Freitag, dem 12.04.2024 um 17:26 +0000 schrieb Dariqq: > The screencast service can now find typelibs and gstreamer plugins. >=20 > * gnu/packages/linux.scm (gnome-shell) > [inputs]: Add gst-plugins-good and pipewire. > [#:phases]<'wrap-programs>: Create a wrapper for screencast service > and use it. >=20 > Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 > --- >=20 > Hi, >=20 > Here is v2 of the patch. The wrapper is now created manually as I was > unable to find a way to manipulate the gstreamer plugin load path > from within javascript. Importantly this leaves the original > javascript file untouched and therefore circumvents the argv[0] > problem in v1. > All the required gstreamer plugins (pipewire and gst-plugins-good) > are now inputs and are in the wrapper via GST_PLUGIN_SYSTEM_PATH. I'm not sure this fix is sounds. It looks like it misses manual invocation from the command line, does it not? (Well, it's gnome- shell, so if you have to invoke it from the command line, things are broken, but still=E2=80=A6) What keeps you from wrapping the environment variable in Javascript? > I've also left a comment for the required home-pipewire-service. > In gnome-shell 45+ the invocation has changed to 'gjs -m service'. > Should this also be a comment somewhere? Gnome-shell 45+ is currently irrelevant, but we might have to adapt things once we get there on gnome-team. We do need a better gjs- patching strategy. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 06:12:16 2024 Received: (at 70282) by debbugs.gnu.org; 20 Apr 2024 10:12:16 +0000 Received: from localhost ([127.0.0.1]:35534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry7hf-0007cQ-Mn for submit@debbugs.gnu.org; Sat, 20 Apr 2024 06:12:16 -0400 Received: from mout01.posteo.de ([185.67.36.65]:34011) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry7hb-0007am-Bj for 70282@debbugs.gnu.org; Sat, 20 Apr 2024 06:12:13 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9DA0924002A for <70282@debbugs.gnu.org>; Sat, 20 Apr 2024 12:11:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1713607910; bh=80NwzpQPnozcN7zxOTb1rEhdT+gvH8EKxvuChaXqT5M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=hUs2u1Yf5snFjGx4xAE3H+swmnzIZ2p2z6mSbeqpkAf+Wfnw+NFp9vPmaRf1itCoy NRzvAGhTLoBZ0NywHPfbYra4Yd7B1Sx756E0ZktNr0UX9uTsZpxcQL4HE1OYIf6Br5 tdy/CeXMSOiP7bABeXzZJ+UrYOX9RcfUQEWjx52bRrzxWqmX7JBaA77jtXpwiaOBoJ T1MsCO4RhFqG3s0woZHuhOa8lgU0U6ucvVtthjgBljuvLCSfCCyFAkkVg3MC+ZJZlC 8Ip8pjYc+FaWLh+BZg6Xgvf8uNqXA3010q42qVDjMf44+Ct2ZlOjElaAfY0JdpPdZB kE+3oyBefPJ2A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VM6kF4sd7z6tm4; Sat, 20 Apr 2024 12:11:49 +0200 (CEST) Message-ID: Date: Sat, 20 Apr 2024 10:11:43 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH v2] gnu: gnome-shell: Wrap screencast service. To: Liliana Marie Prikler , 70282@debbugs.gnu.org References: <0497984af8f383af8e8b981d78dc9baf23869e30.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <0497984af8f383af8e8b981d78dc9baf23869e30.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 19.04.24 20:51, Liliana Marie Prikler wrote: > Am Freitag, dem 12.04.2024 um 17:26 +0000 schrieb Dariqq: >> The screencast service can now find typelibs and gstreamer plugins. >> >> * gnu/packages/linux.scm (gnome-shell) >> [inputs]: Add gst-plugins-good and pipewire. >> [#:phases]<'wrap-programs>: Create a wrapper for screencast service >> and use it. >> >> Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 >> --- >> >> Hi, >> >> Here is v2 of the patch. The wrapper is now created manually as I was >> unable to find a way to manipulate the gstreamer plugin load path >> from within javascript. Importantly this leaves the original >> javascript file untouched and therefore circumvents the argv[0] >> problem in v1. >> All the required gstreamer plugins (pipewire and gst-plugins-good) >> are now inputs and are in the wrapper via GST_PLUGIN_SYSTEM_PATH. > I'm not sure this fix is sounds. It looks like it misses manual > invocation from the command line, does it not? (Well, it's gnome- > shell, so if you have to invoke it from the command line, things are > broken, but still…) If only the typelib path is set the dbus service now longer greets you with an error but still fails to start without the gstreamer plugins. That's why in v1 I was propagating pipewire through gnome-essential-extras. I am not sure what you mean by manual invocation. The screencast service should get started via dbus. Nothing manual should be required (other than enabling the pipewire home service). What keeps you from wrapping the environment > variable in Javascript? I was unable to find a way to manipulate the GST_PLUGIN_PATH or specify the gst search path from within javascript. There is Gst.Registry().scan_path but this creates a new registry and I don't think is what we want here. (but I don't know anything about gstreamer and javascript so I could be wrong here). I guess the most simple patch for the typelibs would be something like diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index fa6c566c75..28c4e540a6 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -9404,13 +9404,15 @@ (define-public gnome-shell (wrap-program (string-append #$output "/bin/" prog) `("GI_TYPELIB_PATH" ":" prefix (,gi-typelib-path)))) '("gnome-shell" "gnome-extensions-app")) - (substitute* (string-append #$output "/share/gnome-shell/" - "org.gnome.Shell.Extensions") - (("imports\\.package\\.start" all) - (string-append "'" gi-typelib-path "'.split(':').forEach(" - "path => imports.gi.GIRepository.Repository." - "prepend_search_path(path));\n" - all))) + (for-each + (lambda (prog) + (substitute* (string-append #$output "/share/gnome-shell/" prog) + (("imports\\.package\\.start" all) + (string-append "'" gi-typelib-path "'.split(':').forEach(" + "path => imports.gi.GIRepository.Repository." + "prepend_search_path(path));\n" + all)))) + '("org.gnome.Shell.Extensions" "org.gnome.Shell.Screencast")) (for-each (lambda (prog) (wrap-program (string-append #$output "/bin/" prog) and dealing with the gstreamer plugins in another way. >> I've also left a comment for the required home-pipewire-service. >> In gnome-shell 45+ the invocation has changed to 'gjs -m service'. >> Should this also be a comment somewhere? > Gnome-shell 45+ is currently irrelevant, but we might have to adapt > things once we get there on gnome-team. We do need a better gjs- > patching strategy. > It would be nice if something like wrap-script would work. But the problem is that the dbus services specify somehting like "Exec= gjs service" rather than executing a gjs-script directly. (which is the main purpose of the patch from nixos). And also gjs not being a valid interpreter for wrap-script (Changing that will rebuild everything) > Cheers > Have an nice day. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 20 06:46:52 2024 Received: (at 70282) by debbugs.gnu.org; 20 Apr 2024 10:46:52 +0000 Received: from localhost ([127.0.0.1]:35678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry8F9-0003F2-M9 for submit@debbugs.gnu.org; Sat, 20 Apr 2024 06:46:52 -0400 Received: from mail-ej1-x641.google.com ([2a00:1450:4864:20::641]:46315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ry8F6-0003E1-M3 for 70282@debbugs.gnu.org; Sat, 20 Apr 2024 06:46:49 -0400 Received: by mail-ej1-x641.google.com with SMTP id a640c23a62f3a-a5544fd07easo313967566b.0 for <70282@debbugs.gnu.org>; Sat, 20 Apr 2024 03:46:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713609988; x=1714214788; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Di+QqbHHBWonAyd4AfnmCzKFAFnZLGBfLOmfE1ns0iE=; b=LYc5anYZtgCvNjzJ8Hg/tQGnV7DRKHL5aXsMovBpOPMjIV0eYAM5bP0fMjc5zZwk0i 7LpUDzdm3VHiRolWvnVCvH/LvTc8WvRr8JKTdPEzAN+Qk13QMRxbCoN6wBgKLsBNsGQa 55O7w0GqmA8GcZkdW64/Jn65f6GIvynOy+00ZUjdoEWCdR/qJhWSBY0SNqYPW628auM1 jXf8PMgogeeFDSoeqIb66XaAhM6aBIUdrE1yRmHPLs2cla0wYXxp7smOw4gw7e2UVsXb mstUjXBQ5TK8+26l0fPROVxWnKX173I0aJFb4HbRuSvQS50H07YNNdB/5M7qyraa65pK nStQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713609988; x=1714214788; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Di+QqbHHBWonAyd4AfnmCzKFAFnZLGBfLOmfE1ns0iE=; b=V+PhVy/iDKGi1/QqpIGHx1EDORyVlbrJ4Qegtd1y7GB2vIF1IjHs17GVMTuFxJmXn7 Jx1vWzAkdgS0s6d5GadFwtzHg7N+AnCNOUnmIsBvDLKwhw5DDXPvFlKsMAM545xMfNLt wWQQk+4dog1DTGSMefIModYW4H4qbDRY1rJ5fe3zvN/V2EE1aHUJRp2+RuTtq0atk/kI YvG1gU3ifQJVMUqsgaiTTP/fi1BlgoCzlPOWQacxgqhsD2jb500MolMgLtlp+bSLRsyu zlX9nMepcfCa/0jvFzOkKRTd7m3yBsm9CN7DtqJf+XZZd0MFOisK/r2IxInZB4nTZTp2 Igcg== X-Forwarded-Encrypted: i=1; AJvYcCWjuixLjXWIc6kN/TSNZIfn3KhremgwaDINUKdvsTiUV1+m0l73nWhnYVTGUes6FcqtyltRSUAgO51uLvRjM+MgFiHGrJ4= X-Gm-Message-State: AOJu0YwYVIKcDl79xUBW0CVv+/+i2qFQUJu0ypQRkEzyOUUqst11MA+Y STMYkxIwQJ9xqSug2BdC8vUXcuwmm/DqJHdV52uIx87ppk2Nb1ky X-Google-Smtp-Source: AGHT+IEMSx8DkVde5I4Fy9icjkwqOqlqiWctEwUcqpRWw7j/MdajT5CCml0l/UDevkCo0rhbUXvpcg== X-Received: by 2002:a17:906:365b:b0:a52:67ce:c64d with SMTP id r27-20020a170906365b00b00a5267cec64dmr2823137ejb.66.1713609987610; Sat, 20 Apr 2024 03:46:27 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id j5-20020a170906410500b00a517995c070sm3258217ejk.33.2024.04.20.03.46.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 20 Apr 2024 03:46:27 -0700 (PDT) Message-ID: <7a635b027f59d348312098650d1606f2e658ffab.camel@gmail.com> Subject: Re: [bug#70282] [PATCH v2] gnu: gnome-shell: Wrap screencast service. From: Liliana Marie Prikler To: Dariqq , 70282@debbugs.gnu.org Date: Sat, 20 Apr 2024 12:46:25 +0200 In-Reply-To: References: <0497984af8f383af8e8b981d78dc9baf23869e30.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gU2Ftc3RhZywgZGVtIDIwLjA0LjIwMjQgdW0gMTA6MTEgKzAwMDAgc2NocmllYiBEYXJpcXE6 Cj4gCj4gCj4gT24gMTkuMDQuMjQgMjA6NTEsIExpbGlhbmEgTWFyaWUgUHJpa2xlciB3cm90ZToK PiA+IEFtIEZyZWl0YWcsIGRlbSAxMi4wNC4yMDI0IHVtIDE3OjI2ICswMDAwIHNjaHJpZWIgRGFy aXFxOgo+ID4gPiBUaGUgc2NyZWVuY2FzdCBzZXJ2aWNlIGNhbiBub3cgZmluZCB0eXBlbGlicyBh bmQgZ3N0cmVhbWVyCj4gPiA+IHBsdWdpbnMuCj4gPiA+IAo+ID4gPiAqIGdudS9wYWNrYWdlcy9s aW51eC5zY20gKGdub21lLXNoZWxsKQo+ID4gPiBbaW5wdXRzXTogQWRkIGdzdC1wbHVnaW5zLWdv b2QgYW5kIHBpcGV3aXJlLgo+ID4gPiBbIzpwaGFzZXNdPCd3cmFwLXByb2dyYW1zPjogQ3JlYXRl IGEgd3JhcHBlciBmb3Igc2NyZWVuY2FzdAo+ID4gPiBzZXJ2aWNlCj4gPiA+IGFuZCB1c2UgaXQu Cj4gPiA+IAo+ID4gPiBDaGFuZ2UtSWQ6IEkyYzMxYmYxYmQ5MmUyODFiODZjNTdiMDY5ODhjNmEz NzkzYTU4ZDQwCj4gPiA+IC0tLQo+ID4gPiAKPiA+ID4gSGksCj4gPiA+IAo+ID4gPiBIZXJlIGlz IHYyIG9mIHRoZSBwYXRjaC4gVGhlIHdyYXBwZXIgaXMgbm93IGNyZWF0ZWQgbWFudWFsbHkgYXMg SQo+ID4gPiB3YXMgdW5hYmxlIHRvIGZpbmQgYSB3YXkgdG8gbWFuaXB1bGF0ZSB0aGUgZ3N0cmVh bWVyIHBsdWdpbiBsb2FkCj4gPiA+IHBhdGggZnJvbSB3aXRoaW4gamF2YXNjcmlwdC4gSW1wb3J0 YW50bHkgdGhpcyBsZWF2ZXMgdGhlIG9yaWdpbmFsCj4gPiA+IGphdmFzY3JpcHQgZmlsZSB1bnRv dWNoZWQgYW5kIHRoZXJlZm9yZSBjaXJjdW12ZW50cyB0aGUgYXJndlswXQo+ID4gPiBwcm9ibGVt IGluIHYxLgo+ID4gPiBBbGwgdGhlIHJlcXVpcmVkIGdzdHJlYW1lciBwbHVnaW5zIChwaXBld2ly ZSBhbmQgZ3N0LXBsdWdpbnMtCj4gPiA+IGdvb2QpIGFyZSBub3cgaW5wdXRzIGFuZCBhcmUgaW4g dGhlIHdyYXBwZXIgdmlhCj4gPiA+IEdTVF9QTFVHSU5fU1lTVEVNX1BBVEguCj4gPiBJJ20gbm90 IHN1cmUgdGhpcyBmaXggaXMgc291bmRzLsKgIEl0IGxvb2tzIGxpa2UgaXQgbWlzc2VzIG1hbnVh bAo+ID4gaW52b2NhdGlvbiBmcm9tIHRoZSBjb21tYW5kIGxpbmUsIGRvZXMgaXQgbm90P8KgIChX ZWxsLCBpdCdzIGdub21lLQo+ID4gc2hlbGwsIHNvIGlmIHlvdSBoYXZlIHRvIGludm9rZSBpdCBm cm9tIHRoZSBjb21tYW5kIGxpbmUsIHRoaW5ncwo+ID4gYXJlIGJyb2tlbiwgYnV0IHN0aWxs4oCm KQo+IAo+IElmIG9ubHkgdGhlIHR5cGVsaWIgcGF0aCBpcyBzZXQgdGhlIGRidXMgc2VydmljZSBu b3cgbG9uZ2VyIGdyZWV0cwo+IHlvdSB3aXRoIGFuIGVycm9yIGJ1dCBzdGlsbCBmYWlscyB0byBz dGFydCB3aXRob3V0IHRoZSBnc3RyZWFtZXIKPiBwbHVnaW5zLiAgVGhhdCdzIHdoeSBpbiB2MSBJ IHdhcyBwcm9wYWdhdGluZyBwaXBld2lyZSB0aHJvdWdoCj4gZ25vbWUtZXNzZW50aWFsLWV4dHJh cy4KPiAKPiBJIGFtIG5vdCBzdXJlIHdoYXQgeW91IG1lYW4gYnkgbWFudWFsIGludm9jYXRpb24u IFRoZSBzY3JlZW5jYXN0Cj4gc2VydmljZSAgc2hvdWxkIGdldCBzdGFydGVkIHZpYSBkYnVzLiBO b3RoaW5nIG1hbnVhbCBzaG91bGQgYmUKPiByZXF1aXJlZCAob3RoZXIgdGhhbiBlbmFibGluZyB0 aGUgcGlwZXdpcmUgaG9tZSBzZXJ2aWNlKS4KSnVzdCB3aGF0IGl0IHNheXMgb24gdGhlIHRpbiwg bWFudWFsbHkgcnVubmluZyB0aGUgImJpbmFyeSIgdGhyb3VnaCB0aGUKY29tbWFuZCBsaW5lLiAg SXQncyBub3Qgc3VwZXIgdXNlZnVsIHdpdGggR05PTUUsIGJ1dCBJIHRoaW5rIHdlIHNob3VsZApt YWtlIHN1cmUgb3VyIHNlcnZpY2VzIHdvcmsgd2hpY2hldmVyIHdheSB0aGV5IGNvdWxkIGJlIGlu dm9rZWQuCgo+IMKgwqAgV2hhdCBrZWVwcyB5b3UgZnJvbSB3cmFwcGluZyB0aGUgZW52aXJvbm1l bnQKPiA+IHZhcmlhYmxlIGluIEphdmFzY3JpcHQ/Cj4gCj4gSSB3YXMgdW5hYmxlIHRvIGZpbmQg YSB3YXkgdG8gbWFuaXB1bGF0ZSB0aGUgR1NUX1BMVUdJTl9QQVRIIG9yCj4gc3BlY2lmeSB0aGUg Z3N0IHNlYXJjaCBwYXRoIGZyb20gd2l0aGluIGphdmFzY3JpcHQuIFRoZXJlIGlzIAo+IEdzdC5S ZWdpc3RyeSgpLnNjYW5fcGF0aCBidXQgdGhpcyBjcmVhdGVzIGEgbmV3IHJlZ2lzdHJ5IGFuZCBJ IGRvbid0IAo+IHRoaW5rIGlzIHdoYXQgd2Ugd2FudCBoZXJlLiAoYnV0IEkgZG9uJ3Qga25vdyBh bnl0aGluZyBhYm91dAo+IGdzdHJlYW1lciBhbmQgamF2YXNjcmlwdCBzbyBJIGNvdWxkIGJlIHdy b25nIGhlcmUpLgpJbnN0ZWFkIG9mIGNyZWF0aW5nIGEgbmV3IEdzdC5SZWdpc3RyeSDigJMgYXMg cGVyIHRoZSAoKSBoZXJlIOKAkyB5b3UgY291bGQKdXNlIGdzdF9yZWdpc3RyeV9nZXQoKSBvciB3 aGF0ZXZlciB0aGUgYWNjb3JkaW5nIEpTIG1ldGhvZCBpcyB0byBhY2Nlc3MKdGhlIFJlZ2lzdHJ5 IHNpbmdsZXRvbi4KClRoZSBSZWdpc3RyeSBjb25zdHJ1Y3RvciBvdWdodCB0byBiZSBwcm90ZWN0 ZWQsIGJ1dCBpZGsgaG93IEdKUyBoYW5kbGVzCnRoYXQuCgo+IEkgZ3Vlc3MgdGhlIG1vc3Qgc2lt cGxlIHBhdGNoIGZvciB0aGUgdHlwZWxpYnMgd291bGQgYmUgc29tZXRoaW5nCj4gbGlrZQo+IAo+ IAo+IGRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvZ25vbWUuc2NtIGIvZ251L3BhY2thZ2VzL2du b21lLnNjbQo+IGluZGV4IGZhNmM1NjZjNzUuLjI4YzRlNTQwYTYgMTAwNjQ0Cj4gLS0tIGEvZ251 L3BhY2thZ2VzL2dub21lLnNjbQo+ICsrKyBiL2dudS9wYWNrYWdlcy9nbm9tZS5zY20KPiBAQCAt OTQwNCwxMyArOTQwNCwxNSBAQCAoZGVmaW5lLXB1YmxpYyBnbm9tZS1zaGVsbAo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICh3cmFwLXByb2dyYW0gKHN0cmlu Zy1hcHBlbmQgIyRvdXRwdXQgIi9iaW4vIgo+IHByb2cpCj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGAoIkdJX1RZUEVMSUJfUEFUSCIgIjoiIHByZWZp eCAKPiAoLGdpLXR5cGVsaWItcGF0aCkpKSkKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgICcoImdub21lLXNoZWxsIiAiZ25vbWUtZXh0ZW5zaW9ucy1hcHAiKSkKPiAt wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3Vic3RpdHV0ZSogKHN0cmluZy1h cHBlbmQgIyRvdXRwdXQgCj4gIi9zaGFyZS9nbm9tZS1zaGVsbC8iCj4gLcKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoAo+ICJvcmcuZ25vbWUuU2hlbGwuRXh0ZW5zaW9ucyIpCj4gLcKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICgoImltcG9ydHNcXC5wYWNrYWdl XFwuc3RhcnQiIGFsbCkKPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAoc3RyaW5nLWFwcGVuZCAiJyIgZ2ktdHlwZWxpYi1wYXRoIAo+ICInLnNwbGl0KCc6JykuZm9y RWFjaCgiCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgInBhdGggPT4gCj4gaW1wb3J0cy5naS5HSVJlcG9zaXRv cnkuUmVwb3NpdG9yeS4iCj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgInByZXBlbmRfc2VhcmNoX3BhdGgocGF0 aCkpO1xuIgo+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFsbCkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIChmb3ItZWFjaAo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgKGxhbWJkYSAocHJvZykKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAoc3Vic3RpdHV0ZSogKHN0cmluZy1hcHBlbmQgIyRvdXRwdXQgCj4gIi9zaGFyZS9n bm9tZS1zaGVsbC8iIHByb2cpCj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgICgoImltcG9ydHNcXC5wYWNrYWdlXFwuc3RhcnQiIGFsbCkKPiArwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoc3RyaW5nLWFwcGVuZCAiJyIg Z2ktdHlwZWxpYi1wYXRoIAo+ICInLnNwbGl0KCc6JykuZm9yRWFjaCgiCj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgInBhdGggPT4gCj4gaW1wb3J0cy5naS5HSVJlcG9zaXRvcnkuUmVwb3NpdG9yeS4i Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiAicHJlcGVuZF9zZWFyY2hfcGF0aChwYXRoKSk7XG4i Cj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgYWxsKSkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgJygib3JnLmdub21lLlNoZWxsLkV4dGVuc2lvbnMiIAo+ICJvcmcuZ25v bWUuU2hlbGwuU2NyZWVuY2FzdCIpKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIChmb3ItZWFjaAo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgKGxhbWJkYSAocHJvZykKPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5kICMkb3V0cHV0ICIvYmluLyIKPiBw cm9nKQo+IAo+IAo+IGFuZCBkZWFsaW5nIHdpdGggdGhlIGdzdHJlYW1lciBwbHVnaW5zIGluIGFu b3RoZXIgd2F5LgpIbW0sIGNvdWxkIHlvdSBhZGQgLS1nc3QtcGx1Z2luLXBhdGggb24gdGhlIGNv bW1hbmQgbGluZT8KCj4gPiA+IEkndmUgYWxzbyBsZWZ0IGEgY29tbWVudCBmb3IgdGhlIHJlcXVp cmVkIGhvbWUtcGlwZXdpcmUtc2VydmljZS4KPiA+ID4gSW4gZ25vbWUtc2hlbGwgNDUrIHRoZSBp bnZvY2F0aW9uIGhhcyBjaGFuZ2VkIHRvICdnanMgLW0KPiA+ID4gc2VydmljZScuCj4gPiA+IFNo b3VsZCB0aGlzIGFsc28gYmUgYSBjb21tZW50IHNvbWV3aGVyZT8KPiA+IEdub21lLXNoZWxsIDQ1 KyBpcyBjdXJyZW50bHkgaXJyZWxldmFudCwgYnV0IHdlIG1pZ2h0IGhhdmUgdG8gYWRhcHQKPiA+ IHRoaW5ncyBvbmNlIHdlIGdldCB0aGVyZSBvbiBnbm9tZS10ZWFtLsKgIFdlIGRvIG5lZWQgYSBi ZXR0ZXIgZ2pzLQo+ID4gcGF0Y2hpbmcgc3RyYXRlZ3kuCj4gPiAKPiAKPiBJdCB3b3VsZCBiZSBu aWNlIGlmIHNvbWV0aGluZyBsaWtlIHdyYXAtc2NyaXB0IHdvdWxkIHdvcmsuIEJ1dCB0aGUgCj4g cHJvYmxlbSBpcyB0aGF0IHRoZSBkYnVzIHNlcnZpY2VzIHNwZWNpZnkgc29tZWh0aW5nIGxpa2Ug IkV4ZWM9IGdqcyAKPiBzZXJ2aWNlIiByYXRoZXIgdGhhbiBleGVjdXRpbmcgYSBnanMtc2NyaXB0 IGRpcmVjdGx5LiAod2hpY2ggaXMgdGhlCj4gbWFpbiBwdXJwb3NlIG9mIHRoZSBwYXRjaCBmcm9t IG5peG9zKS4gQW5kIGFsc28gZ2pzIG5vdCBiZWluZyBhIHZhbGlkCj4gaW50ZXJwcmV0ZXIgZm9y IHdyYXAtc2NyaXB0IChDaGFuZ2luZyB0aGF0IHdpbGwgcmVidWlsZCBldmVyeXRoaW5nKQpZb3Ug Y2FuIHJlZG8gdGhlIG5lZWRlZCBsb2dpYyBsb2NhbGx5IGFuZCBhZGQgYSAiWFhYOiBVc2Ugd3Jh cC1zY3JpcHQKb25jZSBpdCBjYW4gaGFuZGxlIGdqcyIgZm9yIGV4YW1wbGUuICBUaGF0J3Mgbm8g aGFyZCBibG9ja2VyLCBidXQgaXQncwpub3QgdGhlIG5pY2VzdCBvcHRpb24gZWl0aGVyLCBJIGFk bWl0LiAgTGV0J3MgdHJ5IG91ciBvdGhlciBvcHRpb25zCmZpcnN0LgoKPiAKQ2hlZXJzCg== From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 08:38:22 2024 Received: (at 70282) by debbugs.gnu.org; 21 Apr 2024 12:38:22 +0000 Received: from localhost ([127.0.0.1]:42750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryWSb-0004ed-MH for submit@debbugs.gnu.org; Sun, 21 Apr 2024 08:38:22 -0400 Received: from mout01.posteo.de ([185.67.36.65]:58683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryWSW-0004d4-1w for 70282@debbugs.gnu.org; Sun, 21 Apr 2024 08:38:20 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CB96C240027 for <70282@debbugs.gnu.org>; Sun, 21 Apr 2024 14:37:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1713703073; bh=JoRynbMAni2qZIlGsj64qbZqKLoVsLBasNuLFLAkqAM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=HrIpXXPeWAdwimudMg6gD82a1ZYIFjJgo8NPoMAc5zizeqXxdo9gU1Ml42Dg1vdAM 5lCdV6lbTA99TJXSQdFHkhHTDJeZN7T4y+blqxaOyLXsJeiT0lERHVq/DxnkYKCENm F3g4UWzRHfYQm1SIkdsn9YmDPcenn+N92ugMczzvIffft/89TPokK1rsjlSbar5N// 4fK2eejUgVhlaqnODKUo7TlMaFnZQf7wFlxUwI7+Kk5U+HT94spXQ8AdKNPnzAbwgQ H+Lv/ntcmuLn7DamW1kWgspXBAFRaOgKWP/9xDn0g4EFlV4YIURTCmkZDp8DopIh5Z 22JTcwJCaUThA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VMnwJ5pXvz6tmv; Sun, 21 Apr 2024 14:37:52 +0200 (CEST) Message-ID: <8e84c417-825a-416a-8ca0-ed5aebda489e@posteo.net> Date: Sun, 21 Apr 2024 12:37:46 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH v2] gnu: gnome-shell: Wrap screencast service. To: Liliana Marie Prikler , 70282@debbugs.gnu.org References: <0497984af8f383af8e8b981d78dc9baf23869e30.camel@gmail.com> <7a635b027f59d348312098650d1606f2e658ffab.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <7a635b027f59d348312098650d1606f2e658ffab.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 20.04.24 12:46, Liliana Marie Prikler wrote: > Am Samstag, dem 20.04.2024 um 10:11 +0000 schrieb Dariqq: >> >> >> On 19.04.24 20:51, Liliana Marie Prikler wrote: >>> Am Freitag, dem 12.04.2024 um 17:26 +0000 schrieb Dariqq: >>>> The screencast service can now find typelibs and gstreamer >>>> plugins. >>>> >>>> * gnu/packages/linux.scm (gnome-shell) >>>> [inputs]: Add gst-plugins-good and pipewire. >>>> [#:phases]<'wrap-programs>: Create a wrapper for screencast >>>> service >>>> and use it. >>>> >>>> Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 >>>> --- >>>> >>>> Hi, >>>> >>>> Here is v2 of the patch. The wrapper is now created manually as I >>>> was unable to find a way to manipulate the gstreamer plugin load >>>> path from within javascript. Importantly this leaves the original >>>> javascript file untouched and therefore circumvents the argv[0] >>>> problem in v1. >>>> All the required gstreamer plugins (pipewire and gst-plugins- >>>> good) are now inputs and are in the wrapper via >>>> GST_PLUGIN_SYSTEM_PATH. >>> I'm not sure this fix is sounds.  It looks like it misses manual >>> invocation from the command line, does it not?  (Well, it's gnome- >>> shell, so if you have to invoke it from the command line, things >>> are broken, but still…) >> >> If only the typelib path is set the dbus service now longer greets >> you with an error but still fails to start without the gstreamer >> plugins. That's why in v1 I was propagating pipewire through >> gnome-essential-extras. >> >> I am not sure what you mean by manual invocation. The screencast >> service should get started via dbus. Nothing manual should be >> required (other than enabling the pipewire home service). > Just what it says on the tin, manually running the "binary" through the > command line. It's not super useful with GNOME, but I think we should > make sure our services work whichever way they could be invoked. > >>    What keeps you from wrapping the environment >>> variable in Javascript? >> >> I was unable to find a way to manipulate the GST_PLUGIN_PATH or >> specify the gst search path from within javascript. There is >> Gst.Registry().scan_path but this creates a new registry and I don't >> think is what we want here. (but I don't know anything about >> gstreamer and javascript so I could be wrong here). > Instead of creating a new Gst.Registry – as per the () here – you could > use gst_registry_get() or whatever the according JS method is to access > the Registry singleton. > > The Registry constructor ought to be protected, but idk how GJS handles > that. > I've tried adding Gst.Registry.get().scan_path() after the GI_TYPELIB expansion but I am not sure why it does not work. Stracing the invocation shows that the pipewire gstreamer plugin is accessed at the beginning but it is still not available somehow. Probably because of my lack of knowledge about gstreamer. >> I guess the most simple patch for the typelibs would be something >> like >> >> >> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm >> index fa6c566c75..28c4e540a6 100644 >> --- a/gnu/packages/gnome.scm >> +++ b/gnu/packages/gnome.scm >> @@ -9404,13 +9404,15 @@ (define-public gnome-shell >>                        (wrap-program (string-append #$output "/bin/" >> prog) >>                          `("GI_TYPELIB_PATH" ":" prefix >> (,gi-typelib-path)))) >>                      '("gnome-shell" "gnome-extensions-app")) >> -                  (substitute* (string-append #$output >> "/share/gnome-shell/" >> - >> "org.gnome.Shell.Extensions") >> -                    (("imports\\.package\\.start" all) >> -                     (string-append "'" gi-typelib-path >> "'.split(':').forEach(" >> -                                    "path => >> imports.gi.GIRepository.Repository." >> -                                    "prepend_search_path(path));\n" >> -                                    all))) >> +                  (for-each >> +                   (lambda (prog) >> +                     (substitute* (string-append #$output >> "/share/gnome-shell/" prog) >> +                       (("imports\\.package\\.start" all) >> +                        (string-append "'" gi-typelib-path >> "'.split(':').forEach(" >> +                                       "path => >> imports.gi.GIRepository.Repository." >> + >> "prepend_search_path(path));\n" >> +                                       all)))) >> +                   '("org.gnome.Shell.Extensions" >> "org.gnome.Shell.Screencast")) >>                     (for-each >>                      (lambda (prog) >>                        (wrap-program (string-append #$output "/bin/" >> prog) >> >> >> and dealing with the gstreamer plugins in another way. > Hmm, could you add --gst-plugin-path on the command line? > >>>> I've also left a comment for the required home-pipewire-service. >>>> In gnome-shell 45+ the invocation has changed to 'gjs -m >>>> service'. >>>> Should this also be a comment somewhere? >>> Gnome-shell 45+ is currently irrelevant, but we might have to adapt >>> things once we get there on gnome-team.  We do need a better gjs- >>> patching strategy. >>> >> >> It would be nice if something like wrap-script would work. But the >> problem is that the dbus services specify somehting like "Exec= gjs >> service" rather than executing a gjs-script directly. (which is the >> main purpose of the patch from nixos). And also gjs not being a valid >> interpreter for wrap-script (Changing that will rebuild everything) > You can redo the needed logic locally and add a "XXX: Use wrap-script > once it can handle gjs" for example. That's no hard blocker, but it's > not the nicest option either, I admit. Let's try our other options > first. > I've just found GLib.setenv() to set environment variables for the process directly from within gjs. The GLib typelib comes from the gobject-introspection package so this should be available. From my limited testing it seems to work (at least for the screencast service). What do you think? > Cheers Have a nice day. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 08:43:42 2024 Received: (at 70282) by debbugs.gnu.org; 21 Apr 2024 12:43:43 +0000 Received: from localhost ([127.0.0.1]:42774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryWXl-0005Fw-CI for submit@debbugs.gnu.org; Sun, 21 Apr 2024 08:43:42 -0400 Received: from mail-lf1-x144.google.com ([2a00:1450:4864:20::144]:59794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryWXh-0005ER-Ph for 70282@debbugs.gnu.org; Sun, 21 Apr 2024 08:43:39 -0400 Received: by mail-lf1-x144.google.com with SMTP id 2adb3069b0e04-51b2f105829so164872e87.3 for <70282@debbugs.gnu.org>; Sun, 21 Apr 2024 05:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713703396; x=1714308196; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ewxLzMxqyzNIwf62E0z5zKDVBO7bRB66bdVhexO+Ses=; b=W5vxQZ/hA7Csu1BhIbR5NCTxQxsPn0NJTVAy2r4W8QDe6WnMxVqqImxMRNt5EPM91c 2ZXQnqiQEYklMMfxwfqmb99XfRs2zM5n6rq4LO3xfCGa5u7g56aY6y790JXSSGtBQGze Ki1XK81Xc4Qo+lSU6swMUhnUMhRz6bTSQIwWVnT8sg/TVyIL6c9QEzDshGwLbZQ/jeRV yggINx6HfNWFxEvH7vcJdD9+DSeQwkQH0B5V12oWJngq4hK6eLnbpjxRJOb3HWcIc8se dttI9l2SBluvPMbKJKsNUhQ546SyXdFVV/b586EIJeYwuLqx4NgN/oK1OnMVRko/hBwu emZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713703396; x=1714308196; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ewxLzMxqyzNIwf62E0z5zKDVBO7bRB66bdVhexO+Ses=; b=YXC4NfguzQBx+/cUVyXMQ9NlTJgqAXLL0tYUM3e2qPMvMZZnDJeLsMvt+m9gWed/Lh IzWif5+YXWA/wTIl59ifxvlMucaSYz4V2lzKPbn76GeUghe7c5vHSfZFOoGuLzh0Um7z rcv9LRPXlVMEtmS0g5xwxNeZwJ+fDWRYHdlhl8j5wYXgGbQjaHW10bN7fMFlOg6V8wH/ Hf/KWgy/eKflfxgtifh6mzBVxoQ/DtKjQhtfU3QTFsVooihyyd8FV0p7z7h7ykBV9tVf cuhNPW6/pQ5oUYRwTUfX3iuejvQleuYnkqTo9BWp9FdpfFsuUGQt0Oxn+scfGlDK4mt8 VebQ== X-Forwarded-Encrypted: i=1; AJvYcCXdMy7tC6nHhHymdn7ACYdJtFaO8pYYChuB0qTkcQEvpo26XjilJpcjPzdnH9pkehus3g+ubK3ycT9LfzD9Ju4MJ84gIh4= X-Gm-Message-State: AOJu0YxEnlbeQhB1ZFXQ8UsPfb8dFFgRqUILuIfSKNJDCmpDxxdzVOeq tt+zEsK+HreQxl9VgIOs0KwKEqO2K0+4ges1p3FnIotmnj5UH0QO X-Google-Smtp-Source: AGHT+IGdbucd2OZWsCraFIePWBBLl3eGyo2j4SSjbAQrfPu0OwbCHr1x7XXAQVHCLiRUr5uSnZ7Ndg== X-Received: by 2002:a05:6512:7a:b0:516:d43f:898 with SMTP id i26-20020a056512007a00b00516d43f0898mr5531160lfo.21.1713703395696; Sun, 21 Apr 2024 05:43:15 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id f15-20020aa7d84f000000b00571db231915sm2441426eds.78.2024.04.21.05.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Apr 2024 05:43:15 -0700 (PDT) Message-ID: Subject: Re: [bug#70282] [PATCH v2] gnu: gnome-shell: Wrap screencast service. From: Liliana Marie Prikler To: Dariqq , 70282@debbugs.gnu.org Date: Sun, 21 Apr 2024 14:43:13 +0200 In-Reply-To: <8e84c417-825a-416a-8ca0-ed5aebda489e@posteo.net> References: <0497984af8f383af8e8b981d78dc9baf23869e30.camel@gmail.com> <7a635b027f59d348312098650d1606f2e658ffab.camel@gmail.com> <8e84c417-825a-416a-8ca0-ed5aebda489e@posteo.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 21.04.2024 um 12:37 +0000 schrieb Dariqq: > >=20 > [...] > I've just found GLib.setenv() to set environment variables for the=20 > process directly from within gjs. The GLib typelib comes from the=20 > gobject-introspection package so this should be available. >=20 > From my limited testing it seems to work (at least for the screencast > service). What do you think? Yes, GLib.setenv is the function I had in mind to twiddle the environment. If you find the right location to do so at the start of the program, please send a patch that does that. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 21 13:10:03 2024 Received: (at 70282) by debbugs.gnu.org; 21 Apr 2024 17:10:03 +0000 Received: from localhost ([127.0.0.1]:43899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryahV-0005np-4m for submit@debbugs.gnu.org; Sun, 21 Apr 2024 13:10:03 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryahP-0005mB-BK for 70282@debbugs.gnu.org; Sun, 21 Apr 2024 13:09:59 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 34014240103 for <70282@debbugs.gnu.org>; Sun, 21 Apr 2024 19:09:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1713719373; bh=nGFU/OKs9Kiz8bgO/nNqGAxAEagGoIv01jW4PmV5Pko=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=noP3IPhwGYN4HiWNYeSkyF6CqRswV1imfr4bR9R8d0YkUK9teiXfoe00zgrgQsFko hPcPc4OrdL4yeYMvUikubTnJB/5PE9FE4qZat4joHusfgxrBPVPtPdljQK5FfRLmzN aXKrSpcuBudtil1/SXxwXdHFcLxNnRzv0/Le9CSZ5h4Z21tSCAaLMF23fLIqNixiZj 5nvCYnjmDBbADRp2c2dLTE1x3m368bMqE41JJ8CilLcdVAPX+F+NXF7mmwJ5VN/kwL Ys3I2PXwHhmZhOs5GJyu0JP8GQUaHenlClfYSPdj7kkUcEa4VUmBaqJ4/KMOcU00Qn SYA89k5vVOrZA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VMvxm5Q8Kz6tm4; Sun, 21 Apr 2024 19:09:32 +0200 (CEST) From: Dariqq To: 70282@debbugs.gnu.org Subject: [PATCH v3] gnu: gnome-shell: Wrap screencast service. Date: Sun, 21 Apr 2024 17:02:18 +0000 Message-ID: <79b8bcd870f61cc79518c4ff8bf560b88661e0b3.1713718938.git.dariqq@posteo.net> MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , Maxim Cournoyer , Vivien Kraus Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: Dariqq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Adjust screencast such that GI_TYPELIB_PATH and GST_PLUGIN_SYSTEM_PATH are set before starting. Add all required gstreamer plugins to inputs. To be able to use it a running pipewire service is needed. * gnu/packages/gnome.scm (gnome-shell): [inputs]: Add gst-plugins-good and pipewire. [#:phases]<'wrap-programs>: Wrap org.gnome.Shell.Screencast. Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 --- Here is v3 which only uses js to set the environment variables. Slight difference to before is that GST_PLUGIN_SYSTEM_PATH gets set to specific paths rather than prepending. I've also tested if GI_TYPELIB_PATH can be set with GLib.setenv but that didn't seem to work, so I 've used something similiar as in other places. gnu/packages/gnome.scm | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 489f23865b..b3c3fb72ad 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -9392,6 +9392,7 @@ (define-public gnome-shell (add-after 'install 'wrap-programs (lambda* (#:key inputs #:allow-other-keys) (let ((gi-typelib-path (getenv "GI_TYPELIB_PATH")) + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) (python-path (string-join (filter (lambda (item) @@ -9411,6 +9412,18 @@ (define-public gnome-shell "path => imports.gi.GIRepository.Repository." "prepend_search_path(path));\n" all))) + ;; Screencast requires a pipewire service running + ;; (i.e. as provided by home-pipewire-service-type) + (substitute* (string-append #$output "/share/gnome-shell/" + "org.gnome.Shell.Screencast") + (("imports\\.package\\.start" all) + (string-append "'" gi-typelib-path "'.split(':').forEach(" + "path => imports.gi.GIRepository.Repository." + "prepend_search_path(path));\n" + "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH'," + "'" gst-plugin-path "'" + ", true);\n" + all))) (for-each (lambda (prog) (wrap-program (string-append #$output "/bin/" prog) @@ -9476,6 +9489,7 @@ (define-public gnome-shell gnome-settings-daemon graphene gst-plugins-base + gst-plugins-good ibus libcanberra libcroco @@ -9486,6 +9500,7 @@ (define-public gnome-shell mesa-headers mutter network-manager-applet + pipewire polkit pulseaudio python-pygobject base-commit: a1d711c92e119f6b5b8e99a620cdba92a4ca3bfb -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 08:58:23 2024 Received: (at 70282) by debbugs.gnu.org; 8 May 2024 12:58:23 +0000 Received: from localhost ([127.0.0.1]:48789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4gsJ-0003GU-62 for submit@debbugs.gnu.org; Wed, 08 May 2024 08:58:23 -0400 Received: from mout01.posteo.de ([185.67.36.65]:45591) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4gsF-0003GO-Ts for 70282@debbugs.gnu.org; Wed, 08 May 2024 08:58:21 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 07C81240027 for <70282@debbugs.gnu.org>; Wed, 8 May 2024 14:57:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715173068; bh=HvaC5ND0z7lSdudB7IsXyj6yJqSYH4pYmiTsxUlSRlE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=Lj1PO3w5mTmNG1ju7qe+2rfTj+PycEQc10nH47v1qwgTCBYEwNqmBnDdIwFwGzRY1 tN7Pbp35x9z9VQZKnwIK9tbHEXIfG0xJwP3vtB536mo+hmsxOkbV1zrQLyVQnqA9xx zK+XuEMQhIc6fNLSSulEsntExnd4qQl7YNyRlH8EEIdnjhFuN4u48P/wiEePUK5lI2 hRLKxUvcYzE3OHIzydP1CDjYQ/c1YMz/XLxwl+J4gc3eG8/25MUZ71cOOKvY/L86sD HsfH+7knOlRIw94lF1lV1RVKyR/gkh984Cv4T4ImQAmHdRcJ9km36SNEB1CbPPrAbz Ko4R4KnBSOTkw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VZFYQ65Lbz6tmv; Wed, 8 May 2024 14:57:46 +0200 (CEST) Message-ID: Date: Wed, 8 May 2024 12:57:43 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH v3] gnu: gnome-shell: Wrap screencast service. To: Liliana Marie Prikler , 70282@debbugs.gnu.org References: <0497984af8f383af8e8b981d78dc9baf23869e30.camel@gmail.com> <7a635b027f59d348312098650d1606f2e658ffab.camel@gmail.com> <8e84c417-825a-416a-8ca0-ed5aebda489e@posteo.net> Content-Language: en-US From: Dariqq In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Liliana, Were you able to take a look at v3 yet? I've sent it a couple of weeks ago utilizing Glib.setenv to set the gst plugin path. Have a nice day. On 21.04.24 14:43, Liliana Marie Prikler wrote: > Am Sonntag, dem 21.04.2024 um 12:37 +0000 schrieb Dariqq: >>> >> [...] >> I've just found GLib.setenv() to set environment variables for the >> process directly from within gjs. The GLib typelib comes from the >> gobject-introspection package so this should be available. >> >> From my limited testing it seems to work (at least for the screencast >> service). What do you think? > Yes, GLib.setenv is the function I had in mind to twiddle the > environment. If you find the right location to do so at the start of > the program, please send a patch that does that. > > Cheers From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 13:25:06 2024 Received: (at 70282) by debbugs.gnu.org; 8 May 2024 17:25:06 +0000 Received: from localhost ([127.0.0.1]:49907 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4l2P-0006G6-Rp for submit@debbugs.gnu.org; Wed, 08 May 2024 13:25:06 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:59416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4l2K-0006Ff-Q0 for 70282@debbugs.gnu.org; Wed, 08 May 2024 13:25:04 -0400 Received: by mail-ej1-x643.google.com with SMTP id a640c23a62f3a-a5a1192c664so36978566b.2 for <70282@debbugs.gnu.org>; Wed, 08 May 2024 10:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715189069; x=1715793869; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=ov2Rzp9Y456LmEQ9Y9NwDsSL97T3JJh1Qo1AQ1o/V+0=; b=AIg6z9aQAAD/CAuNrXWT1RVbLDasUTDPFuVUqFZHf/JNuH2V/9EWdTBeMB41HyiaZP PreSisO7jTdMjCttK6fALQ0pXnUvVcWQhDSe83fNUF80/GjBH9KnnxDQCmlbdb3re+wH zQXZCb+Hf4rJmNvsYp3lbmt0RCCVHgYij9jY2PMdGE1qchNXtUKXZLBoF2uo26dOUgYN wI8sNr6BxW12/NvSwMbD5BwWXhnqJm5NNpHdpivSDOQ3FyKyRb/FrTgEZL+dxtM6n0Mv Fr57Liv1vKIY5oObAVj5QbNJA49Xs9nUhR5HmnV77kxcPaRF21eEKtbIcoWhrVTGY0mA Ad9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715189069; x=1715793869; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ov2Rzp9Y456LmEQ9Y9NwDsSL97T3JJh1Qo1AQ1o/V+0=; b=h8oRoSCxe261UpReL8hzuWq2odxOw4QKI2GfmnjRvZZPvLu1E3YkHnXtkPZXgVs02b FiVQDjJZh1Bve3sKhjGHm8X7W3nu8KUsw653iw7wgNpG69iGGUSwD0DAx4eFqZE9aL3P UJEMEPEF1T2dBCV3CAb9obsdqK89vbEE7pI+UJA9Q++L+HjdbjG/EuU88oWW/wiJfOK8 Zml8zwTVi717paw1LXjhwwU9BT4+IOJ5uc2nNolDQNQonemOcfSzatmDcia7zRp75nIO 5TqGBIawrpbafD9g36K41LEaEEPpaMDqL/4wXREJVkEruhAZMnEC2CQvHUCuFH1WwBhc OMJA== X-Forwarded-Encrypted: i=1; AJvYcCW0T2Tkv+dTMjPuvPOTTQisLuqreRR+kt+v/eaCx7Ea8j5clGMpkbhcGWgq22A/Dnh1AlaFFIE/JrKy9+e9SoBFyFeM6EM= X-Gm-Message-State: AOJu0YwKWhoqWHPk7dBv9YILJlVw79Epv0v8OOVCoSpUzsONBc0JkWCF K52yD4nfmpC5GOqPYkAviWUviNM7n2LscFUxaT3IqVecL6V2xYtf9f4lx/ZI X-Google-Smtp-Source: AGHT+IGcBAs/EOOcQFSb83prdqO5jK4KRSsHfThps7OzPKk+pRjY8GK5PuO8wqJHj7XWVeytasm5EQ== X-Received: by 2002:a50:ab14:0:b0:572:7d5b:9923 with SMTP id 4fb4d7f45d1cf-5731d9d920amr3088059a12.22.1715189068328; Wed, 08 May 2024 10:24:28 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id r1-20020a50d681000000b0057297f5935dsm8110657edi.57.2024.05.08.10.24.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 10:24:27 -0700 (PDT) Message-ID: <387b26046838cb9968515ded3eeedbf86f1b9558.camel@gmail.com> Subject: Re: [bug#70282] [PATCH v3] gnu: gnome-shell: Wrap screencast service. From: Liliana Marie Prikler To: Dariqq , 70282@debbugs.gnu.org Date: Wed, 08 May 2024 19:24:26 +0200 In-Reply-To: <79b8bcd870f61cc79518c4ff8bf560b88661e0b3.1713718938.git.dariqq@posteo.net> References: <79b8bcd870f61cc79518c4ff8bf560b88661e0b3.1713718938.git.dariqq@posteo.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: Vivien Kraus , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gU29ubnRhZywgZGVtIDIxLjA0LjIwMjQgdW0gMTc6MDIgKzAwMDAgc2NocmllYiBEYXJpcXE6 Cj4gQWRqdXN0IHNjcmVlbmNhc3Qgc3VjaCB0aGF0IEdJX1RZUEVMSUJfUEFUSCBhbmQKPiBHU1Rf UExVR0lOX1NZU1RFTV9QQVRIIGFyZSBzZXQKPiBiZWZvcmUgc3RhcnRpbmcuCj4gCj4gQWRkIGFs bCByZXF1aXJlZCBnc3RyZWFtZXIgcGx1Z2lucyB0byBpbnB1dHMuCj4gCj4gVG8gYmUgYWJsZSB0 byB1c2UgaXQgYSBydW5uaW5nIHBpcGV3aXJlIHNlcnZpY2UgaXMgbmVlZGVkLgo+IAo+ICogZ251 L3BhY2thZ2VzL2dub21lLnNjbSAoZ25vbWUtc2hlbGwpOgo+IFtpbnB1dHNdOiBBZGQgZ3N0LXBs dWdpbnMtZ29vZCBhbmQgcGlwZXdpcmUuCj4gWyM6cGhhc2VzXTwnd3JhcC1wcm9ncmFtcz46IFdy YXAgb3JnLmdub21lLlNoZWxsLlNjcmVlbmNhc3QuCj4gCj4gQ2hhbmdlLUlkOiBJMmMzMWJmMWJk OTJlMjgxYjg2YzU3YjA2OTg4YzZhMzc5M2E1OGQ0MAo+IC0tLQo+IAo+IEhlcmUgaXMgdjMgd2hp Y2ggb25seSB1c2VzIGpzIHRvIHNldCB0aGUgZW52aXJvbm1lbnQgdmFyaWFibGVzLgo+IFNsaWdo dCBkaWZmZXJlbmNlIHRvIGJlZm9yZSBpcyB0aGF0IEdTVF9QTFVHSU5fU1lTVEVNX1BBVEggZ2V0 cyBzZXQKPiB0byBzcGVjaWZpYyBwYXRocyByYXRoZXIgdGhhbiBwcmVwZW5kaW5nLgo+IEkndmUg YWxzbyB0ZXN0ZWQgaWYgR0lfVFlQRUxJQl9QQVRIIGNhbiBiZSBzZXQgd2l0aCBHTGliLnNldGVu diBidXQKPiB0aGF0IGRpZG4ndCBzZWVtIHRvIHdvcmssCj4gc28gSSAndmUgdXNlZCBzb21ldGhp bmcgc2ltaWxpYXIgYXMgaW4gb3RoZXIgcGxhY2VzLgo+IAo+IMKgZ251L3BhY2thZ2VzL2dub21l LnNjbSB8IDE1ICsrKysrKysrKysrKysrKwo+IMKgMSBmaWxlIGNoYW5nZWQsIDE1IGluc2VydGlv bnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2dub21lLnNjbSBiL2dudS9wYWNr YWdlcy9nbm9tZS5zY20KPiBpbmRleCA0ODlmMjM4NjViLi5iM2MzZmI3MmFkIDEwMDY0NAo+IC0t LSBhL2dudS9wYWNrYWdlcy9nbm9tZS5zY20KPiArKysgYi9nbnUvcGFja2FnZXMvZ25vbWUuc2Nt Cj4gQEAgLTkzOTIsNiArOTM5Miw3IEBAIChkZWZpbmUtcHVibGljIGdub21lLXNoZWxsCj4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIChhZGQtYWZ0ZXIgJ2luc3RhbGwgJ3dyYXAtcHJvZ3JhbXMK PiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChsYW1iZGEqICgjOmtleSBpbnB1dHMgIzph bGxvdy1vdGhlci1rZXlzKQo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChsZXQg KChnaS10eXBlbGliLXBhdGjCoCAoZ2V0ZW52ICJHSV9UWVBFTElCX1BBVEgiKSkKPiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChnc3QtcGx1Z2luLXBhdGjCoCAo Z2V0ZW52Cj4gIkdTVF9QTFVHSU5fU1lTVEVNX1BBVEgiKSkKPiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAocHl0aG9uLXBhdGgKPiDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChzdHJpbmctam9pbgo+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoZmlsdGVyIChsYW1iZGEgKGl0 ZW0pCj4gQEAgLTk0MTEsNiArOTQxMiwxOCBAQCAoZGVmaW5lLXB1YmxpYyBnbm9tZS1zaGVsbAo+ IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAicGF0aCA9Pgo+IGltcG9ydHMuZ2kuR0lSZXBvc2l0b3J5LlJlcG9z aXRvcnkuIgo+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAicHJlcGVuZF9zZWFyY2hfcGF0aChwYXRoKSk7XG4i Cj4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIGFsbCkpKQo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIDs7IFNjcmVlbmNhc3QgcmVxdWlyZXMgYSBwaXBld2lyZSBzZXJ2aWNlIHJ1bm5pbmcK PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCA7OyAoaS5lLiBhcyBwcm92aWRl ZCBieSBob21lLXBpcGV3aXJlLXNlcnZpY2UtCj4gdHlwZSkKPiArwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAoc3Vic3RpdHV0ZSogKHN0cmluZy1hcHBlbmQgIyRvdXRwdXQKPiAi L3NoYXJlL2dub21lLXNoZWxsLyIKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg Cj4gIm9yZy5nbm9tZS5TaGVsbC5TY3JlZW5jYXN0IikKPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgKCgiaW1wb3J0c1xcLnBhY2thZ2VcXC5zdGFydCIgYWxsKQo+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChzdHJpbmctYXBwZW5kICIn IiBnaS10eXBlbGliLXBhdGgKPiAiJy5zcGxpdCgnOicpLmZvckVhY2goIgo+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgICJwYXRoID0+Cj4gaW1wb3J0cy5naS5HSVJlcG9zaXRvcnkuUmVwb3NpdG9yeS4iCj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgInByZXBlbmRfc2VhcmNoX3BhdGgocGF0aCkpO1xuIgo+ICvCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgCj4gImltcG9ydHMuZ2kuR0xpYi5zZXRlbnYoJ0dTVF9QTFVHSU5fU1lTVEVNX1BBVEgnLCIK PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAiJyIgZ3N0LXBsdWdpbi1wYXRoICInIgo+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ICIsIHRydWUpO1xuIgo+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGFsbCkpKQpTb3JyeSBmb3IgdGhlIGxhdGUg cmVwbHkuICBZb3Ugb3VnaHQgdG8gdXNlIEdMaWIuZ2V0ZW52IHRvIGdldCB0aGUKY3VycmVudCB2 YWx1ZSwgc28gdGhhdCB5b3UgY2FuIGFkZCB0aGUgbmVlZGVkIHBhdGhzIGFzIGEgcHJlZml4IChv cgpzdWZmaXg/IEknZCBwZXJzb25hbGx5IHByZWZlciBsZXR0aW5nIHRoZSB1c2VyIHByZWZpeCB0 aGVtKS4KCkNoZWVycyAK From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 14:41:43 2024 Received: (at 70282) by debbugs.gnu.org; 8 May 2024 18:41:43 +0000 Received: from localhost ([127.0.0.1]:50246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4mEZ-0007Gz-D9 for submit@debbugs.gnu.org; Wed, 08 May 2024 14:41:43 -0400 Received: from mout01.posteo.de ([185.67.36.65]:33029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4mEU-0007Gr-95 for 70282@debbugs.gnu.org; Wed, 08 May 2024 14:41:42 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 84971240027 for <70282@debbugs.gnu.org>; Wed, 8 May 2024 20:41:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715193666; bh=2iJ2G2nVrdvOlzpCo0kk9l4gne/RPMC6Zf1s5Xp2Rec=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=TeO9LcMmtM6aOgoeEJOxeGHCpDkxS+NuCozEqLZnx1jsEyfCfbxXnPOm3xfCLmc82 lXK9/JOT3gwYz71tPNgUf2JlRokf61CvvvLF2H5OOKJ8bV4qDN/upCMn95s+2f+Map EOYM+eRIFC8jjnjmC4osnJioS26NMJUhFaFYTVVjen4QNthtacr3DapcMxxvasB/8l QY0JDwik8pq6R9JX2vEGG1qssHUrxNcv2M5yj02yTa1oEsGDEgBBxUpyijgXtiRiqq reIY9gycrRJ1ijfbZrodohAwtjE/t2FEeTMXbjV7h64pPGDPt5sdr3aWM8DEz1px0O TIUSCNtpO5ggw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VZP9Y6M5Vz6tvZ; Wed, 8 May 2024 20:41:05 +0200 (CEST) From: Dariqq To: 70282@debbugs.gnu.org Subject: [PATCH v4] gnu: gnome-shell: Wrap screencast service. Date: Wed, 8 May 2024 18:33:30 +0000 Message-ID: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> MIME-Version: 1.0 X-Debbugs-Cc: Liliana Marie Prikler , Maxim Cournoyer , Vivien Kraus Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: Dariqq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Adjust screencast such that GI_TYPELIB_PATH and GST_PLUGIN_SYSTEM_PATH are set before starting. Add all required gstreamer plugins to inputs. To be able to use it a running pipewire service is needed. * gnu/packages/gnome.scm (gnome-shell): [inputs]: Add gst-plugins-good and pipewire. [#:phases]<'wrap-programs>: Wrap org.gnome.Shell.Screencast. Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 --- Here is v4 which appends the gstreamer plugins to GST_PLUGIN_SYSTEM_PATH, handling the case when getenv returns null. I think the difference between appendending or prepending in this case is not too important as the user GST_PLUGIN_PATH should take precedent. The more important thing is that the plugins are in any plugin path at all. gnu/packages/gnome.scm | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index 92e35e3c5a..4bbff2a89b 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -9408,6 +9408,7 @@ (define-public gnome-shell (add-after 'install 'wrap-programs (lambda* (#:key inputs #:allow-other-keys) (let ((gi-typelib-path (getenv "GI_TYPELIB_PATH")) + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) (python-path (string-join (filter (lambda (item) @@ -9427,6 +9428,19 @@ (define-public gnome-shell "path => imports.gi.GIRepository.Repository." "prepend_search_path(path));\n" all))) + ;; Screencast requires a pipewire service running + ;; (i.e. as provided by home-pipewire-service-type) + (substitute* (string-append #$output "/share/gnome-shell/" + "org.gnome.Shell.Screencast") + (("imports\\.package\\.start" all) + (string-append "'" gi-typelib-path "'.split(':').forEach(" + "path => imports.gi.GIRepository.Repository." + "prepend_search_path(path));\n" + "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH'," + "[imports.gi.GLib.getenv('GST_PLUGIN_SYSTEM_PATH')," + "'" gst-plugin-path "'].filter(v => v).join(':')," + "true);\n" + all))) (for-each (lambda (prog) (wrap-program (string-append #$output "/bin/" prog) @@ -9492,6 +9506,7 @@ (define-public gnome-shell gnome-settings-daemon graphene gst-plugins-base + gst-plugins-good ibus libcanberra libcroco @@ -9502,6 +9517,7 @@ (define-public gnome-shell mesa-headers mutter network-manager-applet + pipewire polkit pulseaudio python-pygobject base-commit: 7b7f299bb493e485c5534b8c554e51d4f3a8c026 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 15:52:09 2024 Received: (at 70282) by debbugs.gnu.org; 8 May 2024 19:52:09 +0000 Received: from localhost ([127.0.0.1]:50565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4nKi-0002Q3-Kt for submit@debbugs.gnu.org; Wed, 08 May 2024 15:52:09 -0400 Received: from mail-qv1-xf2a.google.com ([2607:f8b0:4864:20::f2a]:57685) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4nKZ-0002PY-Gg for 70282@debbugs.gnu.org; Wed, 08 May 2024 15:52:07 -0400 Received: by mail-qv1-xf2a.google.com with SMTP id 6a1803df08f44-69b5de48126so837666d6.3 for <70282@debbugs.gnu.org>; Wed, 08 May 2024 12:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715197888; x=1715802688; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/0352/4BawxYl29mhY4BMG2oQiSjoQwKYJxBSUyH5Bc=; b=Pjay7jpEQSQn+9CT30TKdYRacr9At4kSS0V2vjFc8ubwKHRbQNbRT/wonLpqLolxer GUfSBO52dw9Om0COjfeiKL9V8a+sN6t5T0UqlJpF8LT0/x7z7iDIOHQG1hVrkuIrJdfJ FgWr+rcNXZtHu28Z00S2OfujxCOB2IeOBohV5cAqhA8flnsR3xkdFPwhZswlBKGMZvG/ uaBVGwg21BRCknRp3XaNeo1S4qOIaKJlDHfH3hvQex1ak04bmgP3aXotbUhlnqqjTSf2 v5DXbv7kt2MKnCVUEfFDofmpKobJp+QzuDEbtAVy48CcoWBCT5qpaFKhrR6uokGnoIOs gAcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715197888; x=1715802688; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/0352/4BawxYl29mhY4BMG2oQiSjoQwKYJxBSUyH5Bc=; b=jZgwBaajSGbhzaHSRUUtsZhdDxsq7JOJqzaiDufVBZTEKTLGjnTOX5z82cJmYOhM31 qd/eq4gHwLOyXOyHi3lATkDL5A+XSQmbQBPQ9/vry83Dfy8+kIzaQHtsSWCTyIbljqkH WgsGcFFHxHQJdj7rmkCJ6j1Hs5068ftS6fnNKeTaCyWMamlxgD4j1w1BoA5FWrRX6gb/ BuZbkUYM2fIcPIOAvD/vwgm9abbsua+l8swt55/aLNrYgVaidNqy+6Mr423eZiSwxMfU 9etMB5sqz1nlNLXC4B66A/tM1czDHFLtPe5RYoZZ5c7LQLPnJJ1tAt0MLFUCmpQ4QqDX tb+g== X-Gm-Message-State: AOJu0Yy0wqjsipeacp1tjuKwMctr6gnkxDHlFz5JJlhVMcvW88YtzDwV fXgCTEmYyO2GLQpcBAU9qP1nZmrempUsL8AbCm3bqBFuOiJ/W1CE X-Google-Smtp-Source: AGHT+IEw+ZlNP9crEnvx4RRhaUulH7wtAv9akolRojO7crGMmfMEqdLBR6fBaHRiQ8/7Fh4Rrb44nA== X-Received: by 2002:a05:6214:4107:b0:6a0:b99e:7ad6 with SMTP id 6a1803df08f44-6a151490281mr43819576d6.34.1715197888169; Wed, 08 May 2024 12:51:28 -0700 (PDT) Received: from hurd (dsl-159-136.b2b2c.ca. [66.158.159.136]) by smtp.gmail.com with ESMTPSA id nd2-20020a056214420200b006a1006ddad2sm5855745qvb.131.2024.05.08.12.51.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 12:51:27 -0700 (PDT) From: Maxim Cournoyer To: Dariqq Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. In-Reply-To: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> (dariqq@posteo.net's message of "Wed, 8 May 2024 18:33:30 +0000") References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> Date: Wed, 08 May 2024 15:51:26 -0400 Message-ID: <87cypw6q0x.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: 70282@debbugs.gnu.org, Vivien Kraus , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: > Adjust screencast such that GI_TYPELIB_PATH and GST_PLUGIN_SYSTEM_PATH are set > before starting. > > Add all required gstreamer plugins to inputs. > > To be able to use it a running pipewire service is needed. > > * gnu/packages/gnome.scm (gnome-shell): > [inputs]: Add gst-plugins-good and pipewire. > [#:phases]<'wrap-programs>: Wrap org.gnome.Shell.Screencast. Thanks for your efforts improving our GNOME desktop experience! > Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 > --- > Here is v4 which appends the gstreamer plugins to > GST_PLUGIN_SYSTEM_PATH, handling the case when getenv returns null. I > think the difference between appendending or prepending in this case > is not too important as the user GST_PLUGIN_PATH should take > precedent. The more important thing is that the plugins are in any > plugin path at all. > > gnu/packages/gnome.scm | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm > index 92e35e3c5a..4bbff2a89b 100644 > --- a/gnu/packages/gnome.scm > +++ b/gnu/packages/gnome.scm > @@ -9408,6 +9408,7 @@ (define-public gnome-shell > (add-after 'install 'wrap-programs > (lambda* (#:key inputs #:allow-other-keys) > (let ((gi-typelib-path (getenv "GI_TYPELIB_PATH")) > + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) > (python-path > (string-join > (filter (lambda (item) > @@ -9427,6 +9428,19 @@ (define-public gnome-shell > "path => imports.gi.GIRepository.Repository." > "prepend_search_path(path));\n" > all))) > + ;; Screencast requires a pipewire service running > + ;; (i.e. as provided by home-pipewire-service-type) > + (substitute* (string-append #$output "/share/gnome-shell/" > + "org.gnome.Shell.Screencast") > + (("imports\\.package\\.start" all) > + (string-append "'" gi-typelib-path "'.split(':').forEach(" > + "path => imports.gi.GIRepository.Repository." > + "prepend_search_path(path));\n" > + "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH'," > + "[imports.gi.GLib.getenv('GST_PLUGIN_SYSTEM_PATH')," > + "'" gst-plugin-path "'].filter(v => v).join(':')," > + "true);\n" > + all))) Perhaps a simple patch would convey the change better and be easier to maintain in the future / be readily available for other distributions to use. > (for-each > (lambda (prog) > (wrap-program (string-append #$output "/bin/" prog) > @@ -9492,6 +9506,7 @@ (define-public gnome-shell > gnome-settings-daemon > graphene > gst-plugins-base > + gst-plugins-good > ibus > libcanberra > libcroco > @@ -9502,6 +9517,7 @@ (define-public gnome-shell > mesa-headers > mutter > network-manager-applet > + pipewire > polkit > pulseaudio > python-pygobject Otherwise, LGTM! -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 17:18:47 2024 Received: (at 70282) by debbugs.gnu.org; 8 May 2024 21:18:47 +0000 Received: from localhost ([127.0.0.1]:50948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4ogY-0003LL-Dl for submit@debbugs.gnu.org; Wed, 08 May 2024 17:18:47 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44197) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4ogS-0003LF-Ln for 70282@debbugs.gnu.org; Wed, 08 May 2024 17:18:45 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id EAB95240029 for <70282@debbugs.gnu.org>; Wed, 8 May 2024 23:18:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715203088; bh=l0vklNk/yg2XeskG9i8Y4nAQWDu00qQj5a9g4RjPLtQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=IfIbkeMZTqnKgkH7AD9uc9iwnAWiDVze5ElX8BRKf2U/Ra/wY7CTYGvEU0ym7NbpW KiNjO3IfHiWj6AELNutoW4qKv1cox1cxUNdG7zn8wpT7zCXtyrbJAZ6oVewY9fgccr riSSoxP8J9cI+vJoJsUwDUgXeBSD1XCjPlvt0FGqoDMC/hkC8jbBmX45HqyIRixHou bEMB+pL2APDqceL0PkEMbdKB92jOp8EtuiXgHYL4zIicv4xN0b7tNyMItffipXfA0K ae0CzLHYTxfO/oHjTHESNfm+w/8LzkLLcWHPnZJ65BbcwHNXLcUpO1BLq+T39qsY7N tzJnr6ZfGQ/8Q== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VZSfl144Jz6tvq; Wed, 8 May 2024 23:18:07 +0200 (CEST) Message-ID: <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> Date: Wed, 8 May 2024 21:18:04 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. To: Maxim Cournoyer References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <87cypw6q0x.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: 70282@debbugs.gnu.org, Vivien Kraus , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, On 08.05.24 21:51, Maxim Cournoyer wrote: > Hi Dariqq, > > Dariqq writes: > >> Adjust screencast such that GI_TYPELIB_PATH and GST_PLUGIN_SYSTEM_PATH are set >> before starting. >> >> Add all required gstreamer plugins to inputs. >> >> To be able to use it a running pipewire service is needed. >> >> * gnu/packages/gnome.scm (gnome-shell): >> [inputs]: Add gst-plugins-good and pipewire. >> [#:phases]<'wrap-programs>: Wrap org.gnome.Shell.Screencast. > > Thanks for your efforts improving our GNOME desktop experience! > The slight annoyance with this is that if pipewire is not running the option to enable the screen recorder is there but it will stop immediately. But at least searching online for this problem has some mentions of pipewire and i added a comment in the pacakge aswell. I think it is definitly a better solution than not knowing that the option is even there as the button does not get displayed at all if the service fails to start. >> Change-Id: I2c31bf1bd92e281b86c57b06988c6a3793a58d40 >> --- >> Here is v4 which appends the gstreamer plugins to >> GST_PLUGIN_SYSTEM_PATH, handling the case when getenv returns null. I >> think the difference between appendending or prepending in this case >> is not too important as the user GST_PLUGIN_PATH should take >> precedent. The more important thing is that the plugins are in any >> plugin path at all. >> >> gnu/packages/gnome.scm | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm >> index 92e35e3c5a..4bbff2a89b 100644 >> --- a/gnu/packages/gnome.scm >> +++ b/gnu/packages/gnome.scm >> @@ -9408,6 +9408,7 @@ (define-public gnome-shell >> (add-after 'install 'wrap-programs >> (lambda* (#:key inputs #:allow-other-keys) >> (let ((gi-typelib-path (getenv "GI_TYPELIB_PATH")) >> + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) >> (python-path >> (string-join >> (filter (lambda (item) >> @@ -9427,6 +9428,19 @@ (define-public gnome-shell >> "path => imports.gi.GIRepository.Repository." >> "prepend_search_path(path));\n" >> all))) >> + ;; Screencast requires a pipewire service running >> + ;; (i.e. as provided by home-pipewire-service-type) >> + (substitute* (string-append #$output "/share/gnome-shell/" >> + "org.gnome.Shell.Screencast") >> + (("imports\\.package\\.start" all) >> + (string-append "'" gi-typelib-path "'.split(':').forEach(" >> + "path => imports.gi.GIRepository.Repository." >> + "prepend_search_path(path));\n" >> + "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH'," >> + "[imports.gi.GLib.getenv('GST_PLUGIN_SYSTEM_PATH')," >> + "'" gst-plugin-path "'].filter(v => v).join(':')," >> + "true);\n" >> + all))) > > Perhaps a simple patch would convey the change better and be easier to > maintain in the future / be readily available for other distributions to > use. The simple patch that would do this is basically the patch from nixos in v1 of this which adds a shebang line for gjs to the service invocation files (rather than the dbus service invoking $gjs $service). The problem then is that wrap-program changes the filename to * .real which makes gjs unhappy. The people from nix circumvent this by using some js at the beginning to reset the entrypoint to the correct value. One nice way around avoiding the problem would be using wrap-script instead though that does not support gjs as interpreter (yet?) and adding that forces a rebuild of all packages due to (guix build utils) changing. Maybe another comment, similiar to the one Liliana suggested earlier in this thread, could be added at the beginning to inform about changing to wrap script + patch instead once that is a viable option? > >> (for-each >> (lambda (prog) >> (wrap-program (string-append #$output "/bin/" prog) >> @@ -9492,6 +9506,7 @@ (define-public gnome-shell >> gnome-settings-daemon >> graphene >> gst-plugins-base >> + gst-plugins-good >> ibus >> libcanberra >> libcroco >> @@ -9502,6 +9517,7 @@ (define-public gnome-shell >> mesa-headers >> mutter >> network-manager-applet >> + pipewire >> polkit >> pulseaudio >> python-pygobject > > Otherwise, LGTM! > Have a nice day From debbugs-submit-bounces@debbugs.gnu.org Wed May 08 18:12:01 2024 Received: (at 70282) by debbugs.gnu.org; 8 May 2024 22:12:01 +0000 Received: from localhost ([127.0.0.1]:51174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4pW4-0003t9-TG for submit@debbugs.gnu.org; Wed, 08 May 2024 18:12:01 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:57537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4pVz-0003t1-Ax for 70282@debbugs.gnu.org; Wed, 08 May 2024 18:11:59 -0400 Received: by mail-ej1-x643.google.com with SMTP id a640c23a62f3a-a59c5c9c6aeso47641066b.2 for <70282@debbugs.gnu.org>; Wed, 08 May 2024 15:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715206284; x=1715811084; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=UPkzK91MVTOBxPMVo7H+5FcvRUfwewPazqq9jrpTSnA=; b=CxCy14wg66irRMEPTOhsVlY8qT/KKKVNZVG8JRWZDRwP0nlQpSIRfkVrBpzPZ7upBA cyx3C7BXyQ+JDrzxmxUAAkaNxwc2aA+XVRDJe+bh9Uyd/ct5RqfS+GJ5PgyYTv/M4gno 2UCCa/Bjzlmyy+jrlaQYgmJZ3dn44dRBMAoSBFS8uNHLXLQBSHi0/d6jERZvBsV9YvHd mqnIPL/moGIn3glJgScZGzwluIWR2C8bp06HZKqkUrvQCVlqrnDSRls3/ZNuWem4dLc6 sqWqPNDjNErX1fVEG+IFN0cbRalODWoTLzmoD80Lx6NDDGEbVBR6t/7Fb0Rb5ZL4qhj2 9hmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715206284; x=1715811084; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UPkzK91MVTOBxPMVo7H+5FcvRUfwewPazqq9jrpTSnA=; b=g0fgkZPQP79B3/l/CmFj0R/0tX8fyNl4J5iPra785NxpIBWW26OPfsCrLQvjuEsm/c RWHcjDTll90oKSLXw5i7Esh0NKhs3SClWw9Jk6E+i9bBwiEsHSiy4waT8uvBu6YLFGw+ bCJATfE7Ne9HhrnROAkeT0vj6z0VVCSpzVh/PBZOCoBVSI/cMFdciLv9gOM+eJD86JlT GFjpDwIgjX/EXrVLPW/WHI6bKioSKBC+ZeS/9GTNMVKdu9bxTR8Kd1cVfLDyd/ydmY82 U8pyk7CSgX9MEPhUPOY1zWriWpfqfv+PjjnuRA/25+qEXyEO5cm4PP7nZcwY8DY8MTEu XQIQ== X-Gm-Message-State: AOJu0YzIgqmd0t+orTu2Ah5AEI70V3UPPXfN2ovAd0uxl7++CJ4QaVS+ aDCRuntmwWblJzLXTcHGe64oic948w1upGyfeSFjiORyXGf9lxZU X-Google-Smtp-Source: AGHT+IEkLChyYc/guHOWSmeg3KuN2F5ONSMoe+8cPRbCtoNmGjFlX/A8Rg0pwHFFcHWN753T7MEgpw== X-Received: by 2002:a17:906:4956:b0:a59:d39a:8d65 with SMTP id a640c23a62f3a-a59fb95556dmr249612166b.21.1715206283383; Wed, 08 May 2024 15:11:23 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a17b17808sm5947866b.217.2024.05.08.15.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 May 2024 15:11:22 -0700 (PDT) Message-ID: <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. From: Liliana Marie Prikler To: Dariqq , Maxim Cournoyer Date: Thu, 09 May 2024 00:11:18 +0200 In-Reply-To: <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: 70282@debbugs.gnu.org, Vivien Kraus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: > [...] >=20 > On 08.05.24 21:51, Maxim Cournoyer wrote: >=20 > > [...] > > Perhaps a simple patch would convey the change better and be easier > > to > > maintain in the future / be readily available for other > > distributions to > > use. >=20 > The simple patch that would do this is basically the patch from nixos > in v1 of this which adds a shebang line for gjs to the service > invocation files (rather than the dbus service invoking $gjs > $service). The problem then is that wrap-program changes the filename > to * .real which makes gjs unhappy. >=20 > [...] > Maybe another comment, similiar to the one Liliana suggested earlier > in this thread, could be added at the beginning to inform about > changing to wrap script + patch instead once that is a viable option? The pattern we typically use is to add an autotools-style "variable", e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use substitute* to fill it in. I don't think it's a requirement, but since Maxim suggested, it'd definitely be nice to have. Cheers From debbugs-submit-bounces@debbugs.gnu.org Thu May 09 04:28:16 2024 Received: (at 70282) by debbugs.gnu.org; 9 May 2024 08:28:16 +0000 Received: from localhost ([127.0.0.1]:53970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4z8S-0004um-02 for submit@debbugs.gnu.org; Thu, 09 May 2024 04:28:16 -0400 Received: from mout02.posteo.de ([185.67.36.66]:41219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4z8O-0004ug-CF for 70282@debbugs.gnu.org; Thu, 09 May 2024 04:28:14 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 32AC5240103 for <70282@debbugs.gnu.org>; Thu, 9 May 2024 10:27:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715243260; bh=5xIkxU1R9tVUXKtlRnbQsAOK2nI5dMFY1u7k06zdITI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=i6WTvXoJ12UQgcoU3O4aqnF8J6vPRXZIvRcaf31LGvhsF1X8T+L91f/ef3Ld5cxKF RerLG3ZwrhN11thRGDR7wPAXK0QkmcdZZnaK/n4974SwYIsllG7FWvvUQd/XQ9U+uS 7IFFZFWb6VJs83kwdlzmslCABWkpnhcy/VhJW/j9JtLw3422ucgXFl8U84F04ahqvq inPP/ioT8oebVdZ43k9/AhaChu3ook4fXbPdU/uYcn6XIExG12AVjNDbWZgpbxLgcX dwcCcjO6hMlZIitgs2mDjSGYDctQ/LSO3n20MDQPv+Ihzaje7w6arNn90jjAb5q3qe zLNjf5bgn8Ppw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VZlWH4rZdz6tvd; Thu, 9 May 2024 10:27:39 +0200 (CEST) Message-ID: <2957c0c2-29b1-43c4-886f-83623d07c9d0@posteo.net> Date: Thu, 9 May 2024 08:27:37 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. To: Liliana Marie Prikler , Maxim Cournoyer References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: 70282@debbugs.gnu.org, Vivien Kraus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Liliana, On 09.05.24 00:11, Liliana Marie Prikler wrote: > Hi Dariqq, > > Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: >> [...] >> >> On 08.05.24 21:51, Maxim Cournoyer wrote: >> >>> [...] >>> Perhaps a simple patch would convey the change better and be easier >>> to >>> maintain in the future / be readily available for other >>> distributions to >>> use. >> >> The simple patch that would do this is basically the patch from nixos >> in v1 of this which adds a shebang line for gjs to the service >> invocation files (rather than the dbus service invoking $gjs >> $service). The problem then is that wrap-program changes the filename >> to * .real which makes gjs unhappy. >> >> [...] >> Maybe another comment, similiar to the one Liliana suggested earlier >> in this thread, could be added at the beginning to inform about >> changing to wrap script + patch instead once that is a viable option? > The pattern we typically use is to add an autotools-style "variable", > e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use > substitute* to fill it in. I don't think it's a requirement, but since > Maxim suggested, it'd definitely be nice to have. How would this work in this case for gnomeshell? Put the js that gets concatenated here into the actual file with a patch adding placeholder variables for GST Plugin path and gi typelib path and replace later? As these js files get generated from a common template for each service this would require substituting all of them and not only the screencast service. > > Cheers > From debbugs-submit-bounces@debbugs.gnu.org Thu May 09 11:30:59 2024 Received: (at 70282) by debbugs.gnu.org; 9 May 2024 15:30:59 +0000 Received: from localhost ([127.0.0.1]:55908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s55jW-0004QF-R8 for submit@debbugs.gnu.org; Thu, 09 May 2024 11:30:59 -0400 Received: from mail-qt1-x82a.google.com ([2607:f8b0:4864:20::82a]:50219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s55jT-0004Q7-7z for 70282@debbugs.gnu.org; Thu, 09 May 2024 11:30:57 -0400 Received: by mail-qt1-x82a.google.com with SMTP id d75a77b69052e-43ddbdf2439so6628121cf.0 for <70282@debbugs.gnu.org>; Thu, 09 May 2024 08:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715268623; x=1715873423; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=gXKxEaJ2ZGfAEZv0J8qNfF0AvT3otpa9/TeoLBGkGnY=; b=LPbrj6OTs6ydbnf398HmaFAgCjTWy6SEtMVNO6mXTUDDLVQzeU088WAi1dVH/srF/P 68WWMpnAEZbBtz3IIzxAlYgvyZLpgWRhk/FtOMkAx2AZFRXIBGiATvrT697EX6jkFPnF svCPxX4djYtK+uL+jWmsgj0nQxOIoUP650qkXCPt9ZJvzpVKVVivPAwKzUbop3D6vhma wFis/RTXTiytuxqzidZRtGeaWSFbMkJoTQ5SzoC2VG7cHTk96ZEogQGRDp+BcNb0wfEt X6BMpeJwFzt2CRn54O6cM7MtKdh8B24ZMwF9jEQFzfAvYYQBJ0cfjW+OGjK0EYOe7waN mJLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715268623; x=1715873423; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gXKxEaJ2ZGfAEZv0J8qNfF0AvT3otpa9/TeoLBGkGnY=; b=T2z879VsfKbsS1PI3GqdfLaBEldNnttE87a8/BW/n1DrygnLJ5eIOY25AzfxCMBozB dME9cd+CYbUzBfUPVcTv4AOU35T4ulQhr/RVqZ+mtFqV3TILVxCvlkoMz3Mnn8Xq0mdf OuivoFVaV+njnaFGfT6uHIGwmlZ9UQgWaXYWj0P/xQBV9blrvDMup8j30yQgk4po2vzB FN4GI/rs095m7OlBCQ26s9w1zj8/pMrPVShYR6jr2oVzs55UdzlpHuWxRVSb/Qlm6S7M JOvkUZMDUOm0TYyw+7vbZ/L+ykJNVb0JpAngMqgUpDPHmH/PDRuzph25ILB/3h3/LGYZ Lz4w== X-Gm-Message-State: AOJu0YzRfTenASuBvoZfoIzdV9R8XqTd9KVkOByoGXM7tJqVy4Bt29OX G0pHtS2NMWOLlKg4oRyUhtaYofIduTcN5AdqupjcwaYCWUhb7dSd X-Google-Smtp-Source: AGHT+IG4GP2qwJTuAAIOS/2ZqQtX7LCxmZZKLSle/njDC8rfYGjj0eBZ9+A1gybmFvB99ubnd77imQ== X-Received: by 2002:a05:622a:1:b0:439:8741:5208 with SMTP id d75a77b69052e-43dbf50f7femr66986811cf.23.1715268623440; Thu, 09 May 2024 08:30:23 -0700 (PDT) Received: from hurd (dsl-152-95.b2b2c.ca. [66.158.152.95]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-43df5da15f4sm8667201cf.68.2024.05.09.08.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 May 2024 08:30:23 -0700 (PDT) From: Maxim Cournoyer To: Dariqq Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. In-Reply-To: <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> (dariqq@posteo.net's message of "Wed, 8 May 2024 21:18:04 +0000") References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> Date: Thu, 09 May 2024 11:30:21 -0400 Message-ID: <87a5kz2eb6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: 70282@debbugs.gnu.org, Vivien Kraus , Liliana Marie Prikler X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Dariqq, Dariqq writes: [...] >>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm >>> index 92e35e3c5a..4bbff2a89b 100644 >>> --- a/gnu/packages/gnome.scm >>> +++ b/gnu/packages/gnome.scm >>> @@ -9408,6 +9408,7 @@ (define-public gnome-shell >>> (add-after 'install 'wrap-programs >>> (lambda* (#:key inputs #:allow-other-keys) >>> (let ((gi-typelib-path (getenv "GI_TYPELIB_PATH")) >>> + (gst-plugin-path (getenv "GST_PLUGIN_SYSTEM_PATH")) >>> (python-path >>> (string-join >>> (filter (lambda (item) >>> @@ -9427,6 +9428,19 @@ (define-public gnome-shell >>> "path => imports.gi.GIRepository.Repository." >>> "prepend_search_path(path));\n" >>> all))) >>> + ;; Screencast requires a pipewire service running >>> + ;; (i.e. as provided by home-pipewire-service-type) >>> + (substitute* (string-append #$output "/share/gnome-shell/" >>> + "org.gnome.Shell.Screencast") >>> + (("imports\\.package\\.start" all) >>> + (string-append "'" gi-typelib-path "'.split(':').forEach(" >>> + "path => imports.gi.GIRepository.Repository." >>> + "prepend_search_path(path));\n" >>> + "imports.gi.GLib.setenv('GST_PLUGIN_SYSTEM_PATH'," >>> + "[imports.gi.GLib.getenv('GST_PLUGIN_SYSTEM_PATH')," >>> + "'" gst-plugin-path "'].filter(v => v).join(':')," >>> + "true);\n" >>> + all))) >> Perhaps a simple patch would convey the change better and be easier >> to >> maintain in the future / be readily available for other distributions to >> use. > > > The simple patch that would do this is basically the patch from nixos > in v1 of this which adds a shebang line for gjs to the service > invocation files (rather than the dbus service invoking $gjs > $service). The problem then is that wrap-program changes the filename > to * .real which makes gjs unhappy. > > The people from nix circumvent this by using some js at the beginning > to reset the entrypoint to the correct value. > > One nice way around avoiding the problem would be using wrap-script > instead though that does not support gjs as interpreter (yet?) and > adding that forces a rebuild of all packages due to (guix build utils) > changing. It'd be nice to prep such support on core-updates. You can test it on master by having a (guix build utils-next) module that you explicitly use. > Maybe another comment, similiar to the one Liliana suggested earlier > in this thread, could be added at the beginning to inform about > changing to wrap script + patch instead once that is a viable option? That could be a good reminder to have, yes. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 10:59:49 2024 Received: (at 70282) by debbugs.gnu.org; 10 May 2024 14:59:49 +0000 Received: from localhost ([127.0.0.1]:42473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5Riv-0002us-4G for submit@debbugs.gnu.org; Fri, 10 May 2024 10:59:49 -0400 Received: from mout01.posteo.de ([185.67.36.65]:44239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5Rit-0002um-Cw for 70282@debbugs.gnu.org; Fri, 10 May 2024 10:59:48 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8C370240027 for <70282@debbugs.gnu.org>; Fri, 10 May 2024 16:59:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715353182; bh=ZQvDzWCStT32Gt2JAYCWwIIp7CyQOa9xrELxJoqfNlc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=cQZ5BKmO5V3g1klgHLWv2XKQkB1XHp4xM4H/Pwu+HznNYl3wDk4vp18M3YFK8aJ1+ SeeP89o/WBuCvxah9rREPRIazP4NdJCCgl13+Qk7y/33MTEatJHBN82kJFtmQW65WG lYRKyfLjUCxp/zTRMgaLK4dYVcH5+bfTgbuJcI2v6Kg9Mg8ICOKv70MwGpH0P5BlBW nJKmNQDQolfxJdmvCGeWH23K2d3HpBikCMCWuj02bigsLDfriKgYBnE8B0TI4oLOMO /+KMTVAWTVNzPbWITo95oRFw2cMDHdeHf8q5eprmoPrepCCHVYPYHrIp0W7yPw2Iif 2ssJ/xkVbeQ9A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VbX993LP1z9rxF; Fri, 10 May 2024 16:59:41 +0200 (CEST) Message-ID: <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net> Date: Fri, 10 May 2024 14:59:40 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. To: Liliana Marie Prikler , Maxim Cournoyer References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: 70282@debbugs.gnu.org, Vivien Kraus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Liliana and Maxim, On 09.05.24 00:11, Liliana Marie Prikler wrote: > Hi Dariqq, > > Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: >> [...] >> >> On 08.05.24 21:51, Maxim Cournoyer wrote: >> >>> [...] >>> Perhaps a simple patch would convey the change better and be easier >>> to >>> maintain in the future / be readily available for other >>> distributions to >>> use. >> >> The simple patch that would do this is basically the patch from nixos >> in v1 of this which adds a shebang line for gjs to the service >> invocation files (rather than the dbus service invoking $gjs >> $service). The problem then is that wrap-program changes the filename >> to * .real which makes gjs unhappy. >> >> [...] >> Maybe another comment, similiar to the one Liliana suggested earlier >> in this thread, could be added at the beginning to inform about >> changing to wrap script + patch instead once that is a viable option? > The pattern we typically use is to add an autotools-style "variable", > e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use > substitute* to fill it in. I don't think it's a requirement, but since > Maxim suggested, it'd definitely be nice to have. > Tried this today and as the js service files are created from a common template using mesons 'configure_file' method this sets all autotools-style variables unknown to meson to the empty string. Afterwardes the susbtitute* at the wrapping phase is unable to replace anything ofc. So I think I would need to either change the naming-scheme of the placeholders or substitute them into the template file before the files get configured by meson. Do you have a preference for any option (or maybe another idea)? > Cheers > Have a nice day From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 12:05:30 2024 Received: (at 70282) by debbugs.gnu.org; 10 May 2024 16:05:30 +0000 Received: from localhost ([127.0.0.1]:42747 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5SkU-0003rC-7X for submit@debbugs.gnu.org; Fri, 10 May 2024 12:05:30 -0400 Received: from mail-ej1-f68.google.com ([209.85.218.68]:49164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5SkS-0003r6-TK for 70282@debbugs.gnu.org; Fri, 10 May 2024 12:05:29 -0400 Received: by mail-ej1-f68.google.com with SMTP id a640c23a62f3a-a599a298990so539869466b.2 for <70282@debbugs.gnu.org>; Fri, 10 May 2024 09:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715357064; x=1715961864; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=d/VHyTaMnvZvSEpE+NALXx/6v4neQyXS2AXBq4XpVck=; b=bJIqMyopp7Jk7XNNR0a+GzfBJ3NKXHHuuxpquAsRuIOfTqR8OXli45jF1uaU5HODAr msvUB/+/TCwI1/N2i/zwxtWnv2VPsg3oOcuKEClVERcqm3d4dVQOoFJmDv+boBkQG/o8 CewtnvExotBlhxC9IJPmJ1j46wv2IvizPq+1n9flrYcKdXC4/gb6H99mP+9xlgSzoS8t b0WDVLNgixRaIJFa+NiXlp9HYAXIBh9qpH2+1HLw9AEm0RIqfgScLe+E5hQF8wk0H0IA 5mxiMyPCRZEPH6mh5D7nramfwyD2DpuV5RY9uL4zPDp+I9gQdambK3+1w3i9Lsj14wDD 4cuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715357064; x=1715961864; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=d/VHyTaMnvZvSEpE+NALXx/6v4neQyXS2AXBq4XpVck=; b=ZAGCrMio5KLnmxZ3fzEI4H6OONzK2i3+IMsBS5LI0R63qY7rE7Cc0VvhIaMVloUzLU Q1UZ+cPKEHYEmHX0v8VQL1ckgtdg2yKFQRWX/Y7SorXf3hMnNNm3JyGz33zRNKhzvMFn p1fTzwy/7wB2emxrzLRVjGY2pTFd8im7wVoRwaXibuOBZhBcBtXV7C46Zd85ri7dl+XC Hz7z71IEiPauQHYqumMsLPOJYFUVn5fDR/+LBYVjXeTersXMst5LEJHn5/5tIyN0bX6q 6oMd+vsHVCqGPLsy9RgLSKag5GKpUI8+fM8HcSeX78kpKDRGZH8wo5ycRgZrCRUXS71S v6Ng== X-Gm-Message-State: AOJu0YzTeRvEpmw1lKS184l3UM7cAmutj7D8ZGl3+ijN0mJnMxIUeL+7 rpA7fyn3guEtrpAVLtqnNSdffXtHlsFIy/EnDZk22CIQSNlmWZIr X-Google-Smtp-Source: AGHT+IFyjvSTOWD+QpiFj36PkjzkC2RVi6TvrzkonWYXaUP+lRla2ZkPsCJasQE7xThyX9HVSeTWkA== X-Received: by 2002:a50:c349:0:b0:572:7ea0:66ca with SMTP id 4fb4d7f45d1cf-5734d6dc34amr2181182a12.36.1715357063844; Fri, 10 May 2024 09:04:23 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5733c2cb54csm1933158a12.60.2024.05.10.09.04.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 May 2024 09:04:22 -0700 (PDT) Message-ID: <9717bead5b1eb65af01143131e7e46fe835ab682.camel@gmail.com> Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. From: Liliana Marie Prikler To: Dariqq , Maxim Cournoyer Date: Fri, 10 May 2024 18:04:21 +0200 In-Reply-To: <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net> References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282 Cc: 70282@debbugs.gnu.org, Vivien Kraus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Freitag, dem 10.05.2024 um 14:59 +0000 schrieb Dariqq: > Hi Liliana and Maxim, >=20 > On 09.05.24 00:11, Liliana Marie Prikler wrote: > > Hi Dariqq, > >=20 > > Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: > > > [...] > > >=20 > > > On 08.05.24 21:51, Maxim Cournoyer wrote: > > >=20 > > > > [...] > > > > Perhaps a simple patch would convey the change better and be > > > > easier > > > > to > > > > maintain in the future / be readily available for other > > > > distributions to > > > > use. > > >=20 > > > The simple patch that would do this is basically the patch from > > > nixos > > > in=C2=A0 v1 of this which adds a shebang line for gjs to the service > > > invocation files (rather than the dbus service invoking $gjs > > > $service). The problem then is that wrap-program changes the > > > filename > > > to * .real which makes gjs unhappy. > > >=20 > > > [...] > > > Maybe another comment, similiar to the one Liliana suggested > > > earlier > > > in this thread, could be added at the beginning to inform about > > > changing to wrap script + patch instead once that is a viable > > > option? > > The pattern we typically use is to add an autotools-style > > "variable", > > e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use > > substitute* to fill it in.=C2=A0 I don't think it's a requirement, but > > since > > Maxim suggested, it'd definitely be nice to have. > >=20 >=20 > Tried this today and as the js service files are created from a > common template using mesons 'configure_file' method this sets all=20 > autotools-style variables unknown to meson to the empty string.=20 > Afterwardes the susbtitute* at the wrapping phase is unable to > replace anything ofc. >=20 > So I think I would need to either change the naming-scheme of the=20 > placeholders or substitute them into the template file=C2=A0 before the > files get configured by meson. Or you add an option to meson_options.txt to fill it in, so that you can provide the right value via #:configure-flags Cheers From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 04:04:07 2024 Received: (at 70282) by debbugs.gnu.org; 11 May 2024 08:04:07 +0000 Received: from localhost ([127.0.0.1]:46910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5hiB-0006SO-3K for submit@debbugs.gnu.org; Sat, 11 May 2024 04:04:07 -0400 Received: from mout01.posteo.de ([185.67.36.65]:42643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5hi8-0006Ru-Sb for 70282@debbugs.gnu.org; Sat, 11 May 2024 04:04:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 4FE5724002A for <70282@debbugs.gnu.org>; Sat, 11 May 2024 10:03:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1715414639; bh=iIgkygLTr42WPySyUEkj8PgWJbg5wxgRGk3hgGlA5cw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:Content-Type: Content-Transfer-Encoding:From; b=ablptLXqeIgMksAJttuZASaQQIPGvPiG536sPWoc98ckfaiPE5SIp/GozHVFxvxns COUoxeNY964aTGoxzENOw6G3Qfsc3WHR2LwOa9BIPBPKdDZUYPRQyw49qBu6IKJuY7 lFUMn97FgthROuwkyaecuzONFxXwMeR3sBjErmf0X6zI0niyUg3t4I3cG/PqNiVeOm Dz4yHdDC01Ev4X9YVwkVBflpvLfC+CVwCkurugL4110DHSzzjdSpB269cumAiYBjGS lSVnW8/2BQW9JzxVqOj/lZAyAENAQV9SxYV6Vrc89JxnHp4kV59BiVSTTDLSEB4gEr 8yLDtXpPUi6Tw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Vbyv21Kzjz6ty3; Sat, 11 May 2024 10:03:58 +0200 (CEST) Message-ID: <44b03f63-e82c-4f62-9d92-3d64007c3f10@posteo.net> Date: Sat, 11 May 2024 08:03:57 +0000 MIME-Version: 1.0 Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. To: Liliana Marie Prikler , Maxim Cournoyer References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <4593fcd10c303e41eee6afc187e9b5a1baad733f.camel@gmail.com> <532cafdd-afc3-4c2b-bd4a-a2be3318747c@posteo.net> <9717bead5b1eb65af01143131e7e46fe835ab682.camel@gmail.com> Content-Language: en-US From: Dariqq In-Reply-To: <9717bead5b1eb65af01143131e7e46fe835ab682.camel@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70282 Cc: 70282@debbugs.gnu.org, Vivien Kraus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 10.05.24 18:04, Liliana Marie Prikler wrote: > Am Freitag, dem 10.05.2024 um 14:59 +0000 schrieb Dariqq: >> Hi Liliana and Maxim, >> >> On 09.05.24 00:11, Liliana Marie Prikler wrote: >>> Hi Dariqq, >>> >>> Am Mittwoch, dem 08.05.2024 um 21:18 +0000 schrieb Dariqq: >>>> [...] >>>> >>>> On 08.05.24 21:51, Maxim Cournoyer wrote: >>>> >>>>> [...] >>>>> Perhaps a simple patch would convey the change better and be >>>>> easier >>>>> to >>>>> maintain in the future / be readily available for other >>>>> distributions to >>>>> use. >>>> >>>> The simple patch that would do this is basically the patch from >>>> nixos >>>> in  v1 of this which adds a shebang line for gjs to the service >>>> invocation files (rather than the dbus service invoking $gjs >>>> $service). The problem then is that wrap-program changes the >>>> filename >>>> to * .real which makes gjs unhappy. >>>> >>>> [...] >>>> Maybe another comment, similiar to the one Liliana suggested >>>> earlier >>>> in this thread, could be added at the beginning to inform about >>>> changing to wrap script + patch instead once that is a viable >>>> option? >>> The pattern we typically use is to add an autotools-style >>> "variable", >>> e.g. @GNOME_SHELL_GST_PLUGIN_SYSTEM_PATH@ through a patch, then use >>> substitute* to fill it in.  I don't think it's a requirement, but >>> since >>> Maxim suggested, it'd definitely be nice to have. >>> >> >> Tried this today and as the js service files are created from a >> common template using mesons 'configure_file' method this sets all >> autotools-style variables unknown to meson to the empty string. >> Afterwardes the susbtitute* at the wrapping phase is unable to >> replace anything ofc. >> >> So I think I would need to either change the naming-scheme of the >> placeholders or substitute them into the template file  before the >> files get configured by meson. > Or you add an option to meson_options.txt to fill it in, so that you > can provide the right value via #:configure-flags I'd want to avoid putting the environement variables together myself and rather use getenv to retrieve the value at build time though. Don't think that would work with #:configure-flags > > Cheers Have a nice day From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 01:36:09 2024 Received: (at 70282-done) by debbugs.gnu.org; 14 May 2024 05:36:09 +0000 Received: from localhost ([127.0.0.1]:37079 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6kpd-0007wX-Dh for submit@debbugs.gnu.org; Tue, 14 May 2024 01:36:09 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:50219) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6kpb-0007wR-CJ for 70282-done@debbugs.gnu.org; Tue, 14 May 2024 01:36:08 -0400 Received: by mail-ej1-f65.google.com with SMTP id a640c23a62f3a-a5a5c930cf6so476710466b.0 for <70282-done@debbugs.gnu.org>; Mon, 13 May 2024 22:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1715664901; x=1716269701; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=B5jruxBmi6cVHwITGSzKLRQp4vH7YjEI/M2MKajzuTQ=; b=ELP1gCNItW3NNrmqYEro9rqtV/G8R8vJg4bw+hFnDzUSdeWRxsed8zDQIwfkcNX49p 8TFvcA22QnvomjSkOf+MDZ9wMOs8E/n/LB4LSRtC+YhUx5IhdCtJzYWI1guTIOieFJ3G LBKtM2V/Y3KBkH9mVAULcPv06YpnqhbXl3eM7r+DCOYom1IUPO6zuYc0pi3UR5pkaN1V THW/EaMo7Ksd7koZ2uNsDvNPU8KUugbTJpBx8MwAMO57TiQLEhbB5kIxoOts0zw0Cg79 GGrhBcg3zwcnXm97oj8BWQKwS4yZaaNlNzgINEmFbjgt4jO9XMpR45VHlKlBWZGlIUVZ PEdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715664901; x=1716269701; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=B5jruxBmi6cVHwITGSzKLRQp4vH7YjEI/M2MKajzuTQ=; b=L+4ZdxvpUjrPmIxeTFxn6bF1aFCScZj2VE1XbXcyboFyE8IgHszaD8E9pPtJP0VWp0 UYExqJ4tRVjPRMlYOM7Deo9s52DOWVFjehTUn8yYNgdsQrxLa7KfLAjubOGa14HemFfQ IFMkQFxr9Xb81FTz0fDmF6cRVXI+cRg6BGiq33jpd/8RyhNRoDY5VWp2mxSJO1qtD7tS n7cIX6Lgp35VzDrdEP7ZfgZFKHgL9DCmgJ1WieaGiSGECr3sPGg/G239bz0t6t59NbvA iRNwd3Yshkg2wjQdI5AhzF6qjg7vtkEu2lGwg4bx8+DUl4jnjyUmILw5o/7gYDYknwKD sCFw== X-Gm-Message-State: AOJu0Ywm4I4XDElLTsENNq6/g7JC3O0if94F/aJz0WEQfoYiox7tKI3O 6D8mtwM4KIg1TuB8eekCE68K5bIMkinMTC+NSfbFhGQUNNFY+a4BmQebXHmI X-Google-Smtp-Source: AGHT+IGHArdf4RU5utjbmOiqapFmb+1jZcsChIQCb7WdQKfoJCyL7dSZP2IqfAWGhvRRPx/dmE3kBg== X-Received: by 2002:a17:906:194a:b0:a59:9b75:b90 with SMTP id a640c23a62f3a-a5a2d53ad53mr779223066b.2.1715664900416; Mon, 13 May 2024 22:35:00 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a5a3c24992dsm521037966b.96.2024.05.13.22.34.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 May 2024 22:34:59 -0700 (PDT) Message-ID: Subject: Re: [bug#70282] [PATCH v4] gnu: gnome-shell: Wrap screencast service. From: Liliana Marie Prikler To: Maxim Cournoyer , Dariqq Date: Tue, 14 May 2024 07:34:58 +0200 In-Reply-To: <87a5kz2eb6.fsf@gmail.com> References: <213d475bd6ad3781baf3876e89bd84c18029dc5e.1715193210.git.dariqq@posteo.net> <87cypw6q0x.fsf@gmail.com> <9e607cae-97fc-4b6d-85bc-dccf58ee1f08@posteo.net> <87a5kz2eb6.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70282-done Cc: 70282-done@debbugs.gnu.org, Vivien Kraus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) QW0gRG9ubmVyc3RhZywgZGVtIDA5LjA1LjIwMjQgdW0gMTE6MzAgLTA0MDAgc2NocmllYiBNYXhp bSBDb3Vybm95ZXI6Cj4gSGkgRGFyaXFxLAo+IAo+IERhcmlxcSA8ZGFyaXFxQHBvc3Rlby5uZXQ+ IHdyaXRlczoKPiAKPiBbLi4uXQo+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMv Z25vbWUuc2NtIGIvZ251L3BhY2thZ2VzL2dub21lLnNjbQo+ID4gPiA+IGluZGV4IDkyZTM1ZTNj NWEuLjRiYmZmMmE4OWIgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZ251L3BhY2thZ2VzL2dub21lLnNj bQo+ID4gPiA+ICsrKyBiL2dudS9wYWNrYWdlcy9nbm9tZS5zY20KPiA+ID4gPiBAQCAtOTQwOCw2 ICs5NDA4LDcgQEAgKGRlZmluZS1wdWJsaWMgZ25vbWUtc2hlbGwKPiA+ID4gPiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAoYWRkLWFmdGVyICdpbnN0YWxsICd3cmFwLXByb2dyYW1zCj4gPiA+ ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChsYW1iZGEqICgjOmtleSBpbnB1dHMg IzphbGxvdy1vdGhlci1rZXlzKQo+ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgKGxldCAoKGdpLXR5cGVsaWItcGF0aMKgIChnZXRlbnYKPiA+ID4gPiAiR0lfVFlQRUxJ Ql9QQVRIIikpCj4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCAoZ3N0LXBsdWdpbi1wYXRowqAgKGdldGVudgo+ID4gPiA+ICJHU1RfUExVR0lOX1NZU1RF TV9QQVRIIikpCj4gPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCAocHl0aG9uLXBhdGgKPiA+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqAgKHN0cmluZy1qb2luCj4gPiA+ID4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGZpbHRlciAobGFtYmRhIChpdGVt KQo+ID4gPiA+IEBAIC05NDI3LDYgKzk0MjgsMTkgQEAgKGRlZmluZS1wdWJsaWMgZ25vbWUtc2hl bGwKPiA+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAicGF0aCA9Pgo+ID4gPiA+IGltcG9ydHMuZ2ku R0lSZXBvc2l0b3J5LlJlcG9zaXRvcnkuIgo+ID4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgCj4gPiA+ ID4gInByZXBlbmRfc2VhcmNoX3BhdGgocGF0aCkpO1xuIgo+ID4gPiA+IMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGFsbCkpKQo+ID4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7 IFNjcmVlbmNhc3QgcmVxdWlyZXMgYSBwaXBld2lyZSBzZXJ2aWNlCj4gPiA+ID4gcnVubmluZwo+ ID4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIDs7IChpLmUuIGFzIHBy b3ZpZGVkIGJ5IGhvbWUtcGlwZXdpcmUtCj4gPiA+ID4gc2VydmljZS10eXBlKQo+ID4gPiA+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIChzdWJzdGl0dXRlKiAoc3RyaW5nLWFw cGVuZCAjJG91dHB1dAo+ID4gPiA+ICIvc2hhcmUvZ25vbWUtc2hlbGwvIgo+ID4gPiA+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAKPiA+ID4gPiAib3JnLmdub21lLlNoZWxsLlNj cmVlbmNhc3QiKQo+ID4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAoKCJpbXBvcnRzXFwucGFja2FnZVxcLnN0YXJ0IiBhbGwpCj4gPiA+ID4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKHN0cmluZy1hcHBlbmQgIiciIGdpLXR5cGVs aWItcGF0aAo+ID4gPiA+ICInLnNwbGl0KCc6JykuZm9yRWFjaCgiCj4gPiA+ID4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgInBhdGggPT4KPiA+ID4gPiBpbXBvcnRzLmdpLkdJUmVwb3NpdG9yeS5SZXBvc2l0b3J5 LiIKPiA+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gPiA+ICJwcmVwZW5kX3NlYXJjaF9wYXRoKHBh dGgpKTtcbiIKPiA+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoAo+ID4gPiA+ICJpbXBvcnRzLmdpLkdMaWIu c2V0ZW52KCdHU1RfUExVR0lOX1NZU1RFTV9QQVRIJywiCj4gPiA+ID4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAK PiA+ID4gPiAiW2ltcG9ydHMuZ2kuR0xpYi5nZXRlbnYoJ0dTVF9QTFVHSU5fU1lTVEVNX1BBVEgn KSwiCj4gPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIiciIGdzdC1wbHVnaW4tcGF0aAo+ID4gPiA+ICIn XS5maWx0ZXIodiA9PiB2KS5qb2luKCc6JyksIgo+ID4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICJ0cnVl KTtcbiIKPiA+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBhbGwpKSkKPiA+ID4gUGVyaGFwcyBhIHNpbXBs ZSBwYXRjaCB3b3VsZCBjb252ZXkgdGhlIGNoYW5nZSBiZXR0ZXIgYW5kIGJlCj4gPiA+IGVhc2ll ciB0byBtYWludGFpbiBpbiB0aGUgZnV0dXJlIC8gYmUgcmVhZGlseSBhdmFpbGFibGUgZm9yIG90 aGVyCj4gPiA+IGRpc3RyaWJ1dGlvbnMgdG8gdXNlLgo+ID4gCj4gPiAKPiA+IFRoZSBzaW1wbGUg cGF0Y2ggdGhhdCB3b3VsZCBkbyB0aGlzIGlzIGJhc2ljYWxseSB0aGUgcGF0Y2ggZnJvbQo+ID4g bml4b3MgaW4gdjEgb2YgdGhpcyB3aGljaCBhZGRzIGEgc2hlYmFuZyBsaW5lIGZvciBnanMgdG8g dGhlCj4gPiBzZXJ2aWNlIGludm9jYXRpb24gZmlsZXMgKHJhdGhlciB0aGFuIHRoZSBkYnVzIHNl cnZpY2UgaW52b2tpbmcKPiA+ICRnanMgJHNlcnZpY2UpLiBUaGUgcHJvYmxlbSB0aGVuIGlzIHRo YXQgd3JhcC1wcm9ncmFtIGNoYW5nZXMgdGhlCj4gPiBmaWxlbmFtZSB0byAqIC5yZWFsIHdoaWNo IG1ha2VzIGdqcyB1bmhhcHB5Lgo+ID4gCj4gPiBUaGUgcGVvcGxlIGZyb20gbml4IGNpcmN1bXZl bnQgdGhpcyBieSB1c2luZyBzb21lIGpzIGF0IHRoZQo+ID4gYmVnaW5uaW5nIHRvIHJlc2V0IHRo ZSBlbnRyeXBvaW50IHRvIHRoZSBjb3JyZWN0IHZhbHVlLgo+ID4gCj4gPiBPbmUgbmljZSB3YXkg YXJvdW5kIGF2b2lkaW5nIHRoZSBwcm9ibGVtIHdvdWxkIGJlIHVzaW5nIHdyYXAtc2NyaXB0Cj4g PiBpbnN0ZWFkIHRob3VnaCB0aGF0IGRvZXMgbm90IHN1cHBvcnQgZ2pzIGFzIGludGVycHJldGVy ICh5ZXQ/KSBhbmQKPiA+IGFkZGluZyB0aGF0IGZvcmNlcyBhIHJlYnVpbGQgb2YgYWxsIHBhY2th Z2VzIGR1ZSB0byAoZ3VpeCBidWlsZAo+ID4gdXRpbHMpIGNoYW5naW5nLgo+IAo+IEl0J2QgYmUg bmljZSB0byBwcmVwIHN1Y2ggc3VwcG9ydCBvbiBjb3JlLXVwZGF0ZXMuwqAgWW91IGNhbiB0ZXN0 IGl0Cj4gb24gbWFzdGVyIGJ5IGhhdmluZyBhIChndWl4IGJ1aWxkIHV0aWxzLW5leHQpIG1vZHVs ZSB0aGF0IHlvdQo+IGV4cGxpY2l0bHkgdXNlLgo+IAo+ID4gTWF5YmUgYW5vdGhlciBjb21tZW50 LCBzaW1pbGlhciB0byB0aGUgb25lIExpbGlhbmEgc3VnZ2VzdGVkCj4gPiBlYXJsaWVyIGluIHRo aXMgdGhyZWFkLCBjb3VsZCBiZSBhZGRlZCBhdCB0aGUgYmVnaW5uaW5nIHRvIGluZm9ybQo+ID4g YWJvdXQgY2hhbmdpbmcgdG8gd3JhcCBzY3JpcHQgKyBwYXRjaCBpbnN0ZWFkIG9uY2UgdGhhdCBp cyBhIHZpYWJsZQo+ID4gb3B0aW9uPwo+IAo+IFRoYXQgY291bGQgYmUgYSBnb29kIHJlbWluZGVy IHRvIGhhdmUsIHllcy4KSSd2ZSBwdXNoZWQgdGhlIGN1cnJlbnQgdmVyc2lvbiBhcy1pcywgd2l0 aG91dCByZW1pbmRlciwgc28gdGhhdCB3ZSBjYW4KYXQgbGVhc3QgbWFyayB0aGUgaXNzdWUgZG9u ZS4gIElmIHNvbWVvbmUgaGFzIGEgZ29vZCB0ZXh0IHRvIGFkZCwKcGxlYXNlIGRvbid0IGhlc2l0 YXRlIHRvIGRvIHNvIGluIHBvc3QuICBBbHNvIGRvbid0IGhlc2l0YXRlIHRvIHN1Ym1pdApuZXcg c3R1ZmYgdG8gZ25vbWUtdGVhbSBvciBjb3JlLXVwZGF0ZXMgYWZ0ZXIgdGhlIHBlbmRpbmcgbWVy Z2VzIGFyZQp0aHJvdWdoLgoKQ2hlZXJzIGFuZCB0aGFua3MgZm9yIGFsbCB0aGUgaGFyZCB3b3Jr IDopCg== From unknown Sun Jun 22 04:09:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Jun 2024 11:24:20 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator