GNU bug report logs - #70269
[PATCH] gnu: Add python-pybadges.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Graves <ngraves <at> ngraves.fr>
To: 70269 <at> debbugs.gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>, Sharlatan Hellseher <sharlatanus <at> gmail.com>, Munyoki Kilyungi <me <at> bonfacemunyoki.com>, Lars-Dominik Braun <lars <at> 6xq.net>, jgart <jgart <at> dismail.de>, Marius Bakke <marius <at> gnu.org>, Tanguy Le Carrour <tanguy <at> bioneland.org>
Subject: [bug#70269] [PATCH] gnu: Add python-pybadges.
Date: Mon, 13 May 2024 07:40:10 +0200

On 2024-04-08 00:13, Giacomo Leidi via Guix-patches via wrote:

> * gnu/packages/python-web.scm (python-pybadges): New variable.
>
> Change-Id: Idd53ddf94b24112015c0a0b82396cf366920417e
> ---
>  gnu/packages/python-web.scm | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
>
> diff --git a/gnu/packages/python-web.scm b/gnu/packages/python-web.scm
> index 9ad081beb1..da4f019476 100644
> --- a/gnu/packages/python-web.scm
> +++ b/gnu/packages/python-web.scm
> @@ -9123,6 +9123,40 @@ (define-public python-whatthepatch
>       "This package provides a library to parse and apply patches.")
>      (license license:expat)))
>  
> +(define-public python-pybadges
> +  (package
> +    (name "python-pybadges")
> +    (version "3.0.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/google/pybadges")
> +                    (commit (string-append version))))

(string-append with a single string is a bit odd ;)

> +              (file-name (git-file-name name version))
> +              (sha256
> +               "1zgb9idz7m3mzf8wvik0gwmyrxp753axqjv2pab326cr5myj1s4b")))
> +    (build-system pyproject-build-system)
> +    (arguments
> +     (list
> +      #:test-flags
> +      #~'("-k"
> +          ;; Disable network dependent tests.
> +          "not test_changes and not test_not_image_url and not test_http_url")))
> +    (propagated-inputs (list python-jinja2 python-requests))
> +    (native-inputs (list python-flask
> +                         python-fonttools
> +                         python-nox
> +                         python-pillow
> +                         python-pytest
> +                         python-xmldiff))
> +    (home-page "https://github.com/google/pybadges")
> +    (synopsis
> +     "Libbrary and command-line tool for generating Github-style badges")
           ^ typo there
> +    (description
> +     "This package provides @code{python-pybadges}: a library and command-line
> +tool for generating Github-style badges.")

Maybe you can be a bit more descriptive: "as SVG images" in the Github
description is informative. I often also like (but I'm not sure it's a
norm) to write my synopsis as an action statement, such as "Generate
Github-style badges on the command-line".

> +    (license license:asl2.0)))

Otherwise LGTM.

> +
>  (define-public python-grid5000
>    (package
>      (name "python-grid5000")
>
> base-commit: 69951a61a1d8f1f2135ea2dc836738be282b97bc

-- 
Best regards,
Nicolas Graves

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.