Subject: Re: [bug#70261] [PATCH v2] gnu: Add wsbg.

From: James Smith <[email-masked]>
Date: Tue, 23 Apr 2024 06:09:17 -0700

NOTE: Forgot to CC to debbugs before sending V3 patch.

Z572 <[email-masked]> writes:

> James Smith via Guix-patches via <[email-masked]> writes:
>
>> * gnu/packages/wm.scm (wsbg): New variable.
>>
>> Change-Id: Ia83a7afcbb0879f0f6d604e1d671388a30800265
>> ---
>>  gnu/packages/wm.scm | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
>> index b5e9dca524..62835b4e63 100644
>> --- a/gnu/packages/wm.scm
>> +++ b/gnu/packages/wm.scm
>> @@ -70,6 +70,7 @@
>>  ;;; Copyright © 2024 Ahmad Draidi <[email-masked]>
>>  ;;; Copyright © 2024 chris <[email-masked]>
>>  ;;; Copyright © 2024 Erik Eduardo Alonso Hernández <[email-masked]>
>> +;;; Copyright © 2024 James Smith <[email-masked]>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -3767,6 +3768,28 @@ (define-public velox
>>  It is inspired by dwm and xmonad.")
>>        (license license:expat))))
>>  
>> +(define-public wsbg
>> +  (let ((commit "15b0d0f6910ea97b9bcc471695fac07270955dd2")
>> +        (revision "133")
>
> revision should "0". when we update this package on guix repo, we add it.
>
Ah, I thought revision corresponds with the number of commits for the
upstream git repo, not the number of package revisions in Guix.
>> +        (version "0.1"))
>
> please add some comment about upstream is no tags.
> and version should 0.1.0, see https://github.com/saibier/wsbg/blob/15b0d0f6910ea97b9bcc471695fac07270955dd2/meson.build#L4
>
>> +    (package
>> +      (inherit swaybg)
>> +      (name "wsbg")
>> +      (version (git-version version revision commit))
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://github.com/saibier/wsbg")
>> +               (commit commit)))
>> +         (file-name (git-file-name name version))
>> +         (sha256
>> +          (base32 "15xrnwp54kghigx06y4qmmn1q9f26fx4cawyl4kcbqrrzfbbj1g6"))))
>> +      (home-page "https://github.com/saibier/wsbg")
>> +      (synopsis "Workspace wallpaper tool for Sway")
>> +      (description "Wallpaper utility for Sway with support for per-workspace
>> +configuration."))))
>> +
>>  (define-public yambar-wayland
>>    (package
>>      (name "yambar-wayland")
>>
>> base-commit: 2126dab4cd81db4cbde4566d8c638e45a4c0077c