GNU bug report logs - #70252
[PATCH 0/4] Update and restyle Khronos OpenCL packages

Previous Next

Package: guix-patches;

Reported by: Ahmad Draidi <a.r.draidi <at> redscript.org>

Date: Sun, 7 Apr 2024 08:07:01 UTC

Severity: normal

Tags: patch

Done: Ahmad Draidi <a.r.draidi <at> redscript.org>

To reply to this bug, email your comments to 70252 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 08:07:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ahmad Draidi <a.r.draidi <at> redscript.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 07 Apr 2024 08:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: guix-patches <at> gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 0/4] Update and restyle Khronos OpenCL packages
Date: Sun,  7 Apr 2024 12:05:10 +0400
Hello Guix,

All 3 packages have to be updated at the same time, which is why the
first patch is a bit unusual.

Thanks!

Ahmad Draidi (4):
  gnu: opencl-headers, opencl-clhpp and opencl-icd-loader: Update to
    2023.12.14.
  gnu: opencl-clhpp: Update package style.
  gnu: opencl-headers: Update package style.
  gnu: opencl-icd-loader: Update package style.

 gnu/packages/opencl.scm | 33 ++++++++++++++++++---------------
 1 file changed, 18 insertions(+), 15 deletions(-)


base-commit: eaccfececd0eec362b247efd47861e2118dd9dd8
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 08:11:01 GMT) Full text and rfc822 format available.

Message #8 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 1/4] gnu: opencl-headers,
 opencl-clhpp and opencl-icd-loader: Update to 2023.12.14.
Date: Sun,  7 Apr 2024 12:09:13 +0400
These packages should be updated together.

* gnu/packages/opencl.scm (opencl-headers): Update to 2023.12.14.
[home-page]: Update URL.
(opencl-clhpp): Update to 2023.12.14.
(opencl-icd-loader): Update to 2023.12.14.
[source]: Update origin URI to fix lint.

Change-Id: I56ee52a6df3fbbe7aa44743f09b28b07e5442b9f
---
 gnu/packages/opencl.scm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 036834f567..f265d983f0 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -55,7 +55,7 @@ (define-module (gnu packages opencl)
 (define-public opencl-headers
   (package
     (name "opencl-headers")
-    (version "2023.02.06")
+    (version "2023.12.14")
     (source
       (origin
         (method git-fetch)
@@ -64,13 +64,13 @@ (define-public opencl-headers
               (commit (string-append "v" version))))
         (file-name (git-file-name name version))
         (sha256
-         (base32 "1jxpx15gwxc6i7vp64xlzcxf57nl0qnaiip6jyr0j7iji47dm404"))))
+         (base32 "13a5zv0nvjp66sswm6zdakmfjxp7536wplampbx9fa6q7i14lpy0"))))
     (build-system cmake-build-system)
     (arguments `(#:tests? #f)) ; Not enabled during build.
     (synopsis "The Khronos OpenCL headers")
     (description
      "This package provides the C headers by Khronos for OpenCL programming.")
-    (home-page "https://www.khronos.org/registry/OpenCL/")
+    (home-page "https://registry.khronos.org/OpenCL/")
     (license license:asl2.0)))
 
 (define (make-opencl-headers major-version subversion)
@@ -96,7 +96,7 @@ (define-public opencl-headers-1.0
 (define-public opencl-clhpp
   (package
     (name "opencl-clhpp")
-    (version "2023.02.06")
+    (version "2023.12.14")
     (source
      (origin
        (method git-fetch)
@@ -104,7 +104,7 @@ (define-public opencl-clhpp
              (url "https://github.com/KhronosGroup/OpenCL-CLHPP")
              (commit (string-append "v" version))))
        (sha256
-        (base32 "1m3v5apjv3qagym32xqg38pq6i8j5d8svz11clsx408nrlyngrj0"))
+        (base32 "0hagizc636wfcfmdl0f4bghprjnz1dba2kvkwh2ysj485n8lmjh4"))
        (file-name (git-file-name name version))))
     (native-inputs
      `(("python" ,python-wrapper)))
@@ -125,16 +125,16 @@ (define-public opencl-clhpp
 (define-public opencl-icd-loader
   (package
     (name "opencl-icd-loader")
-    (version "2023.02.06")
+    (version "2023.12.14")
     (source (origin
               (method git-fetch)
               (uri (git-reference
-                    (url "https://github.com/KhronosGroup/OpenCL-ICD-Loader.git")
+                    (url "https://github.com/KhronosGroup/OpenCL-ICD-Loader")
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1cmbcm6bz6kfvr0dy9hzf2vgfwcz8gbm8rxspqqpva6z74dz0qxr"))))
+                "03xjkfb98paya5h18qsqdf3gqp063iblgbgahcfji9q91i0b327z"))))
     (build-system cmake-build-system)
     (arguments `(#:tests? #f)) ; Tests need stub loader setup.
     (native-search-paths
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 08:11:02 GMT) Full text and rfc822 format available.

Message #11 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 2/4] gnu: opencl-clhpp: Update package style.
Date: Sun,  7 Apr 2024 12:09:14 +0400
* gnu/packages/opencl.scm: Add #:use-module (guix gexp).
(opencl-clhpp): [native-inputs]: Remove labels.
[arguments]: Use G-expressions.

Change-Id: I5de85d6c1ed9d62bc481626ec3df2d0f0f939f32
---
 gnu/packages/opencl.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index f265d983f0..c70dc4655f 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -24,6 +24,7 @@ (define-module (gnu packages opencl)
   #:use-module (guix build-system python)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
@@ -107,14 +108,16 @@ (define-public opencl-clhpp
         (base32 "0hagizc636wfcfmdl0f4bghprjnz1dba2kvkwh2ysj485n8lmjh4"))
        (file-name (git-file-name name version))))
     (native-inputs
-     `(("python" ,python-wrapper)))
+     (list python-wrapper))
     (propagated-inputs
      (list opencl-headers))
     (arguments
-     `(#:configure-flags (list "-DBUILD_EXAMPLES=OFF" "-DBUILD_TESTS=OFF"
-                               "-DBUILD_TESTING=OFF") ;; CTest needs this to be turned off
-       ;; The regression tests require a lot more dependencies.
-       #:tests? #f))
+     (list #:configure-flags #~(list "-DBUILD_EXAMPLES=OFF"
+                                     "-DBUILD_TESTS=OFF"
+                                     ;; CTest needs this to be turned off
+                                     "-DBUILD_TESTING=OFF")
+           ;; The regression tests require a lot more dependencies.
+           #:tests? #f))
     (build-system cmake-build-system)
     (home-page "https://github.khronos.org/OpenCL-CLHPP/")
     (synopsis "Khronos OpenCL-CLHPP")
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 08:12:01 GMT) Full text and rfc822 format available.

Message #14 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 3/4] gnu: opencl-headers: Update package style.
Date: Sun,  7 Apr 2024 12:09:15 +0400
* gnu/packages/opencl.scm (opencl-headers): [arguments]: Use G-expressions.

Change-Id: Ib8b5aa7cebf7757466e237a4eed868f0fb7ece9c
---
 gnu/packages/opencl.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index c70dc4655f..f6f9b76c85 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -67,7 +67,7 @@ (define-public opencl-headers
         (sha256
          (base32 "13a5zv0nvjp66sswm6zdakmfjxp7536wplampbx9fa6q7i14lpy0"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f)) ; Not enabled during build.
+    (arguments (list #:tests? #f)) ; Not enabled during build.
     (synopsis "The Khronos OpenCL headers")
     (description
      "This package provides the C headers by Khronos for OpenCL programming.")
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 08:12:02 GMT) Full text and rfc822 format available.

Message #17 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH 4/4] gnu: opencl-icd-loader: Update package style.
Date: Sun,  7 Apr 2024 12:09:16 +0400
* gnu/packages/opencl.scm (opencl-icd-loader): [arguments]: Use G-expressions.

Change-Id: Ibb78b54186b268b8cd5a8c97177a31e36b4ca69d
---
 gnu/packages/opencl.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index f6f9b76c85..1e985f7039 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -139,7 +139,7 @@ (define-public opencl-icd-loader
                (base32
                 "03xjkfb98paya5h18qsqdf3gqp063iblgbgahcfji9q91i0b327z"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f)) ; Tests need stub loader setup.
+    (arguments (list #:tests? #f)) ; Tests need stub loader setup.
     (native-search-paths
      (list (search-path-specification
             (variable "OCL_ICD_VENDORS")
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 20:34:01 GMT) Full text and rfc822 format available.

Message #20 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v2 0/5] Update and restyle Khronos OpenCL packages
Date: Mon,  8 Apr 2024 00:19:56 +0400
Hello Guix,

Version 2 of this patch series uses a common version variable.

While working on Vulkan packages, I noticed the common version variable
%vulkan-sdk-version so I thought I'd use the same pattern here. Upstream
seems to be unified or unifying also[1].

I avoided using the full version string with the "v" included (e.g. v2023.12.14)
to minimize changes, though it might be more future proof to use the whole string.

[1]: https://github.com/KhronosGroup/OpenCL-SDK

Ahmad Draidi (5):
  gnu: opencl-headers, opencl-clhpp and opencl-icd-loader: Replace
    version with %opencl-sdk-version.
  gnu: %opencl-sdk-version: Update to 2023.12.14.
  gnu: opencl-clhpp: Update package style.
  gnu: opencl-headers: Update package style.
  gnu: opencl-icd-loader: Update package style.

 gnu/packages/opencl.scm | 42 +++++++++++++++++++++++------------------
 1 file changed, 24 insertions(+), 18 deletions(-)


base-commit: 298aed72a2a76be33f9a55bed22636acd7a4f9b9
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 20:38:01 GMT) Full text and rfc822 format available.

Message #23 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v2 1/5] gnu: opencl-headers,
 opencl-clhpp and opencl-icd-loader: Replace version with
 %opencl-sdk-version.
Date: Mon,  8 Apr 2024 00:33:50 +0400
These packages must be updated together. Therefore, we use a common version
variable.

* gnu/packages/opencl.scm (%opencl-sdk-version): New variable.
(opencl-headers)[version]: Replace with %opencl-sdk-version.
(opencl-clhpp)[version]: Likewise.
(opencl-icd-loader)[version]: Likewise.

Change-Id: I2cf25e2e7b951f0c0ff54a48c4e4a4fb470bff6a
---
 gnu/packages/opencl.scm | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 036834f567..d6fb344458 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -49,13 +49,16 @@ (define-module (gnu packages opencl)
 ;; tests that require such devices are all disabled.
 ;; Check https://lists.gnu.org/archive/html/guix-devel/2018-04/msg00293.html
 
-;; If you update either of opencl-headers, opencl-clhpp or opencl-icd-loader
-;; note that they are released together (lockstep) and must be updated
-;; together.
+;; The packages opencl-headers, opencl-clhpp and opencl-icd-loader are released
+;; together (lockstep) and must be updated together. The following variable
+;; facilitates that.
+
+(define %opencl-sdk-version "2023.02.06")
+
 (define-public opencl-headers
   (package
     (name "opencl-headers")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source
       (origin
         (method git-fetch)
@@ -96,7 +99,7 @@ (define-public opencl-headers-1.0
 (define-public opencl-clhpp
   (package
     (name "opencl-clhpp")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source
      (origin
        (method git-fetch)
@@ -125,7 +128,7 @@ (define-public opencl-clhpp
 (define-public opencl-icd-loader
   (package
     (name "opencl-icd-loader")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source (origin
               (method git-fetch)
               (uri (git-reference
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 20:38:02 GMT) Full text and rfc822 format available.

Message #26 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v2 2/5] gnu: %opencl-sdk-version: Update to 2023.12.14.
Date: Mon,  8 Apr 2024 00:33:51 +0400
This updates opencl-headers, opencl-clhpp and opencl-icd-loader.

* gnu/packages/opencl.scm (opencl-headers)[source]: Update hash.
[home-page]: Update URL.
(opencl-clhpp)[source]: Update hash.
(opencl-icd-loader)[source]: Update hash. Update origin URI to fix lint.

Change-Id: I674fc8aa79d1d98bac7ff66ba3a0e0fcb9b243cb
---
 gnu/packages/opencl.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index d6fb344458..b3d917d28b 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -53,7 +53,7 @@ (define-module (gnu packages opencl)
 ;; together (lockstep) and must be updated together. The following variable
 ;; facilitates that.
 
-(define %opencl-sdk-version "2023.02.06")
+(define %opencl-sdk-version "2023.12.14")
 
 (define-public opencl-headers
   (package
@@ -67,13 +67,13 @@ (define-public opencl-headers
               (commit (string-append "v" version))))
         (file-name (git-file-name name version))
         (sha256
-         (base32 "1jxpx15gwxc6i7vp64xlzcxf57nl0qnaiip6jyr0j7iji47dm404"))))
+         (base32 "13a5zv0nvjp66sswm6zdakmfjxp7536wplampbx9fa6q7i14lpy0"))))
     (build-system cmake-build-system)
     (arguments `(#:tests? #f)) ; Not enabled during build.
     (synopsis "The Khronos OpenCL headers")
     (description
      "This package provides the C headers by Khronos for OpenCL programming.")
-    (home-page "https://www.khronos.org/registry/OpenCL/")
+    (home-page "https://registry.khronos.org/OpenCL/")
     (license license:asl2.0)))
 
 (define (make-opencl-headers major-version subversion)
@@ -107,7 +107,7 @@ (define-public opencl-clhpp
              (url "https://github.com/KhronosGroup/OpenCL-CLHPP")
              (commit (string-append "v" version))))
        (sha256
-        (base32 "1m3v5apjv3qagym32xqg38pq6i8j5d8svz11clsx408nrlyngrj0"))
+        (base32 "0hagizc636wfcfmdl0f4bghprjnz1dba2kvkwh2ysj485n8lmjh4"))
        (file-name (git-file-name name version))))
     (native-inputs
      `(("python" ,python-wrapper)))
@@ -132,12 +132,12 @@ (define-public opencl-icd-loader
     (source (origin
               (method git-fetch)
               (uri (git-reference
-                    (url "https://github.com/KhronosGroup/OpenCL-ICD-Loader.git")
+                    (url "https://github.com/KhronosGroup/OpenCL-ICD-Loader")
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1cmbcm6bz6kfvr0dy9hzf2vgfwcz8gbm8rxspqqpva6z74dz0qxr"))))
+                "03xjkfb98paya5h18qsqdf3gqp063iblgbgahcfji9q91i0b327z"))))
     (build-system cmake-build-system)
     (arguments `(#:tests? #f)) ; Tests need stub loader setup.
     (native-search-paths
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 20:38:03 GMT) Full text and rfc822 format available.

Message #29 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v2 3/5] gnu: opencl-clhpp: Update package style.
Date: Mon,  8 Apr 2024 00:33:52 +0400
* gnu/packages/opencl.scm: Add #:use-module (guix gexp).
(opencl-clhpp): [native-inputs]: Remove labels.
[arguments]: Use G-expressions.

Change-Id: I9c61aad824b5a57f941853635f30d2ec2dad38d8
---
 gnu/packages/opencl.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index b3d917d28b..e62cea52eb 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -24,6 +24,7 @@ (define-module (gnu packages opencl)
   #:use-module (guix build-system python)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
@@ -110,14 +111,16 @@ (define-public opencl-clhpp
         (base32 "0hagizc636wfcfmdl0f4bghprjnz1dba2kvkwh2ysj485n8lmjh4"))
        (file-name (git-file-name name version))))
     (native-inputs
-     `(("python" ,python-wrapper)))
+     (list python-wrapper))
     (propagated-inputs
      (list opencl-headers))
     (arguments
-     `(#:configure-flags (list "-DBUILD_EXAMPLES=OFF" "-DBUILD_TESTS=OFF"
-                               "-DBUILD_TESTING=OFF") ;; CTest needs this to be turned off
-       ;; The regression tests require a lot more dependencies.
-       #:tests? #f))
+     (list #:configure-flags #~(list "-DBUILD_EXAMPLES=OFF"
+                                     "-DBUILD_TESTS=OFF"
+                                     ;; CTest needs this to be turned off
+                                     "-DBUILD_TESTING=OFF")
+           ;; The regression tests require a lot more dependencies.
+           #:tests? #f))
     (build-system cmake-build-system)
     (home-page "https://github.khronos.org/OpenCL-CLHPP/")
     (synopsis "Khronos OpenCL-CLHPP")
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 20:38:05 GMT) Full text and rfc822 format available.

Message #32 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v2 4/5] gnu: opencl-headers: Update package style.
Date: Mon,  8 Apr 2024 00:33:53 +0400
* gnu/packages/opencl.scm (opencl-headers)[arguments]: Use G-expressions.

Change-Id: I3704206aa0d92dafc99953753914f5090192785d
---
 gnu/packages/opencl.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index e62cea52eb..9495cb59a4 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -70,7 +70,7 @@ (define-public opencl-headers
         (sha256
          (base32 "13a5zv0nvjp66sswm6zdakmfjxp7536wplampbx9fa6q7i14lpy0"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f)) ; Not enabled during build.
+    (arguments (list #:tests? #f)) ; Not enabled during build.
     (synopsis "The Khronos OpenCL headers")
     (description
      "This package provides the C headers by Khronos for OpenCL programming.")
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 07 Apr 2024 20:38:06 GMT) Full text and rfc822 format available.

Message #35 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v2 5/5] gnu: opencl-icd-loader: Update package style.
Date: Mon,  8 Apr 2024 00:33:54 +0400
* gnu/packages/opencl.scm (opencl-icd-loader)[arguments]: Use G-expressions.

Change-Id: I0d2e2a6e1b267d01c75ea560c8ef7fde12fdec4a
---
 gnu/packages/opencl.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 9495cb59a4..2d7f9fc15b 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -142,7 +142,7 @@ (define-public opencl-icd-loader
                (base32
                 "03xjkfb98paya5h18qsqdf3gqp063iblgbgahcfji9q91i0b327z"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f)) ; Tests need stub loader setup.
+    (arguments (list #:tests? #f)) ; Tests need stub loader setup.
     (native-search-paths
      (list (search-path-specification
             (variable "OCL_ICD_VENDORS")
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sat, 04 May 2024 16:42:01 GMT) Full text and rfc822 format available.

Message #38 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Ahmad Draidi <a.r.draidi <at> redscript.org>
Cc: John Kehayias <john.kehayias <at> protonmail.com>, 70252 <at> debbugs.gnu.org
Subject: Re: [bug#70252] [PATCH v2 0/5] Update and restyle Khronos OpenCL
 packages
Date: Sat, 04 May 2024 18:40:56 +0200
Hello Ahmad,

Ahmad Draidi <a.r.draidi <at> redscript.org> skribis:

>   gnu: opencl-headers, opencl-clhpp and opencl-icd-loader: Replace
>     version with %opencl-sdk-version.
>   gnu: %opencl-sdk-version: Update to 2023.12.14.
>   gnu: opencl-clhpp: Update package style.
>   gnu: opencl-headers: Update package style.
>   gnu: opencl-icd-loader: Update package style.

I think this is very much under the scope of the “MESA team”, so I’m
Cc’ing John who’s more familiar with this area than I am.

  https://issues.guix.gnu.org/70252

(BTW, there’s actually no “MESA team” in etc/teams.scm.  Should we add
one, John?)

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 29 Sep 2024 12:46:01 GMT) Full text and rfc822 format available.

Message #41 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: John Kehayias <john.kehayias <at> protonmail.com>,
 Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: [bug#70252] [PATCH v2 0/5] Update and restyle Khronos OpenCL
 packages
Date: Sun, 29 Sep 2024 16:43:30 +0400
Greetings,

A new version came out since I submitted this. I'm sending an 
updated series shortly.

Thanks.




Information forwarded to a.r.draidi <at> redscript.org, ludo <at> gnu.org, guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 29 Sep 2024 12:50:06 GMT) Full text and rfc822 format available.

Message #44 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v3 2/5] gnu: %opencl-sdk-version: Update to 2024.05.08.
Date: Sun, 29 Sep 2024 16:45:35 +0400
This updates opencl-headers, opencl-clhpp and opencl-icd-loader.

* gnu/packages/opencl.scm (opencl-headers)[source]: Update hash.
[home-page]: Update URL.
(opencl-clhpp)[source]: Update hash.
(opencl-icd-loader)[source]: Update hash. Update origin URI to fix lint.

Change-Id: I674fc8aa79d1d98bac7ff66ba3a0e0fcb9b243cb
---
v3: update to latest version.

 gnu/packages/opencl.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index d6fb344458..f7f2bd0e0b 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -53,7 +53,7 @@ (define-module (gnu packages opencl)
 ;; together (lockstep) and must be updated together. The following variable
 ;; facilitates that.
 
-(define %opencl-sdk-version "2023.02.06")
+(define %opencl-sdk-version "2024.05.08")
 
 (define-public opencl-headers
   (package
@@ -67,13 +67,13 @@ (define-public opencl-headers
               (commit (string-append "v" version))))
         (file-name (git-file-name name version))
         (sha256
-         (base32 "1jxpx15gwxc6i7vp64xlzcxf57nl0qnaiip6jyr0j7iji47dm404"))))
+         (base32 "0m0znpwjsgsgccgrdn2pw8j6z8inkbyq6dsv7r2jjdm6kdmxjw0m"))))
     (build-system cmake-build-system)
     (arguments `(#:tests? #f)) ; Not enabled during build.
     (synopsis "The Khronos OpenCL headers")
     (description
      "This package provides the C headers by Khronos for OpenCL programming.")
-    (home-page "https://www.khronos.org/registry/OpenCL/")
+    (home-page "https://registry.khronos.org/OpenCL/")
     (license license:asl2.0)))
 
 (define (make-opencl-headers major-version subversion)
@@ -107,7 +107,7 @@ (define-public opencl-clhpp
              (url "https://github.com/KhronosGroup/OpenCL-CLHPP")
              (commit (string-append "v" version))))
        (sha256
-        (base32 "1m3v5apjv3qagym32xqg38pq6i8j5d8svz11clsx408nrlyngrj0"))
+        (base32 "172jxbx78bv6gapxx43bh7ni7zciw010gxx17h47sndhdasbi2bc"))
        (file-name (git-file-name name version))))
     (native-inputs
      `(("python" ,python-wrapper)))
@@ -132,12 +132,12 @@ (define-public opencl-icd-loader
     (source (origin
               (method git-fetch)
               (uri (git-reference
-                    (url "https://github.com/KhronosGroup/OpenCL-ICD-Loader.git")
+                    (url "https://github.com/KhronosGroup/OpenCL-ICD-Loader")
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1cmbcm6bz6kfvr0dy9hzf2vgfwcz8gbm8rxspqqpva6z74dz0qxr"))))
+                "0q3hj2b3vw0mdzbizbd8jnrcjgmiyql2c4sgv83x255p9gb1qp60"))))
     (build-system cmake-build-system)
     (arguments `(#:tests? #f)) ; Tests need stub loader setup.
     (native-search-paths
-- 
2.46.0





Information forwarded to a.r.draidi <at> redscript.org, ludo <at> gnu.org, guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 29 Sep 2024 12:51:02 GMT) Full text and rfc822 format available.

Message #47 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v3 4/5] gnu: opencl-headers: Update package style.
Date: Sun, 29 Sep 2024 16:45:37 +0400
* gnu/packages/opencl.scm (opencl-headers)[arguments]: Use G-expressions.

Change-Id: I3704206aa0d92dafc99953753914f5090192785d
---
 gnu/packages/opencl.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 11fe4c8fd3..452bf54245 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -70,7 +70,7 @@ (define-public opencl-headers
         (sha256
          (base32 "0m0znpwjsgsgccgrdn2pw8j6z8inkbyq6dsv7r2jjdm6kdmxjw0m"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f)) ; Not enabled during build.
+    (arguments (list #:tests? #f)) ; Not enabled during build.
     (synopsis "The Khronos OpenCL headers")
     (description
      "This package provides the C headers by Khronos for OpenCL programming.")
-- 
2.46.0





Information forwarded to a.r.draidi <at> redscript.org, ludo <at> gnu.org, guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 29 Sep 2024 12:51:02 GMT) Full text and rfc822 format available.

Message #50 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v3 1/5] gnu: opencl-headers,
 opencl-clhpp and opencl-icd-loader: Replace version with
 %opencl-sdk-version.
Date: Sun, 29 Sep 2024 16:45:34 +0400
These packages must be updated together. Therefore, we use a common version
variable.

* gnu/packages/opencl.scm (%opencl-sdk-version): New variable.
(opencl-headers)[version]: Replace with %opencl-sdk-version.
(opencl-clhpp)[version]: Likewise.
(opencl-icd-loader)[version]: Likewise.

Change-Id: I2cf25e2e7b951f0c0ff54a48c4e4a4fb470bff6a
---
 gnu/packages/opencl.scm | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 036834f567..d6fb344458 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -49,13 +49,16 @@ (define-module (gnu packages opencl)
 ;; tests that require such devices are all disabled.
 ;; Check https://lists.gnu.org/archive/html/guix-devel/2018-04/msg00293.html
 
-;; If you update either of opencl-headers, opencl-clhpp or opencl-icd-loader
-;; note that they are released together (lockstep) and must be updated
-;; together.
+;; The packages opencl-headers, opencl-clhpp and opencl-icd-loader are released
+;; together (lockstep) and must be updated together. The following variable
+;; facilitates that.
+
+(define %opencl-sdk-version "2023.02.06")
+
 (define-public opencl-headers
   (package
     (name "opencl-headers")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source
       (origin
         (method git-fetch)
@@ -96,7 +99,7 @@ (define-public opencl-headers-1.0
 (define-public opencl-clhpp
   (package
     (name "opencl-clhpp")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source
      (origin
        (method git-fetch)
@@ -125,7 +128,7 @@ (define-public opencl-clhpp
 (define-public opencl-icd-loader
   (package
     (name "opencl-icd-loader")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source (origin
               (method git-fetch)
               (uri (git-reference

base-commit: e464a3e166b826a040aea7140ee33f3e89da6a88
-- 
2.46.0





Information forwarded to a.r.draidi <at> redscript.org, ludo <at> gnu.org, guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 29 Sep 2024 12:51:03 GMT) Full text and rfc822 format available.

Message #53 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v3 3/5] gnu: opencl-clhpp: Update package style.
Date: Sun, 29 Sep 2024 16:45:36 +0400
* gnu/packages/opencl.scm: Add #:use-module (guix gexp).
(opencl-clhpp): [native-inputs]: Remove labels.
[arguments]: Use G-expressions.

Change-Id: I9c61aad824b5a57f941853635f30d2ec2dad38d8
---
 gnu/packages/opencl.scm | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index f7f2bd0e0b..11fe4c8fd3 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -24,6 +24,7 @@ (define-module (gnu packages opencl)
   #:use-module (guix build-system python)
   #:use-module (guix download)
   #:use-module (guix utils)
+  #:use-module (guix gexp)
   #:use-module (guix git-download)
   #:use-module ((guix licenses) #:prefix license:)
   #:use-module (guix packages)
@@ -110,14 +111,16 @@ (define-public opencl-clhpp
         (base32 "172jxbx78bv6gapxx43bh7ni7zciw010gxx17h47sndhdasbi2bc"))
        (file-name (git-file-name name version))))
     (native-inputs
-     `(("python" ,python-wrapper)))
+     (list python-wrapper))
     (propagated-inputs
      (list opencl-headers))
     (arguments
-     `(#:configure-flags (list "-DBUILD_EXAMPLES=OFF" "-DBUILD_TESTS=OFF"
-                               "-DBUILD_TESTING=OFF") ;; CTest needs this to be turned off
-       ;; The regression tests require a lot more dependencies.
-       #:tests? #f))
+     (list #:configure-flags #~(list "-DBUILD_EXAMPLES=OFF"
+                                     "-DBUILD_TESTS=OFF"
+                                     ;; CTest needs this to be turned off
+                                     "-DBUILD_TESTING=OFF")
+           ;; The regression tests require a lot more dependencies.
+           #:tests? #f))
     (build-system cmake-build-system)
     (home-page "https://github.khronos.org/OpenCL-CLHPP/")
     (synopsis "Khronos OpenCL-CLHPP")
-- 
2.46.0





Information forwarded to a.r.draidi <at> redscript.org, ludo <at> gnu.org, guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Sun, 29 Sep 2024 12:51:03 GMT) Full text and rfc822 format available.

Message #56 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v3 5/5] gnu: opencl-icd-loader: Update package style.
Date: Sun, 29 Sep 2024 16:45:38 +0400
* gnu/packages/opencl.scm (opencl-icd-loader)[arguments]: Use G-expressions.

Change-Id: I0d2e2a6e1b267d01c75ea560c8ef7fde12fdec4a
---
 gnu/packages/opencl.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 452bf54245..32b489a42a 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -142,7 +142,7 @@ (define-public opencl-icd-loader
                (base32
                 "0q3hj2b3vw0mdzbizbd8jnrcjgmiyql2c4sgv83x255p9gb1qp60"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f)) ; Tests need stub loader setup.
+    (arguments (list #:tests? #f)) ; Tests need stub loader setup.
     (native-search-paths
      (list (search-path-specification
             (variable "OCL_ICD_VENDORS")
-- 
2.46.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Fri, 02 May 2025 04:42:02 GMT) Full text and rfc822 format available.

Message #59 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v4 1/5] gnu: opencl-headers,
 opencl-clhpp and opencl-icd-loader: Replace version with
 %opencl-sdk-version.
Date: Fri,  2 May 2025 08:40:05 +0400
These packages must be updated together. Therefore, we use a common version
variable.

* gnu/packages/opencl.scm (%opencl-sdk-version): New variable.
(opencl-headers)[version]: Replace with %opencl-sdk-version.
(opencl-clhpp)[version]: Likewise.
(opencl-icd-loader)[version]: Likewise.

Change-Id: I2cf25e2e7b951f0c0ff54a48c4e4a4fb470bff6a
---
 gnu/packages/opencl.scm | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 11a2c43b63c..6071617fd1a 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -54,13 +54,16 @@ (define-module (gnu packages opencl)
 ;; tests that require such devices are all disabled.
 ;; Check https://lists.gnu.org/archive/html/guix-devel/2018-04/msg00293.html
 
-;; If you update either of opencl-headers, opencl-clhpp or opencl-icd-loader
-;; note that they are released together (lockstep) and must be updated
-;; together.
+;; The packages opencl-headers, opencl-clhpp and opencl-icd-loader are released
+;; together (lockstep) and must be updated together. The following variable
+;; facilitates that.
+
+(define %opencl-sdk-version "2023.02.06")
+
 (define-public opencl-headers
   (package
     (name "opencl-headers")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source
       (origin
         (method git-fetch)
@@ -101,7 +104,7 @@ (define-public opencl-headers-1.0
 (define-public opencl-clhpp
   (package
     (name "opencl-clhpp")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source
      (origin
        (method git-fetch)
@@ -130,7 +133,7 @@ (define-public opencl-clhpp
 (define-public opencl-icd-loader
   (package
     (name "opencl-icd-loader")
-    (version "2023.02.06")
+    (version %opencl-sdk-version)
     (source (origin
               (method git-fetch)
               (uri (git-reference

base-commit: b2b7d2a3275d5ba866ae7fecac928ed4bd416beb
-- 
2.49.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Fri, 02 May 2025 04:43:01 GMT) Full text and rfc822 format available.

Message #62 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v4 2/5] gnu: %opencl-sdk-version: Update to 2024.10.24.
Date: Fri,  2 May 2025 08:40:06 +0400
This updates opencl-headers, opencl-clhpp and opencl-icd-loader.

* gnu/packages/opencl.scm (opencl-headers)[source]: Update hash.
[home-page]: Update URL.
(opencl-clhpp)[source]: Update hash.
(opencl-icd-loader)[source]: Update hash. Update origin URI to fix lint.

Change-Id: I674fc8aa79d1d98bac7ff66ba3a0e0fcb9b243cb
---
v4: Updated to latest version

 gnu/packages/opencl.scm | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 6071617fd1a..470c7506a69 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -58,7 +58,7 @@ (define-module (gnu packages opencl)
 ;; together (lockstep) and must be updated together. The following variable
 ;; facilitates that.
 
-(define %opencl-sdk-version "2023.02.06")
+(define %opencl-sdk-version "2024.10.24")
 
 (define-public opencl-headers
   (package
@@ -72,13 +72,13 @@ (define-public opencl-headers
               (commit (string-append "v" version))))
         (file-name (git-file-name name version))
         (sha256
-         (base32 "1jxpx15gwxc6i7vp64xlzcxf57nl0qnaiip6jyr0j7iji47dm404"))))
+         (base32 "0c3s6g8b3ggfr36cl27axdf3kn79kj6cb880jizcf6q89nw6nf98"))))
     (build-system cmake-build-system)
     (arguments `(#:tests? #f)) ; Not enabled during build.
     (synopsis "The Khronos OpenCL headers")
     (description
      "This package provides the C headers by Khronos for OpenCL programming.")
-    (home-page "https://www.khronos.org/registry/OpenCL/")
+    (home-page "https://registry.khronos.org/OpenCL/")
     (license license:asl2.0)))
 
 (define (make-opencl-headers major-version subversion)
@@ -112,7 +112,7 @@ (define-public opencl-clhpp
              (url "https://github.com/KhronosGroup/OpenCL-CLHPP")
              (commit (string-append "v" version))))
        (sha256
-        (base32 "1m3v5apjv3qagym32xqg38pq6i8j5d8svz11clsx408nrlyngrj0"))
+        (base32 "1s9z30p80qc1dgp04wvc6szgcs4r167m3nk9622d2bbaaalgd5vg"))
        (file-name (git-file-name name version))))
     (native-inputs
      `(("python" ,python-wrapper)))
@@ -137,12 +137,12 @@ (define-public opencl-icd-loader
     (source (origin
               (method git-fetch)
               (uri (git-reference
-                    (url "https://github.com/KhronosGroup/OpenCL-ICD-Loader.git")
+                    (url "https://github.com/KhronosGroup/OpenCL-ICD-Loader")
                     (commit (string-append "v" version))))
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "1cmbcm6bz6kfvr0dy9hzf2vgfwcz8gbm8rxspqqpva6z74dz0qxr"))))
+                "0rnyx83iwisxfj818dzf016fmi62kk1hrlfav0b8a1pjfbzmvr03"))))
     (build-system cmake-build-system)
     (arguments `(#:tests? #f)) ; Tests need stub loader setup.
     (native-search-paths
-- 
2.49.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Fri, 02 May 2025 04:43:02 GMT) Full text and rfc822 format available.

Message #65 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v4 3/5] gnu: opencl-clhpp: Update package style.
Date: Fri,  2 May 2025 08:40:07 +0400
* gnu/packages/opencl.scm (opencl-clhpp): [native-inputs]: Remove labels.
[arguments]: Use G-expressions.

Change-Id: I9c61aad824b5a57f941853635f30d2ec2dad38d8
---
v4: Rebased

 gnu/packages/opencl.scm | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 470c7506a69..d1f9b885f3b 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -115,14 +115,16 @@ (define-public opencl-clhpp
         (base32 "1s9z30p80qc1dgp04wvc6szgcs4r167m3nk9622d2bbaaalgd5vg"))
        (file-name (git-file-name name version))))
     (native-inputs
-     `(("python" ,python-wrapper)))
+     (list python-wrapper))
     (propagated-inputs
      (list opencl-headers))
     (arguments
-     `(#:configure-flags (list "-DBUILD_EXAMPLES=OFF" "-DBUILD_TESTS=OFF"
-                               "-DBUILD_TESTING=OFF") ;; CTest needs this to be turned off
-       ;; The regression tests require a lot more dependencies.
-       #:tests? #f))
+     (list #:configure-flags #~(list "-DBUILD_EXAMPLES=OFF"
+                                     "-DBUILD_TESTS=OFF"
+                                     ;; CTest needs this to be turned off
+                                     "-DBUILD_TESTING=OFF")
+           ;; The regression tests require a lot more dependencies.
+           #:tests? #f))
     (build-system cmake-build-system)
     (home-page "https://github.khronos.org/OpenCL-CLHPP/")
     (synopsis "Khronos OpenCL-CLHPP")
-- 
2.49.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Fri, 02 May 2025 04:43:02 GMT) Full text and rfc822 format available.

Message #68 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v4 4/5] gnu: opencl-headers: Update package style.
Date: Fri,  2 May 2025 08:40:08 +0400
* gnu/packages/opencl.scm (opencl-headers)[arguments]: Use G-expressions.

Change-Id: I3704206aa0d92dafc99953753914f5090192785d
---
v4: Rebased

 gnu/packages/opencl.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index d1f9b885f3b..079d8e2230e 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -74,7 +74,7 @@ (define-public opencl-headers
         (sha256
          (base32 "0c3s6g8b3ggfr36cl27axdf3kn79kj6cb880jizcf6q89nw6nf98"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f)) ; Not enabled during build.
+    (arguments (list #:tests? #f)) ; Not enabled during build.
     (synopsis "The Khronos OpenCL headers")
     (description
      "This package provides the C headers by Khronos for OpenCL programming.")
-- 
2.49.0





Information forwarded to guix-patches <at> gnu.org:
bug#70252; Package guix-patches. (Fri, 02 May 2025 04:43:03 GMT) Full text and rfc822 format available.

Message #71 received at 70252 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252 <at> debbugs.gnu.org
Cc: Ahmad Draidi <a.r.draidi <at> redscript.org>
Subject: [PATCH v4 5/5] gnu: opencl-icd-loader: Update package style.
Date: Fri,  2 May 2025 08:40:09 +0400
* gnu/packages/opencl.scm (opencl-icd-loader)[arguments]: Use G-expressions.

Change-Id: I0d2e2a6e1b267d01c75ea560c8ef7fde12fdec4a
---
v4: Rebased

 gnu/packages/opencl.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index 079d8e2230e..433a2bef850 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -146,7 +146,7 @@ (define-public opencl-icd-loader
                (base32
                 "0rnyx83iwisxfj818dzf016fmi62kk1hrlfav0b8a1pjfbzmvr03"))))
     (build-system cmake-build-system)
-    (arguments `(#:tests? #f)) ; Tests need stub loader setup.
+    (arguments (list #:tests? #f)) ; Tests need stub loader setup.
     (native-search-paths
      (list (search-path-specification
             (variable "OCL_ICD_VENDORS")
-- 
2.49.0





Reply sent to Ahmad Draidi <a.r.draidi <at> redscript.org>:
You have taken responsibility. (Sun, 25 May 2025 12:19:02 GMT) Full text and rfc822 format available.

Notification sent to Ahmad Draidi <a.r.draidi <at> redscript.org>:
bug acknowledged by developer. (Sun, 25 May 2025 12:19:02 GMT) Full text and rfc822 format available.

Message #76 received at 70252-done <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 70252-done <at> debbugs.gnu.org
Date: Sun, 25 May 2025 16:18:40 +0400
Migrated to Codeberg here: https://codeberg.org/guix/guix/pulls/3





This bug report was last modified 22 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.