From unknown Fri Jun 20 07:15:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70249 <70249@debbugs.gnu.org> To: bug#70249 <70249@debbugs.gnu.org> Subject: Status: [PATCH] gnu: open-ssh-session: =?UTF-8?Q?Don=E2=80=99t?= require public key. Reply-To: bug#70249 <70249@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:15:28 +0000 retitle 70249 [PATCH] gnu: open-ssh-session: Don=E2=80=99t require public k= ey. reassign 70249 guix-patches submitter 70249 Ian Eure severity 70249 normal tag 70249 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 19:17:31 2024 Received: (at submit) by debbugs.gnu.org; 6 Apr 2024 23:17:31 +0000 Received: from localhost ([127.0.0.1]:41254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtFHv-0002nz-3I for submit@debbugs.gnu.org; Sat, 06 Apr 2024 19:17:31 -0400 Received: from lists.gnu.org ([2001:470:142::17]:60246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtFHr-0002ne-D2 for submit@debbugs.gnu.org; Sat, 06 Apr 2024 19:17:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtFHe-0007dZ-Sy for guix-patches@gnu.org; Sat, 06 Apr 2024 19:17:14 -0400 Received: from fhigh7-smtp.messagingengine.com ([103.168.172.158]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rtFHc-000889-S1 for guix-patches@gnu.org; Sat, 06 Apr 2024 19:17:14 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 247871140090; Sat, 6 Apr 2024 19:17:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 06 Apr 2024 19:17:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :subject:subject:to:to; s=fm1; t=1712445431; x=1712531831; bh=H8 xkMWxqj56JOSz0jLl+1hDUmWy0IK0cxa5Xdn791RM=; b=JOzoUXvsIGouG8waif rzZQEIRPEem1+hh09ZdNbaEEv3rw6leFAnGa+zgCn1ZQe4AcrNWsLAAfLKIpXSM4 2fVzoMBk4BYQNTn4iZATWYIJKS4RXiEruhQQyWXiCHMCMt877eSO9oCn+SJuDROF H8KxaDbEGQ4ldEdEpxtBmijmVeXpFFsEnrolnf0aXfQoiwi1InQp1S7jDUN3cLgR nbVYLr1OkJO5FvnW5BMdn6bC6TvphJrZsuadS7v0ZjEBRoVYmyubvWXQlt5//sTL C+FANOGRhJ3QBIZht3ikJ1NzzRiXD5ejTbP/jmjmgfqHL6C+OQu0GK4t3ZSdXnnh nbTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1712445431; x=1712531831; bh=H8xkMWxqj56JO Sz0jLl+1hDUmWy0IK0cxa5Xdn791RM=; b=jAZoD0mKXl+2lPBOAqPHCRUsZBSDo 8edja13HcLAKCMpHw/QoDeZq4Xa+oTVdJJr56qFwKp/fDcDXSdEelOAi7LBcPMNp JDSHNP9B1cuHCRAWI4fJY+saLXSz/7CzvG1prO+RnuAtswClkRfm7rkFC5/P4lfb c6EMNnR9RI3Q8f6g7Aej5P+YUz/ZSDZdlNpjHwpWFNnfjp2fyrufkRDYJoqqHltq YOFFEwKNt5rEbfCz4fCC0LS2MxbqqrvGa63zixfAfztfWUZO+bmgtaNU6qEyYGlv 91bDwAHCkm8fYfs3wlx6AsU3Lnt3y6SwqEW3M8hlK/ST5XrqeV0Qo4AEg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudegfedgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffogggtgfesthekre dtredtjeenucfhrhhomhepkfgrnhcugfhurhgvuceoihgrnhesrhgvthhrohhsphgvtgdr thhvqeenucggtffrrghtthgvrhhnpefgueekffejudfgvdevteelteeitdeuuddufffhue fhiefhjeetuefhgfettedvteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhep mhgrihhlfhhrohhmpehirghnsehrvghtrhhoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Apr 2024 19:17:09 -0400 (EDT) From: Ian Eure To: guix-patches@gnu.org Subject: [PATCH] =?UTF-8?q?gnu:=20open-ssh-session:=20Don=E2=80=99t=20requ?= =?UTF-8?q?ire=20public=20key.?= Date: Sat, 6 Apr 2024 16:17:06 -0700 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Debbugs-Cc: Christopher Baines , Josselin Poiret , Ludovic Courtès , Mathieu Othacehe , Ricardo Wurmus , Simon Tournier , Tobias Geerinckx-Rice Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=103.168.172.158; envelope-from=ian@retrospec.tv; helo=fhigh7-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding. Public keys aren’t required for client connections, and this binding is unused. The behavior of assuming a ".pub"-suffixed file exists in the same directory as the secret key is undocumented and surprising. Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359 --- guix/scripts/offload.scm | 3 --- 1 file changed, 3 deletions(-) diff --git a/guix/scripts/offload.scm b/guix/scripts/offload.scm index 137e3b5fe3..93e9d3759c 100644 --- a/guix/scripts/offload.scm +++ b/guix/scripts/offload.scm @@ -213,9 +213,6 @@ (define* (open-ssh-session machine #:optional max-silent-time) When MAX-SILENT-TIME is true, it must be a positive integer denoting the number of seconds after which the connection times out." (let ((private (private-key-from-file* (build-machine-private-key machine))) - (public (public-key-from-file - (string-append (build-machine-private-key machine) - ".pub"))) (session (make-session #:user (build-machine-user machine) #:host (build-machine-name machine) #:port (build-machine-port machine) base-commit: ab3731d255ff1ac8d6874bc0f68ad94f21f08e79 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 15:33:06 2024 Received: (at 70249-done) by debbugs.gnu.org; 7 Apr 2024 19:33:06 +0000 Received: from localhost ([127.0.0.1]:44723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtYGI-0003mT-6y for submit@debbugs.gnu.org; Sun, 07 Apr 2024 15:33:06 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43316) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtYGF-0003mB-Sj for 70249-done@debbugs.gnu.org; Sun, 07 Apr 2024 15:33:04 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 5B30C27BBEA; Sun, 7 Apr 2024 20:32:56 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id ba0f2981; Sun, 7 Apr 2024 19:32:56 +0000 (UTC) From: Christopher Baines To: Ian Eure Subject: Re: [bug#70249] [PATCH] gnu: open-ssh-session: =?utf-8?Q?Don?= =?utf-8?Q?=E2=80=99t?= require public key. In-Reply-To: (Ian Eure's message of "Sat, 6 Apr 2024 16:17:06 -0700") References: User-Agent: mu4e 1.12.2; emacs 29.3 Date: Sun, 07 Apr 2024 20:32:55 +0100 Message-ID: <87zfu5dl3s.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70249-done Cc: Josselin Poiret , Simon Tournier , Mathieu Othacehe , Ludovic =?utf-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , 70249-done@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ian Eure writes: > * guix/scripts/offload.scm (open-ssh-session): Delete `public' binding. > Public keys aren=E2=80=99t required for client connections, and this bind= ing is > unused. The behavior of assuming a ".pub"-suffixed file exists in the sa= me > directory as the secret key is undocumented and surprising. > > Change-Id: I9b532be2abe68dae0323e4ef6e1ceab1e5603359 > --- > guix/scripts/offload.scm | 3 --- > 1 file changed, 3 deletions(-) I can't see how this binding is used either, so I've pushed this to master as 298aed72a2a76be33f9a55bed22636acd7a4f9b9. Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYS9OdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XejmRAApmPt25lJFx4B3HelZHjjX6hDUHPjcGtT Fp6F99j4V5v25kLy3JwPT1cTISwkJ8nA06oHfsNOp9UiQZ+hTYYdlwWvXirDGpRh YFkXc9cYh85GBXwiIzU8GmXojho9onXTtHlOyKn8ABAxYKz7VJt5QpqJ2qOe9dqu OEXD0bcS/TpG8eKasWfZgKv8BrT0CgSgIKF3T1XgcHZHPd+6S70r7pHcizRmY2PW iS1e81YnuY05ljkYawxXxPB2vzPUIi6QsXNmrWm6MkYfZfDwaz0WfZv10tfXYgU3 8650JRcOAHpnkykSulkG1DxrcWq1u35yc2OlwQ+bR1/EzcJhhMWhwn+arZTOSmqH S7O4NsRaMuTbSrmuhBkcikQM8oD+EOUDN8BPFKmF8orWQl+h+awwcniiudCTemyS FlJroZOxJfMgmNgTRaJ15u58aL0qOM/zKgDrfUevVga3Km1cPezSvbxFqhCdIuOU G2UpefscS8w6oYYS8BRE1hGKZNjojLdRTsvJW/65F2J+PaoO4mf4+g3bzdzLYyt4 hPa3GX/tbvOJChTNGBVmE3FX6bcy3V00gaFIgyOFR/0VyKnpw01gFqKYbDXGIaNM 8efJm/t5zXZyVt8WoEtcuu/lY3xdDc7wVmUmoxHCJI/lDCJY062QfQj7fAhIgylo Ux9kblALUM0= =u0gD -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Jun 20 07:15:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 06 May 2024 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator