From unknown Sun Jun 15 01:09:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70240 <70240@debbugs.gnu.org> To: bug#70240 <70240@debbugs.gnu.org> Subject: Status: [PATCH] gnu: uefitool: Add extra outputs, correct typo Reply-To: bug#70240 <70240@debbugs.gnu.org> Date: Sun, 15 Jun 2025 08:09:04 +0000 retitle 70240 [PATCH] gnu: uefitool: Add extra outputs, correct typo reassign 70240 guix-patches submitter 70240 Ian Eure severity 70240 normal tag 70240 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 11:24:59 2024 Received: (at submit) by debbugs.gnu.org; 6 Apr 2024 15:24:59 +0000 Received: from localhost ([127.0.0.1]:40623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7ub-0003O5-OH for submit@debbugs.gnu.org; Sat, 06 Apr 2024 11:24:59 -0400 Received: from lists.gnu.org ([2001:470:142::17]:40634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt7uW-0003N8-B9 for submit@debbugs.gnu.org; Sat, 06 Apr 2024 11:24:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rt7uK-0005ht-1I for guix-patches@gnu.org; Sat, 06 Apr 2024 11:24:40 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rt7uH-0006zO-7R for guix-patches@gnu.org; Sat, 06 Apr 2024 11:24:39 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id F2DD25C007D; Sat, 6 Apr 2024 11:24:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 06 Apr 2024 11:24:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=retrospec.tv; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to; s=fm1; t=1712417072; x=1712503472; bh=ORdW7rKOJk9nDsUZPf64Y Jil7lmj2rXdY1qdB3vbiFM=; b=d6kDWABAJW3ymwMht3W+HDc5RIye1G8I7IYDj QtN8r/YJm9A9DNvwCNMwTI70rwvzsoyG+UVMa2UFpjFK39xMM3Mu+EFDKz155PAL KpkRbq7gjYdBa/yawGy9MWXhhf7vFH0KZ5puMOerLcJdtM0RPJuZISVzrjLN6F78 eUksaQh9OwTqTOr6pRbpUdLTO4Kg3fDlehLi1OQp64XdrXdr8in2sRBD1r8bOWCJ U+MZQNxZaXMek9LAwax2jcE6VFx76fBRlsodoCsTFeAIBogFN6W9hTzCckFGX9+a Bjqb6D4uetXdL1YqYrYzVbyycuFdBfKZ1DkU22TEntTeUz2aQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1712417072; x=1712503472; bh=ORdW7rKOJk9nDsUZPf64YJil7lmj 2rXdY1qdB3vbiFM=; b=C8YTg0M4YkIWh3xeHXASVFaLs0uFlPl8d/W0wLVepJQF /hBPF2KtHkf9vS1cc9AZWRdfucdtiMczPtkM06/WBdm8cAgWzT7Vq5Kz7H3W/PlC WFq65fYQMz1db7HUNjHfANNpAIQ3u6YTJ1+akMsbbsAa9Seh9MvoTLzLreYtN8cM 0hXPJSlC6qhtX8pYleBBzPGbONa47PWK5ewZhaVR4KZ5TimaIH04iK6wI9gLppPy 7FRap2KSaOV1vYYT+NdFj2o8VSctDNPgn3+fRRrH43/DI/KvSmS/NYAnlR8AL83y vxDeSv4kLSfRJ635haQaPFsH29qtbm0/Nbe3FfE1Ag== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudegvddgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefkrghnucfguhhrvgcuoehirghnsehrvghtrhhoshhpvggtrdht vheqnecuggftrfgrthhtvghrnhepffelteehgfeugeekteetuddufedvfeeuhfdtudffgf evueeutdejudetfedukeegnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehirghnsehrvghtrh hoshhpvggtrdhtvh X-ME-Proxy: Feedback-ID: id9014242:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 6 Apr 2024 11:24:32 -0400 (EDT) From: Ian Eure To: guix-patches@gnu.org Subject: [PATCH] gnu: uefitool: Add extra outputs, correct typo Date: Sat, 6 Apr 2024 08:24:00 -0700 Message-ID: X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=66.111.4.29; envelope-from=ian@retrospec.tv; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit Cc: Ian Eure X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) * gnu/packages/flashing-tools.scm (uefitool): Add UEFIPatch and UEFIReplace in addition to UEFITool; add outputs for them. Correct package description. Change-Id: I45ca03a71c463c91ab11e9dcd47971afc06724b7 --- gnu/packages/flashing-tools.scm | 46 ++++++++++++++++++++++++--------- 1 file changed, 34 insertions(+), 12 deletions(-) diff --git a/gnu/packages/flashing-tools.scm b/gnu/packages/flashing-tools.scm index 83a4c3e3e7..3787e9d32a 100644 --- a/gnu/packages/flashing-tools.scm +++ b/gnu/packages/flashing-tools.scm @@ -493,29 +493,51 @@ (define-public uefitool (source (origin (method git-fetch) (uri (git-reference - (url "https://github.com/LongSoft/UEFITool") - (commit version))) + (url "https://github.com/LongSoft/UEFITool") + (commit version))) (sha256 (base32 "1n2hd2dysi5bv2iyq40phh1jxc48gdwzs414vfbxvcharcwapnja")) (file-name (git-file-name name version)))) (build-system gnu-build-system) + (outputs '("out" "uefipatch" "uefireplace")) (arguments - `(#:phases - (modify-phases %standard-phases - (replace 'configure - (lambda _ - (invoke "qmake" "-makefile"))) - (replace 'install - (lambda* (#:key outputs #:allow-other-keys) - (install-file "UEFITool" (string-append (assoc-ref outputs "out") - "/bin"))))))) + (list + #:phases + #~(modify-phases %standard-phases + (replace 'configure + (lambda _ + (invoke "qmake" "-makefile"))) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (install-file "UEFITool" (string-append (assoc-ref outputs "out") + "/bin")))) + (add-after 'configure 'configure-extras + (lambda _ + (with-directory-excursion "UEFIPatch" + (invoke "qmake" "-makefile")) + (with-directory-excursion "UEFIReplace" + (invoke "qmake" "-makefile")))) + (add-after 'build 'build-extras + (lambda _ + (with-directory-excursion "UEFIPatch" + (invoke "make" "-j")) + (with-directory-excursion "UEFIReplace" + (invoke "make" "-j")))) + (add-after 'install 'install-extras + (lambda* (#:key outputs #:allow-other-keys) + (install-file "UEFIPatch/UEFIPatch" + (string-append (assoc-ref outputs "uefipatch") + "/bin")) + (install-file "UEFIReplace/UEFIReplace" + (string-append (assoc-ref outputs "uefireplace") + "/bin"))))))) (inputs (list qtbase-5)) (home-page "https://github.com/LongSoft/UEFITool/") (synopsis "UEFI image editor") (description "@code{uefitool} is a graphical image file editor for -Unifinished Extensible Firmware Interface (UEFI) images.") +Unified Extensible Firmware Interface (UEFI) images.") (license license:bsd-2))) (define-public srecord base-commit: ab3731d255ff1ac8d6874bc0f68ad94f21f08e79 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 15 04:58:33 2024 Received: (at 70240) by debbugs.gnu.org; 15 Apr 2024 08:58:33 +0000 Received: from localhost ([127.0.0.1]:36658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwIAZ-0003Da-8H for submit@debbugs.gnu.org; Mon, 15 Apr 2024 04:58:33 -0400 Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27]:51609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rwIAU-0003Cd-2M for 70240@debbugs.gnu.org; Mon, 15 Apr 2024 04:58:27 -0400 Received: from localhost (unknown [212.132.255.10]) by mira.cbaines.net (Postfix) with ESMTPSA id 6C48627BBE2; Mon, 15 Apr 2024 09:58:13 +0100 (BST) Received: from felis (localhost.lan [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 1b7d88e2; Mon, 15 Apr 2024 08:58:12 +0000 (UTC) From: Christopher Baines To: Ian Eure Subject: Re: [bug#70240] [PATCH] gnu: uefitool: Add extra outputs, correct typo In-Reply-To: (Ian Eure's message of "Sat, 6 Apr 2024 08:24:00 -0700") References: User-Agent: mu4e 1.12.2; emacs 29.3 Date: Mon, 15 Apr 2024 09:58:12 +0100 Message-ID: <87ttk30zq3.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70240 Cc: 70240@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Ian Eure writes: > * gnu/packages/flashing-tools.scm (uefitool): Add UEFIPatch and UEFIReplace in > addition to UEFITool; add outputs for them. Correct package description. > > Change-Id: I45ca03a71c463c91ab11e9dcd47971afc06724b7 > --- > gnu/packages/flashing-tools.scm | 46 ++++++++++++++++++++++++--------- > 1 file changed, 34 insertions(+), 12 deletions(-) > > diff --git a/gnu/packages/flashing-tools.scm b/gnu/packages/flashing-tools.scm > index 83a4c3e3e7..3787e9d32a 100644 > --- a/gnu/packages/flashing-tools.scm > +++ b/gnu/packages/flashing-tools.scm > @@ -493,29 +493,51 @@ (define-public uefitool > (source (origin > (method git-fetch) > (uri (git-reference > - (url "https://github.com/LongSoft/UEFITool") > - (commit version))) > + (url "https://github.com/LongSoft/UEFITool") > + (commit version))) > (sha256 > (base32 > "1n2hd2dysi5bv2iyq40phh1jxc48gdwzs414vfbxvcharcwapnja")) > (file-name (git-file-name name version)))) > (build-system gnu-build-system) > + (outputs '("out" "uefipatch" "uefireplace")) Is there a reason you have split the files across several outputs? Generally, unless there's a specific reason to do so, it's better to keep things simple and in one output. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmYc7CRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9Xc4jA//cgniHJSgwRoA771Uxqa5XihHtdIzkJrs YEzgVLjGwWeQYYb/bU7w8A0jIyF6xYg7nVgW4bC+q9oHNHlq1VxsoVOg8JIX55Kw g/kIyvuR1DYKRscilU6jDdJMZqiK88T9XdZDXwBSHiJ8AXW7KMzKXOlHuL9uOKvN twTFtDu5xjq+klJKMgOTmqgbGMdQI3zBkZHbK2tAVC6ldmaFbATaAXPHoxQamOEe 7OwYP6zo35PdMEIWA0oNqCVyjMrZAz59rfFG8nzH+DmCwa5vE+4Cz6IXVRBjpNq5 RzJDvf2NRaDaPBRfJ+DjhB/6/O533DN7i0Q1bhvGNoePKT4KmmJuQ+NIB2MxaeB3 eQm9KqaG+cGt6268KoZrPEWiP+wWP0/WnaoAUwQpPsBH7t0EHYtIgTweyr5z4UKO /8vlgaLqVI4dYuo+2AOJv4tVmQ3+mRvfeuBFIA3f9Va7Lyryrv4zlOLGCKKAQsjd XZcNlGHcvbsOgcNI0IcIW6M9NIgIgZ8A96dYSKRzpi25haZhjCnRSOsPgqg3Ah95 Sx3STq+2JmnWmjIaIQB1zu0QgVIoXBGw3fivVVWaM0BhJBXtS980iTQAhSv/DkWq 0eq6RMdwa98qGQL/2RXmdhhd1aN5BOoLhYmqUBFuXvAE8iRDX3hUvQsieDj7QSvF UxBVTAOKUjk= =Xasz -----END PGP SIGNATURE----- --=-=-=--