Subject: Re: [bug#70240] [PATCH] gnu: uefitool: Add extra outputs, correct typo

From: Christopher Baines <[email-masked]>
Date: Mon, 15 Apr 2024 09:58:12 +0100

Ian Eure <[email-masked]> writes:

> * gnu/packages/flashing-tools.scm (uefitool): Add UEFIPatch and UEFIReplace in
> addition to UEFITool; add outputs for them.  Correct package description.
>
> Change-Id: I45ca03a71c463c91ab11e9dcd47971afc06724b7
> ---
>  gnu/packages/flashing-tools.scm | 46 ++++++++++++++++++++++++---------
>  1 file changed, 34 insertions(+), 12 deletions(-)
>
> diff --git a/gnu/packages/flashing-tools.scm b/gnu/packages/flashing-tools.scm
> index 83a4c3e3e7..3787e9d32a 100644
> --- a/gnu/packages/flashing-tools.scm
> +++ b/gnu/packages/flashing-tools.scm
> @@ -493,29 +493,51 @@ (define-public uefitool
>      (source (origin
>                (method git-fetch)
>                (uri (git-reference
> -                     (url "https://github.com/LongSoft/UEFITool")
> -                     (commit version)))
> +                    (url "https://github.com/LongSoft/UEFITool")
> +                    (commit version)))
>                (sha256
>                 (base32
>                  "1n2hd2dysi5bv2iyq40phh1jxc48gdwzs414vfbxvcharcwapnja"))
>                (file-name (git-file-name name version))))
>      (build-system gnu-build-system)
> +    (outputs '("out" "uefipatch" "uefireplace"))

Is there a reason you have split the files across several outputs?

Generally, unless there's a specific reason to do so, it's better to
keep things simple and in one output.