GNU bug report logs - #70230
30.0.50; [PATCH] * lisp/master.el (master-says): check nil parameter

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70230: closed (30.0.50; [PATCH] * lisp/master.el
 (master-says): check nil parameter)
Date: Sun, 07 Apr 2024 06:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 07 Apr 2024 09:17:00 +0300
with message-id <86h6gd1yub.fsf <at> gnu.org>
and subject line Re: bug#70230: 30.0.50; [PATCH] * lisp/master.el (master-says): check nil parameter
has caused the debbugs.gnu.org bug report #70230,
regarding 30.0.50; [PATCH] * lisp/master.el (master-says): check nil parameter
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70230: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70230
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Lin Sun <sunlin7.mail <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] * lisp/master.el (master-says): check nil parameter
Date: Sat, 6 Apr 2024 00:05:29 +0000

[Message part 3 (text/plain, inline)]

Hi,

The `(master-says)' will trigger an unexpected error message with follow code:

(require 'master)
(master-says)

> Wrong type argument: stringp, nil

The patch tries checking the nil parameter before calling `get-buffer'
to avoid the unexpected err message.

Please help check it. Thanks.

Best regards
Lin

[0001-lisp-master.el-master-says-check-nil-parameter.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lin Sun <sunlin7.mail <at> gmail.com>
Cc: 70230-done <at> debbugs.gnu.org
Subject: Re: bug#70230: 30.0.50; [PATCH] * lisp/master.el (master-says): check
 nil parameter
Date: Sun, 07 Apr 2024 09:17:00 +0300

> From: Lin Sun <sunlin7.mail <at> gmail.com>
> Date: Sat, 6 Apr 2024 21:26:49 +0000
> Cc: 70230 <at> debbugs.gnu.org
> 
> Yes, the "Current buffer is not a master of any other buffer" is more accurate.
> The changed message path is attached.

Thanks, installed on master, and closing the bug.

P.S. Please in the future format the commit log message according to
our conventions, and also mention the bug number when known.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.