From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 01:25:43 2024 Received: (at submit) by debbugs.gnu.org; 6 Apr 2024 05:25:43 +0000 Received: from localhost ([127.0.0.1]:37948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsyYg-0006eF-Li for submit@debbugs.gnu.org; Sat, 06 Apr 2024 01:25:43 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56790) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsyYd-0006e0-HU for submit@debbugs.gnu.org; Sat, 06 Apr 2024 01:25:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsyYR-0001L3-Tc for guix-patches@gnu.org; Sat, 06 Apr 2024 01:25:27 -0400 Received: from mail-ed1-x543.google.com ([2a00:1450:4864:20::543]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsyYQ-0000Mq-2N for guix-patches@gnu.org; Sat, 06 Apr 2024 01:25:27 -0400 Received: by mail-ed1-x543.google.com with SMTP id 4fb4d7f45d1cf-56e480e770fso33365a12.3 for ; Fri, 05 Apr 2024 22:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712381123; x=1712985923; darn=gnu.org; h=mime-version:to:subject:date:from:message-id:from:to:cc:subject :date:message-id:reply-to; bh=zfRqnHJyYb6F281p+573BZQ/OdsUzncPxDOPW8bDvR0=; b=HpnzU4FkNjW9Fi4A0ezdRZfpvcjHoqIY4a/7U+AfBzY/blO3v8Edwla14/8q4FPXTV vLeCzq0Fq/NKSO2YxD9uEQRwiPHpcUm+6lZdqKfbObO4Wg7B38kxDD63JBc7eOTsOus5 LvNe/RH5LwlXGdUeD2EQczuXGjrzynltjhyml/FwjWeWkWKXIcrX5ewxCTl9YeT/r2F3 3vHPTig+9UtpWy8TNzAeOPOrdmBY8jC7KbPsSyzx99DT2uHNBHApNNMFDegO60DfNgqy ZRwzUyvy5fps23WacAt0bf3qo5SVyR8F+iwow6pUlGf1YJRrCYfMJrjBMezIdIhd7X89 dDnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712381123; x=1712985923; h=mime-version:to:subject:date:from:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zfRqnHJyYb6F281p+573BZQ/OdsUzncPxDOPW8bDvR0=; b=GP/VYhqjjokq9uW8X24ilvZ7fu//rp27xIwZfgkjeChvLxVo5q3SoxZGX54WfwGL/m 7w80nndUOrbjofej/oVcjOJoyPwD3yJiIOx0RCfJmuFbiq3HQPq5aNVljCscx9Mbe4mO qAD8hoQdHMDZ6rrXh7hbwRh2tKTxJq3LfBuckBtElFcTDSrOwKlJ1zFM/PWJE/OZ3uER QHaNHYBfM1ckTunTgiSuNuMmsscmJr6WEn4+bEkIYLTHDUyaGOx0ia+qG+cher6qshxx QGRcPl1qFB5CCFF5VH8IzqHEWcQrQZs/9u94smlYyb3UHjoAAgv/N5nSlX5njqmkIpor uJsw== X-Gm-Message-State: AOJu0YxyrroJS25B5Eij+bct2YDlSDWcc8cA1DAdiqEh5mcEOgcPccww 3L6Qj2a1W33+i7BjJcCi9Q8n9LEbkED7rSu0Zn1RrxrD8QXE2+UpLmoeSxcFsNg= X-Google-Smtp-Source: AGHT+IGI4t6zW2VZeBn5rRsHsyU1JKsdzX/o5wv7st9wBXnboepFQa3QtkVDm6bgRabYm1anozdK6Q== X-Received: by 2002:a17:907:7245:b0:a4e:768a:1445 with SMTP id ds5-20020a170907724500b00a4e768a1445mr2872788ejc.16.1712381123385; Fri, 05 Apr 2024 22:25:23 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id qx28-20020a170907b59c00b00a51a80028e8sm1340609ejc.65.2024.04.05.22.25.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 22:25:22 -0700 (PDT) Message-ID: <72ce110b29c2a54f369b3f95131811058fd2592b.1712380995.git.liliana.prikler@gmail.com> From: Liliana Marie Prikler Date: Sat, 6 Apr 2024 07:21:19 +0200 Subject: [PATCH] doc: Update gnome-desktop-configuration. X-Debbugs-Cc: liliana.prikler@gmail.com, maxim.cournoyer@gmail.com, rg@raghavgururajan.name, vivien@planete-kraus.eu to: guix-patches@gnu.org MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::543; envelope-from=liliana.prikler@gmail.com; helo=mail-ed1-x543.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, MALFORMED_FREEMAIL=1.049, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 3.0 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * doc/guix.texi (gnome-desktop-configuration): Fill in missing fields. [gnome]: Talk about the deprecation. --- Hi Guix, this patch updates the gnome-desktop-configuration documentation, that really ought to have been updated sooner. It does not quite match the auto-generated documentation, because I took some stylistic [...] Content analysis details: (3.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.1 MALFORMED_FREEMAIL Bad headers on message from free email service X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: * doc/guix.texi (gnome-desktop-configuration): Fill in missing fields. [gnome]: Talk about the deprecation. --- Hi Guix, this patch updates the gnome-desktop-configuration documentation, that really ought to have been updated sooner. It does not quite match the auto-generated documentation, because I took some stylistic [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.1 MALFORMED_FREEMAIL Bad headers on message from free email service -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager * doc/guix.texi (gnome-desktop-configuration): Fill in missing fields. [gnome]: Talk about the deprecation. --- Hi Guix, this patch updates the gnome-desktop-configuration documentation, that really ought to have been updated sooner. It does not quite match the auto-generated documentation, because I took some stylistic choices and went further in some places. There is IIRC already a bug report talking about this, but I cannot at the top of my head recall its number. Cheers doc/guix.texi | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index acfe60b47a..e856e95fb5 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -24818,10 +24818,42 @@ Desktop Services @deftp {Data Type} gnome-desktop-configuration Configuration record for the GNOME desktop environment. +Available @code{gnome-desktop-configuration} fields are: @table @asis -@item @code{gnome} (default: @code{gnome}) -The GNOME package to use. +@item @code{core-services} (type: list-of-packages) +A list of packages that the GNOME Shell and applications may rely on. + +@item @code{shell} (type: list-of-packages) +A list of packages that constitute the GNOME Shell, without +applications. + +@item @code{utilities} (type: list-of-packages) +A list of packages that serve as applications to use on top of the GNOME Shell. + +@item @code{gnome} (type: maybe-package) +This field used to be the only configuration point and specified +a GNOME meta-package to install system-wide. Since the meta-package +itself provides neither sources nor the actual packages and is only +used to propagate them, this field is deprecated. + +@item @code{extra-packages} (type: list-of-packages) +A list of GNOME-adjacent packages to also include. This field is +intended for users to add their own packages to their GNOME experience. +Note, that it already includes some packages that are considered +essential by some (most?) GNOME users. + +@item @code{udev-ignorelist} (default: @code{()}) (type: list-of-strings) +A list of regular expressions denoting udev rules or hardware file names +provided by any package that should not be installed. By default, every +udev rule and hardware file specified by any package referenced in the +other fields are installed. + +@item @code{polkit-ignorelist} (default: @code{()}) (type: list-of-strings) +A list of regular expressions denoting polkit rules provided by any +package that should not be installed. By default, every polkit rule +added by any package referenced in the other fields are installed. + @end table @end deftp base-commit: bfc614397b5f146056bda4b5a8e3a67bd1ca7b23 -- 2.41.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 11:50:52 2024 Received: (at 70228) by debbugs.gnu.org; 6 Apr 2024 15:50:52 +0000 Received: from localhost ([127.0.0.1]:40670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt8Jg-0005hV-1I for submit@debbugs.gnu.org; Sat, 06 Apr 2024 11:50:52 -0400 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:48163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rt8Jd-0005h9-Uu for 70228@debbugs.gnu.org; Sat, 06 Apr 2024 11:50:51 -0400 Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3c3d3710018so2018100b6e.0 for <70228@debbugs.gnu.org>; Sat, 06 Apr 2024 08:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712418637; x=1713023437; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=UfrmEwh9xkdt4jJQ8TjYyxqCc5j2JQ68wCdd4V0ujlg=; b=K7ck+TbL4E+G9PG9dfTpB6BnOW+DSn12crQ6PXsY3DCEdwa0emXknc8kjtDf5pmatn JN9/G6b/oG9d+mDX6t/R7ADXUqtFNIXL7KLbWRo3pIKzB9LgObQrYqSgqKJfG/58bikf VpKr7ZVXGekUsurqcaV4BYCYgmlh7lsvQxN+Coy/6A8C6NClhgHYTMkdb7/rkLbcMVrO jt7m+UhO56mZODXvZf4gZlNLLd1F1HXHpyWYifa7/JChj+mRiKDPWzaWbncmHJ7rpe3y hQ1LSFrdv9f1Rb5cW3062k/StPs38O7A4U4dEoo69Fe+qntLCHAjYN5shgS/V40E1zKe a1Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712418637; x=1713023437; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UfrmEwh9xkdt4jJQ8TjYyxqCc5j2JQ68wCdd4V0ujlg=; b=KB5glBKz7ONVXbtB5HwQb4UkYzzIkJeYH+/1iSJkwPsE26zJ+qBjRBQeLt9iJ/Xoev wQ9Fe/P+54geRVVER2tWIgnRVn7cFb8WCoVLU8ZCXhNejzNtcizmVG+sU44Uc8L+kiH5 k5WrhiDgY59wRy1LGOh4C0+ZhKO1lPrx9nxgpj6Pl21tTBrncJxCBQi5jvtHKusdcm3w sG7bsLeiWZczxOlH1T2H54dGxRExP1FANUHXocPVcy7wvEBOYX99srleX93chuchRlvh lNQgMauN7el8iUJVJ47hewiYNoyEz1kHwnpcNAVR9FsGD5WkC/TLs1KT9+ugOGGsCH/X DeRQ== X-Gm-Message-State: AOJu0YxbDuPniB6sF7VSGQKGTutHmQgOozf2oylaemUQaCaJxNALQvlr aCFBVp/ISS0i1ZklAQPwkNUBWJ1pMC9hnPtLgXPvOiRy8Pj1yf9E X-Google-Smtp-Source: AGHT+IHAbvLoJDcan4CW0x0Dkx+qmI4nMDWGIQ5gfMe6tx4YtBIXLzzyW93fUVkqahZo8wdM4vwiag== X-Received: by 2002:a05:6808:144d:b0:3c5:ebe6:1848 with SMTP id x13-20020a056808144d00b003c5ebe61848mr1152490oiv.47.1712418636837; Sat, 06 Apr 2024 08:50:36 -0700 (PDT) Received: from hurd (dsl-154-241.b2b2c.ca. [66.158.154.241]) by smtp.gmail.com with ESMTPSA id fu33-20020a05622a5da100b0042f04e421d2sm1846729qtb.24.2024.04.06.08.50.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 08:50:36 -0700 (PDT) From: Maxim Cournoyer To: Liliana Marie Prikler Subject: Re: [bug#70228] [PATCH] doc: Update gnome-desktop-configuration. In-Reply-To: <72ce110b29c2a54f369b3f95131811058fd2592b.1712380995.git.liliana.prikler@gmail.com> (Liliana Marie Prikler's message of "Sat, 6 Apr 2024 07:21:19 +0200") References: <72ce110b29c2a54f369b3f95131811058fd2592b.1712380995.git.liliana.prikler@gmail.com> Date: Sat, 06 Apr 2024 11:50:35 -0400 Message-ID: <871q7itrqs.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70228 Cc: 70228@debbugs.gnu.org, rg@raghavgururajan.name, vivien@planete-kraus.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Liliana, Liliana Marie Prikler writes: > * doc/guix.texi (gnome-desktop-configuration): Fill in missing fields. > [gnome]: Talk about the deprecation. > --- > Hi Guix, > > this patch updates the gnome-desktop-configuration documentation, > that really ought to have been updated sooner. It does not quite match > the auto-generated documentation, because I took some stylistic choices > and went further in some places. The long term plan (TM) is to have the auto-generated documentation truly auto-generated at build time. You should think of any extra edits manually made as possibly lost in the future, so it'd be best to either 1. edit the real source (docstrings) 2. fix the doc-generating macros if there's a problem worthy of addressing Otherwise, LGTM. -- Thanks, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 02:23:47 2024 Received: (at 70228) by debbugs.gnu.org; 7 Apr 2024 06:23:47 +0000 Received: from localhost ([127.0.0.1]:41439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtLwR-00042T-HL for submit@debbugs.gnu.org; Sun, 07 Apr 2024 02:23:47 -0400 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]:43362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtLwL-000412-BM for 70228@debbugs.gnu.org; Sun, 07 Apr 2024 02:23:46 -0400 Received: by mail-wm1-x343.google.com with SMTP id 5b1f17b1804b1-416422e2acbso2660365e9.1 for <70228@debbugs.gnu.org>; Sat, 06 Apr 2024 23:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712471008; x=1713075808; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=3PhXCdeiKAsKJDbLaHppHeNKcLGxCE8meRFB8CXJks0=; b=SfOrbgPJQ5jsKl+3xt1L4dytQWGi6hG3cJXdcwJ3kJnPwQuIV9ySoJ+XAxiN9N/EUw ptFKi1iJcgJHy6SlGOKbbO5uE95q/SY6AQPUNV7ugd3hZoB+4DxuNXML1IIE0A6jXi63 cLRnq0JAzRY5KaGhyUzt2DGOilN3dutAbfMI89lmswzikCiWUN2HXJFfeKFq7bEsoYSi OGxvhq3IhK4YzhXufY+Mbl5aLX4SrmCBUW3K3oYYDbmdDUhyfKsXmX/nGhp/remi+19K HnVty1UF/s07yPOhtuz0BEfsTFV1ngzu020m6VN5A1ZaCd/q98nwIvqcXn59pec7nfgu 7Dbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712471008; x=1713075808; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3PhXCdeiKAsKJDbLaHppHeNKcLGxCE8meRFB8CXJks0=; b=JFuHLhX48LrMD3x/rBu6Vpvaz4xJKUVj/eIMF+PF3mMnb1Q5hx2eDirIeGsUSrwQYV nhcnbhhivSO57GTeIiyRT3fCbVg7YFGJSGSNKZT5B+iB1Ujk9JPbp0v2TWUimA2Tpaka 1sGX8yZDrjuVEOZLYAC9jkI7Wbd5JLdGtDvHnsoOX5C+RR21iCfRjYLK6YmCUkU5borL 28Smpw9+jlMGVJAlpv5SVjTS8R/m5SqqE4UYglkfYLsiEzzlhBu/NjsDQhn5LGUVDU7t Rp+VtLpug/wWRm52LPDi/l9XJTawjJcYqaha+9lgTK+EMlYYT7yQdyNs3BCkkT2z3aPa 6RhA== X-Gm-Message-State: AOJu0Ywe+KySns8OC6v4+VPUGUQNzEwxsy/kzKRIlAPfiOpDFnloEb8j XuUdaxuV/NgPyVwZ4K3R1Qa8cI68J9cYMS7KfFfRvTtKhiwGGED3 X-Google-Smtp-Source: AGHT+IFqoJrwSCOIqlvmwfufn6dVTXsKmsiVfr9N0inHNucZfBitFtDSgWu5C+Jz+/rbphFemTD3Rg== X-Received: by 2002:a05:600c:444b:b0:416:551a:95ec with SMTP id v11-20020a05600c444b00b00416551a95ecmr523103wmn.20.1712471007491; Sat, 06 Apr 2024 23:23:27 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id s11-20020a05600c45cb00b004162d06768bsm9584935wmo.21.2024.04.06.23.23.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Apr 2024 23:23:26 -0700 (PDT) Message-ID: <9860b8ef787feca5deebf0f3281563b90eddd8ce.camel@gmail.com> Subject: Re: [bug#70228] [PATCH] doc: Update gnome-desktop-configuration. From: Liliana Marie Prikler To: Maxim Cournoyer Date: Sun, 07 Apr 2024 08:23:17 +0200 In-Reply-To: <871q7itrqs.fsf@gmail.com> References: <72ce110b29c2a54f369b3f95131811058fd2592b.1712380995.git.liliana.prikler@gmail.com> <871q7itrqs.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70228 Cc: 70228@debbugs.gnu.org, rg@raghavgururajan.name, vivien@planete-kraus.eu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Samstag, dem 06.04.2024 um 11:50 -0400 schrieb Maxim Cournoyer: > Hi Liliana, >=20 > Liliana Marie Prikler writes: >=20 > > * doc/guix.texi (gnome-desktop-configuration): Fill in missing > > fields. > > [gnome]: Talk about the deprecation. > > --- > > Hi Guix, > >=20 > > this patch updates the gnome-desktop-configuration documentation, > > that really ought to have been updated sooner.=C2=A0 It does not quite > > match the auto-generated documentation, because I took some > > stylistic choices and went further in some places. >=20 > The long term plan (TM) is to have the auto-generated documentation > truly auto-generated at build time.=C2=A0 You should think of any extra > edits manually made as possibly lost in the future, so it'd be best > to either >=20 > 1. edit the real source (docstrings) > 2. fix the doc-generating macros if there's a problem worthy of > addressing >=20 > Otherwise, LGTM. My edits concern a field that I'd like to see gone in that long-term future, so it's fine. Maybe I'm missing a record-level documentation field, though, because I'm also adding a line there. Cheers