GNU bug report logs - #70217
[PATCH] Add substring-partial-completion style

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Spencer Baugh <sbaugh <at> janestreet.com>
Subject: bug#70217: closed (Re: bug#70217: [PATCH] Add substring-partial-completion
 style)
Date: Sat, 24 Aug 2024 09:25:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#70217: [PATCH] Add substring-partial-completion style

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 70217 <at> debbugs.gnu.org.

-- 
70217: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70217
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Spencer Baugh <sbaugh <at> janestreet.com>
Cc: 70217-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#70217: [PATCH] Add substring-partial-completion style
Date: Sat, 24 Aug 2024 12:23:12 +0300

> From: Spencer Baugh <sbaugh <at> janestreet.com>
> Cc: 70217 <at> debbugs.gnu.org,  monnier <at> iro.umontreal.ca
> Date: Wed, 21 Aug 2024 12:16:15 -0400
> 
> Spencer Baugh <sbaugh <at> janestreet.com> writes:
> 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> >>> Eli, could you please install this patch, then?
> >>
> >> I tried, but it no longer applies cleanly.  Could you please rebase
> >> and repost?
> >
> > Rebased on trunk:
> 
> Oops, also updated the commit message:

Thanks, installed on master, and closing the bug.

[Message part 3 (message/rfc822, inline)]

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: bug-gnu-emacs <at> gnu.org
Cc: monnier <at> iro.umontreal.ca
Subject: [PATCH] Add substring-partial-completion style
Date: Fri, 05 Apr 2024 08:41:47 -0400

[Message part 4 (text/plain, inline)]

Tags: patch


The substring completion style completes "foo-bar" as "*foo-bar*".
The partial-completion completion style completes "foo-bar" as
"foo*bar*".

It is currently not possible to get completion as "*foo*bar*",
e.g. combining the two.

This patch adds a completion style that combines the two.  (It's a bit
rough right now, just a quick implementation, will clean it up with
feedback)

It's preferable for this to be a separate style from partial-completion
rather than a customization for partial-completion, because completing
with a leading glob is inefficient: it doesn't allow the completion
table to do any filtering at all.  So, for example, one might want the
regular partial-completion style to run first, and if it doesn't find
anything then the substring-partial-completion style can run.

Further claim: I think the substring completion style should be replaced
with the substring-partial-completion style in most places.  But that
may be a bit more controversial.

In GNU Emacs 29.2.50 (build 6, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.15.12, Xaw scroll bars) of 2024-03-25 built on
 igm-qws-u22796a
Repository revision: 5d867aca5ea016c07fe9e8b60f55345f83012333
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12011000
System Description: Rocky Linux 8.9 (Green Obsidian)

Configured using:
 'configure -C --with-x-toolkit=lucid --with-native-compilation
 --with-gif=ifavailable'

[0001-Add-substring-partial-completion-style.patch (text/patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.