From unknown Thu Aug 14 21:46:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70193 <70193@debbugs.gnu.org> To: bug#70193 <70193@debbugs.gnu.org> Subject: Status: eglot: RFE: recenter buffer upon showDocument request Reply-To: bug#70193 <70193@debbugs.gnu.org> Date: Fri, 15 Aug 2025 04:46:13 +0000 retitle 70193 eglot: RFE: recenter buffer upon showDocument request reassign 70193 emacs submitter 70193 Alan Donovan severity 70193 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 09:17:49 2024 Received: (at submit) by debbugs.gnu.org; 4 Apr 2024 13:17:49 +0000 Received: from localhost ([127.0.0.1]:60832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsMyT-0004YL-Br for submit@debbugs.gnu.org; Thu, 04 Apr 2024 09:17:49 -0400 Received: from lists.gnu.org ([2001:470:142::17]:35794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsMyQ-0004XS-TQ for submit@debbugs.gnu.org; Thu, 04 Apr 2024 09:17:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsMyF-000863-Kh for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:17:35 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsMyA-0007N3-DX for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 09:17:33 -0400 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-1e2add0b990so112405ad.0 for ; Thu, 04 Apr 2024 06:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712236647; x=1712841447; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=Yirw83qEKFLjPIFTag5/4dGsiBHnfqbUeDEBhpn2TVY=; b=Kr3c1JPI4RQ1bFKLsB9vBu97MaRK1kU2MphbTrYdidGhib4LM8+eVd26+9/w46apKR eLxf6Tsb9/mF4clCS3nEquwY8hlyNR87NszCn7I8JwQwvNEPxCaP9ZAAa7gTLA34UJub QvL0UhEMjmj92Epm9fXDFGA4Zt+vyv1BQD9+uGg429JRaT8rXFjJL4iJJonSk42TkWUD jCg4vzDuewD9oDrRLjzv/aQVTOq1+qsXJ/U7Fa9QEHc9OQJH2Uqx44hXX3EOJ1UMRcfA nDHlBDRKMBjcOfdFHj5pRVZrlqD4YkJXtSXStPytod93DYU0bIPIKCsCnuL5zAmxTZqH vbZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712236647; x=1712841447; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Yirw83qEKFLjPIFTag5/4dGsiBHnfqbUeDEBhpn2TVY=; b=C8MSHRPiQOZiWMc8sBv2wWE9XGMhLDXd+FGcKkZfBDQ9FBMUiYat7r0MFb4WyBOedt R2LVtrvfPK971Jepz/0Ft4mghWbSHWxFT0FpM3cvCVYGYd7Ooa1pEXtad0kqOASA1fe7 FNKCW7obyhQTj6l243m+5fQeJCb1DmDkAJHy/MxMedT7/x657VF5T7+Vw5YM5mm3uHje fBC3prKAPyAbGx6GhUOUmZyiG7JAMBb4QNUu2vzTW5TCst4kx/ZSpHSrWPJz86aNguSQ QjRL0ME0huoPql9jBlM+7JQUfRglY8J4zJpRatW+zMY0XgVSuDrEwgEOXFUE/aD8HIsr hp4Q== X-Gm-Message-State: AOJu0YzGHkC+oq9NQazTzbcxSh8n+MvGFBGGxFsg/ehhz2E4TFovcam9 n4zVfrcKU4Y492s69eDVi/C+mzm4UGyoijdHhAhKIAkWSu1FGntJ+9PfUserDs04NlT7wmv0Ng6 h38VSPSJBkx1lBcA8icyIv4Qr5W6YaoiL79c6RZEBk7H0B+yy38Ad X-Google-Smtp-Source: AGHT+IGmgbQXLvW/ZIq65Awk2ljjU2+S0jEDTAMHlVLniDHFUHBy36gP3NBio6jKzIozUNYCnll84GIA7hO9VFj3CVA= X-Received: by 2002:a17:903:1d1:b0:1e0:b385:838f with SMTP id e17-20020a17090301d100b001e0b385838fmr79279plh.1.1712236646740; Thu, 04 Apr 2024 06:17:26 -0700 (PDT) MIME-Version: 1.0 From: Alan Donovan Date: Thu, 4 Apr 2024 09:17:13 -0400 Message-ID: Subject: eglot: RFE: recenter buffer upon showDocument request To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=adonovan@google.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) In eglot 1.17, the LSP showDocument downcall opens the designated file, moves the cursor to the designated position, and raises the frame. One other thing it could do to make it easier to see where the cursor is would be to recenter the buffer. The patch below is a minimal fix; the discussion at https://github.com/joaotavora/eglot/discussions/1382 suggests a couple of possible refinements. xtools$ git diff ~/.emacs.d/elpa/eglot-1.17/eglot.el{.bak,} --- elpa/eglot-1.17/eglot.el.orig +++ elpa/eglot-1.17/eglot.el @@ -2460,6 +2460,7 @@ THINGS are either registrations or unregisterations (sic)." ;; function, but `xref--goto-char' happens to have ;; exactly the semantics we want vis-a-vis widening. (xref--goto-char beg) + (recenter) (pulse-momentary-highlight-region beg end 'highlight))))))) (t (setq success :json-false))) `(:success ,success))) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 09:32:59 2024 Received: (at 70193) by debbugs.gnu.org; 4 Apr 2024 13:32:59 +0000 Received: from localhost ([127.0.0.1]:60872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsND9-0006BS-F9 for submit@debbugs.gnu.org; Thu, 04 Apr 2024 09:32:59 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]:35891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsND8-0006Aa-8i for 70193@debbugs.gnu.org; Thu, 04 Apr 2024 09:32:59 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1e28d7b03e9so176555ad.0 for <70193@debbugs.gnu.org>; Thu, 04 Apr 2024 06:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712237567; x=1712842367; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VJ0GRwLBeVFy7VvWrPreoJDWccJlvvMbs3SvA3sL430=; b=p+78xC8H/rZtG4jbdr65Sz3Zn+7RAQfLG5ezddRTV4lF88bWmNDZjEWhHJ46tZ/9Wq ETJjhPWLlgPz2fQ89pXmPghHICejufqqzBFhRojDgiOUZQfze4ZSxnKNbfEwoVyLfmrP gqWeZ5B6I9L3lbnqgBHaNdmVS7ccZuFtWxl3AdT2MPnDP+gQadA0HuHhI/JC+furTCqB dfon+3QZrag7kWYes0Pd9phYeikeMNbeE/k/81skpTucIFNPKQ11UZyEY0zl50nVS9YT obFfwm8MzsS8ythVasLHJ33N1pwU0/5i6gegipuTB4Nd7bOFCGoHfu9rS2pFeZd33Rsp V6ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712237567; x=1712842367; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VJ0GRwLBeVFy7VvWrPreoJDWccJlvvMbs3SvA3sL430=; b=UUVNf22AwY57bUc5FYB+V1/idXyVVocphSGpINm8W1qmG0iltxJkugsh7Ehfxv/LoR CG4S6bO6NhXf4Q8RJZ0xshCbrmGFOXG/NYh2yjUGyllLBLPxFSgE8lyDwHdN4s3qOPTb Pwk1D+vZlqzVAHhNMcMGzjtsXNZ4qcx5UEXqpL8s45Azi4J4R5K+FuF7BXlbrYOgqsNh xXeDB/vm6MjBQ/SH7EqVZVqkNS0qyXnBrsWgKLDvBRE4ORqbqNjcDJsLmLCZq1rDMxci PEQ1Cb+p0C5Jvsr8gFzA2ySur9VvdmuaTa7OGHpNkQ8dj/xbtHVYCWYjAk9CWBvdHlcx UuwA== X-Gm-Message-State: AOJu0YwgP4j3qxhPdY/yNJz81USVfF55NUxprHMXe80+7gRVCI3kEaKY f/jZoVIQfu/l+YPR85aCgeE5caEdn2yGKOLrxbm9f5mqnWbt+nhVvNNGELAo+1kbUs0WDAMLvOn BYWSE9PJfuvGAMpi5/PjZAUxPtm2LKpiBXFZ89zxkvqYHFODlJrtD X-Google-Smtp-Source: AGHT+IFEMqxS2qbgI0XDrbGvS7ckkyVJS1ckUY0SPnHr7zLFcb0XGViMp++j+6xpKU3j1Q+Dqj5kHPKTwDHT76KUiTY= X-Received: by 2002:a17:903:32ca:b0:1e0:c571:d652 with SMTP id i10-20020a17090332ca00b001e0c571d652mr86371plr.1.1712237566805; Thu, 04 Apr 2024 06:32:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alan Donovan Date: Thu, 4 Apr 2024 09:32:35 -0400 Message-ID: Subject: Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) To: 70193@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 70193 Cc: rudalics@gmx.at X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) +cc Martin Rudalics (as suggested by Joao Tavora) On Thu, 4 Apr 2024 at 09:17, Alan Donovan wrote: > > In eglot 1.17, the LSP showDocument downcall opens the designated > file, moves the cursor to the designated position, and raises the > frame. One other thing it could do to make it easier to see where the > cursor is would be to recenter the buffer. > > The patch below is a minimal fix; the discussion at > https://github.com/joaotavora/eglot/discussions/1382 suggests a couple > of possible refinements. > > xtools$ git diff ~/.emacs.d/elpa/eglot-1.17/eglot.el{.bak,} > --- elpa/eglot-1.17/eglot.el.orig > +++ elpa/eglot-1.17/eglot.el > @@ -2460,6 +2460,7 @@ THINGS are either registrations or > unregisterations (sic)." > ;; function, but `xref--goto-char' happens to have > ;; exactly the semantics we want vis-a-vis widening. > (xref--goto-char beg) > + (recenter) > (pulse-momentary-highlight-region beg end 'highlight))))))) > (t (setq success :json-false))) > `(:success ,success))) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 04 10:43:39 2024 Received: (at 70193) by debbugs.gnu.org; 4 Apr 2024 14:43:39 +0000 Received: from localhost ([127.0.0.1]:34489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsOJX-0004ns-2c for submit@debbugs.gnu.org; Thu, 04 Apr 2024 10:43:39 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:57490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsOJT-0004n8-DR for 70193@debbugs.gnu.org; Thu, 04 Apr 2024 10:43:37 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-516cbf3fd3dso978374e87.2 for <70193@debbugs.gnu.org>; Thu, 04 Apr 2024 07:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712241804; x=1712846604; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=bxK4qjvDRU+zrzxSgtHl/osFbkxXd6C3OjpdjNeOChU=; b=QXUGGKo1lOFTWyYgyXnAQ6hjZacVAA1SEw2s6TNy4Cyt8zJ+UnGkbSGkCQeJLZnItD Ej4VTWRLWz1LzFW3d6N+kp2anevQZVvFjOnVez+JmQiJ5CGFRXXQP8F/QFjMFHrV6TfV MxO8b8+m2fxrLI5/1CGnwS6iO3iTWpp7/5J8+DqxjhBs1Z96wrtO1eXhHUUNgsZlmrDA h3B0hvfy9aEL+xLe7krOna5Kpw4KTbZ2oQV22Ud/VhvhYVwAC5F/0LdwBw5e4w1NRgzW c8tM6n4SUDOxj3wkdNVWy8MuV25wXakZcgSdIdVqvyJFziE1CowiXd59PVhdRRe8AcTh SVaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712241804; x=1712846604; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bxK4qjvDRU+zrzxSgtHl/osFbkxXd6C3OjpdjNeOChU=; b=q/Wexeq8qfrzvZgPL76XdlK+2tpxaLJeY+t9sLiUzm0TlYepuw0Knx2jLwlLNZgKve /JNwnOKo2T2cvObFX+5fUJvkSkoD6mO9x34y0aNufJuk8mwAWis4nDlav+DV+MLIdSl8 swLuP9ZAjdvrolvP4WXCaLSS1ub77Vx26VF8ndpqtnPcepynYsLHkvWGm2mEhDRIfBjZ YVELmtUuxZMLQNXqt1x0hesfTaOVxPdJnJnqbOqf+xZT7AKMwIXETolUu+Whnaptr7cU FL8x4KW0QXOUSlKNPmG5/zPbXhI4fmrrzNl22iTCz7fBTk+Y2v7RnWYWOwZV05TRWryS j9TA== X-Gm-Message-State: AOJu0YxZIYbSRWZRR8z0S4O5cTEO4pvVatoRj3ScIs2NEXdwlTvbbA8v m+wmCFvqBvU9OAfhnwf+wugmjQ34syX8oNog7ryY28plDXgm7Z4C X-Google-Smtp-Source: AGHT+IHZRODFiRyyCucepAXLuCbtbyoWC6AMAi8MRgqgruLvUhWgK4uiPoJAQ9h0Qhvt/ULUrJB1gQ== X-Received: by 2002:ac2:4902:0:b0:516:a31d:6fbf with SMTP id n2-20020ac24902000000b00516a31d6fbfmr2023503lfi.18.1712241800239; Thu, 04 Apr 2024 07:43:20 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id dq4-20020a170907734400b00a4e2a09efcasm8579857ejc.217.2024.04.04.07.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Apr 2024 07:43:19 -0700 (PDT) From: Felician Nemeth To: 70193@debbugs.gnu.org Subject: Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) References: Date: Thu, 04 Apr 2024 16:43:18 +0200 In-Reply-To: (Alan Donovan via's message of "Thu, 4 Apr 2024 09:32:35 -0400") Message-ID: <871q7lgpdl.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70193 Cc: rudalics@gmx.at, Alan Donovan X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> the discussion at >> https://github.com/joaotavora/eglot/discussions/1382 I'd like to repeat the patched code may behave worse. So, I don't think it is a good idea to merge it in its current form. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 05:08:19 2024 Received: (at 70193) by debbugs.gnu.org; 5 Apr 2024 09:08:20 +0000 Received: from localhost ([127.0.0.1]:35189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsfYX-0004eR-3L for submit@debbugs.gnu.org; Fri, 05 Apr 2024 05:08:19 -0400 Received: from mout.gmx.net ([212.227.15.19]:46877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsfYS-0004dr-89 for 70193@debbugs.gnu.org; Fri, 05 Apr 2024 05:08:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1712308079; x=1712912879; i=rudalics@gmx.at; bh=HWrP7mxGeAuiPBVqdSgtaQntL2XOpLHNtE6VLFXvpuU=; h=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To; b=IawPh9G96t2aH4q3R2YuNabQKUjANWN5cvOUbrAbMkbSe8Q2wI8kUQ93lJfTIEWe UVUtG80jowNaQffHJfPgtd41J2gdClWxr0yJSLQdt1OF/dLB5SnsFZ4vTzz/vHNAs wS4uoZwuFdDVG1ai/RaRPRY6TUs2o74JConCkD9yyPgDusd3+pn3XtqU3IiVzIXuc kYPdV5mUMCnOa873MAQXX/gPIk3JzaN311sWkDyBjX/md+piwfCAn5GZHlILbNIjT IDb15AukGJAg4NzhsRRVvPj0Usz7Jpjc3O1UvR7t9fRPvKj400PreOTmNlMeao6es yULvgWfzRMgcX5GvwQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([213.142.97.167]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MulqD-1siZLg1qWx-00rtSu; Fri, 05 Apr 2024 11:07:59 +0200 Content-Type: multipart/mixed; boundary="------------lXBjr9cet293ndfYxwmW02L2" Message-ID: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> Date: Fri, 5 Apr 2024 11:07:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) To: Alan Donovan , 70193@debbugs.gnu.org References: Content-Language: en-US From: martin rudalics In-Reply-To: X-Provags-ID: V03:K1:aq+qMegcUzW6QxxmMHuRV8l4a09lGs/DI8MytilixEwy+l/IkTs lwyLRsxj0s9F3MdSSA18JY8L89OXeOmTPYVyYsX1EIK+qonSZtNxMZBp79+hFkdFUKaFaxn z6hiO0RO21FcRrYMVV6r3Qvd/imJk7wKhkPsQnI9EmsPhR308iKFmrpqbNxseq3q84Z+47+ H1Dyy2eHTWimYvAQ9tcYg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:DEacy2t/tqM=;tu1ewiJ7H6wNCP30QzxlDyGwSNp UjhvuRbWK1JleWmZBbkZ+uPsdV9TOzGoy2W93ofIEwRt0sfJFsaNARDVyzOYoEr/gQrpU0Lic WHwHK6V06cDYmZlqmTxFx9XI+qQHAknTfsM6tUM5wHrWqd0/5CsS8vdwMejT1D1Z4okk73wPs 6CLWLLy/ceTteXVrnBQ1Zb+nwYR4R3AtrjEYAdkjTLQLjEZvjZoTjUp34QK7eAqBHY+S7jaqH NNwTqYPpiG1dbJhpMEp384Z0/k8a8TsqgzK7jtHmW2Rh6VzyTt6sLXlRihoUtj9wsLoUhUkje 7oj7A2bND6I9OBU6OJD909Qk32ddtkQjZJ9KoYcsUCND+5TrSkWYz3b2doi4q968DZ99Peq5a T3cZu+37yMYyW5wu2i+vxDtVBAj23LZlhmLOBIaWVoc+bSotr+3guQ9z5E5QPIa3vEJKMsRD6 aVisKF+1q//mjgzktXv/el+V2HJGa0fJ/wbjEOVJctIG2u+plXsdy8021pEJpUCfw2J6MF9kX 86MTmyzeYYdL7eHtjnYlDA2L7F5rYTGgwDejbEg7B0dht7SVG1Ppxwep33HUib5c6trMV4dvt BipAa4ZJkh3hyTE3dF6vnPMlOsnGH0f6vdS1Gax4Q1AsrEBDeh98D8Xns/529neIYNkzXsdM9 COnE4oSCGj87+8Ia31S+RPl6fM9qsNxcRfnJRo5yxvt7qKWhU5VaRoRYvS7b5LPFwr2saJDmt ZpWjEqfxCJVaezOgErRIy9yL/WMPCDNbJfrfB7HBzT7g+tkxvmcilO5amhgb2266nqTO2t89m 4BqcFRPHk9KcfwPIqYUEON1v9pavm3YxuqW0nRVJQekMk= X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > +cc Martin Rudalics (as suggested by Joao Tavora) I refer to the following text from https://github.com/joaotavora/eglot/discussions/1382 Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [213.142.97.167 listed in zen.spamhaus.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.19 listed in wl.mailspike.net] X-Debbugs-Envelope-To: 70193 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.9 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > +cc Martin Rudalics (as suggested by Joao Tavora) I refer to the following text from https://github.com/joaotavora/eglot/discussions/1382 Content analysis details: (1.9 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [213.142.97.167 listed in zen.spamhaus.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [212.227.15.19 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.15.19 listed in list.dnswl.org] -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager This is a multi-part message in MIME format. --------------lXBjr9cet293ndfYxwmW02L2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > +cc Martin Rudalics (as suggested by Joao Tavora) I refer to the following text from https://github.com/joaotavora/eglot/discussions/1382 > A variant of recenter that centers the whole selection if > (and only if) it fits might be a useful addition, perhaps to the the > core elisp library. In our case, which I suspect is fairly typical, the > selection is a single identifier such as a function or type declaration, > so the behavior of recenter is ideal, as it allows you to see the doc > comments above the declaration and (at least the start of) the function > body below it. The attached 'window-recenter-region-start-position' should address that. I am not aware of whether we have a function on master to get the line height of a specific window as if a specific buffer were displayed in it so I used 'frame-char-height' for the window in question. The rest of the function is straightforward but there might be off-by-one glitches. Roughly tested with the also contained 'recenter-region'. martin --------------lXBjr9cet293ndfYxwmW02L2 Content-Type: text/x-emacs-lisp; charset=UTF-8; name="recenter-region.el" Content-Disposition: attachment; filename="recenter-region.el" Content-Transfer-Encoding: base64 KGRlZnVuIHdpbmRvdy1yZWNlbnRlci1yZWdpb24tc3RhcnQtcG9zaXRpb24gKCZvcHRpb25h bCBmcm9tIHRvIHdpbmRvdyBidWZmZXIpCiAgIlJldHVybiB3aW5kb3cgc3RhcnQgcG9zaXRp b24gZm9yIHJlY2VudGVyZWQgcmVnaW9uLgpXSU5ET1cgc3BlY2lmaWVzIHRoZSB3aW5kb3cg d2hvc2Ugc3RhcnQgcG9zaXRpb24gdG8gcmV0dXJuIGFuZCBkZWZhdWx0cwp0byB0aGUgc2Vs ZWN0ZWQgd2luZG93LiAgQlVGRkVSIHNwZWNpZmllcyB0aGUgYnVmZmVyIHRoYXQgY29udGFp bnMgdGhlCnJlZ2lvbiBhbmQgZGVmYXVsdHMgdG8gV0lORE9XJ3MgYnVmZmVyLiBGUk9NIGFu ZCBUTyBzcGVjaWZ5IHRoZQpiZWdpbm5pbmcgYW5kIGVuZCBvZiB0aGUgcmVnaW9uIGluIEJV RkZFUiBhbmQgZGVmYXVsdCB0byB0aGUgYWN0aXZlCnJlZ2lvbiBvciB0aGUgZW50aXJlIHRl eHQgb2YgQlVGRkVSLiIKICAobGV0KiAoKHdpbmRvdyAob3Igd2luZG93IChzZWxlY3RlZC13 aW5kb3cpKSkKCSAoYnVmZmVyIChvciBidWZmZXIgKHdpbmRvdy1idWZmZXIpKSkKCSAoZnJv bSAob3IgZnJvbQoJCSAgIChhbmQgKGVxIGJ1ZmZlciAoY3VycmVudC1idWZmZXIpKQoJCQko cmVnaW9uLWFjdGl2ZS1wKQoJCQkocmVnaW9uLWJlZ2lubmluZykpCgkJICAgKHdpdGgtY3Vy cmVudC1idWZmZXIgYnVmZmVyCgkJICAgICAocG9pbnQtbWluKSkpKQoJICh0byAob3IgdG8K CQkgKGFuZCAoZXEgYnVmZmVyIChjdXJyZW50LWJ1ZmZlcikpCgkJICAgICAgKHJlZ2lvbi1h Y3RpdmUtcCkKCQkgICAgICAocmVnaW9uLWVuZCkpCgkJICh3aXRoLWN1cnJlbnQtYnVmZmVy IGJ1ZmZlcgoJCSAgIChwb2ludC1tYXgpKSkpCgkgKGJvZHktd2lkdGggKHdpbmRvdy1ib2R5 LXdpZHRoIHdpbmRvdykpCgkgKGJvZHktaGVpZ2h0ICh3aW5kb3ctYm9keS1oZWlnaHQgd2lu ZG93KSkKCSBvbGQtYnVmZmVyIG9sZC1zdGFydCBvbGQtcG9pbnQgaGVpZ2h0IHN0YXJ0KQog ICAgKHVubGVzcyAoZXEgKHdpbmRvdy1idWZmZXIgd2luZG93KSBidWZmZXIpCiAgICAgIChz ZXRxIG9sZC1idWZmZXIgKHdpbmRvdy1idWZmZXIgd2luZG93KSkKICAgICAgKHNldHEgb2xk LXN0YXJ0ICh3aW5kb3ctc3RhcnQgd2luZG93KSkKICAgICAgKHNldHEgb2xkLXBvaW50ICh3 aW5kb3ctcG9pbnQgd2luZG93KSkKICAgICAgKHNldC13aW5kb3ctYnVmZmVyIHdpbmRvdyBi dWZmZXIpKQogICAgKHNldHEgaGVpZ2h0CgkgICgvIChjZHIgKHdpbmRvdy10ZXh0LXBpeGVs LXNpemUKCQkgICB3aW5kb3cgZnJvbSB0byBib2R5LXdpZHRoIGJvZHktaGVpZ2h0KSkKCSAg ICAgKGZyYW1lLWNoYXItaGVpZ2h0ICh3aW5kb3ctZnJhbWUgd2luZG93KSkpKQogICAgKHNh dmUtZXhjdXJzaW9uCiAgICAgIChnb3RvLWNoYXIgZnJvbSkKICAgICAgKHdoZW4gKDw9IGhl aWdodCBib2R5LWhlaWdodCkKCShmb3J3YXJkLWxpbmUgKC0gKG1heCAoLyAoLSBib2R5LWhl aWdodCBoZWlnaHQpIDIpIDApKSkpCiAgICAgIChzZXRxIHN0YXJ0IChwb3MtYm9sKSkpCiAg ICAod2hlbiBvbGQtYnVmZmVyCiAgICAgIChzZXQtd2luZG93LWJ1ZmZlciB3aW5kb3cgb2xk LWJ1ZmZlcikKICAgICAgKHNldC13aW5kb3ctcG9pbnQgd2luZG93IG9sZC1wb2ludCkKICAg ICAgKHNldC13aW5kb3ctc3RhcnQgd2luZG93IG9sZC1wb2ludCkpCiAgICBzdGFydCkpCgoo ZGVmdW4gcmVjZW50ZXItcmVnaW9uICgpCiAgKGludGVyYWN0aXZlKQogIChtYXJrLXBhcmFn cmFwaCkKICAoc2V0LXdpbmRvdy1zdGFydAogICAoc2VsZWN0ZWQtd2luZG93KSAod2luZG93 LXJlY2VudGVyLXJlZ2lvbi1zdGFydC1wb3NpdGlvbikpKQo= --------------lXBjr9cet293ndfYxwmW02L2-- From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 09:53:23 2024 Received: (at 70193) by debbugs.gnu.org; 5 Apr 2024 13:53:23 +0000 Received: from localhost ([127.0.0.1]:35463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsk0R-0006dI-86 for submit@debbugs.gnu.org; Fri, 05 Apr 2024 09:53:23 -0400 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]:59603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsk0M-0006cO-E8 for 70193@debbugs.gnu.org; Fri, 05 Apr 2024 09:53:21 -0400 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a51a8749478so63036266b.2 for <70193@debbugs.gnu.org>; Fri, 05 Apr 2024 06:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712325186; x=1712929986; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=mDvfQL6lFYB0AzpIWp5/tZORcvG6gQMJruNhod03r8Q=; b=dMYRH3fAqm5dQ9d1CgGUIqlyrX7RvEMEisO9Yuu9n2KFkNHNvvIOvLkBShNWObGJGN dFn1MEzx2dIl4WQDHNoTyXxUlZ0A/d+VwwPEt0TvszwOnfNkg1S54W/12bmatG0IdRHy 4BztQhrkotbbNWNMWPSZ8NFUcl86QHgcHoz81VfWf65CpwpkRsjLR3445cFjDNHO6Z+P xjmqjhWfsyI9YHTIIhfbrfvT8Uy3TBUZYzUbHWJxiaeyvm8jeMYqbZuWRSF/+doF06nK HVtegb+zCoXH75oaBufkApJK1BH2wYFV72mzo7frcr55MbAvdxaW3KBvLaHvaj4Dl61G td/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712325186; x=1712929986; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=mDvfQL6lFYB0AzpIWp5/tZORcvG6gQMJruNhod03r8Q=; b=IqRPtVmfomeMImuKRqz5RfUDkdOJB16tuf7pCCX/5pPI+7ITqTlcvN1RMTAlzhwtVT R7lUATr3xmlNgcxFYCTrQAIpoRJPv+Er1iCzFWtTmYfU6Qx4fEqu/EfGTl8M9ig9inBB esB+m9YZ/4809HnCIekB6RsvXJiInwRhpWnQwImbRp8KWNGasbEOLxzr6VMSMtc8b+Oi Z/Btzjs2F3mwW7r3D/S4QDhsf54m9kWW7oC1tabWQ5dyabn4aBcsFNjeO4wYmlNKxixV b6urtWMCiwxzM9mnIKuLa30sUfRC6DviKV+/juP93AURoF6am2a3vp8xcozS4I1HhNr2 uPWA== X-Forwarded-Encrypted: i=1; AJvYcCUIBSpGRUaOPIf5V4YRg2IS3+tzjCkbBn+sdDWAQkSBPw2wdeh97ihrFCXpiIxAxFeOih6QDyXiWTgQAZoDrCuXj11uy2M= X-Gm-Message-State: AOJu0YzQeeVXb5+t61rcnos+vWilAv5CYjpufhM7YhXQle2wc+nSxTAA N2kTlNZKFLoiOR0jUqWXnJMms+x1LZEQtl3jUFGwPH0BslK9Hv8Hx4FS4+O5 X-Google-Smtp-Source: AGHT+IFWfoINBNTIcARLBBWyqABnIGyjKyOAl9fg6rBAtcP2gkOzpNm/b1xl1ch+1hcO+rZH/ZpBXw== X-Received: by 2002:a17:906:f90a:b0:a4e:14e5:5737 with SMTP id lc10-20020a170906f90a00b00a4e14e55737mr1283299ejb.45.1712325185819; Fri, 05 Apr 2024 06:53:05 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id s11-20020a170906c30b00b00a4e222225ebsm872684ejz.15.2024.04.05.06.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 06:53:05 -0700 (PDT) From: Felician Nemeth To: martin rudalics Subject: Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> Date: Fri, 05 Apr 2024 15:53:04 +0200 In-Reply-To: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> (martin rudalics via's message of "Fri, 5 Apr 2024 11:07:58 +0200") Message-ID: <878r1rgblr.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEU2EgDVmFNHKAa4dz4q AwCDUSH2zWrE61tmAAACeklEQVQ4jU2UwY7jIAyGEZN5ABSFc9Ytcx6K6DmqmHsD8tyZKrz/I+xv yI6WKlHlj982tomiVckiWrUrgRU5jlqMpJKCkch5W419DQAiQGHDxdrWmm0/2kXCApiUmrZLq20s cjexq3VL25QuxjY7wOcJVEpb+jLeGLAK+OMyaa1hx9rFbkwHFWBVA2y8w1wHaLE7GuDdw5cEuOM5 SLIdrpwBkN0ezwI7nYoiilqthbcYc89KgC5+NnaOHGbZz0T6BCEgOLJ0vmYXuNdPAIXgDZJhF2Yu fjnPNwAsoUTUN/P8q3AAyz4zB/xmifEfiIbvS4jh7b7QqZiSm4MJC5kXNpCRaOsoyQXAMN2XCJfs j94NKfo7ACKUEgKE3y+Sg4jibUZ1A0jgYpxtvYMC3gHaHPq6x32ACeALIZoZxB+l9VrRNIA1ncRg wwC8pvQIvYO+a2yt3VXMVyli6L0VV6aOrJa4CpilVQA+eHt0xavk61akih5BUMay/0BAqu783C5h FifY/3QsAIoWYk6PgpwAzLI652+96e2IfN2cF+BD1uT23F21Ghh5OUl4RlO15oh5A2iv+Zk2wsjZ 2DtB5Sm3A4P0+kyb2vs4iEW7G9ohoN3Stl2kVat6MCkXldo6OKaE8P6GhmrKKxWZXQH1iklhhn+d iVeNf6mDdkV0ltFwApRbp+kXSGBFHGV2aPqnIIyQyzhD5n47khqKI08bIapcas4O+hPkct20NAEv ALRuZFUp3PrnQSAm+4lTdHCsYYZ/nGqQrM5z3NS3zefFxkfFPRFbsjpIfbTlvF3ibpVZQ9nzqv60 F/KXSRLJ1AGappJulZll70N/qz6EfwEOCdYOuTHAzAAAAABJRU5ErkJggg== MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70193 Cc: Alan Donovan , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Martin, > The attached 'window-recenter-region-start-position' should address > that. I am not aware of whether we have a function on master to get the > line height of a specific window as if a specific buffer were displayed > in it so I used 'frame-char-height' for the window in question. The > rest of the function is straightforward but there might be off-by-one > glitches. I have a not so recent build: Development version e4d1739a2917 on HEAD branch; build date 2024-03-16. But when I debug window-recenter-region-start-position, the height is set to 0. The patch below seems to fix the problem. Thanks, Felici=E1n --- /tmp/recenter-region.el~ 2024-04-05 15:35:24.043123595 +0200 +++ /tmp/recenter-region.el 2024-04-05 15:47:55.430121441 +0200 @@ -19,8 +19,9 @@ (region-end)) (with-current-buffer buffer (point-max)))) - (body-width (window-body-width window)) (body-height (window-body-height window)) + (body-pixel-width (window-body-width window t)) + (body-pixel-height (window-body-height window t)) old-buffer old-start old-point height start) (unless (eq (window-buffer window) buffer) (setq old-buffer (window-buffer window)) @@ -29,7 +30,7 @@ (set-window-buffer window buffer)) (setq height (/ (cdr (window-text-pixel-size - window from to body-width body-height)) + window from to body-pixel-width body-pixel-height)) (frame-char-height (window-frame window)))) (save-excursion (goto-char from) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 07 03:30:23 2024 Received: (at 70193) by debbugs.gnu.org; 7 Apr 2024 07:30:23 +0000 Received: from localhost ([127.0.0.1]:41482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtMyt-0000mg-7h for submit@debbugs.gnu.org; Sun, 07 Apr 2024 03:30:23 -0400 Received: from mout.gmx.net ([212.227.17.20]:60661) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rtMyo-0000lo-5Z for 70193@debbugs.gnu.org; Sun, 07 Apr 2024 03:30:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1712475003; x=1713079803; i=rudalics@gmx.at; bh=YnI/QQGRzRRrl5AN0BxKGL6Gdc7YIZ6Ut0iofpVELPc=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=bMFMSRT7spp6Ou3Dqu6OYqkAaalry4fHQADdlZhhYyfz5pkb8axshWaXAO+cFfEt BxWgd/h18wul581u3K6hVNg+4riEuWj/+cSiYa1zTywfH7AbX5d0410/s14zkr6Ug mTAJ3XGFrzus4u/HANpxquzULp5p2ZrTst3U9MFod5S4BixtgNeE8Nbc4unGimI6G h8y65W+HKPBuAkbH3s7N/HFBwDg9YybPi5ElmEpI0gwkHuBI3WY/98854NvRvOSf4 ODbp5wnod/oJTEbvekUWuSJmrzCnUk96SyDnX1zsDHYHqYaKQ4GszqvjsNU3FqOB3 ekV+fYjXPVH2tJEWUQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.31.113] ([212.95.5.44]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MXp9Y-1sIe751qyi-00YB6N; Sun, 07 Apr 2024 09:30:03 +0200 Content-Type: multipart/mixed; boundary="------------MREP0Fhbj2M07E1nQMYsKtWP" Message-ID: <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> Date: Sun, 7 Apr 2024 09:30:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) To: Felician Nemeth References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> Content-Language: en-US From: martin rudalics In-Reply-To: <878r1rgblr.fsf@betli.tmit.bme.hu> X-Provags-ID: V03:K1:SWS0xDfPqU6BTBxdWWNnq6bUU0LhzAHRZ2gI7mtL9FKu7RZDrlg wbRWKbpxQxVBWiiXpWyGt1hVFPNECZgm3cYgED3cS3tRA5+qPYZAiMAOo7VgGcTP9/uTTjr xYlmj6NWXwSjwBqrTj8edbx5kBmVQHp8Zs7az62RqBbd9D5lKktuSNsdVt3R5/baD3j+aw/ v0yKJFOWrVLI54X3qtFtA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:QPXmUhmVGVc=;uOa7p9/bGKosrVm0zG/D9AkHe8O pG8jXCTI8ejcQJjbVrkhW1+oYb/EXY/fxOwNK+ZAijSek3exYRapckvkFVUuKBtlOoOW7igZG jyKD0a+AxdyrNzEWKsLHZG6VnA3nMjar1qKhQOpQNnCUF+sQdCsNB+lVeP9mxcGkluI+ev17P mvVy8zWOApTb9KqZBxzL77QMr7Vflx0AxrxlR28K8fT9F9aFCbqYzimApT4F/dV5PeZ4Cs2Uh IsbJTiuuF3UT5YirfPzAsqo7OBtOhdcp5Mh1tzeNb+vKRHjH2fq38nEYAy18jM/YyQNKfkiMb o98KFVkpY2LauPr2J5Hy1eToTMSoZEo0w5F545gRCxNFR0kIUe8FN0pU0fEmfnw1d6Acfvtgk ojbH7BcadR/NYF1Xgt72WV+k0OMNQUisSrtspy0aavAYxbRDg86sbU8qvbf/72qp2z02gcoxw lBvgZ+lvDcdjOViOV4I/XO0rvp7Uyorq2+Q+8iNi4LGHKw/dF98nQcRILb9ILeBmz/oKvfqkv tjYZi9dGnqFoOcYOLcjY5n3LVDae2Cg571d+cvfoF/ZF/Lr5hNPHw4/QbqdKpW3LssIHtvNeD XvCmDc/YkiOxuVDNVr9RwPvia4uGTaD0oOkBI3iCS9zuU4g3z9V3m/grud1Pl7jpx9NeSDIxY z4mU/Mf63M/IQ3f37n8iedL4a5V7PDiKuk7hdT1N0ydzw6LNnaf6NihiNBu4blXuYiy376GrN qpVSIB/7coI1rbwqis+IojHkU/yltQF/8ftBZFlHE2i48/p8sgop0nLnXNZ0eOIWqqQjH7+I7 EU/Gek00CezKQsh9Apa81SU+uiL/F0PtXDt5dSzV7y6Pzgo7Bc5OtzxYTlHGt/ASVd X-Spam-Score: 2.8 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > But when I debug window-recenter-region-start-position, the height is > set to 0. The patch below seems to fix the problem. [...] > + (body-pixel-width (window-body-width window t)) > + (body-pixel [...] Content analysis details: (2.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.20 listed in wl.mailspike.net] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.44 listed in zen.spamhaus.org] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: 70193 Cc: Alan Donovan , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.8 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > But when I debug window-recenter-region-start-position, the height is > set to 0. The patch below seems to fix the problem. [...] > + (body-pixel-width (window-body-width window t)) > + (body-pixel [...] Content analysis details: (1.8 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [212.227.17.20 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [212.95.5.44 listed in zen.spamhaus.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [212.227.17.20 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (rudalics[at]gmx.at) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager This is a multi-part message in MIME format. --------------MREP0Fhbj2M07E1nQMYsKtWP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > But when I debug window-recenter-region-start-position, the height is > set to 0. The patch below seems to fix the problem. [...] > + (body-pixel-width (window-body-width window t)) > + (body-pixel-height (window-body-height window t)) You're right. I meanwhile fixed the code to calculate how many lines to step backwards by using 'window-text-pixel-size' there too. So now this should work with text scaling and varying line heights too. If you want to test it with 'recenter-region', then a rough estimate is that the number of lines shown after the first "L:" should be equal to or one less than the number of lines shown after the third "L:" in each message issued. Thanks, martin --------------MREP0Fhbj2M07E1nQMYsKtWP Content-Type: text/x-emacs-lisp; charset=UTF-8; name="recenter-region.el" Content-Disposition: attachment; filename="recenter-region.el" Content-Transfer-Encoding: base64 KGRlZnVuIHdpbmRvdy1yZWNlbnRlci1yZWdpb24tc3RhcnQtcG9zaXRpb24gKCZvcHRpb25h bCBmcm9tIHRvIHdpbmRvdyBidWZmZXIpCiAgIlJldHVybiB3aW5kb3cgc3RhcnQgcG9zaXRp b24gZm9yIHJlY2VudGVyZWQgcmVnaW9uLgpXSU5ET1cgc3BlY2lmaWVzIHRoZSB3aW5kb3cg d2hvc2Ugc3RhcnQgcG9zaXRpb24gdG8gcmV0dXJuIGFuZCBkZWZhdWx0cwp0byB0aGUgc2Vs ZWN0ZWQgd2luZG93LiAgQlVGRkVSIHNwZWNpZmllcyB0aGUgYnVmZmVyIHN1cHBvc2VkIHRv IGNvbnRhaW4KdGhlIHJlZ2lvbiBhbmQgZGVmYXVsdHMgdG8gV0lORE9XJ3MgYnVmZmVyLiBG Uk9NIGFuZCBUTyBzcGVjaWZ5IHRoZQpiZWdpbm5pbmcgYW5kIGVuZCBvZiB0aGUgcmVnaW9u IGluIEJVRkZFUiBhbmQgZGVmYXVsdCB0byB0aGUgYWN0aXZlCnJlZ2lvbiBvciB0aGUgZW50 aXJlIHRleHQgb2YgQlVGRkVSLiIKICAobGV0KiAoKHdpbmRvdyAob3Igd2luZG93IChzZWxl Y3RlZC13aW5kb3cpKSkKCSAoYnVmZmVyIChvciBidWZmZXIgKHdpbmRvdy1idWZmZXIgd2lu ZG93KSkpCgkgKGZyb20gKG9yIGZyb20KCQkgICAoYW5kIChlcSBidWZmZXIgKGN1cnJlbnQt YnVmZmVyKSkKCQkJKHJlZ2lvbi1hY3RpdmUtcCkKCQkJKHJlZ2lvbi1iZWdpbm5pbmcpKQoJ CSAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIGJ1ZmZlcgoJCSAgICAgKHBvaW50LW1pbikpKSkK CSAodG8gKG9yIHRvCgkJIChhbmQgKGVxIGJ1ZmZlciAoY3VycmVudC1idWZmZXIpKQoJCSAg ICAgIChyZWdpb24tYWN0aXZlLXApCgkJICAgICAgKHJlZ2lvbi1lbmQpKQoJCSAod2l0aC1j dXJyZW50LWJ1ZmZlciBidWZmZXIKCQkgICAocG9pbnQtbWF4KSkpKQoJIChib2R5LXdpZHRo ICh3aW5kb3ctYm9keS13aWR0aCB3aW5kb3cgdCkpCgkgKGJvZHktaGVpZ2h0ICh3aW5kb3ct Ym9keS1oZWlnaHQgd2luZG93IHQpKQoJIG9sZC1idWZmZXIgb2xkLXN0YXJ0IG9sZC1wb2lu dAoJIHJlbWFpbmRlciBoZWlnaHQgc3RhcnQgcHJldikKICAgIDs7IElmIFdJTkRPVyBkb2Vz bid0IHNob3cgQlVGRkVFUiwgc3ZhZSBpdHMgYnVmZmVlciwgc3RhcnQgYW5kIHBvaW50CiAg ICA7OyBwb3NpdGlvbnMuCiAgICAodW5sZXNzIChlcSAod2luZG93LWJ1ZmZlciB3aW5kb3cp IGJ1ZmZlcikKICAgICAgKHNldHEgb2xkLWJ1ZmZlciAod2luZG93LWJ1ZmZlciB3aW5kb3cp KQogICAgICAoc2V0cSBvbGQtc3RhcnQgKHdpbmRvdy1zdGFydCB3aW5kb3cpKQogICAgICAo c2V0cSBvbGQtcG9pbnQgKHdpbmRvdy1wb2ludCB3aW5kb3cpKQogICAgICAoc2V0LXdpbmRv dy1idWZmZXIgd2luZG93IGJ1ZmZlcikpCgogICAgOzsgVGhlIGFtb3VudCBvZiBwaXhlbHMg Ynkgd2hpY2ggdGhlIHJlZ2lvbiBjYW4gYmUgc2Nyb2xsZWQgZG93biBpbgogICAgOzsgdGhl IHdpbmRvdy4gIEluaXRpYWxseSwgaGFsZiBvZiB0aGUgZGlmZmVyZW5jZSBvZiB0aGUgaGVp Z2h0IG9mCiAgICA7OyB0aGUgd2luZG93J3MgYm9keSBhbmQgdGhhdCBvZiB0aGUgcmVnaW9u LgogICAgKHNldHEgcmVtYWluZGVyCgkgIChyb3VuZAoJICAgKC8gKC0gYm9keS1oZWlnaHQK CQkgKGNkciAod2luZG93LXRleHQtcGl4ZWwtc2l6ZQoJCSAgICAgICB3aW5kb3cgZnJvbSB0 byBib2R5LXdpZHRoIGJvZHktaGVpZ2h0KSkpCgkgICAgICAyLjApKSkKCiAgICA7OyBOb3cg bW92ZSBiYWNrIGFuZCBzdWJ0cmFjdCB0aGUgaGVpZ2h0IG9mIG9uZSBsaW5lIHByZWNlZGlu ZyB0aGUKICAgIDs7IHJlZ2lvbiB1bnRpbCB0aGUgcmVtYWluZGVyIGhhcyBiZWVuIHVzZWQu CiAgICAoc2F2ZS1leGN1cnNpb24KICAgICAgKGdvdG8tY2hhciBmcm9tKQogICAgICAoc2V0 cSBzdGFydCAocG9zLWJvbCkpCiAgICAgICh3aGlsZSAoYW5kIChub3QgKGJvYnApKQoJCSAg KD49IHJlbWFpbmRlciAwKQoJCSAgKHNldHEgcHJldiAocG9zLWJvbCAwKSkKCQkgIChzZXRx IGhlaWdodCAoY2RyICh3aW5kb3ctdGV4dC1waXhlbC1zaXplCgkJCQkgICB3aW5kb3cgcHJl diBzdGFydAoJCQkJICAgYm9keS13aWR0aCBib2R5LWhlaWdodCkpKQoJCSAgOzsgQXQgbGVh c3QgaGFsZiBvZiB0aGUgbGluZSBzaG91bGQgZml0LgoJCSAgKD49IHJlbWFpbmRlciAoLyBo ZWlnaHQgMi4wKSkpCgkoc2V0cSByZW1haW5kZXIgKC0gcmVtYWluZGVyIGhlaWdodCkpCgko c2V0cSBzdGFydCBwcmV2KQoJKGdvdG8tY2hhciBzdGFydCkpKQoKICAgIDs7IFJlc3RvcmUg V0lORE9XJ3Mgb2xkIGJ1ZmZlciwgc3RhcnQgYW5kIHBvaW50LgogICAgKHdoZW4gb2xkLWJ1 ZmZlcgogICAgICAoc2V0LXdpbmRvdy1idWZmZXIgd2luZG93IG9sZC1idWZmZXIpCiAgICAg IChzZXQtd2luZG93LXBvaW50IHdpbmRvdyBvbGQtcG9pbnQpCiAgICAgIChzZXQtd2luZG93 LXN0YXJ0IHdpbmRvdyBvbGQtcG9pbnQpKQoKICAgIDs7IFJldHVybiB0aGUgbmV3IHN0YXJ0 IHBvc2l0aW9uLgogICAgc3RhcnQpKQoKKGRlZnVuIHJlY2VudGVyLXJlZ2lvbiAoKQogIChp bnRlcmFjdGl2ZSkKICAobWFyay1wYXJhZ3JhcGgpCiAgKGxldCAoKGZyb20gKHJlZ2lvbi1i ZWdpbm5pbmcpKQoJKHRvIChyZWdpb24tZW5kKSkKCShib2R5LXdpZHRoICh3aW5kb3ctYm9k eS13aWR0aCBuaWwgdCkpCgkoYm9keS1oZWlnaHQgKHdpbmRvdy1ib2R5LWhlaWdodCBuaWwg dCkpCgl3aW5kb3ctc3RhcnQgd2luZG93LWVuZAoJYmVmb3JlIGF0IGFmdGVyKQoKICAgIChz ZXQtd2luZG93LXN0YXJ0CiAgICAgKHNlbGVjdGVkLXdpbmRvdykgKHdpbmRvdy1yZWNlbnRl ci1yZWdpb24tc3RhcnQtcG9zaXRpb24pKQogICAgKHNldHEgd2luZG93LXN0YXJ0ICh3aW5k b3ctc3RhcnQpKQogICAgKHNldHEgd2luZG93LWVuZCAod2luZG93LWVuZCBuaWwgdCkpCiAg ICAobWVzc2FnZSAiJXMuLiVzIEw6ICVzIFA6ICVzIC0gTDogJXMgUDogJXMgLSAlcy4uJXMg TDogJXMgUDogJXMgLSBMOiAlcyBQOiAlcyBCOiAlcyBTOiAlcyIKCSAgICAgd2luZG93LXN0 YXJ0IGZyb20gKGNvdW50LWxpbmVzIHdpbmRvdy1zdGFydCBmcm9tKQoJICAgICAoc2V0cSBi ZWZvcmUgKGNkciAod2luZG93LXRleHQtcGl4ZWwtc2l6ZQoJCQkJbmlsIHdpbmRvdy1zdGFy dCBmcm9tIGJvZHktd2lkdGggYm9keS1oZWlnaHQpKSkKCSAgICAgKGNvdW50LWxpbmVzIGZy b20gdG8pCgkgICAgIChzZXRxIGF0IChjZHIgKHdpbmRvdy10ZXh0LXBpeGVsLXNpemUKCQkJ ICAgIG5pbCBmcm9tIHRvIGJvZHktd2lkdGggYm9keS1oZWlnaHQgbmlsIHQpKSkKCSAgICAg dG8gd2luZG93LWVuZCAoY291bnQtbGluZXMgdG8gd2luZG93LWVuZCkKCSAgICAgKHNldHEg YWZ0ZXIgKGNkciAod2luZG93LXRleHQtcGl4ZWwtc2l6ZQoJCQkgICAgICAgbmlsIHRvIHdp bmRvdy1lbmQgYm9keS13aWR0aCBib2R5LWhlaWdodCkpKQoJICAgICAoY291bnQtbGluZXMg d2luZG93LXN0YXJ0IHdpbmRvdy1lbmQpCgkgICAgIChjZHIgKHdpbmRvdy10ZXh0LXBpeGVs LXNpemUKCQkgICBuaWwgd2luZG93LXN0YXJ0IHdpbmRvdy1lbmQgYm9keS13aWR0aCBib2R5 LWhlaWdodCkpCgkgICAgIGJvZHktaGVpZ2h0ICgrIGJlZm9yZSBhdCBhZnRlcikpKSkK --------------MREP0Fhbj2M07E1nQMYsKtWP-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 04:08:50 2024 Received: (at 70193) by debbugs.gnu.org; 13 Apr 2024 08:08:50 +0000 Received: from localhost ([127.0.0.1]:60055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYRO-0008JK-Fd for submit@debbugs.gnu.org; Sat, 13 Apr 2024 04:08:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYRL-0008Ic-ML for 70193@debbugs.gnu.org; Sat, 13 Apr 2024 04:08:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvYR4-0008Fk-SP; Sat, 13 Apr 2024 04:08:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=xmK795hWYQnlewZl26NxIUm/PpKdrkYfSoA8oEM6cRo=; b=bmcPz9AUIT4w ayYVX3f9vu7T2rA+jZqjESKj/7a7TMoAa17DFLQYwmDbkL9UnFCUzH+SunEon8V7Wyi3I5+2qfuMQ u5WQmr1/++MAFmGUvMgzyewNaAyUTIa4nUmj6kDDtFmtiIfMqhdb55MhZBO9PTC10P/7JWFZOo5yU e0/n5YsAN5l0tnhzggP/o25NOcOWAGKak2CTRvZUCkQzMFBqelW+2lsreZ54RRH1XNbPvXbquA00K p34fcSeLzY0EAAoxtcr9Sgh6ALcSsS9Aw90mFZfbfaciJbbvYoiVKYr2Nbs/HjTLgOHjU7HSgL6NQ BQQpW2MmRNY8sviu4gQSKw==; Date: Sat, 13 Apr 2024 11:08:28 +0300 Message-Id: <867ch1r8g3.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics , felician.nemeth@gmail.com, adonovan@google.com In-Reply-To: <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> (bug-gnu-emacs@gnu.org) Subject: Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70193 Cc: 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Alan Donovan , 70193@debbugs.gnu.org > Date: Sun, 7 Apr 2024 09:30:02 +0200 > From: martin rudalics via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > But when I debug window-recenter-region-start-position, the height is > > set to 0. The patch below seems to fix the problem. > [...] > > + (body-pixel-width (window-body-width window t)) > > + (body-pixel-height (window-body-height window t)) > > You're right. I meanwhile fixed the code to calculate how many lines to > step backwards by using 'window-text-pixel-size' there too. So now this > should work with text scaling and varying line heights too. > > If you want to test it with 'recenter-region', then a rough estimate is > that the number of lines shown after the first "L:" should be equal to > or one less than the number of lines shown after the third "L:" in each > message issued. I'm unsure how to proceed with this bug report. Should it be closed, or is there anything left to be done here, and if the latter, then what has to be done to resolve the issues? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 05:11:17 2024 Received: (at 70193) by debbugs.gnu.org; 13 Apr 2024 09:11:17 +0000 Received: from localhost ([127.0.0.1]:60125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZPn-0003ge-NZ for submit@debbugs.gnu.org; Sat, 13 Apr 2024 05:11:17 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]:58672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvZPk-0003fp-WD for 70193@debbugs.gnu.org; Sat, 13 Apr 2024 05:11:14 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-343d1003106so1092770f8f.1 for <70193@debbugs.gnu.org>; Sat, 13 Apr 2024 02:11:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712999456; x=1713604256; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=NJ3FsD2PdIDPPlxW2Qm7re+61T9EQH5j23mmbaPT8Rs=; b=hNW+l1x/eigA3CQK4gvPRwKSAePfe2ma9xqD98IyEN0TWqxAcyxL26gcaqLyeC7IPh 9No9C/Hp3ephwA7QPvYDSJECQrQuFtvWm+PKJW9gqTH1tEISHEWhfhk6fyS8gFA7D/sU jgZslUNLIJWZea5gfh5JU1aQNzBbIoOm3ILVGqjE97EiAGTYB5vAk82+vUkDuPM9B2Kv ldM+nOsdJY0IKg39vrNZ5I7BrVUQZKurJFOuy6a3ShezCg/Wtz/vWAIBWPUWIezvy+HM L2kN4a2/+C+Ke5idFheIE7ObCpqvJDwYSUbhtX1Tt7ku386detFBkLai15bdWeA6gn3h EyFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712999456; x=1713604256; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NJ3FsD2PdIDPPlxW2Qm7re+61T9EQH5j23mmbaPT8Rs=; b=dggDnIFwEgZmEVXTgwJiwskB+DhBxXX5lKgPpdLVIosfxg0z4RrUXdP97Ev9WLrCvV E07GEXcDziQYkUtgd2ytlFUYuU7wKiuvtDb47zCuaicq1GCL277rV+2GgPHsiyewoduW LJbdS33Yxvppd1Gr9FiW9L5aDXZ/6e844pBH3Ed0NP46sCBmbRdwRBpAvpUoZBk+cdpr A9IDmCLP86zVAZR7sV5H59JF4jaYXdLfmYTo4NZaqkI2L243WQsT8Hm445Sj3ali9AG+ 54z13FgZR/5Y7czizZ+S5CC/2uLgUiqTaDa9UQEbJpSr3dVIOmL20bAw4gIbYDxjY4gA Bccw== X-Forwarded-Encrypted: i=1; AJvYcCV/vTER1SGVWg5X5E2/Z3+rLM3JfoxAwjzImNfgeNLg6M7brjOQVA0PvP5uapinlOqkMovFtNsmHXh6fc3L9vq3xQdKbYI= X-Gm-Message-State: AOJu0YzZv950JWkk2Mbc3vOadBLe5kyqDPFDnzRWO/ArOTBDr/baqQlX 2rk7QiSOd35zIjbSJ7+OrZ34qv3TIT53RcNTrjIsY4xQFdV+WsFSV6NzRg== X-Google-Smtp-Source: AGHT+IEOXalwB+KzS+EdzatteoJzh4nhRPRh8cPUoh2NMvfuhgFmwKxf6Wp7HUXPVO13XC6xzp6BZA== X-Received: by 2002:a05:600c:5493:b0:417:ca54:e9de with SMTP id iv19-20020a05600c549300b00417ca54e9demr4807309wmb.41.1712999455959; Sat, 13 Apr 2024 02:10:55 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id k21-20020a05600c1c9500b004182a36b185sm892045wms.2.2024.04.13.02.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 13 Apr 2024 02:10:55 -0700 (PDT) From: Felician Nemeth To: Eli Zaretskii , adonovan@google.com Subject: Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> Date: Sat, 13 Apr 2024 11:10:54 +0200 In-Reply-To: <867ch1r8g3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Apr 2024 11:08:28 +0300") Message-ID: <8734rpmxup.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70193 Cc: martin rudalics , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Cc: Alan Donovan , 70193@debbugs.gnu.org >> Date: Sun, 7 Apr 2024 09:30:02 +0200 >> From: martin rudalics via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> > But when I debug window-recenter-region-start-position, the height is >> > set to 0. The patch below seems to fix the problem. >> [...] >> > + (body-pixel-width (window-body-width window t)) >> > + (body-pixel-height (window-body-height window t)) >> >> You're right. I meanwhile fixed the code to calculate how many lines to >> step backwards by using 'window-text-pixel-size' there too. So now this >> should work with text scaling and varying line heights too. >> >> If you want to test it with 'recenter-region', then a rough estimate is >> that the number of lines shown after the first "L:" should be equal to >> or one less than the number of lines shown after the third "L:" in each >> message issued. > > I'm unsure how to proceed with this bug report. Should it be closed, > or is there anything left to be done here, and if the latter, then > what has to be done to resolve the issues? Sorry, I meant to write back earlier. I've done some limited test for varying line heights as well, the patch seems to work well. The question, I think, is whether this is generally useful enough to have a polished window-recenter-region to be part of Emacs, or should it just be added to Eglot. In the original report, showDocument requested to show a source code file, where I think `reposition-window' would be more useful. Alan, can you check whether your use-case is better served with `reposition-window' than with `recenter'? However, the LSP specification does not guarantee that the target of showDocument is a source file, so Eglot needs window-recenter-region for completeness. Also I don't know if reposition-window supports every programing language or "go" in particular. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 12:37:19 2024 Received: (at 70193) by debbugs.gnu.org; 13 Apr 2024 16:37:19 +0000 Received: from localhost ([127.0.0.1]:33708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvgNR-0006Ia-Ce for submit@debbugs.gnu.org; Sat, 13 Apr 2024 12:37:18 -0400 Received: from mail-il1-x12f.google.com ([2607:f8b0:4864:20::12f]:36303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvgNM-0006Gf-3L for 70193@debbugs.gnu.org; Sat, 13 Apr 2024 12:37:16 -0400 Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-36b0a277e4dso106145ab.1 for <70193@debbugs.gnu.org>; Sat, 13 Apr 2024 09:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713026215; x=1713631015; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=81ZfsIQ/1NOQS1yghFgeU+Kh3hxAmz9mPrqAXM9oDsk=; b=jVal2ASu1qdAUhem5ygGTHKgqxc7+xPqHwhRUJ1QOCdZYCN/lDn+ds3cK/s2yOb7SY tW5R3kUe8hD9Hl+Z7NjMJEmrliwbCfm31I77tLVBuvfcePT7/3qZ93Jm4xXl/Mf/6Wdc VPrlJqr7SbEFM2VakAWNfzQAvrFlkHuG5eb65YvikVWk1X5mF3hHDVxqj0L5HdeO/d15 6Y16v0w0ug1ex5kvmxRvf6ploxecpp384q7o1iBCy/ZJlTCwQyQeZ7q4xS5ujNxub3cJ Kx2f7TA3dnOftXxxMcos0JYQEXHJcSONruIEZIvSRbNpXVkTlOOs4Zj1QDBNmshgthmk Ziow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713026215; x=1713631015; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=81ZfsIQ/1NOQS1yghFgeU+Kh3hxAmz9mPrqAXM9oDsk=; b=PmeaoSGlYxAH6NpqMg3XMfFzhZxveT3ryrmkTr4xvEOSIL8qv2/w9IoCHcIu94+z+w dxKCcQnE2yy6EMZ7rmXzm31UBFtCT9pKpyGOsMHf5FUdEBP4TE9PwjyrEQC9TbhS3pu5 NqgLpjYLBdA4zSt9I22tojHPtV/77LIPkYyMN6Vef8EJqrMo8gZkbbWmzeVpIM+nu11j 8QIs4B7NiP7Df4WDiz5Evmf45VQhI/R3UQGTNm5vtQArsopcGrtCAHCdCgQRjUB0NvSe Dg67iYhLUBGM+M9OIR1bBoviSifjbKRFQB8X8BBVEcdeWzmlJV6U2EG6sOWNAdp3h/Zc 6Lzw== X-Forwarded-Encrypted: i=1; AJvYcCXkORIIbuL2h+sJ4aTNGu8Di2Y4bmqyrl/fu0sNHnUQTg1AE5FVK+bHm3M+1p4yPNwSHiWfF+w64ojpsAjzh6Ks7ZsR34w= X-Gm-Message-State: AOJu0YxzZ++r4JuFIlk6xUwuhIld8VRnGcflV4JUkASgb9qmFDYE3MZq MGU5yQsiuGqK85gTQH7dDBLfWuPJc2fFpu0djGMDZN4ewSw/4HD6n02/qOdsytZtShnAaPjH+Rv DG44KcXKyzUenRt0K8dqJjJCr/0/XLKOsbQT6 X-Google-Smtp-Source: AGHT+IGSxHFuB7BoQAmy2stLYmG28bI8kwNol/ToFu8yc2VAn3Qr5Clc2zID7KisR6tz2TmSWbwC5moNRFyuSNViNkE= X-Received: by 2002:a05:6e02:e4f:b0:36a:f36:7275 with SMTP id l15-20020a056e020e4f00b0036a0f367275mr114748ilk.25.1713026215495; Sat, 13 Apr 2024 09:36:55 -0700 (PDT) MIME-Version: 1.0 References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> <8734rpmxup.fsf@betli.tmit.bme.hu> In-Reply-To: <8734rpmxup.fsf@betli.tmit.bme.hu> From: Alan Donovan Date: Sat, 13 Apr 2024 12:36:41 -0400 Message-ID: Subject: Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) To: Felician Nemeth Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: -8.0 (--------) X-Debbugs-Envelope-To: 70193 Cc: martin rudalics , Eli Zaretskii , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -9.0 (---------) > Alan, can you check whether your use-case is better served with `reposit= ion-window' than with `recenter'? However, the LSP specification does not = guarantee that the target of showDocument is a source file, so Eglot needs = window-recenter-region for completeness. Also I don't know if reposition-wi= ndow supports every programming language or "go" in particular. Thanks, I wasn't aware of `reposition-window', but it looks like exactly what I want. I just tried it, and found that it positions the point at the top of the frame, but is sufficiently aware of the syntax of the language that if the point is in a declaration (as in my case) then it uses the start of the preceding doc comment, if any. It is clearly superior to recenter for my needs, and I would be quite happy to use it instead. On Sat, 13 Apr 2024 at 05:10, Felician Nemeth w= rote: > > Eli Zaretskii writes: > > >> Cc: Alan Donovan , 70193@debbugs.gnu.org > >> Date: Sun, 7 Apr 2024 09:30:02 +0200 > >> From: martin rudalics via "Bug reports for GNU Emacs, > >> the Swiss army knife of text editors" > >> > >> > But when I debug window-recenter-region-start-position, the height = is > >> > set to 0. The patch below seems to fix the problem. > >> [...] > >> > + (body-pixel-width (window-body-width window t)) > >> > + (body-pixel-height (window-body-height window t)) > >> > >> You're right. I meanwhile fixed the code to calculate how many lines = to > >> step backwards by using 'window-text-pixel-size' there too. So now th= is > >> should work with text scaling and varying line heights too. > >> > >> If you want to test it with 'recenter-region', then a rough estimate i= s > >> that the number of lines shown after the first "L:" should be equal to > >> or one less than the number of lines shown after the third "L:" in eac= h > >> message issued. > > > > I'm unsure how to proceed with this bug report. Should it be closed, > > or is there anything left to be done here, and if the latter, then > > what has to be done to resolve the issues? > > Sorry, I meant to write back earlier. I've done some limited test for > varying line heights as well, the patch seems to work well. The > question, I think, is whether this is generally useful enough to have a > polished window-recenter-region to be part of Emacs, or should it just > be added to Eglot. > > In the original report, showDocument requested to show a source code > file, where I think `reposition-window' would be more useful. Alan, can > you check whether your use-case is better served with > `reposition-window' than with `recenter'? However, the LSP > specification does not guarantee that the target of showDocument is a > source file, so Eglot needs window-recenter-region for completeness. > Also I don't know if reposition-window supports every programing > language or "go" in particular. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 17 05:15:59 2024 Received: (at 70193) by debbugs.gnu.org; 17 Apr 2024 09:15:59 +0000 Received: from localhost ([127.0.0.1]:45740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx1OU-0000U5-Bs for submit@debbugs.gnu.org; Wed, 17 Apr 2024 05:15:59 -0400 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]:61815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx1ON-0000SL-To for 70193@debbugs.gnu.org; Wed, 17 Apr 2024 05:15:52 -0400 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-5193363d255so1555956e87.3 for <70193@debbugs.gnu.org>; Wed, 17 Apr 2024 02:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713345327; x=1713950127; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=IxxvMo/wb60uqJDU5LzSZsnkYxz8o7ICX+rjkNAhpZI=; b=YVM/tt7fxeC/N1TpiuayfinUJLA3Rx7waMNNdFXMJC2qYZuEoq4yTmFjqs/9a0DZJu fSMbo/HcmDldGP1w1wKMzWT31pZtniPhKOL0E7AAMaS95bgkinFGi/mohrR6VlNobCpw 3f4HraKKMp8+BNeBiu3sP7WnZZ1trb3c0xjtpO7eGyPNKGCrRAFBXAPUOHvhgFn2HiIX lDKNe9zu5E1dR04hTEfNBpFA62+jJFZvQNYtWWXd/Ukg07BNjFXCIUZYNeN4YKmuShIb Ps+OHFuuoYf2GEKBU7tHBK4DkFt5YMZXi2Qe6H4g22xgxznuYOfwTt1od8qoofB6IKOg V2DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713345327; x=1713950127; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IxxvMo/wb60uqJDU5LzSZsnkYxz8o7ICX+rjkNAhpZI=; b=HmzmsEZjxzAWoaN5SmgZPiEKymx1f/ya4XyS6YKorDvZ+qMgKvi3A4AvslGsI6UENi Ds+KoEwV5ohDJHgXjItNBodFIsfuoNNPQ3hyf8kzBWBoERM22PkQHPV+XdbRcZtg0yIZ eSl4xMoe/JhcpAcYi9StJwunWLnQOf47iM4E/0LCimgknFg3LCFjLjoMOEF6LVjl/cQm NdrOgb/+CiV2Co+SNiuMzpc9VZInVcAQyv4AliL8hGZdhikAhLber7Bi7WuHQccd1KBa QPwJthOO2bcH1MiNBaOC6EJGJbTbZjH7jWnCOqEgPHcmQrUuUFmqDgrH0OwTNFOQLgXx SY2A== X-Forwarded-Encrypted: i=1; AJvYcCWBMsoCXh6brUczwwhz7Vqr3GrKf0HSjdOslHIhBUa1K1JJEmlveXeQOb2erI4HpTHEAqInyWHd/ICPY8n4CGNzEnzZ2Qw= X-Gm-Message-State: AOJu0YyvYFO0aFh2IsBP51gI5eHaq6aDACpZ9n4XLN6aU9Q31Ue671Kk UPk/cy0NAODa+kQEEDdX7Z3T0yMWPq88KJHN+qebGQFeIg1iFo68FqJ+hA== X-Google-Smtp-Source: AGHT+IHam/U9YYk4OxTj1kqYbxp/w7OTebvNhVPzrxrgbjYgiYnYmY9vHqgX5E6hEfhQnHBDhG/vnQ== X-Received: by 2002:a2e:a58a:0:b0:2d8:144e:c464 with SMTP id m10-20020a2ea58a000000b002d8144ec464mr10534861ljp.36.1713345326916; Wed, 17 Apr 2024 02:15:26 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id g2-20020adff3c2000000b00343300a4eb8sm16994801wrp.49.2024.04.17.02.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Apr 2024 02:15:26 -0700 (PDT) From: Felician Nemeth To: joaotavora@gmail.com Subject: [PATCH] Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> <8734rpmxup.fsf@betli.tmit.bme.hu> Date: Wed, 17 Apr 2024 11:15:25 +0200 In-Reply-To: (Alan Donovan's message of "Sat, 13 Apr 2024 12:36:41 -0400") Message-ID: <87sezkcpua.fsf_-_@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70193 Cc: martin rudalics , Eli Zaretskii , Alan Donovan , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Jo=C3=A3o, I've attached a patch fixing this issue. It includes Martin's new recenter-region. This is the original report: > In eglot 1.17, the LSP showDocument downcall opens the designated > file, moves the cursor to the designated position, and raises the > frame. One other thing it could do to make it easier to see where the > cursor is would be to recenter the buffer. >=20 > The patch below is a minimal fix; the discussion at > https://github.com/joaotavora/eglot/discussions/1382 suggests a couple > of possible refinements. Thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Eglot-Recenter-buffer-upon-showDocument-request-bug-.patch >From 9496ee48c77f60c17387b4331911ba7ad5642c0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felici=C3=A1n=20N=C3=A9meth?= Date: Wed, 17 Apr 2024 10:47:03 +0200 Subject: [PATCH] Eglot: Recenter buffer upon showDocument request (bug#70193) * lisp/progmodes/eglot.el (eglot--window-recenter-region): New defun. (eglot-handle-request window/showDocument): Try to show the whole selection centered; in prog modes, try to show preceding comments as well. Co-authored-by: Martin Rudalics --- lisp/progmodes/eglot.el | 91 +++++++++++++++++++++++++++++++++++++++-- 1 file changed, 87 insertions(+), 4 deletions(-) diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 5e4f7bba679..cbadd495b28 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -2488,6 +2488,76 @@ eglot-handle-request "Handle server request workspace/workspaceFolders." (eglot-workspace-folders server)) +(defun eglot--window-recenter-region (&optional from to window buffer) + "Center region and return window start position for recentered region. +WINDOW specifies the window whose start position to return and defaults +to the selected window. BUFFER specifies the buffer supposed to contain +the region and defaults to WINDOW's buffer. FROM and TO specify the +beginning and end of the region in BUFFER and default to the active +region or the entire text of BUFFER." + (let* ((window (or window (selected-window))) + (buffer (or buffer (window-buffer window))) + (from (or from + (and (eq buffer (current-buffer)) + (region-active-p) + (region-beginning)) + (with-current-buffer buffer + (point-min)))) + (to (or to + (and (eq buffer (current-buffer)) + (region-active-p) + (region-end)) + (with-current-buffer buffer + (point-max)))) + (body-width (window-body-width window t)) + (body-height (window-body-height window t)) + old-buffer old-point + remainder height start prev) + ;; If WINDOW doesn't show BUFFER, save its buffer, start and point + ;; positions. + (unless (eq (window-buffer window) buffer) + (setq old-buffer (window-buffer window)) + (setq old-point (window-point window)) + (set-window-buffer window buffer)) + + ;; The amount of pixels by which the region can be scrolled down in + ;; the window. Initially, half of the difference of the height of + ;; the window's body and that of the region. + (setq remainder + (round + (/ (- body-height + (cdr (window-text-pixel-size + window from to body-width body-height))) + 2.0))) + + ;; Now move back and subtract the height of one line preceding the + ;; region until the remainder has been used. + (save-excursion + (goto-char from) + (setq start (pos-bol)) + (while (and (not (bobp)) + (>= remainder 0) + (setq prev (pos-bol 0)) + (setq height (cdr (window-text-pixel-size + window prev start + body-width body-height))) + ;; At least half of the line should fit. + (>= remainder (/ height 2.0))) + (setq remainder (- remainder height)) + (setq start prev) + (goto-char start))) + + ;; Restore WINDOW's old buffer, start and point. + (when old-buffer + (set-window-buffer window old-buffer) + (set-window-point window old-point) + (set-window-start window old-point)) + + (set-window-start window start) + + ;; Return the new start position. + start)) + (cl-defmethod eglot-handle-request (_server (_method (eql window/showDocument)) &key uri external takeFocus selection) @@ -2510,10 +2580,23 @@ eglot-handle-request ((display-buffer (current-buffer)))) (when selection (pcase-let ((`(,beg . ,end) (eglot-range-region selection))) - ;; FIXME: it is very naughty to use someone else's `--' - ;; function, but `xref--goto-char' happens to have - ;; exactly the semantics we want vis-a-vis widening. - (xref--goto-char beg) + (with-selected-window (get-buffer-window (current-buffer)) + ;; FIXME: it is very naughty to use someone else's `--' + ;; function, but `xref--goto-char' happens to have + ;; exactly the semantics we want vis-a-vis widening. + (xref--goto-char end) + (xref--goto-char beg) + (eglot--window-recenter-region beg end) + + (when (derived-mode-p 'prog-mode) + (let ((recentered-visible (pos-visible-in-window-p end)) + (recentered-start (window-start))) + (reposition-window) ; Try to show preceding comments. + (when (and recentered-visible + (not (pos-visible-in-window-p end))) + ;; reposition-window ruined visibility of selection. + (set-window-start nil recentered-start))))) + (pulse-momentary-highlight-region beg end 'highlight))))))) (t (setq success :json-false))) `(:success ,success))) -- 2.39.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 17 08:13:45 2024 Received: (at 70193) by debbugs.gnu.org; 17 Apr 2024 12:13:45 +0000 Received: from localhost ([127.0.0.1]:45969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx4Aa-0001L1-PW for submit@debbugs.gnu.org; Wed, 17 Apr 2024 08:13:45 -0400 Received: from mail-lj1-x235.google.com ([2a00:1450:4864:20::235]:60723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rx4AX-0001K9-5S for 70193@debbugs.gnu.org; Wed, 17 Apr 2024 08:13:43 -0400 Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2d094bc2244so62951241fa.1 for <70193@debbugs.gnu.org>; Wed, 17 Apr 2024 05:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713356002; x=1713960802; darn=debbugs.gnu.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=U3jZA0AnnqfAvHjS92vE2eZ0pXyvs9LvhdNu0f/7cOo=; b=Ti+eAIjoBdrul1oDF1Dbz9pp3yK6i5ZCvabGr8dGz5GDaYT2HzDeZlu75PYJdX2nRm Xy0f95xniXPqs/7zpOT6pv3gWB5e5FqKgXQkmZMKhelQb3UQE2RrANB+j/t3zEgYwwvR nPNreOWv98+2gYm7bH3rJDBfYP/A+SpgGJ1VBOkzTZNYVOt0+HWe9zTINaPvh8n+XzXy gd/5fUtIWx/kYz+qtI92+OSMqxWPp0Zz5dHKLyH8x1NNuSLov+hOzW5YLfP4rWCqaWP1 e5d2Ujp7RnSxgDot1npgG+wsAyzvHMK8gSyMjyz1JWh1RtF/kC9HlPszmGOA2hFo2Kok q0DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713356002; x=1713960802; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U3jZA0AnnqfAvHjS92vE2eZ0pXyvs9LvhdNu0f/7cOo=; b=mmLUJSr1tOjM4Rse9f3zC4HTSkIbhrfem/HcZ11ZXis0I+ImdTXeOeELKRgVffZjZA VMiY32hzS4yIka5DUJJvsnLIkHT98G2t4quOb9QJMbryAOSOw/ZRRrQjIxKRMnMrcTGC FfuFTjK6z1yK0j6chD4FbP7a7Sa5HjtOIy4/Q2a7Fj5P2lS/oq3yv1i0sj6u8QaUdnBP rLJqyJsnXjCHRS129KN+ydzV+u0OzDICPy9qAxx5+6q3hDlUcqeIK6hVYeG5t8IQDUAn 8DM+UCWHOpk6IpvvNWKwSblSQjtGYygrLm0Y8gouMWA76D+mo8GSQbhdWSdNtoHUtbG0 dDEw== X-Forwarded-Encrypted: i=1; AJvYcCXfNy4gAB/RXQbMIId0eeo/WiTs4yMW1ItXt1Luw2PsIRtrH8UwiWmTeZwDkweLWbAgr8HRet/G3xpbP8fs4xi3s6bo/J4= X-Gm-Message-State: AOJu0YwXKCrdyvkeBys2AW9BU+fjUKPPfG4pAzhYrpG1p/8Tpv8G1N0h morPeGniDBsOFg3sklAp5cqvbVhP1qkkPkk2Q/xlx3Mzx/Hb9BhiRdKqK85hUR4NegKRU4Gk97Y Fp1x2XclemC3uzY9r84q6cDfxTpI= X-Google-Smtp-Source: AGHT+IHbEfD3exADwWg7Nbks6JWxuwI518lGX+2h9/OrP9loPjhCqZTaTErraDvx+bYhRI+UfvtYcYZYp6XDpfVXkBE= X-Received: by 2002:a2e:9e82:0:b0:2d8:a82f:50a0 with SMTP id f2-20020a2e9e82000000b002d8a82f50a0mr9765952ljk.35.1713356001956; Wed, 17 Apr 2024 05:13:21 -0700 (PDT) MIME-Version: 1.0 References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> <8734rpmxup.fsf@betli.tmit.bme.hu> <87sezkcpua.fsf_-_@betli.tmit.bme.hu> In-Reply-To: <87sezkcpua.fsf_-_@betli.tmit.bme.hu> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 17 Apr 2024 13:13:10 +0100 Message-ID: Subject: Re: [PATCH] Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) To: Felician Nemeth Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70193 Cc: "Philip K." , martin rudalics , Eli Zaretskii , Alan Donovan , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed, Apr 17, 2024 at 10:15=E2=80=AFAM Felician Nemeth wrote: > > Hi Jo=C3=A3o, > > I've attached a patch fixing this issue. It includes Martin's new > recenter-region. Thanks. I'm sure the patch is correct but 50+ lines of window-management code in eglot.el? Just for that one user? There's nothing LSP-specific in the new function `eglot--window-recenter-region`, it's pure window management code. The derived-mode-p specifically bit also looks very much out of place in Eglot. What is it accomplishing, and why is this prog-mode exception not in the preceding function itself (maybe as an optional toggle) In fact, there's nothing intrinsically LSP-specific about having clients request Emacs shows the user a given part of a file. I can't believe this obscure LSP interface is its only client. Is it really? So, if this new impeccably documented function designed by Emacs's window management expert :-) does what it says, I think we should put it somewhere else. In fact, I think I've independently implemented parts of it in my SLY and Zapp extensions at some point in time, where they also don't belong so it would definitely be useful. Practical matters: there's the usual problem with Eglot compatibility with older Emacsen, but there's: * compat.el (I think Phil has already made Eglot use compat.el recently) * there's the strategy of using (or creating) another GNU ELPA :core packag= e (like external-completion.el and many other ones) * there' the strategy of 'fboundp' where this nice-to-have "excellent recentering" feature would only appear to Eglot users running it on a recent Emacs. I think all of these are preferable to bloating Eglot's code by this much motivated by this minuscule use case. All that said: I'll let you make the call Felici=C3=A1n :-) If this is another baby step towards you becoming Eglot maintainer, I'm happy :-) Jo=C3=A3o Jo=C3=A3o From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 03:44:18 2024 Received: (at 70193) by debbugs.gnu.org; 23 Apr 2024 07:44:18 +0000 Received: from localhost ([127.0.0.1]:50568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzAp7-0005vx-C5 for submit@debbugs.gnu.org; Tue, 23 Apr 2024 03:44:18 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:53623) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzAp1-0005uv-Lc for 70193@debbugs.gnu.org; Tue, 23 Apr 2024 03:44:16 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-518a3e0d2ecso7965922e87.3 for <70193@debbugs.gnu.org>; Tue, 23 Apr 2024 00:43:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713858229; x=1714463029; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=uezFjA3NPuqaBgkMzHyXoNEbTa8jgIP4kqGN4nh7o+A=; b=V3/KHFOPx448d+1/UurwrhKEOUumHjTBMHwC7zBBIVJHvVKA+vQ1lleTAc9T//OW29 7Q53j7zuxKNUTRMq7TZ4+2n1hj9etP9W8sX0DZwPDZedUoYsQYz87hM8dEQz74IEUj4d rHucJ0KthzoXbdCXGuDg1Tg6sKDfLZ0Z5vhGRpAqqKvUvzocQKB7z5QuayfZMyzQ8B/T 2xklaaIQRuGuwQfXJHYvs1OSh/vttDzsToNw+pHGQygT6GJc7d7TPebz1Bw7eSj3tXwU AgNbhHKcrJyvBxdk51j3f472X+UQw0m2ZikU+IYKnKSqhDA5KDH5kuNWkvV7upnjalzh MJXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713858229; x=1714463029; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uezFjA3NPuqaBgkMzHyXoNEbTa8jgIP4kqGN4nh7o+A=; b=dB3yyG18rKb3M9lh+k3hMXFxeYdGu7eioSMzWKaODyk0virmzo/ZIDS9RsVybDuULr xQkyhQJuN/j2i5b6hwayLW1Jo3ye16CxV9XjzUcqUqM+jDCIFOH7aEPcVaXrcA5bqjID U2DAvWI2tNXylkFhTswjdqQ5lPILOSkx56bE8Q5fKo4XwyhEzAUmrKJ3Jto0hn0IpJB7 yUQJh6ixdHifINGKI32uZRi7nO57bYMM5po5vMiMTM0fetzXXzxC//UIjyD4Sv67QCUi RneZMaYej80FF5KLFhzQVF0SWimssRlomhC5rB4T1K+0H68PNX/NT8nrUBwXV5LEGlT6 w6rw== X-Forwarded-Encrypted: i=1; AJvYcCUPfLC5uXz5zKROe+ME4+J6LTsVjKqXlPdjZwAOy2Ojlxqu99wMuMveIY4IN7lX3RnSnhoLTbKaKwUXyyDxU8jpuq8Mq5U= X-Gm-Message-State: AOJu0YwwxxPjNN2jYEUKL3IG6OVvSfJWRCis3DoaLNilDZkLzjwZBld6 DArAYYgURugrTgIxJ6CyBifjc0M6mbQPN7k7A9cbBtemLij/8YQI X-Google-Smtp-Source: AGHT+IHMKTYqRHDf0V/63S6D0F1iwtONMGVw+M2DQobZaAMKQZKrHHtENCHc4o93AMqLt0opfkK1zg== X-Received: by 2002:a05:6512:483:b0:518:e7ed:3c7c with SMTP id v3-20020a056512048300b00518e7ed3c7cmr9726604lfq.14.1713858228949; Tue, 23 Apr 2024 00:43:48 -0700 (PDT) Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id d17-20020a1709063ed100b00a52222f2b21sm6682308ejj.66.2024.04.23.00.43.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 00:43:48 -0700 (PDT) From: Felician Nemeth To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: [PATCH] Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> <8734rpmxup.fsf@betli.tmit.bme.hu> <87sezkcpua.fsf_-_@betli.tmit.bme.hu> Date: Tue, 23 Apr 2024 09:43:47 +0200 In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 17 Apr 2024 13:13:10 +0100") Message-ID: <877cgobk24.fsf@betli.tmit.bme.hu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEUMBwgHAgMFAAGPjY7/ //80MDHq6eqJt3pKAAABr0lEQVQ4jX2UzZKDIAzHqR177q7TPbtx2HMr6guQcrbY9txZ0fd/hA0f onXazcEJ/CD8E4Js8/HS9mwjXtqeMRxHXJkakTEm4b4GPVQW8PU8ov4fQCqeThlF60MBWdo1IXzd 2nEEZE7CEAZLwI0N/gJAhTj7ESQAX4gPgO8lyI+cvgViSVPlNomAj2M9gW40eg7VWY3cATjUcyiO Z+i03cFruGLYoUR7VyU3HihdmCEVhoDN65FXkpbSxkomOzsTQN/gySaodGb9Gdi1oSRXP46gdBWh LcUKJNdeGCWac74GKakmne0aHCFvyqJPYLsCFAVlhRTvGdzMdLHqtgRyUulyXIAH7CYQ3AB0Nody JQhAkq/qtOnbjhxdzYDkXPxlH5y4WdUAeUcX1NVJ6GR7UQEYPGWoAnA36OQNn5lRRp38vHTAp9Br LoTmvlPPDoRCKzpjG1SXT89AaT5l456BamJuMcs+NIOMzJ/s5dI6yUVcrARlruwOebfdv6gunTn4 ww3+QjGBEn5suVyLHoSGvAqREuDLN+iqZ+VcFg+HBbsJUU9+FZthbez9T+bdb+kPv2Ls6ct3hTkA AAAASUVORK5CYII= MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70193 Cc: "Philip K." , martin rudalics , Eli Zaretskii , Alan Donovan , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jo=C3=A3o T=C3=A1vora writes: > I'm sure the patch is correct but 50+ lines of window-management code > in eglot.el?=20 I agree it can go elsewhere. > Just for that one user? I don't think that should matter. > There's nothing LSP-specific in the new function > `eglot--window-recenter-region`, it's pure window management code. > > The derived-mode-p specifically bit also looks very much out > of place in Eglot. What is it accomplishing, and why is this > prog-mode exception not in the preceding function itself > (maybe as an optional toggle) reposition-window relies on `beginning-of-defun' and `end-of-defun', but it is potentially better than window-recenter-region, because if the selection of showDocument is inside a function, then it tries to show the preceding comments as well. > In fact, there's nothing intrinsically LSP-specific about having > clients request Emacs shows the user a given part of a file. > I can't believe this obscure LSP interface is its only client. > Is it really? Maybe textDocument/publishDiagnostics is somewhat similar. Flymake shows the region of the diagnostic messages with as little care as Eglot currently shows the selection of showDocument. > So, if this new impeccably documented function designed by Emacs's > window management expert :-) does what it says, I think we should > put it somewhere else. I agree. > Practical matters: there's the usual problem with Eglot > compatibility with older Emacsen, but there's: > > * compat.el (I think Phil has already made Eglot use compat.el recently) > * there's the strategy of using (or creating) another GNU ELPA :core pack= age > (like external-completion.el and many other ones) > * there' the strategy of 'fboundp' where this nice-to-have "excellent > recentering" feature would only appear to Eglot users running it on > a recent Emacs. I think the third option is good enough in this case. The current patch can be regarded as a prof-of-concept implementation if anyone is interested in continuing to work on this. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 23 05:28:17 2024 Received: (at 70193) by debbugs.gnu.org; 23 Apr 2024 09:28:17 +0000 Received: from localhost ([127.0.0.1]:51024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzCRk-0005Ve-9J for submit@debbugs.gnu.org; Tue, 23 Apr 2024 05:28:16 -0400 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:44442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzCRh-0005U9-TA for 70193@debbugs.gnu.org; Tue, 23 Apr 2024 05:28:15 -0400 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-51ab4ee9df8so5412108e87.1 for <70193@debbugs.gnu.org>; Tue, 23 Apr 2024 02:27:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713864470; x=1714469270; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lzJDEb2NRPXbMOHtJqJskrsnM+D0lFV8Lw0/x1oTzoQ=; b=kYAjRQxGuyYXpdYxZr2FkrQVOfl/czeupRO8ENo7iOooDQbZitBcKBASuJvs85ppMI Ai1cvfuPKTEvu4JmTMcTM2Z4gfHGdQc/gPAfWeei6sYPLLfw/On8kaMQqYlhGwTNUaxS JH1FAfilf6/58C34WRp32dzAgoc3nv+P9/CnNcwPw2nYvFgiLQpPDB3vaVArmRNWWV/P pXkI1xGzQZvkileCHDrK5di9RGWMZh93i8WB9myq0h6zYIvqW4SWnVNBqOpmibPZkS5+ Thorm1ngEgwJfHhTWFNz++3zhxqn5EyFfKFAxIs5vM7Ac1RzV1tWu6zQmet2JrwVwS3R cQfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713864470; x=1714469270; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lzJDEb2NRPXbMOHtJqJskrsnM+D0lFV8Lw0/x1oTzoQ=; b=qGPhifY24mr8pvcXi3c3hKi0TfPVPGNZ/C1NavBLap8pekwNgW9FZpRU8ilPY6Z9RH T+Ygyd+I74YTnCvS/ssBs+dme8RDF7vKADol9ajPKPztF4C5l4vwodAULhQXkGfn3SlO KeWChaRDH2Wx5WbYJsVF6zgaYfNo4bG0clLJRBzR5br+1b5G8uIcGunRt7kXrSauCFhU YHfjaSAFLL+t5Db/p6siHgSggbNV+XOOzR5hLBqis4P8UkYlnnx08ku1q0OaDRh4rcPl TpbKRpKUwjRZ7ak79b8uJiTJ/QvD+zbtlrqxE2B3CwLPeV9F7/3Lysnw0/X/WxzgflzM I7gA== X-Forwarded-Encrypted: i=1; AJvYcCWibJKdLGhLt+2b4XiUI2d6kqpgjVvvM7xH4QM9wUN5LLgejTDK6EiAkAv/WClNC7kyTTlvUkJIh9hEC0WeMrUMeXT0S6A= X-Gm-Message-State: AOJu0Ywf1Dqzip6Ud83ayDxuA7mj1k7bBBW1aTy7wv3U6zFFCUamLFZJ mryf53cKoxbjabrHQOljmiJgFiY2bZkBovMJFqUsWBtal3rTeA+S0kGflz/cq98izedBcgtYpp+ 4CGle7UypvN+/e8v2wG2t5r2Kbwg= X-Google-Smtp-Source: AGHT+IF+OtAE8OPtzwGbICBXqRcEj7Z1vmZyzhxKcEUNq92NWhC3Dq/J3c3agRK0lpZGeuvwEUp531suldL04qbzrA0= X-Received: by 2002:a05:6512:118e:b0:51b:4e3:1fa9 with SMTP id g14-20020a056512118e00b0051b04e31fa9mr5522751lfr.12.1713864469719; Tue, 23 Apr 2024 02:27:49 -0700 (PDT) MIME-Version: 1.0 References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> <8734rpmxup.fsf@betli.tmit.bme.hu> <87sezkcpua.fsf_-_@betli.tmit.bme.hu> <877cgobk24.fsf@betli.tmit.bme.hu> In-Reply-To: <877cgobk24.fsf@betli.tmit.bme.hu> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Tue, 23 Apr 2024 10:27:37 +0100 Message-ID: Subject: Re: [PATCH] Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) To: Felician Nemeth Content-Type: multipart/alternative; boundary="000000000000e9433f0616c02a7b" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70193 Cc: "Philip K." , martin rudalics , Eli Zaretskii , Alan Donovan , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e9433f0616c02a7b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 23, 2024 at 8:43=E2=80=AFAM Felician Nemeth wrote: > Jo=C3=A3o T=C3=A1vora writes: > > > I'm sure the patch is correct but 50+ lines of window-management code > > in eglot.el? > > I agree it can go elsewhere. > window.el seem like a good place. > > Just for that one user? > > I don't think that should matter. > What I meant is that if it goes into eglot.el it will be "just for that one [Eglot] user" . If it goes somewhere else, it's for more users. > There's nothing LSP-specific in the new function > > `eglot--window-recenter-region`, it's pure window management code. > > > > The derived-mode-p specifically bit also looks very much out > > of place in Eglot. What is it accomplishing, and why is this > > prog-mode exception not in the preceding function itself > > (maybe as an optional toggle) > > reposition-window relies on `beginning-of-defun' and `end-of-defun', but > it is potentially better than window-recenter-region, because if the > selection of showDocument is inside a function, then it tries to show > the preceding comments as well. > I see, more or less. So it's a further refinement specific to window-recenter-region specific to prog-mode buffers. Can it operate independently or does it have to come necessarily after a call to window-recenter-region? Regardless of the answer, I think it would be best placed in prog-mode.el or whereabouts. > > In fact, there's nothing intrinsically LSP-specific about having > > clients request Emacs shows the user a given part of a file. > > I can't believe this obscure LSP interface is its only client. > > Is it really? > > Maybe textDocument/publishDiagnostics is somewhat similar. Flymake > shows the region of the diagnostic messages with as little care as Eglot > currently shows the selection of showDocument. > Eh. Guilty as charged. So another user, showing Flymake diagnostics (not necessarily from LSP publishDiagnostics, mind you). > > * compat.el (I think Phil has already made Eglot use compat.el recently= ) > > * there's the strategy of using (or creating) another GNU ELPA :core > package > > (like external-completion.el and many other ones) > > * there' the strategy of 'fboundp' where this nice-to-have "excellent > > recentering" feature would only appear to Eglot users running it on > > a recent Emacs. > > I think the third option is good enough in this case. > It's a nice one. I think compat.el is not in Eglot just yet anyway. Jo=C3=A3o --000000000000e9433f0616c02a7b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Apr 23, 2024 at 8:43=E2=80=AFAM Felician Nemeth <<= a href=3D"mailto:felician.nemeth@gmail.com">felician.nemeth@gmail.com&g= t; wrote:
Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> writes:
> I'm sure the patch is correct but 50+ lines of window-management c= ode
> in eglot.el?

I agree it can go elsewhere.

window.el = seem like a good place.
=C2=A0
> Just for that one user?

I don't think that should matter.

<= span style=3D"font-family:Arial,Helvetica,sans-serif">What I meant is that = if it goes into eglot.el it will be "just for that one [Eglot]=C2=A0
user= " .=C2=A0 If it goes somewhere else, it's for more users.=C2=A0=C2= =A0

> There's nothing LSP-specific in the new function
> `eglot--window-recenter-region`,=C2=A0 it's pure window management= code.
>
> The derived-mode-p specifically bit also looks very much out
> of place in Eglot.=C2=A0 What is it accomplishing, and why is this
> prog-mode exception not in the preceding function itself
> (maybe as an optional toggle)

reposition-window relies on `beginning-of-defun' and `end-of-defun'= , but
it is potentially better than window-recenter-region, because if the
selection of showDocument is inside a function, then it tries to show
the preceding comments as well.

I see, = more or less.=C2=A0 So it's a further refinement specific to=C2=A0
window-recenter-region specific to prog-mode buffers.=C2=A0 Can it op= erate=C2=A0
independently=C2=A0 or does it have to come necessari= ly after a call to=C2=A0
window-recenter-region?=C2=A0 Regardless= of the answer, I think it=C2=A0
would be best placed in prog-mod= e.el=C2=A0or whereab= outs.
=C2=A0
> In fact, there's nothing intrinsically LSP-specific about having > clients request Emacs shows the user a given part of a file.
> I can't believe this obscure LSP interface is its only client.
> Is it really?

Maybe textDocument/publishDiagnostics is somewhat similar.=C2=A0 Flymake shows the region of the diagnostic messages with as little care as Eglot currently shows the selection of showDocument.

Eh.=C2=A0 Guilty as charged.=C2=A0 So another user, showing Flymake= diagnostics
(not necessarily from LSP publishDiagnostics, mind y= ou).
=C2=A0
<1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> <8734rpmxup.fsf@betli.tmit.bme.hu> <87sezkcpua.fsf_-_@betli.tmit.bme.hu> <877cgobk24.fsf@betli.tmit.bme.hu> Date: Wed, 24 Apr 2024 19:37:23 +0300 Message-ID: <86v846wx80.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70193 Cc: "Philip K." , Felician Nemeth , martin rudalics , Alan Donovan , Eli Zaretskii , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > > I'm sure the patch is correct but 50+ lines of window-management code > > in eglot.el? > > I agree it can go elsewhere. > > window.el seem like a good place. window.el is already full, there is no free space left in window.el. However, reposition.el is almost empty, there is only 1 function in it. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 16:14:57 2024 Received: (at 70193) by debbugs.gnu.org; 24 Apr 2024 20:14:58 +0000 Received: from localhost ([127.0.0.1]:60137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzj13-0003VV-9n for submit@debbugs.gnu.org; Wed, 24 Apr 2024 16:14:57 -0400 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]:54759) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzj0w-0003T6-By for 70193@debbugs.gnu.org; Wed, 24 Apr 2024 16:14:49 -0400 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-51bab51e963so270178e87.1 for <70193@debbugs.gnu.org>; Wed, 24 Apr 2024 13:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713989663; x=1714594463; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=VhH8z+AGQf6l4cMDBzkep7Q+FKNAxuipQSQ2kiQsClA=; b=PM/wdLIeS/ioHuf6m5kt3vsqbxnkW8xMJEsPJX5H8socCSXMq/PHlvMbrxG6DL/gbm FPyEbja60IHheOeSIiXCwz6hpZBXFoFvveiH0U/I0yOTyKKpRrTfQfFne0v5qnY2TI3a 3ivgKYMfaTi+VMCqy2BHqA1aMjoIKADJPvQ0eEApEE3yXMdBT569IkQEM2qGgInuCu21 FM1MqlHEv4bGXibrnU/LMuhV+xV7AFtp+hx2lf+wwNVtiQ6Mndxtg+oPjzJW4aou+6/H eQuAvh6ycaNA64uDNGtuT9010gAuUNg9hdrv7HpNcIxkwKBINEf808hGBevSILnC9dXZ Fugw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713989663; x=1714594463; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VhH8z+AGQf6l4cMDBzkep7Q+FKNAxuipQSQ2kiQsClA=; b=eCENgPYvhprZ9XPikfultOClqrMYBy2Cx9aSm8GF7FWqi9zuNdZTr3A+yZGY6+OxjF 8CAJbqx5np+Px/NSR/D0MGL30i2qit6XEqt5vnM5Xfsx537zDmzM80Ky74skPRCjDq/L mzk+WN537q+Z6a4989hTEGOyt+2eNXVKoOmjEbVbCH2C6xpm75ccOuaugvesC/DF6rt+ Ar+XiB5wvm7xgj8/yQWu/R6jc6tj+iBhGweLBqeM3ZljretLVTQenfUvd6+7trCvOaKF d46mELEzpAiNYo4FuuD9oYWf4myEv+VwTMOL1RbyhJqdSsWV9y+hUD45xllwAEPcRlfs +C+w== X-Forwarded-Encrypted: i=1; AJvYcCXg0TCV/49BLMUPQ0Yovze4UvElS8BNw7mQ6DgRnmH4fky53t4QkOoyqO6rbLYZ8kpuvFaJkUFaKMkudpzXP/79NraPERM= X-Gm-Message-State: AOJu0YxPpWtU8QP3QJCHnG4WasN7m0po4NwKlTvoljkqo4N2Bq00YANp +JEHhMvqSxQOD2EJf/9LlIHGKM4VK/jpep7AX+XmI3Am836cOmbeJ+t7bEeT870tiuR5cCin7kA KtDN+/hY004D57ejM6vM8MKCPJqeHuA== X-Google-Smtp-Source: AGHT+IHraTAfqUonoYEpbZ2aispB6vCkIfZfD8/VGxsHmhvCqpvlqC6cE/cwfPY8a//lya1b27cG4hM2jvSDBPNUEFk= X-Received: by 2002:ac2:5f5c:0:b0:51b:455a:d649 with SMTP id 28-20020ac25f5c000000b0051b455ad649mr2230339lfz.38.1713989662641; Wed, 24 Apr 2024 13:14:22 -0700 (PDT) MIME-Version: 1.0 References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> <8734rpmxup.fsf@betli.tmit.bme.hu> <87sezkcpua.fsf_-_@betli.tmit.bme.hu> <877cgobk24.fsf@betli.tmit.bme.hu> <86v846wx80.fsf@mail.linkov.net> In-Reply-To: <86v846wx80.fsf@mail.linkov.net> From: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Wed, 24 Apr 2024 21:14:09 +0100 Message-ID: Subject: Re: bug#70193: [PATCH] Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) To: Juri Linkov Content-Type: multipart/alternative; boundary="000000000000fd93b50616dd50f3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70193 Cc: "Philip K." , Felician Nemeth , martin rudalics , Alan Donovan , Eli Zaretskii , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000fd93b50616dd50f3 Content-Type: text/plain; charset="UTF-8" On Wed, Apr 24, 2024, 17:56 Juri Linkov wrote: > > > I'm sure the patch is correct but 50+ lines of window-management > code > > > in eglot.el? > > > > I agree it can go elsewhere. > > > > window.el seem like a good place. > > window.el is already full, there is no free space left in window.el. > However, reposition.el is almost empty, there is only 1 function in it. > :) > --000000000000fd93b50616dd50f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Apr 24, 2024, 17:56 Juri Linkov <juri@linkov.net> wrote:
>=C2=A0 =C2=A0 =C2=A0> I'm sure the patch is correc= t but 50+ lines of window-management code
>=C2=A0 =C2=A0 =C2=A0> in eglot.el?
>
>=C2=A0 =C2=A0 =C2=A0I agree it can go elsewhere.
>
> window.el seem like a good place.

window.el is already full, there is no free space left in window.el.
However, reposition.el is almost empty, there is only 1 function in it.
=

:)
--000000000000fd93b50616dd50f3-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 27 06:25:47 2024 Received: (at 70193) by debbugs.gnu.org; 27 Apr 2024 10:25:47 +0000 Received: from localhost ([127.0.0.1]:39009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0fFa-0002vf-0Q for submit@debbugs.gnu.org; Sat, 27 Apr 2024 06:25:47 -0400 Received: from mout01.posteo.de ([185.67.36.65]:56171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0fFX-0002u9-8H for 70193@debbugs.gnu.org; Sat, 27 Apr 2024 06:25:44 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 5ED84240028 for <70193@debbugs.gnu.org>; Sat, 27 Apr 2024 12:25:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1714213518; bh=/HG2Yt4WdKtgm4WqFIfku0aDyjExMlvI+98xoFYy4Bg=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=mVZBWNmLB0rsF3SD2ovl6Es04N9gv83Q8UTR55nbhDplOqdsahqlsd6ywJ+hL4ioQ M7+ueKzJ40WQwoNo5NRSSAKRYbk1O3Z9ArQWF+GxzvlnhdZlrzNgyfJQUKagdme+F9 y6M/f3v/4Pj1PC8S052Ncf9x/WFVtTVZ9K2msAnPHjlK9QZSrguS3kveAKM70vW/qJ YPc0/I7FGuOAAcK9hvIkjIErbjwHMrX37fJfTWLKsZf6q3Bq3Q5fbKWvcXZy3sq1Rv h9LWZAdQphQWppuivLer0L1gVLSSJil7G/lLnHWsckPANw5iafSKShgCt9nx/gTTos tnW3J38G/cYHA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VRQhY51ykz6tm4; Sat, 27 Apr 2024 12:25:17 +0200 (CEST) From: Philip Kaludercic To: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Subject: Re: [PATCH] Re: bug#70193: Acknowledgement (eglot: RFE: recenter buffer upon showDocument request) In-Reply-To: (=?utf-8?Q?=22Jo=C3=A3o_T=C3=A1vora=22's?= message of "Wed, 17 Apr 2024 13:13:10 +0100") References: <1658f0ac-472f-4039-bf83-7abc31d77803@gmx.at> <878r1rgblr.fsf@betli.tmit.bme.hu> <4cdce8b3-66ea-4f16-b9ef-036466650eef@gmx.at> <867ch1r8g3.fsf@gnu.org> <8734rpmxup.fsf@betli.tmit.bme.hu> <87sezkcpua.fsf_-_@betli.tmit.bme.hu> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Sat, 27 Apr 2024 10:25:16 +0000 Message-ID: <877cgjqf03.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70193 Cc: martin rudalics , Eli Zaretskii , Felician Nemeth , Alan Donovan , 70193@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jo=C3=A3o T=C3=A1vora writes: [...] > Practical matters: there's the usual problem with Eglot > compatibility with older Emacsen, but there's: > > * compat.el (I think Phil has already made Eglot use compat.el recently) FTR: This is true, but the changes haven't been pushed yet, since I have to find the time to integrate them into Eglot's GitHub system. --=20 Philip Kaludercic on peregrine