GNU bug report logs - #70189
[PATCH] Simple request to add '.eln' to the 'completion-ignored-extensions' list

Previous Next

To reply to this bug, email your comments to 70189 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Burks <rburksdev <at> gmail.com>
To: GNU BUGS <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Thu, 4 Apr 2024 04:46:57 -0400

[Message part 1 (text/plain, inline)]

(8 of 9)

Patch 0024:  I am submitting this patch as a simple request to add native
compiled
files to the 'completion-ignored-extensions' list.

[Message part 2 (text/html, inline)]

[0024-Added-.eln-to-completion-ignored-extensions.patch (application/x-patch, attachment)]

Message #8 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Corallo <acorallo <at> gnu.org>
To: Robert Burks <rburksdev <at> gmail.com>
Cc: 70189 <at> debbugs.gnu.org
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Thu, 04 Apr 2024 05:51:02 -0400

Robert Burks <rburksdev <at> gmail.com> writes:

> (8 of 9)
>
> Patch 0024:  I am submitting this patch as a simple request to add native compiled
> files to the 'completion-ignored-extensions' list.

Hi Robert,

the patch LGTM, do you have the copyright assignment already done?

For this single patch should be not necessary but I see you are sending
out a number of...

Thanks

  Andrea

Message #11 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <acorallo <at> gnu.org>
Cc: 70189 <at> debbugs.gnu.org, rburksdev <at> gmail.com
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Thu, 04 Apr 2024 14:57:08 +0300

> Cc: 70189 <at> debbugs.gnu.org
> From: Andrea Corallo <acorallo <at> gnu.org>
> Date: Thu, 04 Apr 2024 05:51:02 -0400
> 
> Hi Robert,
> 
> the patch LGTM, do you have the copyright assignment already done?

He doesn't.

Message #14 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Robert Burks <rburksdev <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70189 <at> debbugs.gnu.org, Andrea Corallo <acorallo <at> gnu.org>
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Thu, 4 Apr 2024 13:02:17 -0400

[Message part 1 (text/plain, inline)]

I've only submitted one trivial patch prior to this.  I will submit the
copyright assignment here shortly.

On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > Cc: 70189 <at> debbugs.gnu.org
> > From: Andrea Corallo <acorallo <at> gnu.org>
> > Date: Thu, 04 Apr 2024 05:51:02 -0400
> >
> > Hi Robert,
> >
> > the patch LGTM, do you have the copyright assignment already done?
>
> He doesn't.
>

[Message part 2 (text/html, inline)]

Message #17 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Robert Burks <rburksdev <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70189 <at> debbugs.gnu.org, Andrea Corallo <acorallo <at> gnu.org>
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Thu, 4 Apr 2024 14:06:53 -0400

[Message part 1 (text/plain, inline)]

I have submitted the request for the forms for past and future changes.

That aspect slipped my mind.  The chain of emails I sent was originally
just a
couple lines to fix the segmentation fault in 'get-variable-watchers' and
then
just kept growing.

I have sent an official request to assign copyright to GNU Emacs for any
future
works and for the past original works I have recently submitted for the
following
documents:
lisp/bindings.el
lisp/progmodes/flymake.el
src/buffer.c
src/data.c
src/eval.c
src/lisp.h
test/src/data-tests.el
test/src/eval-tests.el

Robert A. Burks

On Thu, Apr 4, 2024 at 1:02 PM Robert Burks <rburksdev <at> gmail.com> wrote:

> I've only submitted one trivial patch prior to this.  I will submit the
> copyright assignment here shortly.
>
> On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>> > Cc: 70189 <at> debbugs.gnu.org
>> > From: Andrea Corallo <acorallo <at> gnu.org>
>> > Date: Thu, 04 Apr 2024 05:51:02 -0400
>> >
>> > Hi Robert,
>> >
>> > the patch LGTM, do you have the copyright assignment already done?
>>
>> He doesn't.
>>
>

[Message part 2 (text/html, inline)]

Message #20 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Robert Burks <rburksdev <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70189 <at> debbugs.gnu.org, Andrea Corallo <acorallo <at> gnu.org>
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Fri, 5 Apr 2024 16:56:03 -0400

[Message part 1 (text/plain, inline)]

Please include the attached with the group of 31 patches I sent prior.
This patch removes the warning suppression from a test in patch 20.
At some point I had altered the test and forgot to remove the warning
suppression.  This is one of the non-bug related tests.

Additionally, if after review you would like me to handle updating bug
numbers in the commits to the ones assigned or correct any typos let me
know.

On Thu, Apr 4, 2024 at 2:06 PM Robert Burks <rburksdev <at> gmail.com> wrote:

> I have submitted the request for the forms for past and future changes.
>
> That aspect slipped my mind.  The chain of emails I sent was originally
> just a
> couple lines to fix the segmentation fault in 'get-variable-watchers' and
> then
> just kept growing.
>
> I have sent an official request to assign copyright to GNU Emacs for any
> future
> works and for the past original works I have recently submitted for the
> following
> documents:
> lisp/bindings.el
> lisp/progmodes/flymake.el
> src/buffer.c
> src/data.c
> src/eval.c
> src/lisp.h
> test/src/data-tests.el
> test/src/eval-tests.el
>
> Robert A. Burks
>
> On Thu, Apr 4, 2024 at 1:02 PM Robert Burks <rburksdev <at> gmail.com> wrote:
>
>> I've only submitted one trivial patch prior to this.  I will submit the
>> copyright assignment here shortly.
>>
>> On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>>
>>> > Cc: 70189 <at> debbugs.gnu.org
>>> > From: Andrea Corallo <acorallo <at> gnu.org>
>>> > Date: Thu, 04 Apr 2024 05:51:02 -0400
>>> >
>>> > Hi Robert,
>>> >
>>> > the patch LGTM, do you have the copyright assignment already done?
>>>
>>> He doesn't.
>>>
>>

[Message part 2 (text/html, inline)]

[0032-Removed-warning-suppression.patch (text/x-patch, attachment)]

Message #23 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Robert Burks <rburksdev <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 70189 <at> debbugs.gnu.org, Andrea Corallo <acorallo <at> gnu.org>
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Fri, 5 Apr 2024 18:51:12 -0400

[Message part 1 (text/plain, inline)]

I had some time so I went ahead and updated the bug numbers in all the
patches.
Please see revised patches attached.

1) Revised all bug numbers to the assigned numbers.
2) Squashed #32 from the email prior to this into #20
3) Fixed the wording of a comment in #11
4) Rebased, rebuilt, and retested on commit 64e1cfb98cb

On Fri, Apr 5, 2024 at 4:56 PM Robert Burks <rburksdev <at> gmail.com> wrote:

> Please include the attached with the group of 31 patches I sent prior.
> This patch removes the warning suppression from a test in patch 20.
> At some point I had altered the test and forgot to remove the warning
> suppression.  This is one of the non-bug related tests.
>
> Additionally, if after review you would like me to handle updating bug
> numbers in the commits to the ones assigned or correct any typos let me
> know.
>
> On Thu, Apr 4, 2024 at 2:06 PM Robert Burks <rburksdev <at> gmail.com> wrote:
>
>> I have submitted the request for the forms for past and future changes.
>>
>> That aspect slipped my mind.  The chain of emails I sent was originally
>> just a
>> couple lines to fix the segmentation fault in 'get-variable-watchers' and
>> then
>> just kept growing.
>>
>> I have sent an official request to assign copyright to GNU Emacs for any
>> future
>> works and for the past original works I have recently submitted for the
>> following
>> documents:
>> lisp/bindings.el
>> lisp/progmodes/flymake.el
>> src/buffer.c
>> src/data.c
>> src/eval.c
>> src/lisp.h
>> test/src/data-tests.el
>> test/src/eval-tests.el
>>
>> Robert A. Burks
>>
>> On Thu, Apr 4, 2024 at 1:02 PM Robert Burks <rburksdev <at> gmail.com> wrote:
>>
>>> I've only submitted one trivial patch prior to this.  I will submit the
>>> copyright assignment here shortly.
>>>
>>> On Thu, Apr 4, 2024 at 7:57 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>>>
>>>> > Cc: 70189 <at> debbugs.gnu.org
>>>> > From: Andrea Corallo <acorallo <at> gnu.org>
>>>> > Date: Thu, 04 Apr 2024 05:51:02 -0400
>>>> >
>>>> > Hi Robert,
>>>> >
>>>> > the patch LGTM, do you have the copyright assignment already done?
>>>>
>>>> He doesn't.
>>>>
>>>

[Message part 2 (text/html, inline)]

[revised-040524.tar.gz (application/gzip, attachment)]

Message #26 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Burks <rburksdev <at> gmail.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 70189 <at> debbugs.gnu.org, acorallo <at> gnu.org
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Sat, 06 Apr 2024 10:19:31 +0300

> From: Robert Burks <rburksdev <at> gmail.com>
> Date: Fri, 5 Apr 2024 18:51:12 -0400
> Cc: Andrea Corallo <acorallo <at> gnu.org>, 70189 <at> debbugs.gnu.org
> 
> I had some time so I went ahead and updated the bug numbers in all the patches.
> Please see revised patches attached.
> 
> 1) Revised all bug numbers to the assigned numbers.
> 2) Squashed #32 from the email prior to this into #20
> 3) Fixed the wording of a comment in #11
> 4) Rebased, rebuilt, and retested on commit 64e1cfb98cb

I'm confused.  You originally filed no fewer than 8 separate bug
reports, each one with several patches.  Does this revised set replace
all of them? some of them?  If the latter, which ones does it replace
and which ones are still relevant as originally submitted?

In general, lumping together several different patches is not a good
idea, especially if you opened several separate bugs for them.  It
makes our work of reviewing and managing these bugs much harder,
especially given the fact that there are no less than 31 patches
overall here with overlapping changes and issues.

(We need to wait for the completion of your legal paperwork anyway.)

Message #29 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Burks <rburksdev <at> gmail.com>
Cc: 70189 <at> debbugs.gnu.org, acorallo <at> gnu.org
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Sat, 06 Apr 2024 10:45:19 +0300

> From: Robert Burks <rburksdev <at> gmail.com>
> Date: Fri, 5 Apr 2024 16:56:03 -0400
> Cc: Andrea Corallo <acorallo <at> gnu.org>, 70189 <at> debbugs.gnu.org
> 
> Please include the attached with the group of 31 patches I sent prior.
> This patch removes the warning suppression from a test in patch 20.
> At some point I had altered the test and forgot to remove the warning
> suppression.  This is one of the non-bug related tests.

Thanks, but this should be part of the patch which triggers the
warning.  IOW, instead of two patches, one on top of the other, please
submit a single patch with both of the change sets.

Message #32 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Robert Burks <rburksdev <at> gmail.com>
Cc: 70189 <at> debbugs.gnu.org
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Sat, 06 Apr 2024 09:22:33 -0400

> Patch 0024:  I am submitting this patch as a simple request to add native
> compiled files to the 'completion-ignored-extensions' list.

I don't see a big problem with it, but I wonder why you found it necessary:
AFAICT `.eln` files are always kept in a special directory that contains
nothing but `.eln` files, so it seems hard/unlikely to encounter
a situation where your patch would make a difference.


        Stefan

Message #35 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Robert Burks <rburksdev <at> gmail.com>
Cc: 70189 <at> debbugs.gnu.org
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Sat, 06 Apr 2024 20:18:45 -0400

[ Re-added 70189 <at> debbugs.gnu.org in the Cc.  ]

> I am trying to recall the specifics, I had added it to my config file
> months ago, then moved it there.  I believe at the time I was working
> in my '.emacs' directory often and I believe it was flex matching IDO that
> was completing on filenames.

A concrete case would be helpful.


        Stefan

Message #38 received at 70189 <at> debbugs.gnu.org (full text, mbox):

From: Robert Burks <rburksdev <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 70189 <at> debbugs.gnu.org
Subject: Re: bug#70189: [PATCH] Simple request to add '.eln' to the
 'completion-ignored-extensions' list
Date: Sun, 7 Apr 2024 02:32:26 -0400

[Message part 1 (text/plain, inline)]

Thanks, I'll look into it.

On Sat, Apr 6, 2024 at 8:18 PM Stefan Monnier <monnier <at> iro.umontreal.ca>
wrote:

> [ Re-added 70189 <at> debbugs.gnu.org in the Cc.  ]
>
> > I am trying to recall the specifics, I had added it to my config file
> > months ago, then moved it there.  I believe at the time I was working
> > in my '.emacs' directory often and I believe it was flex matching IDO
> that
> > was completing on filenames.
>
> A concrete case would be helpful.
>
>
>         Stefan
>
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.