GNU bug report logs - #70182
[PATCH] Fix + ert for segmentation fault in get-variable-watchers (1 of 9)

Previous Next

Full log

Message #17 received at 70182 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Robert Burks <rburksdev <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 70182 <at> debbugs.gnu.org
Subject: Re: bug#70182: [PATCH] Fix + ert for segmentation fault in
 get-variable-watchers (1 of 9)
Date: Sat, 22 Jun 2024 04:05:19 -0700

Robert Burks <rburksdev <at> gmail.com> writes:

> Got it.
>
> On Sun, Apr 7, 2024 at 3:58 AM Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>> [Please use Reply All to reply, to keep the bug tracker CC'ed.]
>>
>> > From: Robert Burks <rburksdev <at> gmail.com>
>> > Date: Sun, 7 Apr 2024 02:30:54 -0400
>> >
>> > I will make the changes.  Sorry if my previous reply came across as
>> rash, wasn't the intent.
>> > Should I remove the bug number tag also?
>>
>> The bug number should be mentioned in the commit log message, not in
>> the sources.
>>
>> > Also, kicking myself, I know they should end with a period and two
>> spaces, every other
>> > comment I've written probably does.  Somehow the only ones I didn't
>> check was the very
>> > first patch, lol.  That first comment wasn't even supposed to go out,
>> that was my personal note
>> > for when I was going through looking for more of the same bug.
>> >
>> > There will probably be other comments to remove.
>>
>> Thanks.
>>

Any news here?

The patch looks okay to me, so perhaps we should just fix up the minor
stylistic issues and install it?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.