GNU bug report logs - #70167
[PATCH] Mark Flymake regions more accurately in lua-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70167: closed ([PATCH] Mark Flymake regions more accurately
 in lua-ts-mode)
Date: Sat, 13 Apr 2024 08:13:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 13 Apr 2024 11:12:14 +0300
with message-id <865xwlr89t.fsf <at> gnu.org>
and subject line Re: bug#70167: [PATCH] Mark Flymake regions more accurately in lua-ts-mode
has caused the debbugs.gnu.org bug report #70167,
regarding [PATCH] Mark Flymake regions more accurately in lua-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70167: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70167
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: john muhl <jm <at> pub.pink>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Mark Flymake regions more accurately in lua-ts-mode
Date: Wed, 03 Apr 2024 12:55:33 -0500

Tags: patch

This changes the diagnostic region end position from being guessed
based on thing-at-point to using the one provided by LuaCheck. As
noted in bug#67152 it was already being matched but not used. I
couldn’t find anything where t-a-p guessed wrong but it seems
preferable to just mark exactly the same region as LuaCheck would.

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: john muhl <jm <at> pub.pink>
Cc: philipk <at> posteo.net, 70167-done <at> debbugs.gnu.org
Subject: Re: bug#70167: [PATCH] Mark Flymake regions more accurately in
 lua-ts-mode
Date: Sat, 13 Apr 2024 11:12:14 +0300

> Cc: 70167 <at> debbugs.gnu.org
> From: john muhl <jm <at> pub.pink>
> Date: Thu, 04 Apr 2024 11:45:05 -0500
> 
> 
> Changed to use push. It doesn’t look like the order matters or did
> I misunderstand something?
> 
> Thanks for the review.

Thanks, I installed this on the master branch, and I'm closing the
bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.