From unknown Sat Jun 21 03:13:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#70148] [PATCH] guix-install.sh: Add daemonize to requirements. Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 02 Apr 2024 16:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70148 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70148@debbugs.gnu.org Cc: Richard Sent X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171207494032223 (code B ref -1); Tue, 02 Apr 2024 16:23:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Apr 2024 16:22:20 +0000 Received: from localhost ([127.0.0.1]:55836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrgtr-0008NB-JB for submit@debbugs.gnu.org; Tue, 02 Apr 2024 12:22:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrgtm-0008Lb-49 for submit@debbugs.gnu.org; Tue, 02 Apr 2024 12:22:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrgta-0000tw-Hd for guix-patches@gnu.org; Tue, 02 Apr 2024 12:21:58 -0400 Received: from mail-108-mta46.mxroute.com ([136.175.108.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrgtY-0001oI-3O for guix-patches@gnu.org; Tue, 02 Apr 2024 12:21:58 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta46.mxroute.com (ZoneMTA) with ESMTPSA id 18e9f9deaac0003bea.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 02 Apr 2024 16:21:50 +0000 X-Zone-Loop: baecaac8d03564c464822a785361533782971da0a5d9 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GLmgSVrtIJ+5ImW6Xk3aZ3Kuyrh/o1wS6eABoget5zw=; b=r0r+BQ3gcV3PrL96ebuNCRdMn+ I06DA5LSOdFbbVzFud0HhopyF3+QNA2CEOIpRqwRwWKGBbyWvnKEaf8a7bUK7klF1G4k/V4nLWFv3 O8WZrazhGwjzJ5cEsQhf15nR0uNPCkDwytil6F5ZOh7osFDt5e/JhgPA+BUgmFpP5eUyudextgBlO z98BusIcKFeDB9EtE2JnQk2WyWlNLl/pUCri4GmsK/vrZ18L4kdIYhNddQAxrs7DozuHe3pEzvxUb Gs0hz3Qf2Ai13qLsS0mSAaUqnNLGvvQjMYqS9B+cK/6iC+T2soQBXNJxr1j+hR1+abo3XJ4qy+C2c cegW0ULA==; From: Richard Sent Date: Tue, 2 Apr 2024 12:14:16 -0400 Message-ID: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com Received-SPF: pass client-ip=136.175.108.46; envelope-from=richard@freakingpenguin.com; helo=mail-108-mta46.mxroute.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * etc/guix-install.sh (REQUIRE): Add daemonize to requirements list. Needed to spawn the Guix Daemon in guix-daemon.in Change-Id: I77c7f2bdd686bb023ecfa108a499c2eafbad1eb7 --- Hi Guix. I noticed that in Debian WSL the guix daemon sysvinit service wouldn't start due to daemonize not being present. This patch should catch that issue sooner. Both openrc and sysvinit use guix-daemon.in so daemonize should be required regardless of the init system. etc/guix-install.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 982fb0a266..94ecb1d8f3 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -56,6 +56,7 @@ set -eo pipefail [ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; } REQUIRE=( + "daemonize" "dirname" "readlink" "wget" base-commit: d67e4f0f9b10c7ddac8fb0ca68cbf1d6ad0a6e5d -- 2.41.0 From unknown Sat Jun 21 03:13:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#70148] [PATCH] guix-install.sh: Add daemonize to requirements. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 May 2024 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70148 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Richard Sent Cc: 70148@debbugs.gnu.org Received: via spool by 70148-submit@debbugs.gnu.org id=B70148.171484140811369 (code B ref 70148); Sat, 04 May 2024 16:51:02 +0000 Received: (at 70148) by debbugs.gnu.org; 4 May 2024 16:50:08 +0000 Received: from localhost ([127.0.0.1]:54628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3IaO-0002xJ-Dw for submit@debbugs.gnu.org; Sat, 04 May 2024 12:50:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3IaJ-0002wm-SE for 70148@debbugs.gnu.org; Sat, 04 May 2024 12:50:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s3IZq-0001Io-SH; Sat, 04 May 2024 12:49:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=d9lJqTEpKqgtHke0XffpUBVr9ocRL2RLIgcxGuKtLPM=; b=NhPx2Ksfgm1+1BOdBOU+ 9PDjbetC1VmfzS5zug29Oit+Ukwi4R82Zi5XMcCEl9sr/YuD8bm3fnYryh7QRxytNh/SMA+MhFl/k 7A1OKIqrHzguMSn+w8cJXGRFV85d/HkgAJj1Kz5ONnwytOd/exsGjETHgnx117GFehOky2mZILmK7 gknZWwGRtqE9XoThtYFIssCisZER4Fq8htJ5jIpFa1TWjt29IEqefCdQF4ln/x8vYAX12iKvWKtIK cYfpSbXtfkcQJ60QlDHk8Hs2oeS3GxFxCOXdfWmeJgBGj2WTJfw/Qlgpbl72NFSsANA5ha/p+Ex0F 6d5terVIkjkJkA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> (Richard Sent's message of "Tue, 2 Apr 2024 12:14:16 -0400") References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> Date: Sat, 04 May 2024 18:49:31 +0200 Message-ID: <87wmo9sesk.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Richard, Richard Sent skribis: > * etc/guix-install.sh (REQUIRE): Add daemonize to requirements list. > Needed to spawn the Guix Daemon in guix-daemon.in > > Change-Id: I77c7f2bdd686bb023ecfa108a499c2eafbad1eb7 > --- > > Hi Guix. I noticed that in Debian WSL the guix daemon sysvinit service > wouldn't start due to daemonize not being present. This patch should > catch that issue sooner. > > Both openrc and sysvinit use guix-daemon.in so daemonize should be > required regardless of the init system. =E2=80=98daemonize=E2=80=99 seems to be used by etc/init.d/guix-daemon.in, = but not by etc/openrc/guix-daemon.in, right? > REQUIRE=3D( > + "daemonize" My only concern is if the majority of users (which I assume use systemd) would get an error for a missing package they don=E2=80=99t actually need. Do you think that is a risk or is =E2=80=98daemonize=E2=80=99 usually insta= lled =E2=80=9Cby default=E2=80=9D even on those systemd distros? Thanks, Ludo=E2=80=99. From unknown Sat Jun 21 03:13:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#70148] [PATCH] guix-install.sh: Add daemonize to requirements. Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 04 May 2024 22:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70148 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 70148@debbugs.gnu.org Received: via spool by 70148-submit@debbugs.gnu.org id=B70148.171486271116484 (code B ref 70148); Sat, 04 May 2024 22:46:02 +0000 Received: (at 70148) by debbugs.gnu.org; 4 May 2024 22:45:11 +0000 Received: from localhost ([127.0.0.1]:56170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3O7z-0004Ho-2w for submit@debbugs.gnu.org; Sat, 04 May 2024 18:45:11 -0400 Received: from mail-108-mta62.mxroute.com ([136.175.108.62]:42667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s3O7t-0004Hg-Sa for 70148@debbugs.gnu.org; Sat, 04 May 2024 18:45:10 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta62.mxroute.com (ZoneMTA) with ESMTPSA id 18f45c7e1f10008ca2.001 for <70148@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sat, 04 May 2024 22:44:38 +0000 X-Zone-Loop: a69bfd4f97d6acc41fbe972e8550b7b49eb817775257 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/ToPSiKqWirHVYccrq7qRK5cOKls8pujJiuU8egpEa0=; b=Mcw5Gyl1UYCG/sEZ62e/6sMmeL hbQRei0PWvOw/o/v/Vo0JcjrBv/TNaAAjCK74sU+BNgVC/k1GWJL35d8hr1VDMU4hX/+KEt1owteq s8qwbvtRb0Bz4c9aXFacZY9X8stvc0z8lvjYfyt9XnAuY1K92DWv6kqVZlRJWVWoiwccseMtmSVhg QRVd4uP0mlteQHM7QoX/PnP+rpRdYpJLx/K/lDmHtsXwBr0quSppWj2zepmECZhcLGjbOmlwIOkE7 Ct6lxXxJLa9TIrbDlH6jPr4hUH048I/kkAmkwnOR6WlIz3mfcI4ANfYFA/WwxLlgHFHOuaou9h8U8 vJajvlZw==; From: Richard Sent In-Reply-To: <87wmo9sesk.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sat, 04 May 2024 18:49:31 +0200") References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> <87wmo9sesk.fsf@gnu.org> Date: Sat, 04 May 2024 18:44:31 -0400 Message-ID: <87bk5l42pc.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo! >> Both openrc and sysvinit use guix-daemon.in so daemonize should be >> required regardless of the init system. > > =E2=80=98daemonize=E2=80=99 seems to be used by etc/init.d/guix-daemon.in= , but not by > etc/openrc/guix-daemon.in, right? Correct, I think I got confused by guix-install.sh copying etc/openrc/guix-daemon to /etc/init.d/guix-daemon. (See the openrc handler in the $INIT_SYS case statement in sys_enable_guix_daemon()). Assuming I understand the script; I find shell scripts hard to parse. > My only concern is if the majority of users (which I assume use systemd) > would get an error for a missing package they don=E2=80=99t actually need. > > Do you think that is a risk or is =E2=80=98daemonize=E2=80=99 usually ins= talled =E2=80=9Cby > default=E2=80=9D even on those systemd distros? I suspect there's a risk. WSL Debian does not come with daemonize out of the box so I imagine normal Debian does not either. If OpenRC/systemd does not require daemonize, there's probably a better way= to handle this. Perhaps a INITD_REQUIRE variable that's only checked conditionally depending on what init system is detected (aka INIT_SYS). --=20 Take it easy, Richard Sent Making my computer weirder one commit at a time. From unknown Sat Jun 21 03:13:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#70148] [PATCH] guix-install.sh: Add daemonize to requirements. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 22 May 2024 15:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70148 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Richard Sent , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 70148@debbugs.gnu.org Received: via spool by 70148-submit@debbugs.gnu.org id=B70148.171639127816579 (code B ref 70148); Wed, 22 May 2024 15:22:01 +0000 Received: (at 70148) by debbugs.gnu.org; 22 May 2024 15:21:18 +0000 Received: from localhost ([127.0.0.1]:56620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9nmH-0004JK-GH for submit@debbugs.gnu.org; Wed, 22 May 2024 11:21:17 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:37986) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s9nm1-0004Gr-ST for 70148@debbugs.gnu.org; Wed, 22 May 2024 11:21:02 -0400 Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-354eb55b288so133246f8f.0 for <70148@debbugs.gnu.org>; Wed, 22 May 2024 08:20:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716391190; x=1716995990; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=LySlEVnluGPhIIm4SUA3n8ROXlnx7S/mXgRDNklGJqw=; b=eplYWTuSyWuEYEzFrcStu7tvfoh7O+cPZSe8ms/KB0gzaWQW9fJstAl4CMxDU8bXOR etAC+40MnfUTZOZ1jc79TOOl9EtXr3HjywQGYZo/AL9mudZWKia6rcTjL2KuFckgxrnB x89VFPu1fKDGvSACKsAAyBpC3cHvGmzJkdui//bCxTMBcC29B7XvYhRdvp1L/XPa+zs1 pPzKkQoQRajOSRf/LGefr++hu+8PeZgwYkvjGroLOu+WDxrtCQv/P9AXMSV1nMVRtKAL ZpKuweaD3UIh3HGxC8NubOE7PWrD/DmwS/MghjoOe/N4v9fXCRiAWPMBdhOeFRf1oqQb VFCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716391190; x=1716995990; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LySlEVnluGPhIIm4SUA3n8ROXlnx7S/mXgRDNklGJqw=; b=Dc0WRlz6J61xJc5eXIYUx0CfHVDJUTks2KfhMMAnCBWHloXqG2TXOOlZPxaqrarkdV 1BtL0lWAdCucm+nz68WkvA9RkrxJ/kpDZ5/HfXtPyQno3G+tOGnL8qNBqVC0KTcWnFGD HcVFa8xvERz4zjNnoGnU2GCYTmaFMetjYFXT47p46Rxz8WBvkqpU4LFKWwvqMS5nJknf VB0DFzdWKGMFsoNFAGaD75Vk77nPcj3S7g61EBSZFy7DsTztiTji5xjJzEo2R03pjuyr 54aU9NBk2wAdJWKo2LQF9GpCzqaGaKR4USYLcDz29U1sRQ3F0bTHSc1J31w21jHfy4IQ 8p4Q== X-Gm-Message-State: AOJu0YzYH9Wx7H8zYG3oYFbEMsXYeSIMRcEu1TKLC3h6/x5ml/EuhhIS DfmGywotBwPjV+ao6jbDTsKZscXzP7fruvjNOkZj5aMtB1aPow+fi2eqbg== X-Google-Smtp-Source: AGHT+IGuXnBjw1wNhTxnjjS5IS61VtQIbbdpeIVcB1upeqyPYVOw5OGU+186fC6V5jfOsZYYRPOtog== X-Received: by 2002:adf:e3c4:0:b0:354:e778:3665 with SMTP id ffacd0b85a97d-354e77837c1mr1179663f8f.5.1716391190315; Wed, 22 May 2024 08:19:50 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:c865:f7ad:a866:6eca]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3502bbbc334sm34538385f8f.103.2024.05.22.08.19.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 08:19:49 -0700 (PDT) From: Simon Tournier In-Reply-To: <87bk5l42pc.fsf@freakingpenguin.com> References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> <87wmo9sesk.fsf@gnu.org> <87bk5l42pc.fsf@freakingpenguin.com> Date: Wed, 22 May 2024 16:08:08 +0200 Message-ID: <87ttiq2b3r.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, On sam., 04 mai 2024 at 18:44, Richard Sent wrote: > If OpenRC/systemd does not require daemonize, there's probably a better way to > handle this. Perhaps a INITD_REQUIRE variable that's only checked > conditionally depending on what init system is detected (aka INIT_SYS). This appears to me the best solution. It seems better that the requirements stay as minimal as possible for most of users. Well, maybe another variable as INITD_REQUIRE. Or maybe a plain test for this daemonize when the init system is detected; since for now there is only one extra package, if I read correctly. Cheers, simon From unknown Sat Jun 21 03:13:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#70148] [PATCH] guix-install.sh: Add daemonize to requirements. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 25 May 2024 14:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70148 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier Cc: Richard Sent , 70148@debbugs.gnu.org Received: via spool by 70148-submit@debbugs.gnu.org id=B70148.171664559831461 (code B ref 70148); Sat, 25 May 2024 14:00:03 +0000 Received: (at 70148) by debbugs.gnu.org; 25 May 2024 13:59:58 +0000 Received: from localhost ([127.0.0.1]:43587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sArwE-0008BM-BN for submit@debbugs.gnu.org; Sat, 25 May 2024 09:59:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sArwD-0008B3-6J for 70148@debbugs.gnu.org; Sat, 25 May 2024 09:59:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sArvz-0000Os-Gk; Sat, 25 May 2024 09:59:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=HkfYJ4FMQ2sBlEH/UOkQkspnxseWTVmQH+Pg1pi7gJ4=; b=SJjLz2w7lH5cpg/i3pRA P43Twr4dR0+7cUbbbZRQ3doY4DitR1Qzbq8w4wpXZiALbnk9/bYinCPT369pfTfjuzwnkKKCwB/Gx iNzd1cW5Jo6bUSs12ibfdXSuhfI3dk+kcfYu7ih/lC+GmjOo811WNjDjrqPvKfjs7zp2z0ejhj6dr 1x1k6kzjtOooC9ji+w2kYylU0ZyVUfAu1xLv0SLZoDvy0sf0cELjyhY0CosQRWqjbDtfbVYugClEf gWQ/WIz0ue2O+3WE65ff0YePICCseFBUw1Ji1x8dSmHoikFzGIP3XGckTBXKNp/FZcCtXitnASZmd 9BRVhLtVJf7oGw==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <87ttiq2b3r.fsf@gmail.com> (Simon Tournier's message of "Wed, 22 May 2024 16:08:08 +0200") References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> <87wmo9sesk.fsf@gnu.org> <87bk5l42pc.fsf@freakingpenguin.com> <87ttiq2b3r.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Septidi 7 Prairial an 232 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Fromental X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 25 May 2024 15:59:23 +0200 Message-ID: <87ed9q0z7o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Simon Tournier skribis: > On sam., 04 mai 2024 at 18:44, Richard Sent = wrote: > >> If OpenRC/systemd does not require daemonize, there's probably a better = way to >> handle this. Perhaps a INITD_REQUIRE variable that's only checked >> conditionally depending on what init system is detected (aka INIT_SYS). > > This appears to me the best solution. It seems better that the > requirements stay as minimal as possible for most of users. +1. Would be best to ensure the installer doesn=E2=80=99t get in the way of those using systemd distros. Could you look into it, Richard? Ludo=E2=80=99. From unknown Sat Jun 21 03:13:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#70148] [PATCH v2] guix-install.sh: Add unique requirement for sysv init system References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> In-Reply-To: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 29 May 2024 00:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70148 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70148@debbugs.gnu.org Cc: ludo@gnu.org, Richard Sent , zimon.toutoune@gmail.com Received: via spool by 70148-submit@debbugs.gnu.org id=B70148.171694325917132 (code B ref 70148); Wed, 29 May 2024 00:41:02 +0000 Received: (at 70148) by debbugs.gnu.org; 29 May 2024 00:40:59 +0000 Received: from localhost ([127.0.0.1]:37020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC7ND-0004SG-2w for submit@debbugs.gnu.org; Tue, 28 May 2024 20:40:59 -0400 Received: from mail-108-mta207.mxroute.com ([136.175.108.207]:43321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sC7N9-0004S3-W0 for 70148@debbugs.gnu.org; Tue, 28 May 2024 20:40:57 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta207.mxroute.com (ZoneMTA) with ESMTPSA id 18fc1cac8ea000efce.001 for <70148@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 29 May 2024 00:40:43 +0000 X-Zone-Loop: 909fca6bbb45f6bb059e33881bc8a80126fa072a689c X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=adtg+/5L37hM9gKpgEtpBRcxQHEC4z32jcRTiIy13xY=; b=VYkqgFiNJW1lTptUreLxETKuXl M16RYRhrH6/8vZRye356vZUlDzBnHuJFH5Bsjbyq17KmShkQov1JEOUbJT6NB8d4EZ0V3EiGlrrPg w22AIy90OS50D2hQFFWgzfLj61pgxWdP+j7jypbz8v4ygyXATY/jSgSUfFUxqdvoMjV3/Fnqyh7jb Teh0AdfXSkNq5QsULYObffZ4CakfQ2EuSf9RorD4NPE7wYl/3al6c34Y4Maa6Uzb5ZB3T2QQosTDi akNRphE5BWx7bJ2KC5h8p7HH38dKxEN5mPxqbHFoXnMlNLm9gXA2WW2BGs3p7x2hK5B42GPRH9+xr VRPQN0Nw==; From: Richard Sent Date: Tue, 28 May 2024 20:36:06 -0400 Message-ID: <4253a50c53caa41f468163c6f9f8730e86678f38.1716942966.git.richard@freakingpenguin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This improves the installer's ability to detect that all requirements are present regardless of init system. It also avoids performing the requirement check twice (printing excessively to the console) and provides a framework for adding new init system specific requirements if it's needed in the future. * etc/guix-install.sh (add_init_sys_require): Create. (SYSV_INIT_REQUIRE): Create. (main_install): Reorder installer steps so all requirements are checked in one pass. Change-Id: Ic541c1b90499d504642b7ab4ae595501b1a37b0d --- Hi all, Here's an updated patch that is more selective about only checking for dependencies when it's required. It might be a touch overengineered, but I felt this was a better solution compared to hardcoding a daemonize requirement check in chk_init_sys or similar. I wanted to avoid calling chk_require twice. Because chk_require outputs to the console, calling it multiple times will either a) print multiple "verification of blah blah blah" messages to the user or b) cause the user to fix the generic requirements, then need to fix init system specific requirements as a two step process. If it's ever relevant, this patch will make it quite easy to add additional checks for specific init systems. etc/guix-install.sh | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 82accfd5d5..09a7ca3ae8 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -15,6 +15,7 @@ # Copyright © 2020 David A. Redick # Copyright © 2024 Janneke Nieuwenhuizen # Copyright © 2024 Tomas Volf <~@wolfsden.cz> +# Copyright © 2024 Richard Sent # # This file is part of GNU Guix. # @@ -81,6 +82,12 @@ REQUIRE=( "xz" ) +# Add variables using form FOO_INIT_REQUIRE when init system FOO dependencies +# should be checked. +SYSV_INIT_REQUIRE=( + "daemonize" +) + PAS=$'[ \033[32;1mPASS\033[0m ] ' ERR=$'[ \033[31;1mFAIL\033[0m ] ' WAR=$'[ \033[33;1mWARN\033[0m ] ' @@ -148,6 +155,18 @@ chk_require() _msg "${PAS}verification of required commands completed" } +add_init_sys_require() +{ # Add the elements of FOO_INIT_SYS to REQUIRE + local init_require="${INIT_SYS}_REQUIRE[@]" + if [[ ! -z "$init_require" ]]; then + # Have to add piecemeal because ${!foo[@]} performs direct array key + # expansion, not indirect plain array expansion. + for r in "${!init_require}"; do + REQUIRE+=("$r") + done + fi +} + chk_gpg_keyring() { # Check whether the Guix release signing public key is present. _debug "--- [ ${FUNCNAME[0]} ] ---" @@ -793,9 +812,10 @@ main_install() _msg "Starting installation ($(date))" chk_term + chk_init_sys + add_init_sys_require chk_require "${REQUIRE[@]}" chk_gpg_keyring - chk_init_sys chk_sys_arch chk_sys_nscd base-commit: 542b18709a46e361de8f25e3fece29860532743c -- 2.41.0 From unknown Sat Jun 21 03:13:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#70148] [PATCH v2] guix-install.sh: Add unique requirement for sysv init system Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Jun 2024 09:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70148 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Richard Sent Cc: 70148@debbugs.gnu.org, zimon.toutoune@gmail.com Received: via spool by 70148-submit@debbugs.gnu.org id=B70148.17173215644575 (code B ref 70148); Sun, 02 Jun 2024 09:47:02 +0000 Received: (at 70148) by debbugs.gnu.org; 2 Jun 2024 09:46:04 +0000 Received: from localhost ([127.0.0.1]:57854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDhmu-0001Bi-7O for submit@debbugs.gnu.org; Sun, 02 Jun 2024 05:46:04 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60974) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDhmr-0001BD-OO for 70148@debbugs.gnu.org; Sun, 02 Jun 2024 05:46:02 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sDhma-0006mM-5Z; Sun, 02 Jun 2024 05:45:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=FmNIaWGO+Wi7FvG2jTwQB3M0RoPHpNTyzNmeqUTsink=; b=YiP+t+BFU0fT8Rj5SIct 0ztplLWZ28yZ3tOQsJT3Wl9ULtdLUCCr81HLSYS29ddC1uu1UvT0NUTnkxA33YRQ5esISRD7ZjQGT Dn9bAuHPX/UpI6dZ2aWJM9qo/XB/uwnzm3fsFD8YoxcrR87s9jUr53iCMZQjqINM1aQ9LCuiIukNL RZwAWfYaeE5dbHFblA+zfwKFCcXhuB4igg8iFf90P/OKQrNthHfbuWvxjkILZho8W5HYdFqUSK02I JPIlr6rVJ43zHzDbcR/Tbj39jgLHc/lWtZBF+YvOZ3e4foG93Vv4zGefobkvyJ+LF4jJkzLcbz8v1 iAZBdtPor09xcQ==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <4253a50c53caa41f468163c6f9f8730e86678f38.1716942966.git.richard@freakingpenguin.com> (Richard Sent's message of "Tue, 28 May 2024 20:36:06 -0400") References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> <4253a50c53caa41f468163c6f9f8730e86678f38.1716942966.git.richard@freakingpenguin.com> Date: Sun, 02 Jun 2024 11:45:27 +0200 Message-ID: <87a5k3n0eg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Richard, Richard Sent skribis: > This improves the installer's ability to detect that all requirements are > present regardless of init system. It also avoids performing the requirem= ent > check twice (printing excessively to the console) and provides a framewor= k for > adding new init system specific requirements if it's needed in the future. > > * etc/guix-install.sh (add_init_sys_require): Create. > (SYSV_INIT_REQUIRE): Create. > (main_install): Reorder installer steps so all requirements are checked i= n one > pass. > > Change-Id: Ic541c1b90499d504642b7ab4ae595501b1a37b0d > --- > Hi all, > > Here's an updated patch that is more selective about only checking for > dependencies when it's required. It might be a touch overengineered, > but I felt this was a better solution compared to hardcoding a > daemonize requirement check in chk_init_sys or similar. Neat! I have one concern though: > +add_init_sys_require() > +{ # Add the elements of FOO_INIT_SYS to REQUIRE > + local init_require=3D"${INIT_SYS}_REQUIRE[@]" > + if [[ ! -z "$init_require" ]]; then > + # Have to add piecemeal because ${!foo[@]} performs direct array= key > + # expansion, not indirect plain array expansion. > + for r in "${!init_require}"; do > + REQUIRE+=3D("$r") > + done > + fi =E2=80=98local=E2=80=99, [[, and arrays are probably Bash-specific. Howeve= r this is a #!/bin/sh script, and some systems such as Debian use Dash as /bin/sh. So I=E2=80=99m afraid the script would break on such systems. WDYT? Do you think we can avoid those features? So much for a script. :-) Thanks! Ludo=E2=80=99. From unknown Sat Jun 21 03:13:17 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#70148] [PATCH v2] guix-install.sh: Add unique requirement for sysv init system Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 02 Jun 2024 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70148 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 70148@debbugs.gnu.org, zimon.toutoune@gmail.com Received: via spool by 70148-submit@debbugs.gnu.org id=B70148.171733886626352 (code B ref 70148); Sun, 02 Jun 2024 14:35:02 +0000 Received: (at 70148) by debbugs.gnu.org; 2 Jun 2024 14:34:26 +0000 Received: from localhost ([127.0.0.1]:60109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDmHy-0006qx-Dx for submit@debbugs.gnu.org; Sun, 02 Jun 2024 10:34:26 -0400 Received: from mail-108-mta182.mxroute.com ([136.175.108.182]:44261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sDmHu-0006qn-5x for 70148@debbugs.gnu.org; Sun, 02 Jun 2024 10:34:25 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta182.mxroute.com (ZoneMTA) with ESMTPSA id 18fd95f2d82000e2b6.001 for <70148@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Sun, 02 Jun 2024 14:34:04 +0000 X-Zone-Loop: 2846cac75cb8978da94986b49de3e4c119a94b192dec X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=9wcqvB6zgd64tPfQ/CPL94Qbx9iJezhqarI/Iiv4DeI=; b=ESznR69sjnn+Mxv+w57cM1cIvR bPNPGb4/kISfcnCHyGj3FTMbs6BMXxmeEpMOEHU7vIwcsZ+tO9Y5efRrpjqeusTLizd+MTtzqIMe+ arEBkhGlEHnKuHt1OgJmule7occJrteRzwmr3FA7OwocEXPGsSphKQ62MX86ELTVdS4YRvYhpVisu P6gaqJ+h7h6O26rRvFdSLmWFNBHOFIbRiorE8JzmO0KUeKgJRD+zTmswhjCK2YeHkEEc6eRfoyq3r PkxuYB6YQEX7n3AUEcPdxTQ6+goJN0RQirJ0MwmJMvvxNWnyH6KKO95vqN30zHiVlAlV7MQpnCCqp Apv4A6sw==; From: Richard Sent In-Reply-To: <87a5k3n0eg.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Sun, 02 Jun 2024 11:45:27 +0200") References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> <4253a50c53caa41f468163c6f9f8730e86678f38.1716942966.git.richard@freakingpenguin.com> <87a5k3n0eg.fsf@gnu.org> Date: Sun, 02 Jun 2024 10:33:56 -0400 Message-ID: <87ikyre7mz.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Authenticated-Id: richard@freakingpenguin.com X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Ludo! Ludovic Court=C3=A8s writes: > =E2=80=98local=E2=80=99, [[, and arrays are probably Bash-specific. Howe= ver this is a > #!/bin/sh script, and some systems such as Debian use Dash as /bin/sh. > So I=E2=80=99m afraid the script would break on such systems. > > WDYT? Do you think we can avoid those features? Right, I did notice that. A strictly 100% POSIX-compliant shell doesn't support local, arrays, or [[]] constructs. From my understanding Dash supports 1 and /maybe/ 3, but not 2. However, the script already contains provisions to enter bash even if launc= hed using a POSIX-complaint shell. See this at the beginning: --8<---------------cut here---------------start------------->8--- if [ "x$BASH_VERSION" =3D "x" ] then exec bash "$0" "$@" fi --8<---------------cut here---------------end--------------->8--- This construct is a little bit odd to me. At the time it was added ( by you ;) ) because /usr/bin/env did not exist on Guix System [1], but that's been added since [2]. Perhaps we should change the shebang to #!/usr/bin/env bash. (Also looks like the comment you wrote re. bash was spliced away from the code.) --8<---------------cut here---------------start------------->8--- # We require Bash but for portability we'd rather not use /bin/bash or # /usr/bin/env in the shebang, hence this hack. # Environment variables ....... if [ "x$BASH_VERSION" =3D "x" ] ....... --8<---------------cut here---------------end--------------->8--- The script is already using all 3 of these constructs too. [1]: https://issues.guix.gnu.org/34279 [2]: https://issues.guix.gnu.org/35910 --=20 Take it easy, Richard Sent Making my computer weirder one commit at a time. From unknown Sat Jun 21 03:13:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Richard Sent Subject: bug#70148: closed (Re: [bug#70148] [PATCH v2] guix-install.sh: Add unique requirement for sysv init system) Message-ID: References: <87zfs16mqq.fsf@gnu.org> <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> X-Gnu-PR-Message: they-closed 70148 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 70148@debbugs.gnu.org Date: Tue, 04 Jun 2024 10:26:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1717496763-29691-1" This is a multi-part message in MIME format... ------------=_1717496763-29691-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #70148: [PATCH] guix-install.sh: Add daemonize to requirements. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 70148@debbugs.gnu.org. --=20 70148: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D70148 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1717496763-29691-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 70148-done) by debbugs.gnu.org; 4 Jun 2024 10:25:23 +0000 Received: from localhost ([127.0.0.1]:36656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sERM2-0007gz-KB for submit@debbugs.gnu.org; Tue, 04 Jun 2024 06:25:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sER98-00073X-H3 for 70148-done@debbugs.gnu.org; Tue, 04 Jun 2024 06:12:03 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sER8p-0007ka-9H; Tue, 04 Jun 2024 06:11:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=+vPVXkhj9PCXKlUVd8z+1uNWCq6zTLtxQrOfs/TlgfI=; b=QgLCaPCjkJgoQWgzH0us 4mdyhpn6AT5BZ/Yvy1kly0OD+vtwO7EtwJ2RKSnlvj3jWY8Zaix8IRNSzGpnabHElPV9rEma1ygg3 rGmuAlKL/yjge8kMwvAx5EL8NOkRU2JtjHoZKhUha78+q+n+FWPEtlF67SJSVWzApmfZIAp3POZxE SzyGe9CCZXy2/LZumwwYEHOy98PmZAJRKd++GsCGc2t2Ba5vvwuiHtftEOuh8VwVgxhKu4IBvLjuX d4eSm3l6ZmjHk4F6OS8hV2wYAjV7stP4u1xd8Mz4+HWN/L5KNGxMsOqonjidnpeT0cDr0yrul/DrU wM5jq/pU1I7gjw==; From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Richard Sent Subject: Re: [bug#70148] [PATCH v2] guix-install.sh: Add unique requirement for sysv init system In-Reply-To: <87ikyre7mz.fsf@freakingpenguin.com> (Richard Sent's message of "Sun, 02 Jun 2024 10:33:56 -0400") References: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> <4253a50c53caa41f468163c6f9f8730e86678f38.1716942966.git.richard@freakingpenguin.com> <87a5k3n0eg.fsf@gnu.org> <87ikyre7mz.fsf@freakingpenguin.com> Date: Tue, 04 Jun 2024 12:11:41 +0200 Message-ID: <87zfs16mqq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70148-done Cc: zimon.toutoune@gmail.com, 70148-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, Richard Sent skribis: > Ludovic Court=C3=A8s writes: > >> =E2=80=98local=E2=80=99, [[, and arrays are probably Bash-specific. How= ever this is a >> #!/bin/sh script, and some systems such as Debian use Dash as /bin/sh. >> So I=E2=80=99m afraid the script would break on such systems. >> >> WDYT? Do you think we can avoid those features? [...] > The script is already using all 3 of these constructs too. Oh right, I had completely overlooked that. In that case my point is moot (it might be useful to not require Bash, but that=E2=80=99s a separate topic). Pushed as 40c6f708393885a2d28f847350e8f47beb11e745, thanks! Ludo=E2=80=99. ------------=_1717496763-29691-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Apr 2024 16:22:20 +0000 Received: from localhost ([127.0.0.1]:55836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrgtr-0008NB-JB for submit@debbugs.gnu.org; Tue, 02 Apr 2024 12:22:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:56456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrgtm-0008Lb-49 for submit@debbugs.gnu.org; Tue, 02 Apr 2024 12:22:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrgta-0000tw-Hd for guix-patches@gnu.org; Tue, 02 Apr 2024 12:21:58 -0400 Received: from mail-108-mta46.mxroute.com ([136.175.108.46]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrgtY-0001oI-3O for guix-patches@gnu.org; Tue, 02 Apr 2024 12:21:58 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta46.mxroute.com (ZoneMTA) with ESMTPSA id 18e9f9deaac0003bea.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 02 Apr 2024 16:21:50 +0000 X-Zone-Loop: baecaac8d03564c464822a785361533782971da0a5d9 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Transfer-Encoding:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GLmgSVrtIJ+5ImW6Xk3aZ3Kuyrh/o1wS6eABoget5zw=; b=r0r+BQ3gcV3PrL96ebuNCRdMn+ I06DA5LSOdFbbVzFud0HhopyF3+QNA2CEOIpRqwRwWKGBbyWvnKEaf8a7bUK7klF1G4k/V4nLWFv3 O8WZrazhGwjzJ5cEsQhf15nR0uNPCkDwytil6F5ZOh7osFDt5e/JhgPA+BUgmFpP5eUyudextgBlO z98BusIcKFeDB9EtE2JnQk2WyWlNLl/pUCri4GmsK/vrZ18L4kdIYhNddQAxrs7DozuHe3pEzvxUb Gs0hz3Qf2Ai13qLsS0mSAaUqnNLGvvQjMYqS9B+cK/6iC+T2soQBXNJxr1j+hR1+abo3XJ4qy+C2c cegW0ULA==; From: Richard Sent To: guix-patches@gnu.org Subject: [PATCH] guix-install.sh: Add daemonize to requirements. Date: Tue, 2 Apr 2024 12:14:16 -0400 Message-ID: <4e4fa72cfff690365f06c94534bc3d03ac7a3418.1712074456.git.richard@freakingpenguin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: richard@freakingpenguin.com Received-SPF: pass client-ip=136.175.108.46; envelope-from=richard@freakingpenguin.com; helo=mail-108-mta46.mxroute.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: Richard Sent X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) * etc/guix-install.sh (REQUIRE): Add daemonize to requirements list. Needed to spawn the Guix Daemon in guix-daemon.in Change-Id: I77c7f2bdd686bb023ecfa108a499c2eafbad1eb7 --- Hi Guix. I noticed that in Debian WSL the guix daemon sysvinit service wouldn't start due to daemonize not being present. This patch should catch that issue sooner. Both openrc and sysvinit use guix-daemon.in so daemonize should be required regardless of the init system. etc/guix-install.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 982fb0a266..94ecb1d8f3 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -56,6 +56,7 @@ set -eo pipefail [ "$UID" -eq 0 ] || { echo "This script must be run as root."; exit 1; } REQUIRE=( + "daemonize" "dirname" "readlink" "wget" base-commit: d67e4f0f9b10c7ddac8fb0ca68cbf1d6ad0a6e5d -- 2.41.0 ------------=_1717496763-29691-1--