From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 11:04:03 2024 Received: (at submit) by debbugs.gnu.org; 2 Apr 2024 15:04:03 +0000 Received: from localhost ([127.0.0.1]:54959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrfg9-0003dk-Cw for submit@debbugs.gnu.org; Tue, 02 Apr 2024 11:04:03 -0400 Received: from lists.gnu.org ([2001:470:142::17]:52058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrfg6-0003ck-UC for submit@debbugs.gnu.org; Tue, 02 Apr 2024 11:04:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrfft-00035l-QH for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 11:03:46 -0400 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrffr-0000f7-SR for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 11:03:45 -0400 Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-dcc80d6006aso4750339276.0 for ; Tue, 02 Apr 2024 08:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712070222; x=1712675022; darn=gnu.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=uB38tA2R1SmCuZNDolcMDAhNol1Um5RO/SCaY7EbrGU=; b=lO1DZE0guX80r4V02O6ArtGUmboQ0WZC1ZAEDu3ambL/J0F/7ETitjo/8w8/fTFsWH ZyaYyOkLX6ViZ4NEtNKM51gMa0TyHznBN6GxG0VIvIWTJstoJGQr5hpfSs2UTHs08lBZ GdqUtTmiz9xjNmaLWUyJwfkbrmFX9MxVbCAgXItE7UkT7CB3rQFzrYFCawQgL415WIw3 OB1BdpIuuOXhFxGGn8C2nvzfWJ9qqYHLYbknxPeaMLpapiq7xERHfCvyNjP//vjMrBoM 2Jig6/Jv69+Rp70FioyUkwRRldmpIh2o63TKxO0a/YKqMxVdXxeSZO+N74F7XQOdbarI Vi6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712070222; x=1712675022; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=uB38tA2R1SmCuZNDolcMDAhNol1Um5RO/SCaY7EbrGU=; b=pRiTuGDhGODE5R0vYNC2mQzrSps7Fp1W2Hg99prV0X4wS63u4bKg8RqJ0c6JCgbMkC teN8GG3R7HZmQNRZB8yqZDSvWcfOQRvY2NRamFZqDbRZ1cJgVvjU35mXTU+j7JBFd8gV kvQ0YFyTfF6HggZ1phbYQCD+gOtQooGHkv+YcxqbdVySj96HR2eSkJSqcMK0T6UWgYHK 5URRrnZFHmSjG5U4zyZ8wJ2o2god9kzmYQRC1RI4hkoAs6di7M5KAHFaRe4Xd80zl+2X Pi7sZljBMBr3YtPIZkds8q4lQG1D/caeWVNQaovaGMmAODFn3aVCDcVaRspkU1hKWHPw B46A== X-Gm-Message-State: AOJu0Yyud2hUz+BFGnW95GAxLMW8AZ0IyNwA/BwEwbGwy0k2LVFCZ/gX Mlz60VB3oEhDuEiqN+strB3Tz3+nDzTBuUtLsXcuh0DEKSnVpvMrwWnlZSWnTizkVMofYqi+sVi cJNHMsvm1u/4azc8PlkLzxnAsAaZjsexS3M0= X-Google-Smtp-Source: AGHT+IFN44YLkfEeHlw7rPw/0JJKomR9OopEYHWKPwbAlQLurGPz7cnKCZ62WLkBvtHM9rmq4FJp0IqiDXTgrNS2Pis= X-Received: by 2002:a25:cd84:0:b0:dcb:ff73:2262 with SMTP id d126-20020a25cd84000000b00dcbff732262mr10335741ybf.36.1712070221646; Tue, 02 Apr 2024 08:03:41 -0700 (PDT) MIME-Version: 1.0 From: Javier Olaechea Date: Tue, 2 Apr 2024 10:03:30 -0500 Message-ID: Subject: [PATCH] Add sqlite-execute-batch command To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="00000000000064652006151e6918" Received-SPF: pass client-ip=2607:f8b0:4864:20::b31; envelope-from=pirata@gmail.com; helo=mail-yb1-xb31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --00000000000064652006151e6918 Content-Type: multipart/alternative; boundary="00000000000064651f06151e6916" --00000000000064651f06151e6916 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi, while writing tests for an Emacs package I found myself needing to execute multiple statements against an in-memory database, to initialize the schema. Currently there is no easy way to do so as sqlite-execute only executes the first command and ignores the rest. The reason most likely being that accepting arguments for multiple statements and properly preparing would be a tricky task. So instead I'm adding the functionality as a new function that takes no arguments. In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.18.0, Xaw3d scroll bars) Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Ubuntu 20.04.6 LTS Configured using: 'configure --prefix=3D/nix/store/0g4xxdsn4xp9qhgc4cylbksqpwsn51vc-emacs-29.1 --disable-build-details --with-modules --with-x-toolkit=3Dlucid --with-xft --with-cairo --with-native-compilation --with-tree-sitter --with-xinput2' --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --00000000000064651f06151e6916 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi, while writing tests for an Emacs package I found mysel= f needing to
execute multiple statements against an in-memory database, = to initialize
the schema. Currently there is no easy way to do so as sql= ite-execute
only executes the first command and ignores the rest. The re= ason most
likely being that accepting arguments for multiple statements = and
properly preparing would be a tricky task. So instead I'm adding= the
functionality as a new function that takes no arguments.

In GNU Emacs 29.1 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
versi= on 1.18.0, Xaw3d scroll bars)
Windowing system distributor 'The X.Or= g Foundation', version 11.0.12013000
System Description: Ubuntu 20.0= 4.6 LTS

Configured using:
=C2=A0'configure
=C2=A0--prefix= =3D/nix/store/0g4xxdsn4xp9qhgc4cylbksqpwsn51vc-emacs-29.1
=C2=A0--disabl= e-build-details --with-modules --with-x-toolkit=3Dlucid
=C2=A0--with-xft= --with-cairo --with-native-compilation --with-tree-sitter
=C2=A0--with-= xinput2'

--=
"I object to doing things that computers can do." = =E2=80=94 Olin Shivers
--00000000000064651f06151e6916-- --00000000000064652006151e6918 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-sqlite-execute-batch-command.patch" Content-Disposition: attachment; filename="0001-Add-sqlite-execute-batch-command.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luiidoik0 RnJvbSA0NTRiMjNjYjMxMzMyZmJkNWI1ZDJjNTExNzM5NGM1Nzg1ODFiNzJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXZpZXIgT2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRh dGU6IFN1biwgMzEgTWFyIDIwMjQgMjM6MDc6MTAgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQg c3FsaXRlLWV4ZWN1dGUtYmF0Y2ggY29tbWFuZAoKVGhpcyBjb21tYW5kIGlzIHNpbWlsYXIgdG8g c3FsaXRlLWV4ZWN1dGUgZXhjZXB0IHRoYXQgaXQgZXhlY3V0ZXMKbXVsdGlwbGUgc3RhdGVtZW50 cyBpbiBleGNoYW5nZSBmb3Igbm90IGFjY2VwdGluZyBhbnkgYXJndW1lbnRzLgoKKiBkb2MvbGlz cHJlZi90ZXh0LnRleGkgKERhdGFiYXNlKTogRG9jdW1lbnQgaXQuCiogc3JjL3NxbGl0ZS5jIChG c3FsaXRlX2V4ZWN1dGVfYmF0Y2gpOiBBZGQgc3FsaXRlX2V4ZWN1dGVfYmF0Y2gKY29tbWFuZC4g SXQgaXMgc2ltaWxhciB0byBzcWxpdGUtZXhlY3V0ZSBidXQgaXQgZXhlY3V0ZXMgYWxsIHRoZQpz dGF0ZW1lbnRzIGluIHRoZSBxdWVyeS4gVW5saWtlIHNxbGl0ZS1leGVjdXRlIHRoZSBjb21tYW5k IGRvZXNuJ3QgdGFrZQphbnkgYXJndW1lbnRzIHRvIHBhc3MgZG93biB0byB0aGUgc3RhdGVtZW50 cy4KLS0tCiBkb2MvbGlzcHJlZi90ZXh0LnRleGkgfCAgNiArKysrKysKIHNyYy9zcWxpdGUuYyAg ICAgICAgICB8IDEwICsrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMTYgaW5zZXJ0aW9ucygr KQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL3RleHQudGV4aSBiL2RvYy9saXNwcmVmL3RleHQu dGV4aQppbmRleCA5MGUyYzZjZTg4Mi4uY2FkNmRmNTJlNTUgMTAwNjQ0Ci0tLSBhL2RvYy9saXNw cmVmL3RleHQudGV4aQorKysgYi9kb2MvbGlzcHJlZi90ZXh0LnRleGkKQEAgLTU0MDQsNiArNTQw NCwxMiBAQCBEYXRhYmFzZQogCiBAZW5kIGRlZnVuCiAKK0BkZWZ1biBzcWxpdGUtZXhlY3V0ZS1i YXRjaCBkYiBzdGF0ZW1lbnRzCitFeGVjdXRlIHRoZSBAYWNyb255bXtTUUx9IEB2YXJ7c3RhdGVt ZW50c30uIFRoaXMgbWlnaHQgYmUgdXNlZnVsIHdoZW4gd2UKK3dhbnQgdG8gZXhlY3V0ZSBtdWx0 aXBsZSBAYWNyb255bXtEREx9IHN0YXRlbWVudHMuCisKK0BlbmQgZGVmdW4KKwogQGRlZnVuIHNx bGl0ZS1zZWxlY3QgZGIgcXVlcnkgJm9wdGlvbmFsIHZhbHVlcyByZXR1cm4tdHlwZQogU2VsZWN0 IHNvbWUgZGF0YSBmcm9tIEB2YXJ7ZGJ9IGFuZCByZXR1cm4gdGhlbS4gIEZvciBpbnN0YW5jZToK IApkaWZmIC0tZ2l0IGEvc3JjL3NxbGl0ZS5jIGIvc3JjL3NxbGl0ZS5jCmluZGV4IDI2MTA4MGRh NjczLi4wNDM4MDE0NTlkMiAxMDA2NDQKLS0tIGEvc3JjL3NxbGl0ZS5jCisrKyBiL3NyYy9zcWxp dGUuYwpAQCAtNjQ2LDYgKzY0NiwxNSBAQCBzcWxpdGVfZXhlYyAoc3FsaXRlMyAqc2RiLCBjb25z dCBjaGFyICpxdWVyeSkKICAgcmV0dXJuIFF0OwogfQogCitERUZVTiAoInNxbGl0ZS1leGVjdXRl LWJhdGNoIiwgRnNxbGl0ZV9leGVjdXRlX2JhdGNoLCBTc3FsaXRlX2V4ZWN1dGVfYmF0Y2gsIDIs IDIsIDAsCisgICAgICAgZG9jOiAvKiBFeGVjdXRlIG11bHRpcGxlIFNRTCBzdGF0ZW1lbnRzLiAg Ki8pCisgIChMaXNwX09iamVjdCBkYiwgTGlzcF9PYmplY3QgcXVlcnkpCit7CisgIGNoZWNrX3Nx bGl0ZSAoZGIsIGZhbHNlKTsKKyAgQ0hFQ0tfU1RSSU5HIChxdWVyeSk7CisgIHJldHVybiBzcWxp dGVfZXhlYyAoWFNRTElURSAoZGIpLT5kYiwgU1NEQVRBIChxdWVyeSkpOworfQorCiBERUZVTiAo InNxbGl0ZS10cmFuc2FjdGlvbiIsIEZzcWxpdGVfdHJhbnNhY3Rpb24sIFNzcWxpdGVfdHJhbnNh Y3Rpb24sIDEsIDEsIDAsCiAgICAgICAgZG9jOiAvKiBTdGFydCBhIHRyYW5zYWN0aW9uIGluIERC LiAgKi8pCiAgIChMaXNwX09iamVjdCBkYikKQEAgLTg2Niw2ICs4NzUsNyBAQCBzeW1zX29mX3Nx bGl0ZSAodm9pZCkKICAgZGVmc3ViciAoJlNzcWxpdGVfY2xvc2UpOwogICBkZWZzdWJyICgmU3Nx bGl0ZV9leGVjdXRlKTsKICAgZGVmc3ViciAoJlNzcWxpdGVfc2VsZWN0KTsKKyAgZGVmc3ViciAo JlNzcWxpdGVfZXhlY3V0ZV9iYXRjaCk7CiAgIGRlZnN1YnIgKCZTc3FsaXRlX3RyYW5zYWN0aW9u KTsKICAgZGVmc3ViciAoJlNzcWxpdGVfY29tbWl0KTsKICAgZGVmc3ViciAoJlNzcWxpdGVfcm9s bGJhY2spOwotLSAKMi4yOS4yLjE1NC5nN2Y3ZWJlMDU0YQoK --00000000000064652006151e6918-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 12:22:27 2024 Received: (at 70145) by debbugs.gnu.org; 2 Apr 2024 16:22:28 +0000 Received: from localhost ([127.0.0.1]:55840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrgu1-0008OB-Qf for submit@debbugs.gnu.org; Tue, 02 Apr 2024 12:22:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:60394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrgty-0008NF-Pw for 70145@debbugs.gnu.org; Tue, 02 Apr 2024 12:22:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrgto-0001ss-E2; Tue, 02 Apr 2024 12:22:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dSkizMr+OF1g8oJeF372dxeaALzih7MEQAdbTV8/588=; b=cgZa5CqZkxIH I7lNhOLLvMO7dQYunApWprEPGwqOhNlxH+zuWOjEVi89RMQQq2Bzw1GmLfVAtXFyNX+67DmRK2Ysw 2li8jqrxs6dAV2Xy41l88bEh6qYkLc/6eOILCijyO5eCgonnBt90vXM6JrhI36WV/k2Dr5lcEY7lh zg4/WXJ3J0O9srDAa7B0T2YWKzZ6uOoTEN5JKPPHqmAT81pIB5/ECEY/xz7UnNAfkUXjXfK5SN3KT J5VW86eLH63s1tTedJhOiU+AadonP9Img/Nb4VIkRxkx/+WBzY4VusIrhTvUHe6aGLrysWDFVpEo0 Tdgm1WYGvUlrUBF58LV0lQ==; Date: Tue, 02 Apr 2024 19:21:52 +0300 Message-Id: <86bk6rag67.fsf@gnu.org> From: Eli Zaretskii To: Javier Olaechea In-Reply-To: (message from Javier Olaechea on Tue, 2 Apr 2024 10:03:30 -0500) Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Javier Olaechea > Date: Tue, 2 Apr 2024 10:03:30 -0500 > > Hi, while writing tests for an Emacs package I found myself needing to > execute multiple statements against an in-memory database, to initialize > the schema. Currently there is no easy way to do so as sqlite-execute > only executes the first command and ignores the rest. The reason most > likely being that accepting arguments for multiple statements and > properly preparing would be a tricky task. So instead I'm adding the > functionality as a new function that takes no arguments. Thanks. > +DEFUN ("sqlite-execute-batch", Fsqlite_execute_batch, Ssqlite_execute_batch, 2, 2, 0, > + doc: /* Execute multiple SQL statements. */) > + (Lisp_Object db, Lisp_Object query) > +{ > + check_sqlite (db, false); > + CHECK_STRING (query); > + return sqlite_exec (XSQLITE (db)->db, SSDATA (query)); > +} > + This has a subtle bug: it will only work correctly for plain-ASCII string in QUERY. If QUERY is allowed to included non-ASCII characters, you need to encode it using encode_string. Also, the doc string should mention the function's arguments, and it should say what kind of Lisp object is QUERY. > +@defun sqlite-execute-batch db statements > +Execute the @acronym{SQL} @var{statements}. This might be useful when we > +want to execute multiple @acronym{DDL} statements. Same here, and in addition please leave two spaces between sentences, per our conventions (in the commit log message as well). From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 14:52:35 2024 Received: (at 70145) by debbugs.gnu.org; 2 Apr 2024 18:52:35 +0000 Received: from localhost ([127.0.0.1]:56337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrjFL-0001KA-0o for submit@debbugs.gnu.org; Tue, 02 Apr 2024 14:52:35 -0400 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]:44455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrjFJ-0001JT-I6 for 70145@debbugs.gnu.org; Tue, 02 Apr 2024 14:52:34 -0400 Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-dcc84ae94c1so5186917276.1 for <70145@debbugs.gnu.org>; Tue, 02 Apr 2024 11:52:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712083944; x=1712688744; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=p/W+JUVJWyzWFmW1/IDa2TszGYO0/bpvcdj3Z9SGzs0=; b=iL0c3GYpdThm7bIWpw6FTPSobqXtz5hkchE6Iw0bOpyqOE32G9K1h2qcrE85cTjPsK Dzr1DF2RLpco1LFLOUz1VZKG4stJS51eYonm0Wt+euWqz/Io7wWLKr8vWYbueO4zOuzD t5TRg9QuQtzEdng3Bq+S1L0oo5HxwqOrwo/S3Gcg5QopwWYfjFnlnnLV2BVn4vVZ+iYl WoMDMkz4IYi08cvhFHVwynn+6RI680ArQZjTEd656uLGEbFKaXAuyeXt+2Pt3qKpFBdr 7EiC7b2E4n80EpRbLUts3H7GXuSHNziXxkT3S0oeWaDn/d2MN+cF3Dcwi+b+wa1ilJcy HVzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712083944; x=1712688744; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p/W+JUVJWyzWFmW1/IDa2TszGYO0/bpvcdj3Z9SGzs0=; b=Eoga+r6pOMoBVvdzcwVlnlHkGLXGgvi2DECg010sUQs/UkjOSjS5J13zAsRVGLCPE5 Do7LXzyi07eInCMkRNfq4giRkomsbNTO7UwDTEhsNiOt0MWpNoQ6UEmoJi9ZrtUlWaoD zRc/VRCBuOJIvaWabGM0q1NG48WaeIdGxwa16aHWcpcpXFpoey2q6GRSVdo8iAVGgGgS HKsm/KK9c7g/oZwtihiENXECppP9o17MaB5no02aR29uvVzymA/sJX+zVT2TdXOwpNTF cCtAq8l5qnNA7H0U/eNTHnFzCv5sKxKfIUkMzZSj/NM7rsW0LSqUzQmqyyfNvTkBITJj 2kZA== X-Gm-Message-State: AOJu0YwN2gYqs/mRBAzqG/jKMSOjtwqOm+lZGvTMxCKL1e8wPccoGCwb xeRCQl58mc9sa0Y34XBVUpUMf5wIexlcXMaxQwOtN6Lc79W1Fb9RSF9GgYfkYzOTNemkROrdIQP 3+o7hGlP0pqnJTI3eTpkGj4hxADk= X-Google-Smtp-Source: AGHT+IGRGAb9SKNa2NdhiSIGOuTi8Cn69zeEClBMYJZ8D50z452a7lA7aVoCouJl0rFrsm5gCd+aMFpft3HYn3EdQuo= X-Received: by 2002:a25:bac6:0:b0:dcf:bc57:cd61 with SMTP id a6-20020a25bac6000000b00dcfbc57cd61mr11914222ybk.50.1712083943881; Tue, 02 Apr 2024 11:52:23 -0700 (PDT) MIME-Version: 1.0 References: <86bk6rag67.fsf@gnu.org> In-Reply-To: <86bk6rag67.fsf@gnu.org> From: Javier Olaechea Date: Tue, 2 Apr 2024 13:52:12 -0500 Message-ID: Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command To: Eli Zaretskii Content-Type: multipart/mixed; boundary="0000000000004d18700615219b5c" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000004d18700615219b5c Content-Type: multipart/alternative; boundary="0000000000004d186e0615219b5a" --0000000000004d186e0615219b5a Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thanks, I've updated the patch according to the feedback. Btw I have a basic test for the functionality which I used to validate the code before submitting the patch. Should I include it in test/sqlite-tests.el? --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --0000000000004d186e0615219b5a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, I've updated the patch according to the f= eedback.

Btw I have a basic test for the func= tionality which I used to validate the code before submitting the patch. Sh= ould I include it in test/sqlite-tests.el?

--
&q= uot;I object to doing things that computers can do." =E2=80=94 Olin Sh= ivers
--0000000000004d186e0615219b5a-- --0000000000004d18700615219b5c Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Add-sqlite-execute-batch-command.patch" Content-Disposition: attachment; filename="0001-Add-sqlite-execute-batch-command.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luiqadtn0 RnJvbSA2Yzk4NDc5OWEzOTM2MzAwYmJkZTYyZTI0Y2NlMjFkZTE5ZmEzYjNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXZpZXIgT2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRh dGU6IFN1biwgMzEgTWFyIDIwMjQgMjM6MDc6MTAgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQg c3FsaXRlLWV4ZWN1dGUtYmF0Y2ggY29tbWFuZAoKVGhpcyBjb21tYW5kIGlzIHNpbWlsYXIgdG8g c3FsaXRlLWV4ZWN1dGUgZXhjZXB0IHRoYXQgaXQgZXhlY3V0ZXMKbXVsdGlwbGUgc3RhdGVtZW50 cyBpbiBleGNoYW5nZSBmb3Igbm90IGFjY2VwdGluZyBhbnkgYXJndW1lbnRzLgoKKiBkb2MvbGlz cHJlZi90ZXh0LnRleGkgKERhdGFiYXNlKTogRG9jdW1lbnQgaXQuCiogc3JjL3NxbGl0ZS5jIChG c3FsaXRlX2V4ZWN1dGVfYmF0Y2gpOiBBZGQgc3FsaXRlX2V4ZWN1dGVfYmF0Y2gKY29tbWFuZC4g IEl0IGlzIHNpbWlsYXIgdG8gc3FsaXRlLWV4ZWN1dGUgYnV0IGl0IGV4ZWN1dGVzIGFsbCB0aGUK c3RhdGVtZW50cyBpbiB0aGUgcXVlcnkuICBVbmxpa2Ugc3FsaXRlLWV4ZWN1dGUgdGhlIGNvbW1h bmQgZG9lc24ndCB0YWtlCmFueSBhcmd1bWVudHMgdG8gcGFzcyBkb3duIHRvIHRoZSBzdGF0ZW1l bnRzLgotLS0KIGRvYy9saXNwcmVmL3RleHQudGV4aSB8ICA4ICsrKysrKysrCiBzcmMvc3FsaXRl LmMgICAgICAgICAgfCAxMiArKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjAgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL3RleHQudGV4aSBiL2RvYy9saXNwcmVm L3RleHQudGV4aQppbmRleCA5MGUyYzZjZTg4Mi4uZjFmOGY4MTM5ODEgMTAwNjQ0Ci0tLSBhL2Rv Yy9saXNwcmVmL3RleHQudGV4aQorKysgYi9kb2MvbGlzcHJlZi90ZXh0LnRleGkKQEAgLTU0MDQs NiArNTQwNCwxNCBAQCBEYXRhYmFzZQogCiBAZW5kIGRlZnVuCiAKK0BkZWZ1biBzcWxpdGUtZXhl Y3V0ZS1iYXRjaCBkYiBzdGF0ZW1lbnRzCitFeGVjdXRlIHRoZSBAYWNyb255bXtTUUx9IEB2YXJ7 c3RhdGVtZW50c30uICBAdmFye3N0YXRlbWVudHN9IGlzIGEKK3N0cmluZyBjb250YWluaW5nIDAg b3IgbW9yZSBAYWNyb255bXtTUUx9IHN0YXRlbWVudHMuICBUaGlzIGNvbW1hbmQKK21pZ2h0IGJl IHVzZWZ1bCB3aGVuIHdlIHdhbnQgdG8gZXhlY3V0ZSBtdWx0aXBsZSBAYWNyb255bXtEREx9Citz dGF0ZW1lbnRzLgorCitAZW5kIGRlZnVuCisKIEBkZWZ1biBzcWxpdGUtc2VsZWN0IGRiIHF1ZXJ5 ICZvcHRpb25hbCB2YWx1ZXMgcmV0dXJuLXR5cGUKIFNlbGVjdCBzb21lIGRhdGEgZnJvbSBAdmFy e2RifSBhbmQgcmV0dXJuIHRoZW0uICBGb3IgaW5zdGFuY2U6CiAKZGlmZiAtLWdpdCBhL3NyYy9z cWxpdGUuYyBiL3NyYy9zcWxpdGUuYwppbmRleCAyNjEwODBkYTY3My4uYzYwNmZhNWY4MzEgMTAw NjQ0Ci0tLSBhL3NyYy9zcWxpdGUuYworKysgYi9zcmMvc3FsaXRlLmMKQEAgLTY0Niw2ICs2NDYs MTcgQEAgc3FsaXRlX2V4ZWMgKHNxbGl0ZTMgKnNkYiwgY29uc3QgY2hhciAqcXVlcnkpCiAgIHJl dHVybiBRdDsKIH0KIAorREVGVU4gKCJzcWxpdGUtZXhlY3V0ZS1iYXRjaCIsIEZzcWxpdGVfZXhl Y3V0ZV9iYXRjaCwgU3NxbGl0ZV9leGVjdXRlX2JhdGNoLCAyLCAyLCAwLAorICAgICAgIGRvYzog LyogRXhlY3V0ZSBtdWx0aXBsZSBTUUwgc3RhdGVtZW50cyBpbiBEQi4KK1F1ZXJ5IGlzIGEgc3Ry aW5nIGNvbnRhaW5pbmcgMCBvciBtb3JlIFNRTCBzdGF0ZW1lbnRzLiAgKi8pCisgIChMaXNwX09i amVjdCBkYiwgTGlzcF9PYmplY3QgcXVlcnkpCit7CisgIGNoZWNrX3NxbGl0ZSAoZGIsIGZhbHNl KTsKKyAgQ0hFQ0tfU1RSSU5HIChxdWVyeSk7CisgIExpc3BfT2JqZWN0IGVuY29kZWQgPSBlbmNv ZGVfc3RyaW5nKHF1ZXJ5KTsKKyAgcmV0dXJuIHNxbGl0ZV9leGVjIChYU1FMSVRFIChkYiktPmRi LCBTU0RBVEEgKGVuY29kZWQpKTsKK30KKwogREVGVU4gKCJzcWxpdGUtdHJhbnNhY3Rpb24iLCBG c3FsaXRlX3RyYW5zYWN0aW9uLCBTc3FsaXRlX3RyYW5zYWN0aW9uLCAxLCAxLCAwLAogICAgICAg IGRvYzogLyogU3RhcnQgYSB0cmFuc2FjdGlvbiBpbiBEQi4gICovKQogICAoTGlzcF9PYmplY3Qg ZGIpCkBAIC04NjYsNiArODc3LDcgQEAgc3ltc19vZl9zcWxpdGUgKHZvaWQpCiAgIGRlZnN1YnIg KCZTc3FsaXRlX2Nsb3NlKTsKICAgZGVmc3ViciAoJlNzcWxpdGVfZXhlY3V0ZSk7CiAgIGRlZnN1 YnIgKCZTc3FsaXRlX3NlbGVjdCk7CisgIGRlZnN1YnIgKCZTc3FsaXRlX2V4ZWN1dGVfYmF0Y2gp OwogICBkZWZzdWJyICgmU3NxbGl0ZV90cmFuc2FjdGlvbik7CiAgIGRlZnN1YnIgKCZTc3FsaXRl X2NvbW1pdCk7CiAgIGRlZnN1YnIgKCZTc3FsaXRlX3JvbGxiYWNrKTsKLS0gCjIuMjkuMi4xNTQu ZzdmN2ViZTA1NGEKCg== --0000000000004d18700615219b5c Content-Type: text/x-emacs-lisp; charset="UTF-8"; name="smoke.el" Content-Disposition: attachment; filename="smoke.el" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luiqiaxk1 OzsgLSotIGxleGljYWwtYmluZGluZzogdCAtKi0KCihyZXF1aXJlICdlcnQpCgooZXJ0LWRlZnRl c3Qgd2l0aC1zcWxpdGUtZXhlY3V0ZS1iYXRjaC10ZXN0ICgpCiAgKGxldCAoKGRiIChzcWxpdGUt b3BlbiBuaWwpKQogICAgICAgIChxdWVyeSAod2l0aC10ZW1wLWJ1ZmZlcgogICAgICAgICAgICAg ICAgIChpbnNlcnQgIi0tIC0qLSBzcWwtcHJvZHVjdDogc3FsaXRlIC0qLQoKLS0gSSDwn5KYIGVt b2ppcwoKQ1JFQVRFIFRBQkxFIHNldHRpbmdzICgKICBuYW1lIFRFWFQgTk9UIE5VTEwsCiAgdmFs dWUgVEVYVCwKICBzZWN0aW9uIFRFWFQgTk9UIE5VTEwsCiAgUFJJTUFSWSBLRVkgKHNlY3Rpb24s IG5hbWUpCik7CgpDUkVBVEUgVEFCTEUgdGFncyAoCiAgbmFtZSBURVhUIFBSSU1BUlkgS0VZIE5P VCBOVUxMCik7CgotLSBDUkVBVEUgVEFCTEUgdG9kb19zdGF0ZXMgKGlkIElOVEVHRVIgUFJJTUFS WSBLRVksIG5hbWUgVEVYVCBOT1QgTlVMTCk7CiIpCiAgICAgICAgICAgICAgICAgKGJ1ZmZlci1z dHJpbmcpKSkpCiAgICAoc3FsaXRlLWV4ZWN1dGUtYmF0Y2ggZGIgcXVlcnkpCiAgICAoc2hvdWxk IChlcXVhbCAnKCgic2V0dGluZ3MiKSAoInRhZ3MiKSkKICAgICAgICAgICAgICAgICAgIChzcWxp dGUtc2VsZWN0IGRiICJzZWxlY3QgbmFtZSBmcm9tIHNxbGl0ZV9tYXN0ZXIgd2hlcmUgdHlwZSA9 ICd0YWJsZScgYW5kIG5hbWUgbm90IGxpa2UgJ3NxbGl0ZV8lJyBvcmRlciBieSBuYW1lIikpKSkp Cg== --0000000000004d18700615219b5c-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 14:56:16 2024 Received: (at 70145) by debbugs.gnu.org; 2 Apr 2024 18:56:16 +0000 Received: from localhost ([127.0.0.1]:56342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrjIt-0001ex-Rl for submit@debbugs.gnu.org; Tue, 02 Apr 2024 14:56:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrjIq-0001dz-Vs for 70145@debbugs.gnu.org; Tue, 02 Apr 2024 14:56:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrjIh-0002Fv-NU; Tue, 02 Apr 2024 14:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=omNF7egO8POXB8+RWnmIX5AEnR1F0FnyUPlIAwd2cXI=; b=CV4rERWHN+ZP NLGOEv8dRnIXcRIRUOYIg6LgoyYu5k8Dd6FI2HxvxYh3LYk8oU54xREEpLQf5JLUrNrmebkFBIU4y D8jRGiiE+os+uAoYR6ZeuCeEEUfKdMlgsrnDrpQzhIfFXlZ2UdibH8QWa+8IrXWpZ2BX/0VbNbnij rSfUPcmImhAHfNUWccI+XKIr1Hnf2cg3QXao0bIikC51/7Uo71UDN4GsXiodq0biaxaivbI794ihc atk1VJAt4+eMPFIZnDx5t1qydME2RyOZ0VEt1grCIaWG3ij0x0Kou++mGg74HYzgQLP5Hi6Dl5UA8 IheQfgkXg1dz/m0voSRHhA==; Date: Tue, 02 Apr 2024 21:56:01 +0300 Message-Id: <864jcja91a.fsf@gnu.org> From: Eli Zaretskii To: Javier Olaechea In-Reply-To: (message from Javier Olaechea on Tue, 2 Apr 2024 13:52:12 -0500) Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command References: <86bk6rag67.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Javier Olaechea > Date: Tue, 2 Apr 2024 13:52:12 -0500 > Cc: 70145@debbugs.gnu.org > > Thanks, I've updated the patch according to the feedback. Thanks, will review soon. > Btw I have a basic test for the functionality which I used to validate the code before submitting the patch. > Should I include it in test/sqlite-tests.el? Yes, more tests are always welcome. From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 15:10:41 2024 Received: (at 70145) by debbugs.gnu.org; 2 Apr 2024 19:10:41 +0000 Received: from localhost ([127.0.0.1]:56365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrjWp-0002tg-Up for submit@debbugs.gnu.org; Tue, 02 Apr 2024 15:10:41 -0400 Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31]:50556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrjWo-0002sy-2X for 70145@debbugs.gnu.org; Tue, 02 Apr 2024 15:10:38 -0400 Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-dbed0710c74so4287830276.1 for <70145@debbugs.gnu.org>; Tue, 02 Apr 2024 12:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712085028; x=1712689828; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=OLMMo/Ip7uyg2AvBqipSASa4RM5P3NvCSMF1jkvbgdo=; b=KQkSLq2m6rFiIbL3LkrIElucEKlhnXLBixRJ+6r9wS54YuWV9uPbmYmcpxt4dgAin7 U2UJ5fQ6tpN0peJmMVUcSQLwmHGGGEYgIuOmDwichsCJVYzQaKzy7qW7PnIgOunVo5R+ 5243uv+Am8VDlSp2gmjwkUv30cfovB5Ha2XWWN8KhZOXPOPV6Ix7JT/xeGXRIZ9FYKLb ol9KouGt8uau62hGWBb3K9X7plf5ZpyUFh5nmS/fNKrrFEfXezIw7k6tLknL2f5X2AlZ wvSwByMK3Z9S7oV4MTqDwh5SIdmE9Ger7+xRzlb9afXaNCPWD17KJ1FS9nAvmqSoGk/A azHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712085028; x=1712689828; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OLMMo/Ip7uyg2AvBqipSASa4RM5P3NvCSMF1jkvbgdo=; b=ETmA8Ym7fAsAZnyxEK0MuvwuGWpS3rR7wUTBe8A+FY2wrjXMwNJlfdMx69zznMvf0W pp7D7KsDiN5KQ397G72IE89KyeQatMOmnQep921DzwTBwMUOegFA0/iOwDHNsTUXu5OS hZ8ZCwhp4QCRAhcn3q6fXkFEcFKli8BLsF+kI//NSrcks76LA32cgkiXgcTzaq+B7UFa B4+dnBNtr0GQQqFoyWM02udIdiDmjoAm1L73cN474rXE7zzUT2cuCJfl38GQr3PsB31X s57LnI/SwR9wThV46eAv/cFgApnwWhPevMwnYt66AMlLsEflIPFhIPYL31rQ/NWkO2ZB 8Q9A== X-Gm-Message-State: AOJu0Yw17kX0kdzuLFdVLx0XZQnaKLuEibochHk4pkWW0rZT33E9AB8L ZC/88iKhcdcBgZYrJO9gHYjm6IIJbfQE2vbE7Hc2d9c7zQM5EyyBJIiIPLADEPf/dYaBlxmAyqL kqQx/BQoZnHCUdOXZzRaakncSouUvCjxP X-Google-Smtp-Source: AGHT+IEACsiHR5vDccprXdofCWiuaWlnNmq9+C09NJSpMwJ0tz7GdEdeSB+NQM+cMj9pn5iBURKoa5fNjbTS0IHGFs4= X-Received: by 2002:a25:bac5:0:b0:dcc:d3ab:2fc0 with SMTP id a5-20020a25bac5000000b00dccd3ab2fc0mr11450333ybk.23.1712085027982; Tue, 02 Apr 2024 12:10:27 -0700 (PDT) MIME-Version: 1.0 References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> In-Reply-To: <864jcja91a.fsf@gnu.org> From: Javier Olaechea Date: Tue, 2 Apr 2024 14:10:15 -0500 Message-ID: Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000eb294e061521db05" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000eb294e061521db05 Content-Type: multipart/alternative; boundary="000000000000eb294c061521db03" --000000000000eb294c061521db03 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ok, updated the patch to include the test On Tue, Apr 2, 2024 at 1:56=E2=80=AFPM Eli Zaretskii wrote: > > From: Javier Olaechea > > Date: Tue, 2 Apr 2024 13:52:12 -0500 > > Cc: 70145@debbugs.gnu.org > > > > Thanks, I've updated the patch according to the feedback. > > Thanks, will review soon. > > > Btw I have a basic test for the functionality which I used to validate > the code before submitting the patch. > > Should I include it in test/sqlite-tests.el? > > Yes, more tests are always welcome. > --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000eb294c061521db03 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Ok, updated the patch to include the test

On Tue, Apr 2= , 2024 at 1:56=E2=80=AFPM Eli Zaretskii <eliz@gnu.org> wrote:
> From: Javier Olaechea <pirata@gmail.com>
> Date: Tue, 2 Apr 2024 13:52:12 -0500
> Cc: 70145@d= ebbugs.gnu.org
>
> Thanks, I've updated the patch according to the feedback.

Thanks, will review soon.

> Btw I have a basic test for the functionality which I used to validate= the code before submitting the patch.
> Should I include it in test/sqlite-tests.el?

Yes, more tests are always welcome.


--
"I objec= t to doing things that computers can do." =E2=80=94 Olin Shivers
--000000000000eb294c061521db03-- --000000000000eb294e061521db05 Content-Type: text/x-patch; charset="UTF-8"; name="0001-Add-sqlite-execute-batch-command.patch" Content-Disposition: attachment; filename="0001-Add-sqlite-execute-batch-command.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luir79mi0 RnJvbSBiMGNiZTA1YzdkYThhYmI0OWI0NWE3OTljMWIwNjZlNzg4Y2YxYzZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXZpZXIgT2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRh dGU6IFN1biwgMzEgTWFyIDIwMjQgMjM6MDc6MTAgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQg c3FsaXRlLWV4ZWN1dGUtYmF0Y2ggY29tbWFuZAoKVGhpcyBjb21tYW5kIGlzIHNpbWlsYXIgdG8g c3FsaXRlLWV4ZWN1dGUgZXhjZXB0IHRoYXQgaXQgZXhlY3V0ZXMKbXVsdGlwbGUgc3RhdGVtZW50 cyBpbiBleGNoYW5nZSBmb3Igbm90IGFjY2VwdGluZyBhbnkgYXJndW1lbnRzLgoKKiBkb2MvbGlz cHJlZi90ZXh0LnRleGkgKERhdGFiYXNlKTogRG9jdW1lbnQgaXQuCiogc3JjL3NxbGl0ZS5jIChG c3FsaXRlX2V4ZWN1dGVfYmF0Y2gpOiBBZGQgc3FsaXRlX2V4ZWN1dGVfYmF0Y2gKY29tbWFuZC4g IEl0IGlzIHNpbWlsYXIgdG8gc3FsaXRlLWV4ZWN1dGUgYnV0IGl0IGV4ZWN1dGVzIGFsbCB0aGUK c3RhdGVtZW50cyBpbiB0aGUgcXVlcnkuICBVbmxpa2Ugc3FsaXRlLWV4ZWN1dGUgdGhlIGNvbW1h bmQgZG9lc24ndCB0YWtlCmFueSBhcmd1bWVudHMgdG8gcGFzcyBkb3duIHRvIHRoZSBzdGF0ZW1l bnRzLgoqIHRlc3QvbGlzcC9zcWxpdGUtdGVzdHMuZWwgKHdpdGgtc3FsaXRlLWV4ZWN1dGUtYmF0 Y2gtdGVzdCk6IFRlc3QgaXQuCi0tLQogZG9jL2xpc3ByZWYvdGV4dC50ZXhpICAgICB8ICA4ICsr KysrKysrCiBzcmMvc3FsaXRlLmMgICAgICAgICAgICAgIHwgMTIgKysrKysrKysrKysrCiB0ZXN0 L2xpc3Avc3FsaXRlLXRlc3RzLmVsIHwgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwogMyBm aWxlcyBjaGFuZ2VkLCA0NSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3ByZWYv dGV4dC50ZXhpIGIvZG9jL2xpc3ByZWYvdGV4dC50ZXhpCmluZGV4IDkwZTJjNmNlODgyLi5mMWY4 ZjgxMzk4MSAxMDA2NDQKLS0tIGEvZG9jL2xpc3ByZWYvdGV4dC50ZXhpCisrKyBiL2RvYy9saXNw cmVmL3RleHQudGV4aQpAQCAtNTQwNCw2ICs1NDA0LDE0IEBAIERhdGFiYXNlCiAKIEBlbmQgZGVm dW4KIAorQGRlZnVuIHNxbGl0ZS1leGVjdXRlLWJhdGNoIGRiIHN0YXRlbWVudHMKK0V4ZWN1dGUg dGhlIEBhY3Jvbnlte1NRTH0gQHZhcntzdGF0ZW1lbnRzfS4gIEB2YXJ7c3RhdGVtZW50c30gaXMg YQorc3RyaW5nIGNvbnRhaW5pbmcgMCBvciBtb3JlIEBhY3Jvbnlte1NRTH0gc3RhdGVtZW50cy4g IFRoaXMgY29tbWFuZAorbWlnaHQgYmUgdXNlZnVsIHdoZW4gd2Ugd2FudCB0byBleGVjdXRlIG11 bHRpcGxlIEBhY3Jvbnlte0RETH0KK3N0YXRlbWVudHMuCisKK0BlbmQgZGVmdW4KKwogQGRlZnVu IHNxbGl0ZS1zZWxlY3QgZGIgcXVlcnkgJm9wdGlvbmFsIHZhbHVlcyByZXR1cm4tdHlwZQogU2Vs ZWN0IHNvbWUgZGF0YSBmcm9tIEB2YXJ7ZGJ9IGFuZCByZXR1cm4gdGhlbS4gIEZvciBpbnN0YW5j ZToKIApkaWZmIC0tZ2l0IGEvc3JjL3NxbGl0ZS5jIGIvc3JjL3NxbGl0ZS5jCmluZGV4IDI2MTA4 MGRhNjczLi5jNjA2ZmE1ZjgzMSAxMDA2NDQKLS0tIGEvc3JjL3NxbGl0ZS5jCisrKyBiL3NyYy9z cWxpdGUuYwpAQCAtNjQ2LDYgKzY0NiwxNyBAQCBzcWxpdGVfZXhlYyAoc3FsaXRlMyAqc2RiLCBj b25zdCBjaGFyICpxdWVyeSkKICAgcmV0dXJuIFF0OwogfQogCitERUZVTiAoInNxbGl0ZS1leGVj dXRlLWJhdGNoIiwgRnNxbGl0ZV9leGVjdXRlX2JhdGNoLCBTc3FsaXRlX2V4ZWN1dGVfYmF0Y2gs IDIsIDIsIDAsCisgICAgICAgZG9jOiAvKiBFeGVjdXRlIG11bHRpcGxlIFNRTCBzdGF0ZW1lbnRz IGluIERCLgorUXVlcnkgaXMgYSBzdHJpbmcgY29udGFpbmluZyAwIG9yIG1vcmUgU1FMIHN0YXRl bWVudHMuICAqLykKKyAgKExpc3BfT2JqZWN0IGRiLCBMaXNwX09iamVjdCBxdWVyeSkKK3sKKyAg Y2hlY2tfc3FsaXRlIChkYiwgZmFsc2UpOworICBDSEVDS19TVFJJTkcgKHF1ZXJ5KTsKKyAgTGlz cF9PYmplY3QgZW5jb2RlZCA9IGVuY29kZV9zdHJpbmcocXVlcnkpOworICByZXR1cm4gc3FsaXRl X2V4ZWMgKFhTUUxJVEUgKGRiKS0+ZGIsIFNTREFUQSAoZW5jb2RlZCkpOworfQorCiBERUZVTiAo InNxbGl0ZS10cmFuc2FjdGlvbiIsIEZzcWxpdGVfdHJhbnNhY3Rpb24sIFNzcWxpdGVfdHJhbnNh Y3Rpb24sIDEsIDEsIDAsCiAgICAgICAgZG9jOiAvKiBTdGFydCBhIHRyYW5zYWN0aW9uIGluIERC LiAgKi8pCiAgIChMaXNwX09iamVjdCBkYikKQEAgLTg2Niw2ICs4NzcsNyBAQCBzeW1zX29mX3Nx bGl0ZSAodm9pZCkKICAgZGVmc3ViciAoJlNzcWxpdGVfY2xvc2UpOwogICBkZWZzdWJyICgmU3Nx bGl0ZV9leGVjdXRlKTsKICAgZGVmc3ViciAoJlNzcWxpdGVfc2VsZWN0KTsKKyAgZGVmc3ViciAo JlNzcWxpdGVfZXhlY3V0ZV9iYXRjaCk7CiAgIGRlZnN1YnIgKCZTc3FsaXRlX3RyYW5zYWN0aW9u KTsKICAgZGVmc3ViciAoJlNzcWxpdGVfY29tbWl0KTsKICAgZGVmc3ViciAoJlNzcWxpdGVfcm9s bGJhY2spOwpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL3NxbGl0ZS10ZXN0cy5lbCBiL3Rlc3QvbGlz cC9zcWxpdGUtdGVzdHMuZWwKaW5kZXggZDQ4OTJhMjdlZmMuLjcwNTMwMjZlYjgyIDEwMDY0NAot LS0gYS90ZXN0L2xpc3Avc3FsaXRlLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9zcWxpdGUtdGVz dHMuZWwKQEAgLTQ4LDQgKzQ4LDI5IEBAIHdpdGgtc3FsaXRlLXRyYW5zYWN0aW9uL3JvbGxiYWNr CiAgICAgOzsgRmlyc3QgaW5zZXJ0aW9uIChhPTEpIHJvbGxlZCBiYWNrLgogICAgIChzaG91bGQt bm90IChzcWxpdGUtc2VsZWN0IGRiICJzZWxlY3QgKiBmcm9tIHRlc3QiKSkpKQogCisoZXJ0LWRl ZnRlc3Qgd2l0aC1zcWxpdGUtZXhlY3V0ZS1iYXRjaC10ZXN0ICgpCisgIChsZXQgKChkYiAoc3Fs aXRlLW9wZW4gbmlsKSkKKyAgICAgICAgKHF1ZXJ5ICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAg ICAgICAgICAgIChpbnNlcnQgIi0tIC0qLSBzcWwtcHJvZHVjdDogc3FsaXRlIC0qLQorCistLSBJ IPCfkpggZW1vamlzCisKK0NSRUFURSBUQUJMRSBzZXR0aW5ncyAoCisgIG5hbWUgVEVYVCBOT1Qg TlVMTCwKKyAgdmFsdWUgVEVYVCwKKyAgc2VjdGlvbiBURVhUIE5PVCBOVUxMLAorICBQUklNQVJZ IEtFWSAoc2VjdGlvbiwgbmFtZSkKKyk7CisKK0NSRUFURSBUQUJMRSB0YWdz8J+TjiAoCisgIG5h bWUgVEVYVCBQUklNQVJZIEtFWSBOT1QgTlVMTAorKTsKKworLS0gQ1JFQVRFIFRBQkxFIHRvZG9f c3RhdGVzIChpZCBJTlRFR0VSIFBSSU1BUlkgS0VZLCBuYW1lIFRFWFQgTk9UIE5VTEwpOworIikK KyAgICAgICAgICAgICAgICAgKGJ1ZmZlci1zdHJpbmcpKSkpCisgICAgKHNxbGl0ZS1leGVjdXRl LWJhdGNoIGRiIHF1ZXJ5KQorICAgIChzaG91bGQgKGVxdWFsICcoKCJzZXR0aW5ncyIpICgidGFn c/Cfk44iKSkKKyAgICAgICAgICAgICAgICAgICAoc3FsaXRlLXNlbGVjdCBkYiAic2VsZWN0IG5h bWUgZnJvbSBzcWxpdGVfbWFzdGVyIHdoZXJlIHR5cGUgPSAndGFibGUnIGFuZCBuYW1lIG5vdCBs aWtlICdzcWxpdGVfJScgb3JkZXIgYnkgbmFtZSIpKSkpKQorCiA7Ozsgc3FsaXRlLXRlc3RzLmVs IGVuZHMgaGVyZQotLSAKMi4yOS4yLjE1NC5nN2Y3ZWJlMDU0YQoK --000000000000eb294e061521db05-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 21:57:09 2024 Received: (at 70145) by debbugs.gnu.org; 3 Apr 2024 01:57:09 +0000 Received: from localhost ([127.0.0.1]:56655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrpsD-0004Fg-0V for submit@debbugs.gnu.org; Tue, 02 Apr 2024 21:57:09 -0400 Received: from mail-108-mta120.mxroute.com ([136.175.108.120]:37695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrps9-0004FD-UP for 70145@debbugs.gnu.org; Tue, 02 Apr 2024 21:57:07 -0400 Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta120.mxroute.com (ZoneMTA) with ESMTPSA id 18ea1ac73f60003bea.001 for <70145@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 03 Apr 2024 01:56:57 +0000 X-Zone-Loop: 7245d37ed2322586f36c57e22963d164d3e710e49400 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jbXmvxEspGJzWMMenSRe9djAmfu4SIeaFcEqFGDPnqE=; b=nRUSWt9pJRa9p4IZ6rr6YBQKd9 W+TbnX8cT579q1DPLW3rsbdK0DcN7gJve+ZaWOP28rE1HBlTWc+V6AS0ukBextCACzbv+6wfQ75r7 oYwhTPv+9edB20XPzp2lMNZkBCB86nnsok9j0/RmFtM+toqyN6izErFz8LabiqHARBOG7i+qeq8xh AQAORLlZh0NOeBH2nd5vFFag+8/BVH4qL3UsnO+rPFLSGxL/K+vLVPLt8LEyDBItB6Cm5AVeMjT2b zTDWj0uiG8cwBIScazrCJSAbnOBLFWdlgdbd7VcACsVgYSuhdDiCyDGAjPgjXidyX8AIxWG7x5NNl Tz+rIzlQ==; From: "J.P." To: Javier Olaechea Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command In-Reply-To: (Javier Olaechea's message of "Tue, 2 Apr 2024 14:10:15 -0500") References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> Date: Tue, 02 Apr 2024 18:56:54 -0700 Message-ID: <87o7arciop.fsf@neverwas.me> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: masked@neverwas.me X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Javier, Thanks for working on this. I think Emacs applications will find it handy for things like initializing a new database. Just a couple things I spotted in passing. (I don't really know anything, though, so feel free to ignore.) Javier Olaechea writes: > * test/lisp/sqlite-tests.el (with-sqlite-execute-batch-test): Test it. ~~~~ I think there's also a test/src/sqlite-tests.el file, which seems to contain tests for those primitives defined in src/sqlite.c. Perhaps this test should go there instead? > diff --git a/test/lisp/sqlite-tests.el b/test/lisp/sqlite-tests.el > index d4892a27efc..7053026eb82 100644 > --- a/test/lisp/sqlite-tests.el > +++ b/test/lisp/sqlite-tests.el > @@ -48,4 +48,29 @@ with-sqlite-transaction/rollback > ;; First insertion (a=1) rolled back. > (should-not (sqlite-select db "select * from test")))) > > +(ert-deftest with-sqlite-execute-batch-test () Maybe I'm mistaken, but I don't think you need the "with-" part (or the "-test" part), no? From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 22:42:30 2024 Received: (at 70145) by debbugs.gnu.org; 3 Apr 2024 02:42:30 +0000 Received: from localhost ([127.0.0.1]:56713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrqa6-0002P7-1P for submit@debbugs.gnu.org; Tue, 02 Apr 2024 22:42:30 -0400 Received: from mail-yb1-xb33.google.com ([2607:f8b0:4864:20::b33]:61481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrqa4-0002OJ-Bt for 70145@debbugs.gnu.org; Tue, 02 Apr 2024 22:42:29 -0400 Received: by mail-yb1-xb33.google.com with SMTP id 3f1490d57ef6-dd045349d42so5261320276.2 for <70145@debbugs.gnu.org>; Tue, 02 Apr 2024 19:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712112138; x=1712716938; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JpAIYVtNFXl7f7lKD9Vl2gpd8R0cSF0UsXgzHsQKYBg=; b=ModK3Cs4emPUgb6gbU99dftGg59chuecoTYEQUgm7EFJ25a5nzaozK4oZENBEkrHyL eDGj+QcY1IA6kF65vCYRxf6QqI+BV/i7PkAiCZNP/APYmGFPnWDT/xgGtd2Bwx4csvA/ 9UT9ECA5jivneNNz5iGF4dxBo7cXOwVPQ3kq3EQDs78XpvJNr/TMptiO/sGCJ2h+3Yey UvoIhr1eBlnvfgCQONfDf2/zPvYtc308Ke2sMbOYgm5/MPkqNRU7cCq02P+8X3Srs1NA tmGO5cSxmVxA00nCzJLXDdIeETGqY6E2shwqluxgr3I2qMPZue1Yp0ZFXNGrOdCxeKyF dWDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712112138; x=1712716938; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JpAIYVtNFXl7f7lKD9Vl2gpd8R0cSF0UsXgzHsQKYBg=; b=ksdbeuBv30sq1A+lXrzgcYTKdVgOvASpbv+nkS5v02QCBYq3JBcr7w7PuWWLf6VB0r p9PTG8hApbLCMX/OL9m4bZFVJXirEFjeHzdmrdHYODBgytJSYi13CoCKVy51voPeZBn5 EPsgfbr9UeCgClfvgUJA7lr68uO1I8DA77Ecra7MJ6eOtFuay9OQ/VbFhuTk7zUWhCq/ KuPvqfA0Ys0ctCHWR08KdYehu2jfIZf8wmnzcoF7KvxPXnw/K1uH6PXyIjYo+5AEG8GY HCLQltXWNzbrA/GI1wl4lqvg2dO5uZEdzGQsET4BAOUbaVWx0K4t1SyD6lKZrLvpbKQT J/DA== X-Forwarded-Encrypted: i=1; AJvYcCVZd0CjqWrrzDjUt9O+24lWQiWb8gT85Ywnsncdv7TCZ27xduehYfQq0zqUF5QpaNajCKWB4Uv+MgbvNwHRQ39D9JwzYnI= X-Gm-Message-State: AOJu0YzSP3OAyjykzaAqxinS5HQssPimXR0rkawZcti7mERv0ybfPi3I h2p6AKZ/V9+juBzE3u6IB8+ruQ8WdaxG7Ut9FiH5h5EmCSZKh0+2iOTunwDndRP9uEGcJV0zNjb /ZHRxJz4WuBOE4JWAbSlpg1vK5LI= X-Google-Smtp-Source: AGHT+IFphqzHkwWPbPYgCQUcGp/UlhkJmdHV5JurGiC6G4hWMxVxzLllbmIZ0myXKYAp5U//7MzzEG1seWGbRGuS5wQ= X-Received: by 2002:a5b:d01:0:b0:ddd:7459:c970 with SMTP id y1-20020a5b0d01000000b00ddd7459c970mr10458009ybp.63.1712112138522; Tue, 02 Apr 2024 19:42:18 -0700 (PDT) MIME-Version: 1.0 References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> <87o7arciop.fsf@neverwas.me> In-Reply-To: <87o7arciop.fsf@neverwas.me> From: Javier Olaechea Date: Tue, 2 Apr 2024 21:42:06 -0500 Message-ID: Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command To: "J.P." Content-Type: multipart/mixed; boundary="000000000000d537990615282b96" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000d537990615282b96 Content-Type: multipart/alternative; boundary="000000000000d537970615282b94" --000000000000d537970615282b94 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Thanks for working on this. I think Emacs applications will find it > handy for things like initializing a new database. Just a couple things > I spotted in passing. (I don't really know anything, though, so feel > free to ignore.) > Feedback is always welcome. It's not like I know anything either ^_^'. > I think there's also a test/src/sqlite-tests.el file, which seems to > contain tests for those primitives defined in src/sqlite.c. Perhaps this > test should go there instead? > > Thanks for pointing that out, I hadn't seen that file. It does seem like a better home for the test. > > diff --git a/test/lisp/sqlite-tests.el b/test/lisp/sqlite-tests.el > > index d4892a27efc..7053026eb82 100644 > > --- a/test/lisp/sqlite-tests.el > > +++ b/test/lisp/sqlite-tests.el > > @@ -48,4 +48,29 @@ with-sqlite-transaction/rollback > > ;; First insertion (a=3D1) rolled back. > > (should-not (sqlite-select db "select * from test")))) > > > > +(ert-deftest with-sqlite-execute-batch-test () > > Maybe I'm mistaken, but I don't think you need the "with-" part (or the > "-test" part), no? > I did find it contrary to the foo-test- prefix I've seen in the elisp code in the wild, but on matters of naming conventions I try to follow the motto: "When in Rome, do as Romans do". So I named the test according to the other tests in the file. Now that I placed it under test/src/sqlite-tests.el I've changed the name to align with the names of the test in that file. I've attached a new patch incorporating your feedback --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000d537970615282b94 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Thanks for working on this. I think Emacs applications will find it
handy for things like initializing a new database. Just a couple things
I spotted in passing. (I don't really know anything, though, so feel free to ignore.)

Feedback is always wel= come. It's not like I know anything either ^_^'.
=C2= =A0
I think there's also a test/src/sqlite-tests.el file, which seems to contain tests for those primitives defined in src/sqlite.c. Perhaps this test should go there instead?


Thanks for pointing that out, I hadn&#= 39;t seen that file. It does seem like a better home for the test.
=C2=A0
> diff --git a/test/lisp/sqlite-tests.el b/test/lisp/sqlite-tests.el
> index d4892a27efc..7053026eb82 100644
> --- a/test/lisp/sqlite-tests.el
> +++ b/test/lisp/sqlite-tests.el
> @@ -48,4 +48,29 @@ with-sqlite-transaction/rollback
>=C2=A0 =C2=A0 =C2=A0 ;; First insertion (a=3D1) rolled back.
>=C2=A0 =C2=A0 =C2=A0 (should-not (sqlite-select db "select * from = test"))))
>=C2=A0
> +(ert-deftest with-sqlite-execute-batch-test ()

Maybe I'm mistaken, but I don't think you need the "with-"= ; part (or the
"-test" part), no?

I did find it contrary to the foo-te= st- prefix I've seen in the elisp code in the wild, but on matters of n= aming conventions I try to follow the motto: "When in Rome, do as Roma= ns do". So I named the test according to the other tests in the file. = Now that I placed it under test/src/sqlite-tests.el I've changed the na= me to align with the names of the test in that file.

I've attached a new patch incorporating your feedback
<= div>
--
"I object to doing things that comp= uters can do." =E2=80=94 Olin Shivers
--000000000000d537970615282b94-- --000000000000d537990615282b96 Content-Type: text/x-patch; charset="UTF-8"; name="0001-Add-sqlite-execute-batch-command.patch" Content-Disposition: attachment; filename="0001-Add-sqlite-execute-batch-command.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luj726mf0 RnJvbSA1OWMwNDQ4MTZmYmQ0MjgzYTEzNGVmYTU0NTRhMzhhOTg1OTgwYjJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXZpZXIgT2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRh dGU6IFN1biwgMzEgTWFyIDIwMjQgMjM6MDc6MTAgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQg c3FsaXRlLWV4ZWN1dGUtYmF0Y2ggY29tbWFuZAoKVGhpcyBjb21tYW5kIGlzIHNpbWlsYXIgdG8g c3FsaXRlLWV4ZWN1dGUgZXhjZXB0IHRoYXQgaXQgZXhlY3V0ZXMKbXVsdGlwbGUgc3RhdGVtZW50 cyBpbiBleGNoYW5nZSBmb3Igbm90IGFjY2VwdGluZyBhbnkgYXJndW1lbnRzLgoKKiBkb2MvbGlz cHJlZi90ZXh0LnRleGkgKERhdGFiYXNlKTogRG9jdW1lbnQgaXQuCiogc3JjL3NxbGl0ZS5jIChG c3FsaXRlX2V4ZWN1dGVfYmF0Y2gpOiBBZGQgc3FsaXRlX2V4ZWN1dGVfYmF0Y2gKY29tbWFuZC4g IEl0IGlzIHNpbWlsYXIgdG8gc3FsaXRlLWV4ZWN1dGUgYnV0IGl0IGV4ZWN1dGVzIGFsbCB0aGUK c3RhdGVtZW50cyBpbiB0aGUgcXVlcnkuICBVbmxpa2Ugc3FsaXRlLWV4ZWN1dGUgdGhlIGNvbW1h bmQgZG9lc24ndCB0YWtlCmFueSBhcmd1bWVudHMgdG8gcGFzcyBkb3duIHRvIHRoZSBzdGF0ZW1l bnRzLgoqIHRlc3Qvc3JjL3NxbGl0ZS10ZXN0cy5lbCAoc3FsaXRlLW11bHRpcGxlLXN0YXRlbWVu dHMpOiBBZGQgc21va2UgdGVzdApmb3Igc3FsaXRlLWV4ZWN1dGUtYmF0Y2guCi0tLQogZG9jL2xp c3ByZWYvdGV4dC50ZXhpICAgIHwgIDggKysrKysrKysKIHNyYy9zcWxpdGUuYyAgICAgICAgICAg ICB8IDEyICsrKysrKysrKysrKwogdGVzdC9zcmMvc3FsaXRlLXRlc3RzLmVsIHwgMjYgKysrKysr KysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKQoK ZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL3RleHQudGV4aSBiL2RvYy9saXNwcmVmL3RleHQudGV4 aQppbmRleCA5MGUyYzZjZTg4Mi4uZjFmOGY4MTM5ODEgMTAwNjQ0Ci0tLSBhL2RvYy9saXNwcmVm L3RleHQudGV4aQorKysgYi9kb2MvbGlzcHJlZi90ZXh0LnRleGkKQEAgLTU0MDQsNiArNTQwNCwx NCBAQCBEYXRhYmFzZQogCiBAZW5kIGRlZnVuCiAKK0BkZWZ1biBzcWxpdGUtZXhlY3V0ZS1iYXRj aCBkYiBzdGF0ZW1lbnRzCitFeGVjdXRlIHRoZSBAYWNyb255bXtTUUx9IEB2YXJ7c3RhdGVtZW50 c30uICBAdmFye3N0YXRlbWVudHN9IGlzIGEKK3N0cmluZyBjb250YWluaW5nIDAgb3IgbW9yZSBA YWNyb255bXtTUUx9IHN0YXRlbWVudHMuICBUaGlzIGNvbW1hbmQKK21pZ2h0IGJlIHVzZWZ1bCB3 aGVuIHdlIHdhbnQgdG8gZXhlY3V0ZSBtdWx0aXBsZSBAYWNyb255bXtEREx9CitzdGF0ZW1lbnRz LgorCitAZW5kIGRlZnVuCisKIEBkZWZ1biBzcWxpdGUtc2VsZWN0IGRiIHF1ZXJ5ICZvcHRpb25h bCB2YWx1ZXMgcmV0dXJuLXR5cGUKIFNlbGVjdCBzb21lIGRhdGEgZnJvbSBAdmFye2RifSBhbmQg cmV0dXJuIHRoZW0uICBGb3IgaW5zdGFuY2U6CiAKZGlmZiAtLWdpdCBhL3NyYy9zcWxpdGUuYyBi L3NyYy9zcWxpdGUuYwppbmRleCAyNjEwODBkYTY3My4uYzYwNmZhNWY4MzEgMTAwNjQ0Ci0tLSBh L3NyYy9zcWxpdGUuYworKysgYi9zcmMvc3FsaXRlLmMKQEAgLTY0Niw2ICs2NDYsMTcgQEAgc3Fs aXRlX2V4ZWMgKHNxbGl0ZTMgKnNkYiwgY29uc3QgY2hhciAqcXVlcnkpCiAgIHJldHVybiBRdDsK IH0KIAorREVGVU4gKCJzcWxpdGUtZXhlY3V0ZS1iYXRjaCIsIEZzcWxpdGVfZXhlY3V0ZV9iYXRj aCwgU3NxbGl0ZV9leGVjdXRlX2JhdGNoLCAyLCAyLCAwLAorICAgICAgIGRvYzogLyogRXhlY3V0 ZSBtdWx0aXBsZSBTUUwgc3RhdGVtZW50cyBpbiBEQi4KK1F1ZXJ5IGlzIGEgc3RyaW5nIGNvbnRh aW5pbmcgMCBvciBtb3JlIFNRTCBzdGF0ZW1lbnRzLiAgKi8pCisgIChMaXNwX09iamVjdCBkYiwg TGlzcF9PYmplY3QgcXVlcnkpCit7CisgIGNoZWNrX3NxbGl0ZSAoZGIsIGZhbHNlKTsKKyAgQ0hF Q0tfU1RSSU5HIChxdWVyeSk7CisgIExpc3BfT2JqZWN0IGVuY29kZWQgPSBlbmNvZGVfc3RyaW5n KHF1ZXJ5KTsKKyAgcmV0dXJuIHNxbGl0ZV9leGVjIChYU1FMSVRFIChkYiktPmRiLCBTU0RBVEEg KGVuY29kZWQpKTsKK30KKwogREVGVU4gKCJzcWxpdGUtdHJhbnNhY3Rpb24iLCBGc3FsaXRlX3Ry YW5zYWN0aW9uLCBTc3FsaXRlX3RyYW5zYWN0aW9uLCAxLCAxLCAwLAogICAgICAgIGRvYzogLyog U3RhcnQgYSB0cmFuc2FjdGlvbiBpbiBEQi4gICovKQogICAoTGlzcF9PYmplY3QgZGIpCkBAIC04 NjYsNiArODc3LDcgQEAgc3ltc19vZl9zcWxpdGUgKHZvaWQpCiAgIGRlZnN1YnIgKCZTc3FsaXRl X2Nsb3NlKTsKICAgZGVmc3ViciAoJlNzcWxpdGVfZXhlY3V0ZSk7CiAgIGRlZnN1YnIgKCZTc3Fs aXRlX3NlbGVjdCk7CisgIGRlZnN1YnIgKCZTc3FsaXRlX2V4ZWN1dGVfYmF0Y2gpOwogICBkZWZz dWJyICgmU3NxbGl0ZV90cmFuc2FjdGlvbik7CiAgIGRlZnN1YnIgKCZTc3FsaXRlX2NvbW1pdCk7 CiAgIGRlZnN1YnIgKCZTc3FsaXRlX3JvbGxiYWNrKTsKZGlmZiAtLWdpdCBhL3Rlc3Qvc3JjL3Nx bGl0ZS10ZXN0cy5lbCBiL3Rlc3Qvc3JjL3NxbGl0ZS10ZXN0cy5lbAppbmRleCBhMTBkY2E5YTBj OS4uZTg3YTVmYzc3YjEgMTAwNjQ0Ci0tLSBhL3Rlc3Qvc3JjL3NxbGl0ZS10ZXN0cy5lbAorKysg Yi90ZXN0L3NyYy9zcWxpdGUtdGVzdHMuZWwKQEAgLTI2MSw0ICsyNjEsMzAgQEAgc3FsaXRlLXJl dHVybmluZwogCQkgICAgICAgICcoIkpvZSIgIkRvZSIpKQogICAgICAgICAnKCgxICJKb2UiKSkp KSkpKQogCisoZXJ0LWRlZnRlc3Qgc3FsaXRlLW11bHRpcGxlLXN0YXRlbWVudHMgKCkKKyAgKHNr aXAtdW5sZXNzIChzcWxpdGUtYXZhaWxhYmxlLXApKQorICAobGV0ICgoZGIgKHNxbGl0ZS1vcGVu IG5pbCkpCisgICAgICAgIChxdWVyeSAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAgICAgICAg ICAoaW5zZXJ0ICItLSAtKi0gc3FsLXByb2R1Y3Q6IHNxbGl0ZSAtKi0KKworLS0gSSDwn5KYIGVt b2ppcworCitDUkVBVEUgVEFCTEUgc2V0dGluZ3MgKAorICBuYW1lIFRFWFQgTk9UIE5VTEwsCisg IHZhbHVlIFRFWFQsCisgIHNlY3Rpb24gVEVYVCBOT1QgTlVMTCwKKyAgUFJJTUFSWSBLRVkgKHNl Y3Rpb24sIG5hbWUpCispOworCitDUkVBVEUgVEFCTEUgdGFnc/Cfk44gKAorICBuYW1lIFRFWFQg UFJJTUFSWSBLRVkgTk9UIE5VTEwKKyk7CisKKy0tIENSRUFURSBUQUJMRSB0b2RvX3N0YXRlcyAo aWQgSU5URUdFUiBQUklNQVJZIEtFWSwgbmFtZSBURVhUIE5PVCBOVUxMKTsKKyIpCisgICAgICAg ICAgICAgICAgIChidWZmZXItc3RyaW5nKSkpKQorICAgIChzcWxpdGUtZXhlY3V0ZS1iYXRjaCBk YiBxdWVyeSkKKyAgICAoc2hvdWxkIChlcXVhbCAnKCgic2V0dGluZ3MiKSAoInRhZ3Pwn5OOIikp CisgICAgICAgICAgICAgICAgICAgKHNxbGl0ZS1zZWxlY3QgZGIgInNlbGVjdCBuYW1lIGZyb20g c3FsaXRlX21hc3RlciB3aGVyZSB0eXBlID0gJ3RhYmxlJyBhbmQgbmFtZSBub3QgbGlrZSAnc3Fs aXRlXyUnIG9yZGVyIGJ5IG5hbWUiKSkpKSkKKwogOzs7IHNxbGl0ZS10ZXN0cy5lbCBlbmRzIGhl cmUKLS0gCjIuMjkuMi4xNTQuZzdmN2ViZTA1NGEKCg== --000000000000d537990615282b96-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 04:04:17 2024 Received: (at 70145) by debbugs.gnu.org; 13 Apr 2024 08:04:17 +0000 Received: from localhost ([127.0.0.1]:60050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYMy-0007cv-PC for submit@debbugs.gnu.org; Sat, 13 Apr 2024 04:04:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34828) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvYMw-0007bY-Af for 70145@debbugs.gnu.org; Sat, 13 Apr 2024 04:04:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvYMg-0007Tp-CL; Sat, 13 Apr 2024 04:03:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RFSE9NWTEYyfYrpVCOkB66cXTrKFWk7QME5JQXANi9c=; b=Ks/fcW1okfpx bgj9f6mld6VIgCAGy9IRuggqWEhdorCe2kfofPjlHxBW0fZ8PNgRjAbWYx8AsgM6LKUqD7Q//Csm9 b/dnOz4mmjt1PQ4EBuobaU19v45RmUydFUtyq0s7+9Pr49Hg+yMkzw2sn+sq7VeW0ko37uoMpZWTs 9SC39uhVQE2zQP+qBxHcar/127ZV1ynuKTi6q58tH3DExGYCncthd79CZuNErFF4TX5NhALxEWNFP 000I7nk6A5ofAqqLQJojaXntNR5WBsgxLsgJzhmWZfI4FDEAgdMIZgT6Q2TsJR+kzo5sLegBeR9cM fWjaru72CWSl9yzYRwx9Xg==; Date: Sat, 13 Apr 2024 11:03:53 +0300 Message-Id: <86a5lxr8nq.fsf@gnu.org> From: Eli Zaretskii To: Javier Olaechea In-Reply-To: (message from Javier Olaechea on Tue, 2 Apr 2024 21:42:06 -0500) Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> <87o7arciop.fsf@neverwas.me> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org, jp@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Javier Olaechea > Date: Tue, 2 Apr 2024 21:42:06 -0500 > Cc: Eli Zaretskii , 70145@debbugs.gnu.org > > Thanks for working on this. I think Emacs applications will find it > handy for things like initializing a new database. Just a couple things > I spotted in passing. (I don't really know anything, though, so feel > free to ignore.) > > Feedback is always welcome. It's not like I know anything either ^_^'. > > I think there's also a test/src/sqlite-tests.el file, which seems to > contain tests for those primitives defined in src/sqlite.c. Perhaps this > test should go there instead? > > Thanks for pointing that out, I hadn't seen that file. It does seem like a better home for the test. > > > diff --git a/test/lisp/sqlite-tests.el b/test/lisp/sqlite-tests.el > > index d4892a27efc..7053026eb82 100644 > > --- a/test/lisp/sqlite-tests.el > > +++ b/test/lisp/sqlite-tests.el > > @@ -48,4 +48,29 @@ with-sqlite-transaction/rollback > > ;; First insertion (a=1) rolled back. > > (should-not (sqlite-select db "select * from test")))) > > > > +(ert-deftest with-sqlite-execute-batch-test () > > Maybe I'm mistaken, but I don't think you need the "with-" part (or the > "-test" part), no? > > I did find it contrary to the foo-test- prefix I've seen in the elisp code in the wild, but on matters of naming > conventions I try to follow the motto: "When in Rome, do as Romans do". So I named the test according to the > other tests in the file. Now that I placed it under test/src/sqlite-tests.el I've changed the name to align with the > names of the test in that file. > > I've attached a new patch incorporating your feedback Thanks. This should have a NEWS entry announcing the new command. Also, to accept this contribution, we'd need a copyright assignment from you. Would you like to start the paperwork for that at this time? If yes, I will send you the form to fill and the instructions to go with it. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 23:32:42 2024 Received: (at 70145) by debbugs.gnu.org; 14 Apr 2024 03:32:43 +0000 Received: from localhost ([127.0.0.1]:34070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvqbe-0002jz-0Y for submit@debbugs.gnu.org; Sat, 13 Apr 2024 23:32:42 -0400 Received: from mail-yb1-xb2f.google.com ([2607:f8b0:4864:20::b2f]:45399) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvqbZ-0002iO-L5 for 70145@debbugs.gnu.org; Sat, 13 Apr 2024 23:32:35 -0400 Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-dc6d8bd618eso2025644276.3 for <70145@debbugs.gnu.org>; Sat, 13 Apr 2024 20:32:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713065537; x=1713670337; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WQTOS/+lIGyPDenIfOIb5t2goB7VoC6GO7U7AerHwWM=; b=FBk8RTvQ6P2qBrUTNyMTJkqCJ0QoYFu0f4WYH7occiNZYxNJ/YqikQmlY3NZ2ntebb Jedbn7zehgd+NC2L7oiydCZMuG4Lh10zW7IELEhLSijUegNOwUvARNEjWhD/Pih8VA9C vmIsgyOVm6fZIs8O1ATtoFUfe+eUG/MeUnC7zUsp3jBl/0dNgXcakZk6NATyasVa6Kg2 lgbTKGXhweyj4JjSkxKmwxaAVAOmydBvME5y6vtebw5XyD3Fz+Yw1YrDtsleQK7xARVq EwFNJ/ocUTe5+B4UTz7Cu07x/fODxd0KBS//vD4fAL6aV4+w3pNuN4VviifnEwzs5XEx FU/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713065537; x=1713670337; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WQTOS/+lIGyPDenIfOIb5t2goB7VoC6GO7U7AerHwWM=; b=p5J3BX0RmD/3ribnpNnsMCH9ZJLDwdyEzS02UzxVg/hS7MUmC3e/xOQA6uqxKaw2D9 A9C1LinxINg7QubmkRYWAHDtUfRQmH1LD39PsSqoFgdGQXd0SRzkUmBTorCY4xvrn0kz qaRKGTKGkcgPQfF4MU2cK5/+FKfN3D3qpW31WPyv7q1TqQmcaHrTkBVmN/KGSMAuV/MT XgriimSiIpzikXxULiCwGD3SEQ66wQ1m1yHg0r+sgD06b+nahd2jAUKCwY5hprR8J3Xd LGyiSDs6y794RjcBxtAnzFl4sr2XSf4r9Ss0EDQIeN281eyiIMI6NTfj1RTSVM+aWJWU QKog== X-Forwarded-Encrypted: i=1; AJvYcCXBNABuIqhJdx1/00wvgGEyCJdvAOAvXE1MYI4T5FHWRb2V84E/SiRdw09sT+hYIHfGeB9K3g6PZdF9sMrLsJQ2wVGhjMQ= X-Gm-Message-State: AOJu0Yw9UOW+NybJyQas8XnyeFox8DUQdPVdA4aihTeCGnAEPOFFXBmb nlAPpKNwd7lyzjY+52x3Hir2vJNDVMYIhqoQCr1KgbleiRVcofG2s9Z/psmHqzuQULrvpNp1y1/ 5pHma1EbtB7sO4TdsJdehScdtZ8Q= X-Google-Smtp-Source: AGHT+IF9kC5Wp9zzs7+oKfAiCcxaaqg+foUicQrisSOfuT42eA5ldRYQZiyf5EadE84Hg09r4AyXTQSxv2GMcQlSfVU= X-Received: by 2002:a25:a188:0:b0:dc6:2e29:4262 with SMTP id a8-20020a25a188000000b00dc62e294262mr5733924ybi.58.1713065537129; Sat, 13 Apr 2024 20:32:17 -0700 (PDT) MIME-Version: 1.0 References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> <87o7arciop.fsf@neverwas.me> <86a5lxr8nq.fsf@gnu.org> In-Reply-To: <86a5lxr8nq.fsf@gnu.org> From: Javier Olaechea Date: Sat, 13 Apr 2024 22:32:05 -0500 Message-ID: Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command To: Eli Zaretskii Content-Type: multipart/mixed; boundary="000000000000d1693506160626f0" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org, jp@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000d1693506160626f0 Content-Type: multipart/alternative; boundary="000000000000d1693206160626ee" --000000000000d1693206160626ee Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > Thanks. This should have a NEWS entry announcing the new command > Updated the patch to include the NEWS entry. > Also, to accept this contribution, we'd need a copyright assignment > from you. Would you like to start the paperwork for that at this > time? If yes, I will send you the form to fill and the instructions > to go with it. > Yes, please send the form please. --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000d1693206160626ee Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Thanks.=C2=A0 This should have a NEWS entry announcing the new command
<= /blockquote>

Updated the patch to include the NEWS entry= .
=C2=A0
Also, to accept this contribution, we'd need a copyright assignment
from you.=C2=A0 Would you like to start the paperwork for that at this
time?=C2=A0 If yes, I will send you the form to fill and the instructions to go with it.

Yes, please send the form please.

--
"I object to doing things that compute= rs can do." =E2=80=94 Olin Shivers
--000000000000d1693206160626ee-- --000000000000d1693506160626f0 Content-Type: text/x-patch; charset="UTF-8"; name="0001-Add-sqlite-execute-batch-command.patch" Content-Disposition: attachment; filename="0001-Add-sqlite-execute-batch-command.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_luyywwc50 RnJvbSAzOTYzMTNjZDFjYWFhZTcxZWYyMTVhYTlmNTA5YzJhNGYwZTk3NWRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYXZpZXIgT2xhZWNoZWEgPHBpcmF0YUBnbWFpbC5jb20+CkRh dGU6IFN1biwgMzEgTWFyIDIwMjQgMjM6MDc6MTAgLTA1MDAKU3ViamVjdDogW1BBVENIXSBBZGQg c3FsaXRlLWV4ZWN1dGUtYmF0Y2ggY29tbWFuZAoKVGhpcyBjb21tYW5kIGlzIHNpbWlsYXIgdG8g c3FsaXRlLWV4ZWN1dGUgZXhjZXB0IHRoYXQgaXQgZXhlY3V0ZXMKbXVsdGlwbGUgc3RhdGVtZW50 cyBpbiBleGNoYW5nZSBmb3Igbm90IGFjY2VwdGluZyBhbnkgYXJndW1lbnRzLgoKKiBkb2MvbGlz cHJlZi90ZXh0LnRleGkgKERhdGFiYXNlKTogRG9jdW1lbnQgaXQuCiogc3JjL3NxbGl0ZS5jIChG c3FsaXRlX2V4ZWN1dGVfYmF0Y2gpOiBBZGQgc3FsaXRlX2V4ZWN1dGVfYmF0Y2gKY29tbWFuZC4g IEl0IGlzIHNpbWlsYXIgdG8gc3FsaXRlLWV4ZWN1dGUgYnV0IGl0IGV4ZWN1dGVzIGFsbCB0aGUK c3RhdGVtZW50cyBpbiB0aGUgcXVlcnkuICBVbmxpa2Ugc3FsaXRlLWV4ZWN1dGUgdGhlIGNvbW1h bmQgZG9lc24ndCB0YWtlCmFueSBhcmd1bWVudHMgdG8gcGFzcyBkb3duIHRvIHRoZSBzdGF0ZW1l bnRzLgoqIHRlc3Qvc3JjL3NxbGl0ZS10ZXN0cy5lbCAoc3FsaXRlLW11bHRpcGxlLXN0YXRlbWVu dHMpOiBBZGQgc21va2UgdGVzdApmb3Igc3FsaXRlLWV4ZWN1dGUtYmF0Y2guCiogZXRjL05FV1M6 IE1lbnRpb24gbmV3IGNvbW1hbmQgJ3NxbGl0ZS1leGVjdXRlLWJhdGNoJy4KLS0tCiBkb2MvbGlz cHJlZi90ZXh0LnRleGkgICAgfCAgOCArKysrKysrKwogZXRjL05FV1MgICAgICAgICAgICAgICAg IHwgIDYgKysrKysrCiBzcmMvc3FsaXRlLmMgICAgICAgICAgICAgfCAxMiArKysrKysrKysrKysK IHRlc3Qvc3JjL3NxbGl0ZS10ZXN0cy5lbCB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrKysr CiA0IGZpbGVzIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9kb2MvbGlz cHJlZi90ZXh0LnRleGkgYi9kb2MvbGlzcHJlZi90ZXh0LnRleGkKaW5kZXggMGNkNGUyYzYxNGUu LmExNTgwNzg5ZDU4IDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi90ZXh0LnRleGkKKysrIGIvZG9j L2xpc3ByZWYvdGV4dC50ZXhpCkBAIC01NDE0LDYgKzU0MTQsMTQgQEAgRGF0YWJhc2UKIAogQGVu ZCBkZWZ1bgogCitAZGVmdW4gc3FsaXRlLWV4ZWN1dGUtYmF0Y2ggZGIgc3RhdGVtZW50cworRXhl Y3V0ZSB0aGUgQGFjcm9ueW17U1FMfSBAdmFye3N0YXRlbWVudHN9LiAgQHZhcntzdGF0ZW1lbnRz fSBpcyBhCitzdHJpbmcgY29udGFpbmluZyAwIG9yIG1vcmUgQGFjcm9ueW17U1FMfSBzdGF0ZW1l bnRzLiAgVGhpcyBjb21tYW5kCittaWdodCBiZSB1c2VmdWwgd2hlbiB3ZSB3YW50IHRvIGV4ZWN1 dGUgbXVsdGlwbGUgQGFjcm9ueW17RERMfQorc3RhdGVtZW50cy4KKworQGVuZCBkZWZ1bgorCiBA ZGVmdW4gc3FsaXRlLXNlbGVjdCBkYiBxdWVyeSAmb3B0aW9uYWwgdmFsdWVzIHJldHVybi10eXBl CiBTZWxlY3Qgc29tZSBkYXRhIGZyb20gQHZhcntkYn0gYW5kIHJldHVybiB0aGVtLiAgRm9yIGlu c3RhbmNlOgogCmRpZmYgLS1naXQgYS9ldGMvTkVXUyBiL2V0Yy9ORVdTCmluZGV4IDdhNzM4MTUx NzljLi5jMmE0MzQwOGRhMiAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAg LTQyNCw2ICs0MjQsMTIgQEAgVXNlICdUQUInIGluIHRoZSBtaW5pYnVmZmVyIHRvIHNob3cgb3Ig aGlkZSB0aGUgcGFzc3dvcmQuICBMaWtld2lzZSwKIHRoZXJlIGlzIGFuIGljb24gb24gdGhlIG1v ZGUtbGluZSwgd2hpY2ggdG9nZ2xlcyB0aGUgdmlzaWJpbGl0eSBvZiB0aGUKIHBhc3N3b3JkIHdo ZW4gY2xpY2tpbmcgd2l0aCAnbW91c2UtMScuCiAKKyoqIE5ldyBjb21tYW5kICdzcWxpdGUtZXhl Y3V0ZS1iYXRjaCcuCitUaGlzIGNvbW1hbmQgbGV0cyB0aGUgdXNlciBleGVjdXRlIG11bHRpcGxl IFNRTCBjb21tYW5kcyBpbiBvbmUKK2NvbW1hbmQuIEl0IGlzIHVzZWZ1bCB3aGVuIHRoZSB1c2Vy IHdhbnRzIHRvIGV2YWx1YXRlIGFuIGVudGlyZSBTUUwKK2ZpbGUuCisKKysrKwogDAogKiBFZGl0 aW5nIENoYW5nZXMgaW4gRW1hY3MgMzAuMQogCmRpZmYgLS1naXQgYS9zcmMvc3FsaXRlLmMgYi9z cmMvc3FsaXRlLmMKaW5kZXggMjYxMDgwZGE2NzMuLmM2MDZmYTVmODMxIDEwMDY0NAotLS0gYS9z cmMvc3FsaXRlLmMKKysrIGIvc3JjL3NxbGl0ZS5jCkBAIC02NDYsNiArNjQ2LDE3IEBAIHNxbGl0 ZV9leGVjIChzcWxpdGUzICpzZGIsIGNvbnN0IGNoYXIgKnF1ZXJ5KQogICByZXR1cm4gUXQ7CiB9 CiAKK0RFRlVOICgic3FsaXRlLWV4ZWN1dGUtYmF0Y2giLCBGc3FsaXRlX2V4ZWN1dGVfYmF0Y2gs IFNzcWxpdGVfZXhlY3V0ZV9iYXRjaCwgMiwgMiwgMCwKKyAgICAgICBkb2M6IC8qIEV4ZWN1dGUg bXVsdGlwbGUgU1FMIHN0YXRlbWVudHMgaW4gREIuCitRdWVyeSBpcyBhIHN0cmluZyBjb250YWlu aW5nIDAgb3IgbW9yZSBTUUwgc3RhdGVtZW50cy4gICovKQorICAoTGlzcF9PYmplY3QgZGIsIExp c3BfT2JqZWN0IHF1ZXJ5KQoreworICBjaGVja19zcWxpdGUgKGRiLCBmYWxzZSk7CisgIENIRUNL X1NUUklORyAocXVlcnkpOworICBMaXNwX09iamVjdCBlbmNvZGVkID0gZW5jb2RlX3N0cmluZyhx dWVyeSk7CisgIHJldHVybiBzcWxpdGVfZXhlYyAoWFNRTElURSAoZGIpLT5kYiwgU1NEQVRBIChl bmNvZGVkKSk7Cit9CisKIERFRlVOICgic3FsaXRlLXRyYW5zYWN0aW9uIiwgRnNxbGl0ZV90cmFu c2FjdGlvbiwgU3NxbGl0ZV90cmFuc2FjdGlvbiwgMSwgMSwgMCwKICAgICAgICBkb2M6IC8qIFN0 YXJ0IGEgdHJhbnNhY3Rpb24gaW4gREIuICAqLykKICAgKExpc3BfT2JqZWN0IGRiKQpAQCAtODY2 LDYgKzg3Nyw3IEBAIHN5bXNfb2Zfc3FsaXRlICh2b2lkKQogICBkZWZzdWJyICgmU3NxbGl0ZV9j bG9zZSk7CiAgIGRlZnN1YnIgKCZTc3FsaXRlX2V4ZWN1dGUpOwogICBkZWZzdWJyICgmU3NxbGl0 ZV9zZWxlY3QpOworICBkZWZzdWJyICgmU3NxbGl0ZV9leGVjdXRlX2JhdGNoKTsKICAgZGVmc3Vi ciAoJlNzcWxpdGVfdHJhbnNhY3Rpb24pOwogICBkZWZzdWJyICgmU3NxbGl0ZV9jb21taXQpOwog ICBkZWZzdWJyICgmU3NxbGl0ZV9yb2xsYmFjayk7CmRpZmYgLS1naXQgYS90ZXN0L3NyYy9zcWxp dGUtdGVzdHMuZWwgYi90ZXN0L3NyYy9zcWxpdGUtdGVzdHMuZWwKaW5kZXggYTEwZGNhOWEwYzku LmU4N2E1ZmM3N2IxIDEwMDY0NAotLS0gYS90ZXN0L3NyYy9zcWxpdGUtdGVzdHMuZWwKKysrIGIv dGVzdC9zcmMvc3FsaXRlLXRlc3RzLmVsCkBAIC0yNjEsNCArMjYxLDMwIEBAIHNxbGl0ZS1yZXR1 cm5pbmcKIAkJICAgICAgICAnKCJKb2UiICJEb2UiKSkKICAgICAgICAgJygoMSAiSm9lIikpKSkp KSkKIAorKGVydC1kZWZ0ZXN0IHNxbGl0ZS1tdWx0aXBsZS1zdGF0ZW1lbnRzICgpCisgIChza2lw LXVubGVzcyAoc3FsaXRlLWF2YWlsYWJsZS1wKSkKKyAgKGxldCAoKGRiIChzcWxpdGUtb3BlbiBu aWwpKQorICAgICAgICAocXVlcnkgKHdpdGgtdGVtcC1idWZmZXIKKyAgICAgICAgICAgICAgICAg KGluc2VydCAiLS0gLSotIHNxbC1wcm9kdWN0OiBzcWxpdGUgLSotCisKKy0tIEkg8J+SmCBlbW9q aXMKKworQ1JFQVRFIFRBQkxFIHNldHRpbmdzICgKKyAgbmFtZSBURVhUIE5PVCBOVUxMLAorICB2 YWx1ZSBURVhULAorICBzZWN0aW9uIFRFWFQgTk9UIE5VTEwsCisgIFBSSU1BUlkgS0VZIChzZWN0 aW9uLCBuYW1lKQorKTsKKworQ1JFQVRFIFRBQkxFIHRhZ3Pwn5OOICgKKyAgbmFtZSBURVhUIFBS SU1BUlkgS0VZIE5PVCBOVUxMCispOworCistLSBDUkVBVEUgVEFCTEUgdG9kb19zdGF0ZXMgKGlk IElOVEVHRVIgUFJJTUFSWSBLRVksIG5hbWUgVEVYVCBOT1QgTlVMTCk7CisiKQorICAgICAgICAg ICAgICAgICAoYnVmZmVyLXN0cmluZykpKSkKKyAgICAoc3FsaXRlLWV4ZWN1dGUtYmF0Y2ggZGIg cXVlcnkpCisgICAgKHNob3VsZCAoZXF1YWwgJygoInNldHRpbmdzIikgKCJ0YWdz8J+TjiIpKQor ICAgICAgICAgICAgICAgICAgIChzcWxpdGUtc2VsZWN0IGRiICJzZWxlY3QgbmFtZSBmcm9tIHNx bGl0ZV9tYXN0ZXIgd2hlcmUgdHlwZSA9ICd0YWJsZScgYW5kIG5hbWUgbm90IGxpa2UgJ3NxbGl0 ZV8lJyBvcmRlciBieSBuYW1lIikpKSkpCisKIDs7OyBzcWxpdGUtdGVzdHMuZWwgZW5kcyBoZXJl Ci0tIAoyLjI5LjIuMTU0Lmc3ZjdlYmUwNTRhCgo= --000000000000d1693506160626f0-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 14 01:52:59 2024 Received: (at 70145) by debbugs.gnu.org; 14 Apr 2024 05:52:59 +0000 Received: from localhost ([127.0.0.1]:34108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvsnS-0007J5-26 for submit@debbugs.gnu.org; Sun, 14 Apr 2024 01:52:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvsnP-0007Ie-BT for 70145@debbugs.gnu.org; Sun, 14 Apr 2024 01:52:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvsn8-0002yx-LM; Sun, 14 Apr 2024 01:52:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bs7P4johcCItUU4BjwOS0nv+yNtMP+8JiZbrNCXYeD4=; b=BlnarS/hLW+Y wsfGq/20F6i7Oka5sPibLDAZ0+FOXQDxBHBS1dUFCeBXh+Ml8XnjAo9WB95nKASF+K/04/a+EkGAg KZEr4ApF4ILNon4nSTUZ7oYZGJPQW0xhLAVRDT5ykrR7xJlEfCS2yT+duCuxNEXF00bB0KG3w2uH5 XzwlNomkwY2kQ8y2INZw40JL5C4LO6bMaSD6THOEylONlZ3j1ZbSEma1i/XiVp1Sx4z+b7L1giDkt ipiWQWFY1ZTJutb9GpCHQFIjBjx4qDBh1eCsr7BEX6PisLcjhIGWKlabqpCQfJcQwv9y2qEQwP3tq 7OyaAaCPhj7bVBCJy1cvxg==; Date: Sun, 14 Apr 2024 08:52:36 +0300 Message-Id: <86bk6co5i3.fsf@gnu.org> From: Eli Zaretskii To: Javier Olaechea In-Reply-To: (message from Javier Olaechea on Sat, 13 Apr 2024 22:32:05 -0500) Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> <87o7arciop.fsf@neverwas.me> <86a5lxr8nq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org, jp@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Javier Olaechea > Date: Sat, 13 Apr 2024 22:32:05 -0500 > Cc: jp@neverwas.me, 70145@debbugs.gnu.org > > Also, to accept this contribution, we'd need a copyright assignment > from you. Would you like to start the paperwork for that at this > time? If yes, I will send you the form to fill and the instructions > to go with it. > > Yes, please send the form please. Form sent off-list. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 04:01:41 2024 Received: (at 70145) by debbugs.gnu.org; 6 Jun 2024 08:01:41 +0000 Received: from localhost ([127.0.0.1]:48839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF845-0005jx-8S for submit@debbugs.gnu.org; Thu, 06 Jun 2024 04:01:41 -0400 Received: from mail-yb1-f181.google.com ([209.85.219.181]:54597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF843-0005jV-Bq for 70145@debbugs.gnu.org; Thu, 06 Jun 2024 04:01:39 -0400 Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-dfab4375f94so798174276.1 for <70145@debbugs.gnu.org>; Thu, 06 Jun 2024 01:01:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717660819; x=1718265619; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=A6fjKPqN+v9lC4Q9EYwjl2GWQ1gkIxoELep2im1tgGg=; b=GxIyXJ5xSGTglmkLUqatgfuyxVC5IiOnrzm48PAmPZoWCo4eJeichji/sJRmZWTgYY WOMyomAxy3vC5nVYt0csZRI69jnQ4BeqkiAcXuBvTF3nsMzaJm7iw4yEkl+zwvx9bPVb meNXWXBxYQzvnP5QqAd7ySGu4H5zdHDtdEuSUwoZfWDf98g28mkkBXPBbHBypeYTj++Z 9tt4CO8n2VeQ5FyZxwCYvRJf8Qx+CQjdKXwSBSX9fTDODBXA1DselpPkLWopYKc1S2Cl +EL195H+DGNZyfSyratTaMXF8ITpzEhNX3iJZlIK4bRtMQEs23c/fcckb3xTsPpq0epa tHsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717660819; x=1718265619; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A6fjKPqN+v9lC4Q9EYwjl2GWQ1gkIxoELep2im1tgGg=; b=jR18x2f57jwwQHwMh7Z6iebXlXg/EyLZRIDIOnyRR9iRUGSiEsu5SioGevRGVaqfWV atzhA1IE28Bo3JGTufw7W20XLVmXVlpdJ69yaWjRJz3u9BobVLB2JaHXjDokfJYbtnIl C+APdFIFqQL4bzbJToOI5zzUa1WvRWaM+LM+OL3umUHh8ZrxqNGqBlOX6pXUWXOG1yrm 6SCtxc/lVt/6mNgIFYewQ0KiieSOfrfulx0ikusJWhGHLMIALGHPXGK3gSws1DbmTnj6 pzzkmxEumuk9SAbGbxIAQ8eTthpWunxYbSJiOfK5AaXC9iHI3/QmaZYGL3wFSiXn54cE 4vpg== X-Forwarded-Encrypted: i=1; AJvYcCU83M7En0LMUwJ7Nj553w6WjGMhn0rDeU4tvt8wxVlMtIPXnZxv/WzJOtpugGZaO5lvAA+w30x2DRXgeb4whBtgk3JCgOI= X-Gm-Message-State: AOJu0YzQrzSNFOzclLSTgYtPjnkgzbtJBWtBnNPWK1DYD9kV430tzAre Wdf6dGmClnOCf0+8FlZRyw5Lfpp+injSzk9ylCzaMJMUtFLZK6WZifbaJUDARWUcH3e7d4q5yaK 447pn9iqi24dhKt+ZEGBuuW3bI2Y= X-Google-Smtp-Source: AGHT+IGihQJ8+7yQTBpGy0he0EXqSENF3Aox0tpbMm7CgE4aAJTXvowesEplyul0ynb8PJDol9jXFFlWnSfWEyIoF3E= X-Received: by 2002:a25:5f42:0:b0:dfa:4de6:6347 with SMTP id 3f1490d57ef6-dfacab30d2fmr4547703276.4.1717660818924; Thu, 06 Jun 2024 01:00:18 -0700 (PDT) MIME-Version: 1.0 References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> <87o7arciop.fsf@neverwas.me> <86a5lxr8nq.fsf@gnu.org> In-Reply-To: From: Javier Olaechea Date: Thu, 6 Jun 2024 08:00:00 +0000 Message-ID: Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command To: Eli Zaretskii Content-Type: multipart/alternative; boundary="000000000000f4ef56061a34128f" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 70145 Cc: 70145@debbugs.gnu.org, jp@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f4ef56061a34128f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Copyright assignment form has been successfully signed --=20 "I object to doing things that computers can do." =E2=80=94 Olin Shivers --000000000000f4ef56061a34128f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Copyright assignment form has been succes= sfully signed

--
"I object to doing thi= ngs that computers can do." =E2=80=94 Olin Shivers
--000000000000f4ef56061a34128f-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 06 06:08:53 2024 Received: (at 70145-done) by debbugs.gnu.org; 6 Jun 2024 10:08:53 +0000 Received: from localhost ([127.0.0.1]:52436 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFA3B-0001hl-6B for submit@debbugs.gnu.org; Thu, 06 Jun 2024 06:08:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sFA37-0001hX-Jl for 70145-done@debbugs.gnu.org; Thu, 06 Jun 2024 06:08:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFA2n-00050g-8i; Thu, 06 Jun 2024 06:08:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Xu4u9xGi5BqZCcjvgWraYzHqHbouLd5ZfXcsX+QlwTk=; b=TraWyWZ6rE/q AbaxBOOCTDuH8nJByrUYJStixPNdn1vI5w8iDD2K4ORY+FZhBadAjjiTfB8itnM4cOCL7JazJVvWm LfcjoJrjNpv2SPD0ZaeSO4TboTiL+LmclBtbX5qz+xLGHgV7luFz1AaicZbysZly5RyP2jRIkveb9 ooVDgO5PFzunAAN3/j2NO0u2pzOjWwURXVXNHxglaF7h8SqMNCxBKaAdJATlIG6XHyNg55Cx3MF+C ZZK/VtccJGl32QKCh7Aiw7G1FD9D1KfwP3sF9wGuwy3nEqgeJfRA4VS5uXcJYXzMW8HvDpO10pMzq 6DDAinTtN8t8m8QMlF310A==; Date: Thu, 06 Jun 2024 13:08:25 +0300 Message-Id: <864ja6idt2.fsf@gnu.org> From: Eli Zaretskii To: Javier Olaechea In-Reply-To: (message from Javier Olaechea on Sat, 13 Apr 2024 22:32:05 -0500) Subject: Re: bug#70145: [PATCH] Add sqlite-execute-batch command References: <86bk6rag67.fsf@gnu.org> <864jcja91a.fsf@gnu.org> <87o7arciop.fsf@neverwas.me> <86a5lxr8nq.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70145-done Cc: 70145-done@debbugs.gnu.org, jp@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Javier Olaechea > Date: Sat, 13 Apr 2024 22:32:05 -0500 > Cc: jp@neverwas.me, 70145@debbugs.gnu.org > > Thanks. This should have a NEWS entry announcing the new command > > Updated the patch to include the NEWS entry. > > Also, to accept this contribution, we'd need a copyright assignment > from you. Would you like to start the paperwork for that at this > time? If yes, I will send you the form to fill and the instructions > to go with it. > > Yes, please send the form please. Now that the copyright assignment paperwork is done, I've installed this on the master branch, and I'm closing this bug. Thanks. From unknown Fri Jun 20 07:28:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 04 Jul 2024 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator