GNU bug report logs - #70130
[PATCH] gnu: Add emacs-stgit-2.

Previous Next

Package: guix-patches;

Reported by: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>

Date: Mon, 1 Apr 2024 20:01:02 UTC

Severity: normal

Tags: patch

Done: Cayetano Santos <csantosb <at> inventati.org>

To reply to this bug, email your comments to 70130 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org:
bug#70130; Package guix-patches. (Mon, 01 Apr 2024 20:01:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>:
New bug report received and forwarded. Copy sent to andrew <at> trop.in, cox.katherine.e+guix <at> gmail.com, liliana.prikler <at> gmail.com, guix-patches <at> gnu.org. (Mon, 01 Apr 2024 20:01:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
To: guix-patches <at> gnu.org
Cc: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Subject: [PATCH] gnu: Add emacs-stgit-2.
Date: Mon,  1 Apr 2024 21:54:20 +0200
* gnu/packages/emacs-xyz.scm (emacs-stgit-2): New variable.

Change-Id: I0231d35ae94ce26eb4a9e55f70d78ab33c5f03e3
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 977aa89729..4999048625 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -7552,6 +7552,32 @@ (define-public emacs-standard-dirs
 configuration, cache, and other data.")
     (license license:gpl3+)))
 
+(define-public emacs-stgit-2
+  (package
+    (inherit stgit-2)
+    (name "emacs-stgit")
+    (build-system emacs-build-system)
+    (native-inputs '())
+    (inputs (list stgit-2 git))
+    (arguments
+     (list
+      #:phases #~(modify-phases %standard-phases
+                   (add-after 'unpack 'chdir
+                     (lambda _
+                       (chdir "contrib")))
+                   (add-after 'chdir 'patch-paths
+                     (lambda* (#:key inputs #:allow-other-keys)
+                       (let ((stgit (search-input-file inputs "/bin/stg"))
+                             (git (search-input-file inputs "/bin/git")))
+                         (substitute* "stgit.el"
+                           (("\"stg\"")
+                            (string-append "\"" stgit "\""))
+                           (("\"git\"")
+                            (string-append "\"" git "\"")))))))))
+    (synopsis "Run Stgit within Emacs")
+    (description
+     "This package provides an Emacs-based interface to the Stgit.")))
+
 (define-public emacs-string-inflection
   (package
     (name "emacs-string-inflection")

base-commit: 9e9ec741d0dc5ce58f8d21d31800ff2cafce128f
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#70130; Package guix-patches. (Mon, 15 Apr 2024 18:53:02 GMT) Full text and rfc822 format available.

Message #8 received at 70130 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>, 70130 <at> debbugs.gnu.org,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#70130] [PATCH] gnu: Add emacs-stgit-2.
Date: Mon, 15 Apr 2024 19:52:15 +0100
[Message part 1 (text/plain, inline)]
Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es> writes:

> * gnu/packages/emacs-xyz.scm (emacs-stgit-2): New variable.
>
> Change-Id: I0231d35ae94ce26eb4a9e55f70d78ab33c5f03e3
> ---
>  gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 977aa89729..4999048625 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -7552,6 +7552,32 @@ (define-public emacs-standard-dirs
>  configuration, cache, and other data.")
>      (license license:gpl3+)))
>  
> +(define-public emacs-stgit-2
> +  (package
> +    (inherit stgit-2)

Package inheritance across modules is problomatic [1], which is probably
what's causing the issue with QA/the data service processing this.

You can avoid this by moving the package definition to the
version-control module where stgit-2 is defined.

1: https://guix.gnu.org/en/manual/devel/en/html_node/Cyclic-Module-Dependencies.html
[signature.asc (application/pgp-signature, inline)]

Reply sent to Cayetano Santos <csantosb <at> inventati.org>:
You have taken responsibility. (Mon, 28 Jul 2025 19:17:02 GMT) Full text and rfc822 format available.

Notification sent to Sergio Pastor Pérez <sergio.pastorperez <at> outlook.es>:
bug acknowledged by developer. (Mon, 28 Jul 2025 19:17:02 GMT) Full text and rfc822 format available.

Message #13 received at 70130-done <at> debbugs.gnu.org (full text, mbox):

From: Cayetano Santos <csantosb <at> inventati.org>
To: 70130-done <at> debbugs.gnu.org
Subject: Close
Date: Mon, 28 Jul 2025 21:16:48 +0200
[Message part 1 (text/plain, inline)]
Merged in 82317da3de.

--
Cayetano Santos
.
gpg: CCB8 1842 F9D7 058E CD67 377A BF5C DF4D F6BF 6682
key: meta.sr.ht/~csantosb.pgp
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 16 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.