GNU bug report logs - #70105
30.0.50; Emacs should support EditorConfig out of the box

Previous Next

Full log

Message #26 received at 70105 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>, Eli Zaretskii <eliz <at> gnu.org>
Cc: Jen-Chieh Shen <jcs090218 <at> gmail.com>,
 Björn Bidar <bjorn.bidar <at> thaodan.de>,
 10sr <8slashes+git <at> gmail.com>, 70105 <at> debbugs.gnu.org
Subject: Re: bug#70105: 30.0.50;
 Emacs should support EditorConfig out of the box
Date: Sun, 9 Jun 2024 04:49:31 -0700

Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> I'm hoping this can get into Emacs-30.
> Comments/objections?

Thanks for working on this.

Your patches LGTM with Eli's comments.

>  (defun find-auto-coding (filename size)
> +  ;; FIXME: Shouldn't we use nil rather than "" to mean that there's no file?
> +  ;; FIXME: Clarify what the SOURCE is for in the return value?

BTW, shouldn't this sentence now end with a "."?  :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.