GNU bug report logs - #70098
[PATCH] gnu: gtk: Fix tests on aarch64.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70098: closed ([PATCH] gnu: gtk: Fix tests on aarch64.)
Date: Tue, 02 Apr 2024 18:18:05 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 2 Apr 2024 21:17:18 +0300
with message-id <ZgxLrgaJLdf1K2as <at> 3900XT>
and subject line Re: [bug#70098] [PATCH] gnu: gtk: Fix tests on aarch64.
has caused the debbugs.gnu.org bug report #70098,
regarding [PATCH] gnu: gtk: Fix tests on aarch64.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70098: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70098
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Nikkilä <hello <at> lnikki.la>
To: guix-patches <at> gnu.org
Cc: Leo Nikkilä <hello <at> lnikki.la>
Subject: [PATCH] gnu: gtk: Fix tests on aarch64.
Date: Sun, 31 Mar 2024 06:14:26 +0300

GTK tests are currently failing on aarch64 with:

    36/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing / gl big-checkerboard-scaled-down2                                              FAIL            0.37s   exit status 1
    37/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing+gsk-compare-flipped-gl / gl big-checkerboard-scaled-down2 flipped               FAIL            0.32s   exit status 1
    38/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing+gsk-compare-repeated-gl / gl big-checkerboard-scaled-down2 repeated             FAIL            0.25s   exit status 1
    39/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing+gsk-compare-rotated-gl / gl big-checkerboard-scaled-down2 rotated               FAIL            0.32s   exit status 1
    40/1521 gtk:gsk+gsk-compare+gsk-gl+gsk-compare-gl+wayland_gles_failing+gsk-compare-masked-gl / gl big-checkerboard-scaled-down2 masked                 FAIL            0.26s   exit status 1

Seems other distributions like Debian have disabled these tests due to
similar issues, although I'm unsure why they're also failing with the
X11 test setup.

* gnu/packages/gtk.scm (gtk)[arguments]<#:test-options>: Skip failing
tests like Debian.
---
 gnu/packages/gtk.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 9252315fd2..da56834df6 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -1157,7 +1157,12 @@ (define-public gtk
                             "--no-suite=failing"
                             "--no-suite=flaky"
                             "--no-suite=headless" ; requires mutter…
-                            "--no-suite=gsk-compare-broadway")
+                            "--no-suite=gsk-compare-broadway"
+                            ;; These seem to fail on aarch64, and Debian has
+                            ;; also disabled these, see:
+                            ;; https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050075
+                            "--no-suite=wayland_failing"
+                            "--no-suite=wayland_gles_failing")
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'generate-gdk-pixbuf-loaders-cache-file
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Leo Nikkilä <hello <at> lnikki.la>
Cc: 70098-done <at> debbugs.gnu.org
Subject: Re: [bug#70098] [PATCH] gnu: gtk: Fix tests on aarch64.
Date: Tue, 2 Apr 2024 21:17:18 +0300

[Message part 4 (text/plain, inline)]

I had previously added a phase to manually skip those tests but I like
your way with the configure flag much better.

Thanks! Patch pushed (and my own reverted).

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   רנשלפ םירפא
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.