GNU bug report logs - #70093
Remove unnecessary `image-tests--map-equal'

Previous Next

Full log

Message #42 received at 70093 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 70093 <at> debbugs.gnu.org, da_vid <at> orange.fr, joseph <at> breatheoutbreathe.in
Subject: Re: bug#70093: Remove unnecessary `image-tests--map-equal'
Date: Sat, 01 Mar 2025 11:31:39 +0200

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Fri, 28 Feb 2025 18:59:30 -0800
> Cc: Eli Zaretskii <eliz <at> gnu.org>, 70093 <at> debbugs.gnu.org, da_vid <at> orange.fr
> 
> Joseph Turner <joseph <at> breatheoutbreathe.in> writes:
> 
> > Eli Zaretskii <eliz <at> gnu.org> writes:
> >
> >>> Cc: Eli Zaretskii <eliz <at> gnu.org>, David Ponce <da_vid <at> orange.fr>
> >>> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
> >>> Date: Sat, 30 Mar 2024 12:44:14 -0700
> >>>
> >>> With the resolution of bug#69992, it may be possible to remove the
> >>> `image-tests--map-equal' equality predicate from lisp/image-tests.el.
> >>
> >> Why is it a good idea to remove tests?  If the test tests some of our
> >> code which should work as the test assumes, we should not remove it.
> >
> > Not removing tests, but rather making the tests more strict (if possible).
> >
> >>> Eli and David, would you please apply the attached patch and then run
> >>> the tests to see if we still need to allow for tolerances in
> >>> `image--compute-map-and-original-map'?
> >>
> >> ENOPATCH
> >
> > Sorry about that.  Please check if the tests still pass on your machine
> > when we use `equal' to compare image maps.
> 
> Was this patch installed?

No.

> Should it be?

I'm not sure, and I said so in the discussion.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.