GNU bug report logs - #70093
Remove unnecessary `image-tests--map-equal'

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: 70093 <at> debbugs.gnu.org, da_vid <at> orange.fr
Subject: bug#70093: Remove unnecessary `image-tests--map-equal'
Date: Sun, 31 Mar 2024 10:33:53 +0300

> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
> Cc: 70093 <at> debbugs.gnu.org, da_vid <at> orange.fr
> Date: Sat, 30 Mar 2024 22:32:26 -0700
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Cc: Eli Zaretskii <eliz <at> gnu.org>, David Ponce <da_vid <at> orange.fr>
> >> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
> >> Date: Sat, 30 Mar 2024 12:44:14 -0700
> >>
> >> With the resolution of bug#69992, it may be possible to remove the
> >> `image-tests--map-equal' equality predicate from lisp/image-tests.el.
> >
> > Why is it a good idea to remove tests?  If the test tests some of our
> > code which should work as the test assumes, we should not remove it.
> 
> Not removing tests, but rather making the tests more strict (if possible).
> 
> >> Eli and David, would you please apply the attached patch and then run
> >> the tests to see if we still need to allow for tolerances in
> >> `image--compute-map-and-original-map'?
> >
> > ENOPATCH
> 
> Sorry about that.  Please check if the tests still pass on your machine
> when we use `equal' to compare image maps.

They pass, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.