GNU bug report logs - #70093
Remove unnecessary `image-tests--map-equal'

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Joseph Turner <joseph <at> breatheoutbreathe.in>
Cc: 70093 <at> debbugs.gnu.org, da_vid <at> orange.fr
Subject: bug#70093: Remove unnecessary `image-tests--map-equal'
Date: Sun, 31 Mar 2024 08:10:07 +0300

> Cc: Eli Zaretskii <eliz <at> gnu.org>, David Ponce <da_vid <at> orange.fr>
> From: Joseph Turner <joseph <at> breatheoutbreathe.in>
> Date: Sat, 30 Mar 2024 12:44:14 -0700
> 
> With the resolution of bug#69992, it may be possible to remove the
> `image-tests--map-equal' equality predicate from lisp/image-tests.el.

Why is it a good idea to remove tests?  If the test tests some of our
code which should work as the test assumes, we should not remove it.

> Eli and David, would you please apply the attached patch and then run
> the tests to see if we still need to allow for tolerances in
> `image--compute-map-and-original-map'?

ENOPATCH

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.