GNU bug report logs - #70085
[PATCH] home: services: add newline to XDG_RUNTIME_DIR warning

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Hilton Chain <hako <at> ultrarare.space>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70085: closed ([PATCH] home: services: add newline to
 XDG_RUNTIME_DIR warning)
Date: Sun, 29 Sep 2024 14:43:05 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 29 Sep 2024 22:38:24 +0800
with message-id <87ed52jzj3.wl-hako <at> ultrarare.space>
and subject line Re: [bug#70085] [PATCH] home: services: add newline to XDG_RUNTIME_DIR warning
has caused the debbugs.gnu.org bug report #70085,
regarding [PATCH] home: services: add newline to XDG_RUNTIME_DIR warning
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70085: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70085
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Richard Sent <richard <at> freakingpenguin.com>
To: guix-patches <at> gnu.org
Cc: Richard Sent <richard <at> freakingpenguin.com>
Subject: [PATCH] home: services: add newline to XDG_RUNTIME_DIR warning
Date: Fri, 29 Mar 2024 21:10:35 -0400

* gnu/home/services.scm: Add end-of-text newline to warning printed by
on-first-login script when XDG_RUNTIME_DIR does not exist.

Change-Id: I3bfe2c415f6941fa9a2231ab2a0be53db965053f
---
Without this change, the prompt will be pushed to the side by the
warning message. Other warnings in the repo follow this convention, so
I assume this one should as well.

 gnu/home/services.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/home/services.scm b/gnu/home/services.scm
index b69cd91203..39c9033ad6 100644
--- a/gnu/home/services.scm
+++ b/gnu/home/services.scm
@@ -445,7 +445,7 @@ (define (compute-on-first-login-script _ gexps)
              (warning (G_ "XDG_RUNTIME_DIR doesn't exists, on-first-login script
 won't execute anything.  You can check if xdg runtime directory exists,
 XDG_RUNTIME_DIR variable is set to appropriate value and manually execute the
-script by running '$HOME/.guix-home/on-first-login'"))))))))
+script by running '$HOME/.guix-home/on-first-login'~%"))))))))
 
 (define (on-first-login-script-entry on-first-login)
   "Return, as a monadic value, an entry for the on-first-login script

base-commit: d67e4f0f9b10c7ddac8fb0ca68cbf1d6ad0a6e5d
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Hilton Chain <hako <at> ultrarare.space>
To: Richard Sent <richard <at> freakingpenguin.com>
Cc: Attila Lendvai <attila <at> lendvai.name>, Fabio Natali <me <at> fabionatali.com>,
 70085-done <at> debbugs.gnu.org
Subject: Re: [bug#70085] [PATCH] home: services: add newline to
 XDG_RUNTIME_DIR warning
Date: Sun, 29 Sep 2024 22:38:24 +0800

Hi everyone,

On Sat, 30 Mar 2024 09:10:35 +0800,
Richard Sent wrote:
> 
> * gnu/home/services.scm: Add end-of-text newline to warning printed by
> on-first-login script when XDG_RUNTIME_DIR does not exist.
> 
> Change-Id: I3bfe2c415f6941fa9a2231ab2a0be53db965053f
> ---
> Without this change, the prompt will be pushed to the side by the
> warning message. Other warnings in the repo follow this convention, so
> I assume this one should as well.
> 
>  gnu/home/services.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied as cbf46d2565112180fe7b316b2530293ed2d3acf3, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.