GNU bug report logs - #70068
[PATCH] Don't warn about lexical binding in lisp-interaction-mode

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Fri, 29 Mar 2024 11:33:02 UTC

Severity: normal

Tags: patch

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Mattias EngdegÄrd <mattias.engdegard <at> gmail.com>
Cc: philipk <at> posteo.net, monnier <at> iro.umontreal.ca, 70068 <at> debbugs.gnu.org
Subject: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
Date: Tue, 09 Apr 2024 14:24:42 +0300
> From: Mattias EngdegÄrd <mattias.engdegard <at> gmail.com>
> Date: Tue, 9 Apr 2024 12:45:18 +0200
> Cc: monnier <at> iro.umontreal.ca,
>  philipk <at> posteo.net,
>  70068 <at> debbugs.gnu.org
> 
> 9 apr. 2024 kl. 11.51 skrev Eli Zaretskii <eliz <at> gnu.org>:
> 
> >> Looks like option 3 won. Actually I implemented option 3' which is like 3 but checks the mode instead of lexical-binding, on the grounds that a user who damages his lexical cookie by mistake wants to be reminded of it as soon as possible.
> > 
> > That's not what I see in the changes you installed on master.
> 
> Then I made a mistake, but I don't see where. The intent is to have flymake add the argument
> 
>   --eval (setq bytecomp--inhibit-lexical-cookie-warning t)
> 
> if (derived-mode-p 'lisp-interaction-mode) is true, and then make the warning conditional on that variable. Doesn't it work?

Ah, okay, then it's my misunderstanding: I saw the
(local-variable-p 'lexical-binding) test and thought you
intended to replace that with a mode test.  Apologies.




This bug report was last modified 1 year and 39 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.