GNU bug report logs - #70068
[PATCH] Don't warn about lexical binding in lisp-interaction-mode

Previous Next

Package: emacs;

Reported by: Philip Kaludercic <philipk <at> posteo.net>

Date: Fri, 29 Mar 2024 11:33:02 UTC

Severity: normal

Tags: patch

Done: Philip Kaludercic <philipk <at> posteo.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70068: closed ([PATCH] Don't warn about lexical binding in
 lisp-interaction-mode)
Date: Wed, 03 Apr 2024 08:54:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 03 Apr 2024 08:52:54 +0000
with message-id <87jzle4yl5.fsf <at> posteo.net>
and subject line Re: bug#70068: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
has caused the debbugs.gnu.org bug report #70068,
regarding [PATCH] Don't warn about lexical binding in lisp-interaction-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70068: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70068
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Philip Kaludercic <philipk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Don't warn about lexical binding in lisp-interaction-mode
Date: Fri, 29 Mar 2024 11:31:49 +0000
[Message part 3 (text/plain, inline)]
The main intention here is to avoid underlining the first line in the
*scratch* buffer when flymake is enabled:

[0001-Don't-warn-about-lexical-binding-in-lisp-interacti.patch (text/x-patch, attachment)]
[Message part 5 (text/plain, inline)]
-- 
	Philip Kaludercic on peregrine
[Message part 6 (message/rfc822, inline)]
From: Philip Kaludercic <philipk <at> posteo.net>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 70068-done <at> debbugs.gnu.org
Subject: Re: bug#70068: [PATCH] Don't warn about lexical binding in
 lisp-interaction-mode
Date: Wed, 03 Apr 2024 08:52:54 +0000
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> My thinking was that one never needs to set the variable anyway, since
>>> `lisp-interaction-mode' sets `lexical-binding' anyway.  Alternatively,
>>> one could also modify the patch to check if `lexical-binding' is non-nil?
>>
>> The latter possibility would be better, I think.  Stefan, WDYT?
>
> Testing `lexical-binding` sounds good: the purpose is to encourage people
> to activate `lexical-binding`, rather than encourage them to add a magic cookie.

OK, I have modified by patch and pushed it to master (0197db7b).

>
>         Stefan
>

-- 
	Philip Kaludercic on peregrine


This bug report was last modified 1 year and 39 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.