GNU bug report logs - #70038
29.3.50; Shift up/down in buffer with images on M-x other-window with some fonts

Previous Next

Full log

Message #38 received at 70038 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: martin rudalics <rudalics <at> gmx.at>, r.diaz <at> uam.es, 70038 <at> debbugs.gnu.org,
 rdiaz02 <at> gmail.com, rahguzar <at> zohomail.eu
Subject: Re: bug#70038: 29.3.50; Shift up/down in buffer with images on M-x
 other-window with some fonts
Date: Sat, 06 Apr 2024 22:20:29 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Po Lu, I'm looking at this part of redisplay_window:
>> 
>>    force_start:
>> 
>>     /* Handle case where place to start displaying has been specified,
>>        unless the specified location is outside the accessible range.  */
>>     if (w->force_start)
>>       {
>> 	/* We set this later on if we have to adjust point.  */
>> 	int new_vpos = -1;
>> 
>> 	w->force_start = false;
>> 
>> 	/* The vscroll should be preserved in this case, since
>> 	   `pixel-scroll-precision-mode' must continue working normally
>> 	   when a mini-window is resized.  (bug#55312) */
>> 	if (!w->preserve_vscroll_p || !window_frozen_p (w))  <<<<<<<<<<<<<<<
>> 	  w->vscroll = 0;
>> 
>> 	w->preserve_vscroll_p = false;
>> 	w->window_end_valid = false;
>> 
>> where you added the condition for resetting w->vscroll in commit
>> fd8eaa72a61, and I'm thinking that perhaps the condition should be
>> 
>> 	if (!w->preserve_vscroll_p && !window_frozen_p (w))
>> 
>> instead?  If not, can you explain why we use OR and not AND there?

I think you are correct.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.