GNU bug report logs - #70036
30.0.50; Move file-truename to the C level

Previous Next

Package: emacs;

Reported by: Theodor Thornhill <theo <at> thornhill.no>

Date: Wed, 27 Mar 2024 19:10:02 UTC

Severity: normal

Found in version 30.0.50

Full log


View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: João Távora <joaotavora <at> gmail.com>
Cc: felician.nemeth <at> gmail.com, 70036 <at> debbugs.gnu.org, theo <at> thornhill.no
Subject: bug#70036: a fix that
Date: Thu, 18 Apr 2024 19:24:06 +0300
> From: João Távora <joaotavora <at> gmail.com>
> Date: Thu, 18 Apr 2024 17:12:34 +0100
> Cc: theo <at> thornhill.no, felician.nemeth <at> gmail.com, 70036 <at> debbugs.gnu.org
> 
> > Profiles can mislead and they can lie.
> 
> Theo's profiles attached to this issue were the best I could find.
> If the manner in which they were collected was enough to make a
> decision in a certainway, they should be good enough to make a decision
> in another way.
> 
> But I fully agree we should have a more constrained test case.
> 
> > It is much easier to time the
> > old and the new code doing the same jobs, and compare the times.
> 
> So... that's what I did.

If you timed this code with the likes of benchmark-run, please show
the timings.  Profiles are not the best instrument for this kind of
decisions.

> Do you have a concrete idea of what this "job" is?

No, sorry.  If nothing else comes to mind, I think Theo had such a
scenario.

> Of course.  Let's have Theo do this comparison and perhaps describe
> in more detail the conditions in which he collected his profiles

Sure, it doesn't matter who does the measurements, as long as we have
them.




This bug report was last modified 1 year and 104 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.