GNU bug report logs -
#70036
30.0.50; Move file-truename to the C level
Previous Next
Full log
View this message in rfc822 format
On Thu, Apr 18, 2024 at 5:11 PM Theodor Thornhill <theo <at> thornhill.no> wrote:
> > Profiles can mislead and they can lie. It is much easier to time the
> > old and the new code doing the same jobs, and compare the times.
> >
> >> If so, I think this simpler patch after my sig is all we need, as it
> >> completely clears the profile of any "file-truename". I have reverted
> >> the earlier patch and pushed a patch very similar to the one after my sig.
>
> That's unfortunate.
For you maybe. From my standpoint noone else besides you has complained
about these problems, and I am still Eglot maintainer and must protect
against regressions.
> > This new code should also be timed and compared to the other two
> > versions, before we make the final decision on this.
>
> This is a very unfortunate change. This completely misses the point and
> reverts any perf gains from my previous patch... I think your
> conclusions are too quick, and actions likewise.
>
> I'd argue that long paths are a way more common occurrence than
> symlinking, and the places you touched in your "better way" ignores the
> performance critical parts.
>
> The function you are suggesting isn't the hotspot. Most notable
> publishDiagnostics is, which now is killed again.
Then you should publish details for a reproducible experiment
and we can take it from there.
The experiments I ran were the ones I could gather from a reading
of your profiles. The patch I used was very effective in solving
the performance effects.
João
This bug report was last modified 1 year and 105 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.