Subject: [bug#70031] [PATCH v2 35/65] gnu: nextcloud-client: Use #:test-exclude.

From: Greg Hogan <[email-masked]>
Date: Tue, 22 Oct 2024 18:09:25 +0000

* gnu/packages/sync.scm (nextcloud-client)[arguments]
<#:test-exclude>: Move exclude regex here from 'check phase.
<#:phases>: Move environment setup to 'pre-check and remove 'check
phase.

Change-Id: Ie5f568bbe1153291f53e429afb0026a96e8dbcc5
---
 gnu/packages/sync.scm | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
index af736d0c28..5055c9c698 100644
--- a/gnu/packages/sync.scm
+++ b/gnu/packages/sync.scm
@@ -143,6 +143,7 @@ (define-public nextcloud-client
        (((guix build glib-or-gtk-build-system) #:prefix glib-or-gtk:)
         (guix build qt-build-system)
         (guix build utils))
+       #:test-exclude "SyncXAttrTest"
        #:phases
        (modify-phases %standard-phases
          (add-after 'unpack 'patch-cmake
@@ -159,13 +160,9 @@ (define-public nextcloud-client
                (("@kwidgetsaddons@")
                 (search-input-directory inputs
                                         "/include/KF5/KWidgetsAddons/")))))
-         (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
-             (when tests?
-               (setenv "QT_QPA_PLATFORM" "offscreen")
-               (invoke "ctest" "-E" "SyncXAttrTest"))))
          (add-before 'check 'pre-check
            (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
              ;; Tests write to $HOME.
              (setenv "HOME" (getcwd))
              #t))
-- 
2.46.1