GNU bug report logs - #70029
[PATCH] gnu: Add emacs-eglot-jl.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org>
Cc: 70029 <at> debbugs.gnu.org, Cayetano Santos <csantosb <at> inventati.org>
Subject: Re: [bug#70029] [PATCH] gnu: Add emacs-eglot-jl.
Date: Wed, 27 Mar 2024 16:59:03 +0100

Hello,

Cayetano Santos via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-eglot-jl): New variable.

Thanks.

> +(define-public emacs-eglot-jl
> +  (package
> +    (name "emacs-eglot-jl")
> +    (version "2.3.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/non-Jedi/eglot-jl.git")

Nitpick: I think ".git" suffixes are usually removed.

> +         (commit (string-append "v" version))))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "144q4fj3am165vf1vx2ljlsmpn8vvvs1b95qi3rxlwqskkx0lig3"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs (list emacs-eglot))
> +    (arguments
> +     '(#:include '("^[^/]+.el$"
> +                   "^[^/]+.jl$"
> +                   "^[^/]+.toml$")))

This is a bit verbose, and ignores %default-include variable. I suggest
(using G-expressions just because we can)

(arguments (list #:include #~(cons "\\.(jl|toml)$" %default-include)))

> +    (home-page "https://github.com/non-Jedi/eglot-jl")
> +    (synopsis "Julia support for eglot")

Nitpick: Julia support for Eglot

> +    (description
> +     "This package adds support for @code{emacs-eglot} to the Julia language.")

Nitpick: ... support for Eglot to the Julia language.

> +    (license:cc-by2.0)))

I think there is a typo here. You mean

  (license license:cc-by2.0)

However, it seems to licensed under CC0 terms.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.