GNU bug report logs - #70023
[PATCH] Add typescript-ts-mode indentation for interface bodies

Previous Next

Package: emacs;

Reported by: Noah Peart <noah.v.peart <at> gmail.com>

Date: Wed, 27 Mar 2024 06:21:02 UTC

Severity: normal

Tags: patch

Fixed in version 29.3

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 70023 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Noah Peart <noah.v.peart <at> gmail.com>
Cc: 70023 <at> debbugs.gnu.org
Subject: Re: bug#70023: [PATCH] Add typescript-ts-mode indentation for
 interface bodies
Date: Thu, 28 Mar 2024 14:11:33 +0100
Noah Peart <noah.v.peart <at> gmail.com> writes:

> Tags: patch
>
> Adds missing indentation for typescript interfaces.
>
> Currently, there is no indentation for property signatures in typescript
> interfaces.
>
> To reproduce, call `M-x (my-test-typescript-indent)`
>
>     (defun my-test-typescript-indent ()
>       (interactive)
>       (typescript-ts-mode)
>       (setq-local typescript-ts-mode-indent-offset 4)
>       (indent-region (point-min) (point-max)))
>
> in buffer with the following typescript code:
>
>     interface Foo {
>     foo: string;   // no matching indent rule
>     bar?: boolean; // no matching indent rule
>     }


Thanks - This looks good to me. Have you contributed to emacs earlier? I
think this could go in regardless as it is a trivial addition, or what,
Eli?

I'll install it on emacs-29 later today if noone cries out :-)

Theo




This bug report was last modified 1 year and 13 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.