GNU bug report logs - #70023
[PATCH] Add typescript-ts-mode indentation for interface bodies

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#70023: closed ([PATCH] Add typescript-ts-mode indentation for
 interface bodies)
Date: Sun, 30 Jun 2024 05:57:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 29 Jun 2024 22:55:42 -0700
with message-id <CADwFkmk8ZdF5a=_6bOemwemhKCktPeyHitZB+Z58U1N_f7ZnHQ <at> mail.gmail.com>
and subject line Re: bug#70023: [PATCH] Add typescript-ts-mode indentation for interface bodies
has caused the debbugs.gnu.org bug report #70023,
regarding [PATCH] Add typescript-ts-mode indentation for interface bodies
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
70023: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=70023
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Noah Peart <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add typescript-ts-mode indentation for interface bodies
Date: Tue, 26 Mar 2024 23:20:18 -0700

[Message part 3 (text/plain, inline)]

Tags: patch


Adds missing indentation for typescript interfaces.

Currently, there is no indentation for property signatures in typescript
interfaces.

To reproduce, call `M-x (my-test-typescript-indent)`

    (defun my-test-typescript-indent ()
      (interactive)
      (typescript-ts-mode)
      (setq-local typescript-ts-mode-indent-offset 4)
      (indent-region (point-min) (point-max)))


in buffer with the following typescript code:

    interface Foo {
    foo: string;   // no matching indent rule
    bar?: boolean; // no matching indent rule
    }


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2024-03-24 built on noah-X580VD
Repository revision: c5de73a95a6ecefe46fe1ac07da8e83032be7f5b
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.4 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 4 (text/html, inline)]

[0001-Add-typescript-ts-mode-indentation-for-interface-bod.patch (text/x-patch, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: Noah Peart <noah.v.peart <at> gmail.com>, 70023-done <at> debbugs.gnu.org
Subject: Re: bug#70023: [PATCH] Add typescript-ts-mode indentation for
 interface bodies
Date: Sat, 29 Jun 2024 22:55:42 -0700

Theodor Thornhill <theo <at> thornhill.no> writes:

> Noah Peart <noah.v.peart <at> gmail.com> writes:
>
>> Tags: patch
>>
>> Adds missing indentation for typescript interfaces.
>>
>> Currently, there is no indentation for property signatures in typescript
>> interfaces.
>>
>> To reproduce, call `M-x (my-test-typescript-indent)`
>>
>>     (defun my-test-typescript-indent ()
>>       (interactive)
>>       (typescript-ts-mode)
>>       (setq-local typescript-ts-mode-indent-offset 4)
>>       (indent-region (point-min) (point-max)))
>>
>
> [...]
>
> Pushed in bcf6dd6e266222a293e359430afdf3a2dc18369c. I also added a test
> confirming the behavior.
>
> As a small aside, this node type was added very recently. Until now we
> had a rule for it in 'object'

I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.