From unknown Fri Jun 20 07:15:02 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#70010 <70010@debbugs.gnu.org> To: bug#70010 <70010@debbugs.gnu.org> Subject: Status: 30.0.50; completion-preview-mode behaves mode-local, but is global Reply-To: bug#70010 <70010@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:15:02 +0000 retitle 70010 30.0.50; completion-preview-mode behaves mode-local, but is g= lobal reassign 70010 emacs submitter 70010 Philip Kaludercic severity 70010 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 11:53:17 2024 Received: (at submit) by debbugs.gnu.org; 26 Mar 2024 15:53:17 +0000 Received: from localhost ([127.0.0.1]:34640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rp96y-00035W-DJ for submit@debbugs.gnu.org; Tue, 26 Mar 2024 11:53:17 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rp96u-000350-US for submit@debbugs.gnu.org; Tue, 26 Mar 2024 11:53:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rp4h2-0006hF-S7 for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2024 07:10:13 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rp4gx-0005t4-PW for bug-gnu-emacs@gnu.org; Tue, 26 Mar 2024 07:10:12 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5CD81240101 for ; Tue, 26 Mar 2024 12:10:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1711451403; bh=SoeCfBzq5OZbYN91fokJOEVhTS2PGmyuR85+BHleRDg=; h=From:To:Subject:OpenPGP:Date:Message-ID:MIME-Version:Content-Type: From; b=l5T0yoF162EFMFuFs64aTiVRDX5W1hVtKc7v8VG/Ivvqm5/SrEjWu7aC5a5QgplmF ymmHK1Y7J5mzWtZ9OK04MqTn2//IDmFmxE4l6HDGFc0sJu+pD8ciJKh/FG/PY447Zu 7vc63qRtW1lQN3JHgzjiIyasqEkcW4NjJNvqIaZFs832+0dBsPg9AWW2Sy6IitLQ7p Ct5yVv7DvprV+dFw24jM0rjW+f9jWBLC2jcwhwu3QcoHOXhXeBGppm1Wfi+O9UUpkh 0bNuSYAw4mqUfWIgy1L5GencEUWK3U/fdttxHCLQq6velUB9UqAHQBeg5UvKAlrks1 hT1APdT3MZJxQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4V3nBy675kz9rxD for ; Tue, 26 Mar 2024 12:10:02 +0100 (CET) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: 30.0.50; completion-preview-mode behaves mode-local, but is global X-Debbugs-Cc: Eshel Yaron OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Tue, 26 Mar 2024 11:10:02 +0000 Message-ID: <87o7b1gsfp.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) I tried to enable `completion-preview-mode' by adding (setopt completion-preview-mode t) in my init, but it had not effect. When I check the implementation, I noticed that it modifies `post-command-hook' locally. I think it would make sense to rename the current `completion-preview-mode' to `completion-preview-local-mode', and then use `define-globalized-minor-mode' to define `completion-preview-mode'. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.41, cairo version 1.18.0) of 2024-03-14 built on peregrine Repository revision: f68765a2ca12362f9e3971c4c743fb3dc9c3ea13 Repository branch: master System Description: Fedora Linux 39 (Workstation Edition) Configured using: 'configure --with-pgtk --with-native-compilation=aot --with-imagemagick' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ IMAGEMAGICK JPEG JSON LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PGTK PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: completion-preview-mode: t rcirc-track-minor-mode: t flyspell-mode: t flymake-mode: t outline-minor-mode: t yas-minor-mode: t repeat-mode: t display-battery-mode: t rcirc-sqlite-log-mode: t display-time-mode: t diff-hl-flydiff-mode: t diff-hl-mode: t winner-mode: t windmove-mode: t electric-pair-mode: t recentf-mode: t save-place-mode: t savehist-mode: t pixel-scroll-precision-mode: t pixel-scroll-mode: t xterm-mouse-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t minibuffer-regexp-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: ~/.config/emacs/site-lisp/.auto-site hides /home/phi/.config/emacs/site-lisp/dot-mode/.auto-site ~/.config/emacs/site-lisp/.auto-site hides /home/phi/.config/emacs/site-lisp/company-coq/.auto-site ~/.config/emacs/site-lisp/.auto-site hides /home/phi/.config/emacs/site-lisp/clang-capf/.auto-site ~/.config/emacs/site-lisp/.auto-site hides /home/phi/.config/emacs/site-lisp/0x0/.auto-site /home/phi/.config/emacs/site-lisp/package-lint/package-lint hides /home/phi/.config/emacs/elpa/package-lint-0.21/package-lint /home/phi/.config/emacs/site-lisp/package-lint/package-lint-flymake hides /home/phi/.config/emacs/elpa/package-lint-0.21/package-lint-flymake /home/phi/.config/emacs/site-lisp/shell-command+/shell-command+ hides /home/phi/.config/emacs/elpa/shell-command+/shell-command+ /home/phi/.config/emacs/site-lisp/shell-command+/shell-command+-tests hides /home/phi/.config/emacs/elpa/shell-command+/shell-command+-tests ~/.config/emacs/site-lisp/.auto-site hides /home/phi/.config/emacs/elpa/site-lisp/.auto-site /home/phi/.config/emacs/elpa/ef-themes-1.6.0/theme-loaddefs hides /home/phi/.config/emacs/elpa/standard-themes-2.0.1/theme-loaddefs /home/phi/.config/emacs/elpa/ef-themes-1.6.0/theme-loaddefs hides /home/phi/.config/emacs/elpa/sweeprolog-0.27.4/theme-loaddefs /home/phi/.config/emacs/site-lisp/vc-backup/vc-backup hides /home/phi/.config/emacs/elpa/vc-backup-1.1.0/vc-backup /home/phi/.config/emacs/elpa/transient-0.5.3/transient hides /home/phi/Source/emacs/lisp/transient /home/phi/.config/emacs/elpa/ef-themes-1.6.0/theme-loaddefs hides /home/phi/Source/emacs/lisp/theme-loaddefs Features: (shadow emacsbug whitespace smerge-mode avy dictionary dictionary-connection url-http url-gw url-cache url-auth eww url-queue mm-url magit-utils crm dash nnselect gnus-search eieio-opt speedbar ezimage dframe eglot external-completion jsonrpc compat ert imenu sml-mode smie thai-util thai-word mule-util cl-print debug backtrace pulse color help-fns bug-reference vc-git find-func typo mailalias smtpmail quail writegood-mode ecomplete flow-fill slime apropos etags fileloop generator xref arc-mode archive-mode hyperspec flymake-cc macrostep-c cmacexp macrostep cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs dired-aux autorevert filenotify gnus-dired mm-archive sort smiley gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg qp gnus-ml char-fold misearch multi-isearch do-at-point hi-lock face-remap disp-table rcirc vc-backup copyright nndraft nnmh utf-7 nnfolder epa-file network-stream nsm gnus-agent gnus-srvr gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig nntp gnus-cache gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message yank-media puny dired-x dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win flyspell ispell checkdoc flymake yasnippet-snippets yasnippet noutline outline init repeat battery dbus xml shell-command+ thingatpt rcirc-sqlite derived time sendmail rfc2047 rfc2045 ietf-drums gnus nnheader gnus-util mail-utils range mm-util mail-prsvr diff-hl-flydiff diff diff-hl log-view pcvs-util vc-dir ewoc vc vc-dispatcher diff-mode hippie-exp winner windmove project finder-inf elec-pair tramp-cache time-stamp recentf tree-widget saveplace tramp-sh tramp trampver tramp-integration files-x tramp-message tramp-compat xdg shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs savehist pixel-scroll cua-base xt-mouse cus-edit pp cus-load wid-edit .auto-site compile text-property-search comint ansi-osc ansi-color ring easy-mmode loaddefs-gen lisp-mnt radix-tree site-lisp setup ada-mode-autoloads agda2-mode-autoloads auctex-autoloads tex-site autocrypt-autoloads avy-autoloads bash-completion-autoloads buffer-env-autoloads debbugs-autoloads diff-hl-autoloads do-at-point-autoloads ef-themes-autoloads ellama-autoloads erlang-autoloads flymake-proselint-autoloads focus-autoloads forth-mode-autoloads geiser-gauche-autoloads geiser-autoloads gnat-compiler-autoloads gnu-apl-mode-autoloads go-mode-autoloads haskell-mode-autoloads htmlize-autoloads llm-autoloads lua-mode-autoloads magit-autoloads git-commit-autoloads magit-section-autoloads dash-autoloads markdown-mode-autoloads package-lint-autoloads proof-general-autoloads proof-site proof-autoloads rcirc-sqlite-autoloads rust-mode-autoloads setup-autoloads shell-command+-autoloads site-lisp-autoloads slime-autoloads macrostep-autoloads sml-mode-autoloads spinner-autoloads standard-themes-autoloads sweeprolog-autoloads transient-autoloads tuareg-autoloads caml-autoloads typo-autoloads uniquify-files-autoloads vc-backup-autoloads vc-fossil-autoloads wisi-autoloads info with-editor-autoloads writegood-mode-autoloads yasnippet-snippets-autoloads yasnippet-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source eieio eieio-core password-cache json map byte-opt comp cl-seq comp-cstr warnings comp-run comp-common rx cl-macs pcase subr-x gv bytecomp byte-compile url-vars cl-extra help-mode icons cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/pgtk-win pgtk-win term/common-win pgtk-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo gtk pgtk multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 1037371 161354) (symbols 48 35127 55) (strings 32 193482 17814) (string-bytes 1 5647670) (vectors 16 97175) (vector-slots 8 2053839 201081) (floats 8 802 7911) (intervals 56 37770 4439) (buffers 984 63)) -- Philip Kaludercic on peregrine From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 15:10:34 2024 Received: (at 70010) by debbugs.gnu.org; 26 Mar 2024 19:10:34 +0000 Received: from localhost ([127.0.0.1]:35054 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpCBt-00077K-SR for submit@debbugs.gnu.org; Tue, 26 Mar 2024 15:10:34 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:59962 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpCBr-000778-50 for 70010@debbugs.gnu.org; Tue, 26 Mar 2024 15:10:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1711480230; bh=2JqozA6KKvcsBor1Amc1wRtjHDD1FRbfmInTHklC6C8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=SvQpm7er/5O14As9yFZ/GFnWk/H84rV4G9XR6/h37n9V/T3OUIaZ9RyzbFlljirh1 EW1KOy7S5KTar7NhjBvp2QQsuFXl9bD8eBoxdk9cnY32S9nfVW9Z5kCNKg146gdwDe p3PaqEVmGkgKrt/gvXN27hHGCz2wqkaudnkVJ0T3VZPf4X7sA4pLMI0+icVUUdtqFP I61VmQ8DeNtSGl62wqnik3DinodTEzEmE4QSNPRHoAoOUCsF8+QQKWgj4UZziyhwmZ HI8dXAxFhKaP3Gk4S2YiJNgyBwoIrM31PH1OHP6gkbFpQf2ob7cmmDgDBIrmg84jq4 HIV3GpYYe4kfg== From: Eshel Yaron To: Philip Kaludercic Subject: Re: bug#70010: 30.0.50; completion-preview-mode behaves mode-local, but is global In-Reply-To: <87o7b1gsfp.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 26 Mar 2024 11:10:02 +0000") References: <87o7b1gsfp.fsf@posteo.net> X-Hashcash: 1:20:240326:philipk@posteo.net::GrRKz88lnWz77Rx7:6B1R X-Hashcash: 1:20:240326:70010@debbugs.gnu.org::RSRy8g5U8Agbtj1J:32oO Date: Tue, 26 Mar 2024 20:10:28 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70010 Cc: 70010@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Philip, Philip Kaludercic writes: > I tried to enable `completion-preview-mode' by adding > > (setopt completion-preview-mode t) > > in my init, but it had not effect. Indeed, it is a minor mode, so one normally enables it by calling the function completion-preview-mode, perhaps interactively via M-x. > When I check the implementation, I noticed that it modifies > `post-command-hook' locally. I think it would make sense to rename > the current `completion-preview-mode' to > `completion-preview-local-mode', and then use > `define-globalized-minor-mode' to define `completion-preview-mode'. We can add a global variant, although IMO the natural scope for completion-preview-mode is per major mode: for some kinds of content you want to have completion preview, and for others you may want it off. Note that a necessary condition for completion-preview-mode to be useful in a certain context is that completion-at-point is useful in that context, since otherwise there's nothing to preview. Therefore, I recommend enabling completion-preview-mode by adding it to major mode hooks, such as prog-mode-hook or comint-mode-hook. Admittedly, if you do want to enable it for all buffers, the major mode hook approach would require adding it to four or five hooks, which is a bit less elegant than enabling a global minor mode once. So I suggest we keep completion-preview-mode local and add a global variant, say, completion-preview-global-mode, for enabling it globally. WDYT? Best, Eshel From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 15:49:31 2024 Received: (at 70010) by debbugs.gnu.org; 26 Mar 2024 19:49:31 +0000 Received: from localhost ([127.0.0.1]:35109 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpCna-0003Uq-Of for submit@debbugs.gnu.org; Tue, 26 Mar 2024 15:49:31 -0400 Received: from mout02.posteo.de ([185.67.36.66]:50821) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpCnX-0003Tf-J6 for 70010@debbugs.gnu.org; Tue, 26 Mar 2024 15:49:29 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 17618240103 for <70010@debbugs.gnu.org>; Tue, 26 Mar 2024 20:49:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1711482561; bh=hc//1Yu+Rub8gvWEl6LYJ0yZzlnbAWtVe+gJUSq904U=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=gjKYVnHcWDloERVXEX4w2maD7p8734nxMkPy1m9krrL/0wdqaWS6fJooZtCQR3HHv TQhIcCexgDJz3GH0q2V6c7dVwkfTZhVAOP5mfMiBHYCMfkEkdOnzHAcS9yHIs6MAg5 TxBSlNiESXkOp/9dHbVmFN8vhZEJpMndPd57mx7bWGWum1010XN+Aqu/D0hj7mN+aj vhV84EejQmD7rTWYDbvLvnSotnjbeEKabMmjGaZB76El51kaN70Lo9RmvlnvCAZRAQ l5TnMVd3n5qTXKPqDBPR9wOaIwu1yYbjq0XDKN66QW9HaWdIwoLq9b4hYhjRqktLPV uiWwwptHD0lkA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4V40k82GrLz6tyQ; Tue, 26 Mar 2024 20:49:20 +0100 (CET) From: Philip Kaludercic To: Eshel Yaron Subject: Re: bug#70010: 30.0.50; completion-preview-mode behaves mode-local, but is global In-Reply-To: (Eshel Yaron's message of "Tue, 26 Mar 2024 20:10:28 +0100") References: <87o7b1gsfp.fsf@posteo.net> OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt Date: Tue, 26 Mar 2024 19:49:19 +0000 Message-ID: <875xx8g4e8.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70010 Cc: 70010@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eshel Yaron writes: > Hello Philip, > > Philip Kaludercic writes: > >> I tried to enable `completion-preview-mode' by adding >> >> (setopt completion-preview-mode t) >> >> in my init, but it had not effect. > > Indeed, it is a minor mode, so one normally enables it by calling the > function completion-preview-mode, perhaps interactively via M-x. I enable all minor modes as user options, so I'd disagree that using a function or invoking the command are the only ways to expect a minor mode to be enabled. >> When I check the implementation, I noticed that it modifies >> `post-command-hook' locally. I think it would make sense to rename >> the current `completion-preview-mode' to >> `completion-preview-local-mode', and then use >> `define-globalized-minor-mode' to define `completion-preview-mode'. > > We can add a global variant, although IMO the natural scope for > completion-preview-mode is per major mode: for some kinds of content you > want to have completion preview, and for others you may want it off. > Note that a necessary condition for completion-preview-mode to be useful > in a certain context is that completion-at-point is useful in that > context, since otherwise there's nothing to preview. > > Therefore, I recommend enabling completion-preview-mode by adding it to > major mode hooks, such as prog-mode-hook or comint-mode-hook. > Admittedly, if you do want to enable it for all buffers, the major mode > hook approach would require adding it to four or five hooks, which is a > bit less elegant than enabling a global minor mode once. > > So I suggest we keep completion-preview-mode local and add a global > variant, say, completion-preview-global-mode, for enabling it globally. > WDYT? That seems fine as well. -- Philip Kaludercic on peregrine From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 26 17:49:10 2024 Received: (at 70010) by debbugs.gnu.org; 26 Mar 2024 21:49:10 +0000 Received: from localhost ([127.0.0.1]:35405 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpEfN-00028H-H8 for submit@debbugs.gnu.org; Tue, 26 Mar 2024 17:49:09 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:37926 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpEfL-00027s-9D for 70010@debbugs.gnu.org; Tue, 26 Mar 2024 17:49:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1711489746; bh=X/dIpZ4UcAvpedu8OMuh6R0ocsyAMXoRhIqRVZZHm9k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IysPlxD7dnh7bq/Jil5VT5pO4wpcBDhR3djgmxMSzWXaBpGuuRUrbCVIksGnXcFiA 7BozS24hNVR6qypwRuQXeJRINBciZdymGQ6VACETWwupDX2FXfic6FiV/GVmdWDH8r HAYm00zcU++Ygyxn1q+DewHqRn8ziJRMuipyvrhuTBs83huQoLvMpdMcA0VOnA4rAi L8PzQm1N1A8W+g1m30deG+aqgC1FghFRdBKQPvixrVDWTHq1LSzlQGc9fFNhikR5Bz B/1QUF1Gy9MdPNWR+bmE6hjTUmorWO+I2gSRuvS4zRlOWLgOBx+doYzMrIrgtekPWm V2iOPeO/LAhzg== From: Eshel Yaron To: Philip Kaludercic Subject: Re: bug#70010: 30.0.50; completion-preview-mode behaves mode-local, but is global In-Reply-To: <875xx8g4e8.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 26 Mar 2024 19:49:19 +0000") References: <87o7b1gsfp.fsf@posteo.net> <875xx8g4e8.fsf@posteo.net> X-Hashcash: 1:20:240326:philipk@posteo.net::wsjUOU5V69u7Sz8h:rNb X-Hashcash: 1:20:240326:70010@debbugs.gnu.org::f0DoR05TXF3xLv8W:14P4 Date: Tue, 26 Mar 2024 22:49:04 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70010 Cc: 70010@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Philip Kaludercic writes: > Eshel Yaron writes: > >> Hello Philip, >> >> Philip Kaludercic writes: >> >>> I tried to enable `completion-preview-mode' by adding >>> >>> (setopt completion-preview-mode t) >>> >>> in my init, but it had not effect. >> >> Indeed, it is a minor mode, so one normally enables it by calling the >> function completion-preview-mode, perhaps interactively via M-x. > > I enable all minor modes as user options, so I'd disagree that using a > function or invoking the command are the only ways to expect a minor > mode to be enabled. Fair enough :) >>> When I check the implementation, I noticed that it modifies >>> `post-command-hook' locally. I think it would make sense to rename >>> the current `completion-preview-mode' to >>> `completion-preview-local-mode', and then use >>> `define-globalized-minor-mode' to define `completion-preview-mode'. >> >> We can add a global variant, although IMO the natural scope for >> completion-preview-mode is per major mode: for some kinds of content you >> want to have completion preview, and for others you may want it off. >> Note that a necessary condition for completion-preview-mode to be useful >> in a certain context is that completion-at-point is useful in that >> context, since otherwise there's nothing to preview. >> >> Therefore, I recommend enabling completion-preview-mode by adding it to >> major mode hooks, such as prog-mode-hook or comint-mode-hook. >> Admittedly, if you do want to enable it for all buffers, the major mode >> hook approach would require adding it to four or five hooks, which is a >> bit less elegant than enabling a global minor mode once. >> >> So I suggest we keep completion-preview-mode local and add a global >> variant, say, completion-preview-global-mode, for enabling it globally. >> WDYT? > > That seems fine as well. All right, here's a patch that adds such a global variant. I find the :predicate argument of define-globalized-minor-mode pretty neat, it adds a user option that lets users choose in which major modes the minor mode should take effect, and we can provide a sane default: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-global-minor-mode-completion-preview-global-mode.patch >From caca8078f95b8e2d6c67ada1da6fdb024262c5bc Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Tue, 26 Mar 2024 22:34:51 +0100 Subject: [PATCH] Add global minor mode 'completion-preview-global-mode' This is a global variant of 'completion-preview-mode'. * lisp/completion-preview.el (completion-preview-global-mode): New global minor mode. (Bug#70010) --- lisp/completion-preview.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el index 75386f96429..f8a3c5ac4a2 100644 --- a/lisp/completion-preview.el +++ b/lisp/completion-preview.el @@ -414,5 +414,9 @@ completion-preview-mode (remove-hook 'post-command-hook #'completion-preview--post-command t) (completion-preview-active-mode -1))) +(define-globalized-minor-mode completion-preview-global-mode + completion-preview-mode completion-preview-mode + :predicate '((not minibuffer-mode special-mode) t)) + (provide 'completion-preview) ;;; completion-preview.el ends here -- 2.44.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 03:20:57 2024 Received: (at 70010) by debbugs.gnu.org; 27 Mar 2024 07:20:57 +0000 Received: from localhost ([127.0.0.1]:35636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpNaj-0007AF-6l for submit@debbugs.gnu.org; Wed, 27 Mar 2024 03:20:57 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:43035) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpNaf-00079d-EJ for 70010@debbugs.gnu.org; Wed, 27 Mar 2024 03:20:54 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id 0DC7C20004; Wed, 27 Mar 2024 07:20:45 +0000 (UTC) From: Juri Linkov To: Eshel Yaron via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#70010: 30.0.50; completion-preview-mode behaves mode-local, but is global In-Reply-To: (Eshel Yaron via's message of "Tue, 26 Mar 2024 22:49:04 +0100") Organization: LINKOV.NET References: <87o7b1gsfp.fsf@posteo.net> <875xx8g4e8.fsf@posteo.net> Date: Wed, 27 Mar 2024 09:07:23 +0200 Message-ID: <8634sc5gvo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: juri@linkov.net X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 70010 Cc: Philip Kaludercic , 70010@debbugs.gnu.org, Eshel Yaron X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > +(define-globalized-minor-mode completion-preview-global-mode > + completion-preview-mode completion-preview-mode > + :predicate '((not minibuffer-mode special-mode) t)) The naming convention for globalized minor modes suggests 'global-completion-preview-mode'. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 05:24:19 2024 Received: (at submit) by debbugs.gnu.org; 27 Mar 2024 09:24:19 +0000 Received: from localhost ([127.0.0.1]:35773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpPW6-00072p-Ti for submit@debbugs.gnu.org; Wed, 27 Mar 2024 05:24:19 -0400 Received: from lists.gnu.org ([2001:470:142::17]:45124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpPW5-00072c-UI for submit@debbugs.gnu.org; Wed, 27 Mar 2024 05:24:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpPVz-0001uM-RY for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 05:24:11 -0400 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpPVy-0004Yr-DI for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2024 05:24:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1711531448; bh=aXbhF1DLLrZ30mJ8r/cF4J5KIvB6HliqejBWHeBqxRo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WHHHDfnRzFN7PljjxrMxe0k1eRkG7M5NA096+5hVV/btjhUKObhPOadp9fzL3I69r kq6yw5L/9NTGgRz0igct1EQltT3K/zJtzUEgpeKjXcJIiTuXz9oi2/MnrJ5AvsziZP 8G2H+ghT/AtXgc2dVEatcLYy5GUmz+Q1OhmXu0lEWYZq9OtmGDR7Tc/cOM6ypF3Mp0 LrMJOgxe723pXlJDrbWVOzcOb+H2YOlTJ/6BhOrOq4seD22A6lEbUfMyVFRcjb2gz3 uCUuhw+U6x5efoBCRYvhFFrbuk26kMmmzuD+HOHNXEOw3yRUqaLqGFNUwJ8Xd49MPW 88BFe6GEQKW1g== From: Eshel Yaron To: Juri Linkov Subject: Re: bug#70010: 30.0.50; completion-preview-mode behaves mode-local, but is global In-Reply-To: <8634sc5gvo.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 27 Mar 2024 09:07:23 +0200") References: <87o7b1gsfp.fsf@posteo.net> <875xx8g4e8.fsf@posteo.net> <8634sc5gvo.fsf@mail.linkov.net> X-Hashcash: 1:20:240327:juri@linkov.net::nTR0foMz0e20tdtD:1xQY X-Hashcash: 1:20:240327:bug-gnu-emacs@gnu.org::rrZChlNGZ3Rzu9cF:0Me0 X-Hashcash: 1:20:240327:philipk@posteo.net::4HZDaNjVA1n1AYKb:tqI X-Hashcash: 1:20:240327:70010@debbugs.gnu.org::GivrAMm4X+jtKKzM:0C5n Date: Wed, 27 Mar 2024 10:24:05 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit Cc: "Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 70010@debbugs.gnu.org, Philip Kaludercic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.1 (/) Juri Linkov writes: >> +(define-globalized-minor-mode completion-preview-global-mode >> + completion-preview-mode completion-preview-mode >> + :predicate '((not minibuffer-mode special-mode) t)) > > The naming convention for globalized minor modes suggests > 'global-completion-preview-mode'. Indeed. I'm not a big fan of this convention as it violates the symbol-prefix-as-a-namespace convention, but it does seem prevalent. So if that's all right with everyone, I'll change the name to global-completion-preview-mode and push in a day or two. Best, Eshel From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 08:09:41 2024 Received: (at 70010) by debbugs.gnu.org; 27 Mar 2024 12:09:41 +0000 Received: from localhost ([127.0.0.1]:35912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpS69-00013F-3i for submit@debbugs.gnu.org; Wed, 27 Mar 2024 08:09:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpS63-00012z-Vl for 70010@debbugs.gnu.org; Wed, 27 Mar 2024 08:09:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpS5x-0001c6-2l; Wed, 27 Mar 2024 08:09:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=sAbXGUeEfU7FLej+6bYjENdL0k83Z/cgIU1EqhChLYY=; b=GGLNByOQyT/4 At7yQUm2FkxR4kCqgGLUlNDR+xgkG1LzuWhgFaS4x1jS//f2dpz6gTVET4/AHysCKa0IMts/2NyQa H59WxYjmZK2ePYwpCrDIJ6CdhlZ2yFFwqPU4DrYuk1JQLWvnM4vavgxfpo+lS0qjkgJgJpBk4k+Fr 2YUkLxAdG1RjKGX8QaOJUBJKykXb8hw0DH2VSSd2aGQyZqdlwEhtczf0dJnJ/rlJ8ey3OGE1PZNtl CWFlapQ7oUIDBW5Gaj4AqXJAz1l7wK8cTOQd5fYngB351arZfHyWJqiszdISmWjXAte5vricpMZGI enX3jVsvidpDCVt90s+Tow==; Date: Wed, 27 Mar 2024 14:09:25 +0200 Message-Id: <86msqjj2q2.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#70010: 30.0.50; completion-preview-mode behaves mode-local, but is global References: <87o7b1gsfp.fsf@posteo.net> <875xx8g4e8.fsf@posteo.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 70010 Cc: philipk@posteo.net, 70010@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 70010@debbugs.gnu.org > Date: Tue, 26 Mar 2024 22:49:04 +0100 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > All right, here's a patch that adds such a global variant. Thanks, but please add a NEWS entry announcing this, and also mention this variant in the user manual, where completion-preview-mode is documented. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 27 12:05:38 2024 Received: (at 70010) by debbugs.gnu.org; 27 Mar 2024 16:05:38 +0000 Received: from localhost ([127.0.0.1]:38232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpVmU-0005iC-Bq for submit@debbugs.gnu.org; Wed, 27 Mar 2024 12:05:38 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:58138 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rpVmP-0005i1-5l for 70010@debbugs.gnu.org; Wed, 27 Mar 2024 12:05:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1711555532; bh=5CZleGrZHCnZrH9gm9Mj1wkoT7aIijORTJbAshXEuCQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=I9RWA0I/LJNn9mVc8zcK9ctxHVEPQZlAGr/Kcj3ks9Zb84d1Rv3jinCaD2dRpUlJl rBVdNy6fnr3M6i9IVg7pM5ee47XWr6Mhw7uNdHGj3cTTgj+JcY8wazh+sYvizMTVHj K2Y1OyQIYsnAwCeBUcr72fM0oIX/C9l8LyFJeohqFfTcOud0f4g5g6dj4AF4l2e7DU YaIlWsjYoqXt8P0tB5RmuALBFjmyLQlxVC1cIy5BgAf2k92lMRTojYRFRNwp0o39sM 2dm908SwDTMHGRNXRVaTbJS1SlEIifeBxYrm40W4MCFvbJceD3xrENGM8y1wPYxf/I Sa8qeBoKtiMgA== From: Eshel Yaron To: Eli Zaretskii Subject: Re: bug#70010: 30.0.50; completion-preview-mode behaves mode-local, but is global In-Reply-To: <86msqjj2q2.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 27 Mar 2024 14:09:25 +0200") References: <87o7b1gsfp.fsf@posteo.net> <875xx8g4e8.fsf@posteo.net> <86msqjj2q2.fsf@gnu.org> X-Hashcash: 1:20:240327:eliz@gnu.org::HbghKVuHoIlShJMG:09ii X-Hashcash: 1:20:240327:philipk@posteo.net::WlkC9dNuUFekXU12:suG X-Hashcash: 1:20:240327:70010@debbugs.gnu.org::fmTT7XGLPAjeHzz8:42am Date: Wed, 27 Mar 2024 17:05:29 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70010 Cc: philipk@posteo.net, 70010@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > Thanks, but please add a NEWS entry announcing this, and also mention > this variant in the user manual, where completion-preview-mode is > documented. All right, I'm attaching an updated patch below. Since 'completion-preview-mode' is new in Emacs 30, I extended the existing NEWS entry with a mention of the global variant, instead of adding another entry. I've also renamed the global variant per Juri's comment: --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v2-0001-Add-global-minor-mode-global-completion-preview-m.patch >From 828544ab372d5e7731772b9854732c9373497903 Mon Sep 17 00:00:00 2001 From: Eshel Yaron Date: Tue, 26 Mar 2024 22:34:51 +0100 Subject: [PATCH v2] Add global minor mode 'global-completion-preview-mode' This is a global variant of 'completion-preview-mode'. * lisp/completion-preview.el (global-completion-preview-mode): New global minor mode. * doc/emacs/programs.texi (Symbol Completion): Document it. * etc/NEWS: Announce it. (Bug#70010) --- doc/emacs/programs.texi | 11 +++++++---- etc/NEWS | 2 ++ lisp/completion-preview.el | 4 ++++ 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/doc/emacs/programs.texi b/doc/emacs/programs.texi index 1627e7e6cb7..de28a9f1dd4 100644 --- a/doc/emacs/programs.texi +++ b/doc/emacs/programs.texi @@ -1706,11 +1706,14 @@ Symbol Completion @cindex suggestion preview @cindex Completion Preview mode @findex completion-preview-mode +@findex global-completion-preview-mode Completion Preview mode is a minor mode that shows completion -suggestions as you type. When you enable this mode (with @kbd{M-x -completion-preview-mode}), Emacs automatically displays the -suggested completion for text around point as an in-line preview -right after point; type @key{TAB} to accept the suggestion. +suggestions as you type. You can enable it for the current buffer with +@kbd{M-x completion-preview-mode}, or globally with @w{@kbd{M-x +global-completion-preview-mode}}. When Completion Preview mode is on, +Emacs automatically displays the suggested completion for text around +point as an in-line preview right after point; type @key{TAB} to accept +the suggestion. @node MixedCase Words @section MixedCase Words diff --git a/etc/NEWS b/etc/NEWS index 60fe75fc340..906bf5a9c3c 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1644,6 +1644,8 @@ sexp navigation more intuitive. This minor mode shows you symbol completion suggestions as you type, using an inline preview. New user options in the 'completion-preview' customization group control exactly when Emacs displays this preview. +'completion-preview-mode' is buffer-local, to enable it globally use +'global-completion-preview-mode'. +++ *** New user option 'extended-command-dim-hyphens'. diff --git a/lisp/completion-preview.el b/lisp/completion-preview.el index 75386f96429..c9f3a81b879 100644 --- a/lisp/completion-preview.el +++ b/lisp/completion-preview.el @@ -414,5 +414,9 @@ completion-preview-mode (remove-hook 'post-command-hook #'completion-preview--post-command t) (completion-preview-active-mode -1))) +(define-globalized-minor-mode global-completion-preview-mode + completion-preview-mode completion-preview-mode + :predicate '((not minibuffer-mode special-mode) t)) + (provide 'completion-preview) ;;; completion-preview.el ends here -- 2.44.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 31 03:38:54 2024 Received: (at 70010) by debbugs.gnu.org; 31 Mar 2024 07:38:55 +0000 Received: from localhost ([127.0.0.1]:46508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqpmI-0006rF-9Q for submit@debbugs.gnu.org; Sun, 31 Mar 2024 03:38:54 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:41806 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rqpmD-0006qK-1G; Sun, 31 Mar 2024 03:38:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1711870726; bh=B8k//t3NOAJxUEU7jUcguxGEE2fh26WDe33ONfypw7w=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=hZjUflQlV4V3PbKP3669ykk54O/DDN+QQzyU0l/wS7rknrAluO1n6h/BFwVmpkR8I DEefdabRWWFytWSsIn2o0yokHk661lpAQccvFAobY4EHqSVVu6GBwxkDXXaqymDxvA uoNE2PEaYyywGCTKWdiiilgeYVYbP/Wp2tyW9FECMw2i6uCec4pqTdLtHY/NX5DJAf p2XO36q04CLcWXAno2yGRUq69Zw7ASymxfbRm5Co1XpSsPzjOEjckaH7ICFZFCgBRu fviMpH3IWb5EVTRitflR4jTR38jeYV9uYyddS8pTmUdBPMLpkm8uGyit3VrgSuMEZ9 R+9ap3p3qc53Q== From: Eshel Yaron To: Eli Zaretskii Subject: Re: bug#70010: 30.0.50; completion-preview-mode behaves mode-local, but is global In-Reply-To: (Eshel Yaron's message of "Wed, 27 Mar 2024 17:05:29 +0100") References: <87o7b1gsfp.fsf@posteo.net> <875xx8g4e8.fsf@posteo.net> <86msqjj2q2.fsf@gnu.org> Date: Sun, 31 Mar 2024 09:38:43 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 70010 Cc: philipk@posteo.net, 70010@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 70010 30.1 quit Eshel Yaron writes: > Eli Zaretskii writes: > >> Thanks, but please add a NEWS entry announcing this, and also mention >> this variant in the user manual, where completion-preview-mode is >> documented. > > All right, I'm attaching an updated patch below. Since > 'completion-preview-mode' is new in Emacs 30, I extended the existing > NEWS entry with a mention of the global variant, instead of adding > another entry. I've also renamed the global variant per Juri's comment: Now pushed to master (de8cae30bcf), and closing the bug. Best, Eshel From unknown Fri Jun 20 07:15:02 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 28 Apr 2024 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator