GNU bug report logs - #69992
Minor improvement to image map transformation logic

Previous Next

Package: emacs;

Reported by: Joseph Turner <joseph <at> ushin.org>

Date: Mon, 25 Mar 2024 01:03:01 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69992: closed (Minor improvement to image map transformation
 logic)
Date: Sat, 30 Mar 2024 13:38:04 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 30 Mar 2024 16:37:15 +0300
with message-id <86h6gndeno.fsf <at> gnu.org>
and subject line Re: bug#69992: Minor improvement to image map transformation logic
has caused the debbugs.gnu.org bug report #69992,
regarding Minor improvement to image map transformation logic
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69992: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69992
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Joseph Turner <joseph <at> ushin.org>
To: Emacs Bugs Mailing List <bug-gnu-emacs <at> gnu.org>
Subject: Minor improvement to image map transformation logic
Date: Sun, 24 Mar 2024 18:00:52 -0700
[Message part 3 (text/plain, inline)]
Hello,

This patch is slight simplification/optimization.

Joseph

[0001-copy-tree-just-image-map-not-entire-image.patch (text/x-diff, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: David Ponce <da_vid <at> orange.fr>
Cc: 69992-done <at> debbugs.gnu.org, joseph <at> breatheoutbreathe.in
Subject: Re: bug#69992: Minor improvement to image map transformation logic
Date: Sat, 30 Mar 2024 16:37:15 +0300
> Date: Sat, 30 Mar 2024 13:59:41 +0100
> From: David Ponce <da_vid <at> orange.fr>
> Cc: 69992 <at> debbugs.gnu.org, joseph <at> breatheoutbreathe.in
> 
> Here is my last patch. The only change compared to the previous patch is that
> now the scale factor is correctly calculated based on the size of the image and
> the displayed size. To minimize the performance impact, I saved a call to
> `image-size' by doing the calculation directly in the `image--compute-map' and
> `image--compute-original-map' functions. I did some benchmarks and the
> difference is not significant. The tests still give the same results :-)
> 
> Here is the new change log:

Thanks, installed on master, and closing the bug.


This bug report was last modified 1 year and 56 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.