GNU bug report logs - #6999
saving included diary files does not regenerate the appointment list

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Wed, 8 Sep 2010 12:30:03 UTC

Severity: minor

Tags: patch

Found in version 23.2

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#6999: closed (saving included diary files does not regenerate
 the appointment list)
Date: Wed, 15 Sep 2010 02:48:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 14 Sep 2010 22:49:51 -0400
with message-id <s1wrqnvhyo.fsf <at> fencepost.gnu.org>
and subject line Re: bug#6999: 23.2; [PATCH] appt ignores included diary files
has caused the GNU bug report #6999,
regarding saving included diary files does not regenerate the appointment list
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6999: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6999
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.2; [PATCH] appt ignores included diary files
Date: Wed, 08 Sep 2010 13:31:42 +0100
When the main diary file includes other diary files. File saving in the
included does no appt-check, which means if one adds appointments
directly into the included file, they will not be added by
appt-update-list.

One simple solution is to make appt-update-list do appt-check if major
mode is diary-mode. Then users can open included files in diary mode and
add appointments.

diff --git a/lisp/calendar/appt.el b/lisp/calendar/appt.el
index 3573c95..818fee4 100644
--- a/lisp/calendar/appt.el
+++ b/lisp/calendar/appt.el
@@ -660,7 +660,8 @@ hour and minute parts."
 (defun appt-update-list ()
   "If the current buffer is visiting the diary, update appointments.
 This function is intended for use with `write-file-functions'."
-  (and (string-equal buffer-file-name (expand-file-name diary-file))
+  (and (or (string-equal buffer-file-name (expand-file-name diary-file))
+           (eq major-mode 'diary-mode))
        appt-timer
        (let ((appt-display-diary nil))
          (appt-check t)))


[Message part 3 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 6999-done <at> debbugs.gnu.org
Subject: Re: bug#6999: 23.2; [PATCH] appt ignores included diary files
Date: Tue, 14 Sep 2010 22:49:51 -0400
Fixed in emacs-23.


This bug report was last modified 14 years and 257 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.