GNU bug report logs -
#69960
[PATCH gnome-team 0/2] Fix todoman test failure
Previous Next
Reported by: Vivien Kraus <vivien <at> planete-kraus.eu>
Date: Sat, 23 Mar 2024 10:46:02 UTC
Severity: normal
Tags: patch
Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69960 in the body.
You can then email your comments to 69960 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, guix-patches <at> gnu.org:
bug#69960; Package
guix-patches.
(Sat, 23 Mar 2024 10:46:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Vivien Kraus <vivien <at> planete-kraus.eu>:
New bug report received and forwarded. Copy sent to
liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com, rg <at> raghavgururajan.name, vivien <at> planete-kraus.eu, guix-patches <at> gnu.org.
(Sat, 23 Mar 2024 10:46:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Dear Guix,
The todoman test suite should be run with the "ci" hypothesis profile, so as
to disable deadlines and other nice improvements.
What do you think?
Best regards,
Vivien
Vivien Kraus (2):
gnu: todoman: Update style.
gnu: todoman: Fix tests.
gnu/packages/task-management.scm | 32 +++++++++++++++++---------------
1 file changed, 17 insertions(+), 15 deletions(-)
base-commit: a9951a74a591a9b22ee2d93d8efe0523c6c42c97
--
2.41.0
Information forwarded
to
guix-patches <at> gnu.org:
bug#69960; Package
guix-patches.
(Sat, 23 Mar 2024 10:48:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 69960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/task-management.scm (todoman) [#:phase 'check]: Load the `ci'
hypothesis profile provided by upstream.
Change-Id: I2ea01f8c424a50cd617303f8338f92563e7b0204
---
gnu/packages/task-management.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/task-management.scm b/gnu/packages/task-management.scm
index aac643799f..96df50d747 100644
--- a/gnu/packages/task-management.scm
+++ b/gnu/packages/task-management.scm
@@ -453,7 +453,8 @@ (define-public todoman
(replace 'check
(lambda* (#:key inputs outputs tests? #:allow-other-keys)
(when tests?
- (invoke "pytest" "-vv" "tests" "-k"
+ (invoke "pytest" "--hypothesis-profile=ci"
+ "-vv" "tests" "-k"
(string-append
;; Test expects wrong output string.
"not test_bad_start_date "
--
2.41.0
Information forwarded
to
guix-patches <at> gnu.org:
bug#69960; Package
guix-patches.
(Sat, 23 Mar 2024 10:48:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 69960 <at> debbugs.gnu.org (full text, mbox):
* gnu/packages/task-management.scm (todoman) [arguments]: Convert to list of G-Expressions.
Change-Id: I63faadabb27fa2053e3e01c3e285176bc040c634
---
gnu/packages/task-management.scm | 31 ++++++++++++++++---------------
1 file changed, 16 insertions(+), 15 deletions(-)
diff --git a/gnu/packages/task-management.scm b/gnu/packages/task-management.scm
index f9221f8483..aac643799f 100644
--- a/gnu/packages/task-management.scm
+++ b/gnu/packages/task-management.scm
@@ -443,21 +443,22 @@ (define-public todoman
(base32 "1j2h5cv8wnmw41fpz1ggsgi599qhk184cas9kgd92glj3m4alg6f"))))
(build-system python-build-system)
(arguments
- `(#:phases
- (modify-phases %standard-phases
- (add-after 'unpack 'patch-tests
- (lambda _
- (substitute* '("tests/test_cli.py" "tests/test_formatter.py")
- (("tests\\.helpers") "helpers"))))
- (replace 'check
- (lambda* (#:key inputs outputs tests? #:allow-other-keys)
- (when tests?
- (invoke "pytest" "-vv" "tests" "-k"
- (string-append
- ;; Test expects wrong output string.
- "not test_bad_start_date "
- ;; Unknown failure
- "and not test_default_command_args"))))))))
+ (list
+ #:phases
+ #~(modify-phases %standard-phases
+ (add-after 'unpack 'patch-tests
+ (lambda _
+ (substitute* '("tests/test_cli.py" "tests/test_formatter.py")
+ (("tests\\.helpers") "helpers"))))
+ (replace 'check
+ (lambda* (#:key inputs outputs tests? #:allow-other-keys)
+ (when tests?
+ (invoke "pytest" "-vv" "tests" "-k"
+ (string-append
+ ;; Test expects wrong output string.
+ "not test_bad_start_date "
+ ;; Unknown failure
+ "and not test_default_command_args"))))))))
(native-inputs
(list python-setuptools-scm
python-pytest
--
2.41.0
Information forwarded
to
guix-patches <at> gnu.org:
bug#69960; Package
guix-patches.
(Sat, 23 Mar 2024 10:51:01 GMT)
Full text and
rfc822 format available.
Message #14 received at 69960 <at> debbugs.gnu.org (full text, mbox):
Am Samstag, dem 23.03.2024 um 11:20 +0100 schrieb Vivien Kraus:
> * gnu/packages/task-management.scm (todoman) [arguments]: Convert to
> list of G-Expressions.
>
> Change-Id: I63faadabb27fa2053e3e01c3e285176bc040c634
LGTM
Information forwarded
to
guix-patches <at> gnu.org:
bug#69960; Package
guix-patches.
(Sat, 23 Mar 2024 10:53:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 69960 <at> debbugs.gnu.org (full text, mbox):
Am Samstag, dem 23.03.2024 um 11:21 +0100 schrieb Vivien Kraus:
> * gnu/packages/task-management.scm (todoman) [#:phase 'check]: Load
> the `ci'
> hypothesis profile provided by upstream.
>
> Change-Id: I2ea01f8c424a50cd617303f8338f92563e7b0204
SGTM. If you're okay with it, I'd locally rephrase this to [#:phases]
<check> and push it with that change once it's confirmed by the rest,
WDTY?
Information forwarded
to
guix-patches <at> gnu.org:
bug#69960; Package
guix-patches.
(Sat, 23 Mar 2024 10:54:01 GMT)
Full text and
rfc822 format available.
Message #20 received at 69960 <at> debbugs.gnu.org (full text, mbox):
Le samedi 23 mars 2024 à 11:50 +0100, Liliana Marie Prikler a écrit :
> Am Samstag, dem 23.03.2024 um 11:21 +0100 schrieb Vivien Kraus:
> > * gnu/packages/task-management.scm (todoman) [#:phase 'check]: Load
> > the `ci'
> > hypothesis profile provided by upstream.
> >
> > Change-Id: I2ea01f8c424a50cd617303f8338f92563e7b0204
> SGTM. If you're okay with it, I'd locally rephrase this to
> [#:phases]
> <check> and push it with that change once it's confirmed by the rest,
> WDTY?
Sorry, I always hesitate with this. I will try my best to do the
correct thing in the future, but in the mean time, please go ahead.
Vivien
Reply sent
to
Liliana Marie Prikler <liliana.prikler <at> gmail.com>:
You have taken responsibility.
(Sun, 24 Mar 2024 11:18:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Vivien Kraus <vivien <at> planete-kraus.eu>:
bug acknowledged by developer.
(Sun, 24 Mar 2024 11:18:02 GMT)
Full text and
rfc822 format available.
Message #25 received at 69960-done <at> debbugs.gnu.org (full text, mbox):
Am Samstag, dem 23.03.2024 um 11:52 +0100 schrieb Vivien Kraus:
> Le samedi 23 mars 2024 à 11:50 +0100, Liliana Marie Prikler a écrit :
> > Am Samstag, dem 23.03.2024 um 11:21 +0100 schrieb Vivien Kraus:
> > > * gnu/packages/task-management.scm (todoman) [#:phase 'check]:
> > > Load the `ci' hypothesis profile provided by upstream.
> > >
> > > Change-Id: I2ea01f8c424a50cd617303f8338f92563e7b0204
> > SGTM. If you're okay with it, I'd locally rephrase this to
> > [#:phases] <check> and push it with that change once it's confirmed
> > by the rest,WDTY?
>
> Sorry, I always hesitate with this. I will try my best to do the
> correct thing in the future, but in the mean time, please go ahead.
It's fine – I do fall back to my own writing style a lot, and the
guidelines aren't super close on the details as of yet, so I sometimes
go ahead with edits and hesitate at other times.
Anyway, pushed.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sun, 21 Apr 2024 11:24:18 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 57 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.