GNU bug report logs - #69952
[PATCH] Support pdumping compiled queries by dumping their source

Previous Next

Package: emacs;

Reported by: Sergey Vinokurov <serg.foo <at> gmail.com>

Date: Sat, 23 Mar 2024 03:29:01 UTC

Severity: normal

Tags: patch

Done: Yuan Fu <casouri <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69952: closed ([PATCH] Support pdumping compiled queries by
 dumping their source)
Date: Sat, 20 Jul 2024 21:08:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 20 Jul 2024 14:06:41 -0700
with message-id <9EE7C31D-B575-4936-8141-B4DB189B72AD <at> gmail.com>
and subject line Re: bug#69952: [PATCH] Support pdumping compiled queries by dumping their source
has caused the debbugs.gnu.org bug report #69952,
regarding [PATCH] Support pdumping compiled queries by dumping their source
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69952: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69952
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Sergey Vinokurov <serg.foo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Support pdumping compiled queries by dumping their source
Date: Sat, 23 Mar 2024 03:27:18 +0000
[Message part 3 (text/plain, inline)]
Hello,

This patch aims to allow more things to be dumped. In particular, 
compiled treesitter queries can be easily dumped by storing their source 
so that they will be recompiled on load.

I noticed that in my config compiled quires are created somewhere which 
prevents me dumping with standard Emacs build. But with this patch I can 
dump successfully and not bother finding out who produced the queries.

It seems like there should be no drawbacks in allowing more things to be 
dumped, please correct me if I'm wrong.

Regards,
Sergey
[pdump.patch (text/x-patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: serg.foo <at> gmail.com, Andrea Corallo <acorallo <at> gnu.org>,
 Daniel Colascione <dancol <at> dancol.org>, 69952-done <at> debbugs.gnu.org
Subject: Re: bug#69952: [PATCH] Support pdumping compiled queries by dumping
 their source
Date: Sat, 20 Jul 2024 14:06:41 -0700
Hey, sorry for the delay. It took me several attempts, but it’s actually pretty simple once I understand it. I just pushed the original patch plus my patch to master. Dumping query and loading it back now works pretty well! 

Yuan

> On Jul 20, 2024, at 2:43 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> Ping!
> 
>> Cc: serg.foo <at> gmail.com, acorallo <at> gnu.org, dancol <at> dancol.org,
>> 69952 <at> debbugs.gnu.org
>> Date: Sat, 06 Jul 2024 10:24:32 +0300
>> From: Eli Zaretskii <eliz <at> gnu.org>
>> 
>>> From: Yuan Fu <casouri <at> gmail.com>
>>> Date: Tue, 18 Jun 2024 23:25:45 -0700
>>> Cc: Andrea Corallo <acorallo <at> gnu.org>,
>>> serg.foo <at> gmail.com,
>>> Daniel Colascione <dancol <at> dancol.org>,
>>> 69952 <at> debbugs.gnu.org
>>> 
>>> 
>>> 
>>>> On Jun 15, 2024, at 12:59 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>>>> 
>>>> Ping!  Any progress there?
>>> 
>>> Unfortunately I haven’t make much progress. I’ll report back when I do. Thanks for the reminder!
>> 
>> Any news with this?
>> 
>> 
>> 
>> 



This bug report was last modified 302 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.