GNU bug report logs - #69952
[PATCH] Support pdumping compiled queries by dumping their source

Previous Next

Full log

Message #53 received at 69952 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: serg.foo <at> gmail.com, dancol <at> dancol.org, 69952 <at> debbugs.gnu.org
Subject: Re: bug#69952: [PATCH] Support pdumping compiled queries by dumping
 their source
Date: Sat, 18 May 2024 11:38:11 +0300

Ping!

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sat, 4 May 2024 14:29:06 -0700
> Cc: serg.foo <at> gmail.com,
>  dancol <at> dancol.org,
>  69952 <at> debbugs.gnu.org
> 
> 
> 
> > On May 4, 2024, at 2:39 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> > 
> >> From: Yuan Fu <casouri <at> gmail.com>
> >> Date: Sun, 21 Apr 2024 23:25:10 -0700
> >> Cc: dancol <at> dancol.org,
> >> serg.foo <at> gmail.com,
> >> 69952 <at> debbugs.gnu.org
> >> 
> >>> On Apr 21, 2024, at 11:18 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> >>> 
> >>> 
> >>> We cannot safely signal an error at that point, I think, so just
> >>> keeping the query as a string should do, as it will then signal an
> >>> error at run time when that query is used, is that right?
> >> 
> >> Yes, most likely a function-undefined signal, since all the treesit.c functions like treesit-query-capture or treesit-query-compile will be nonexistent. And usually the Lisp program trying to use the query would check for tree-sitter availability with treesit-available-p before trying to use any tree-sitter functions; so that signal will be usually avoided as well.
> > 
> > Can you suggest such an addition to the patch?
> 
> Let me take a look.
> 
> Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.