GNU bug report logs - #69949
[PATCH gnome-team] gnu: pango@1.90: Disable failing test.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69949: closed ([PATCH gnome-team] gnu: pango <at> 1.90: Disable
 failing test.)
Date: Sun, 24 Mar 2024 10:35:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 24 Mar 2024 10:33:21 +0000
with message-id <87zfunhqam.fsf <at> cbaines.net>
and subject line Re: [bug#69949] [PATCH gnome-team] gnu: pango <at> 1.90: Disable failing test.
has caused the debbugs.gnu.org bug report #69949,
regarding [PATCH gnome-team] gnu: pango <at> 1.90: Disable failing test.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69949: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69949
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Vivien Kraus <vivien <at> planete-kraus.eu>
To: guix-patches <at> gnu.org
Subject: [PATCH gnome-team] gnu: pango <at> 1.90: Disable failing test.
Date: Fri, 22 Mar 2024 22:45:04 +0100

* gnu/packages/gtk.scm (pango-1.90) [snippet]: Disable failing test.

Change-Id: Ib0f6dcd42c9475c4b543400f43836c2f3f8db16f
---
Dear Guix,

I don’t fully understand what’s pango 1.90, but it has an unfixed failing test
and very few users, so maybe disabling the failing test could be OK.

What do you think?

Best regards,

Vivien

 gnu/packages/gtk.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index f43eece4f2..9252315fd2 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -466,7 +466,12 @@ (define-public pango-1.90
                #~(begin
                    (substitute* "pango/pangocairo-font.c"
                      (("cairo_user_font_face_set_render_color_glyph_func")
-                      "cairo_user_font_face_set_render_glyph_func"))))))))
+                      "cairo_user_font_face_set_render_glyph_func"))
+                   ;; Disable a failing test
+                   (substitute* "tests/testmisc.c"
+                     (("\
+g_test_add_func \\(\"/layout/gravity-metrics2\", test_gravity_metrics2\\);")
+                      ""))))))))
 
 (define-public pangox-compat
   (package

base-commit: a9951a74a591a9b22ee2d93d8efe0523c6c42c97
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Vivien Kraus <vivien <at> planete-kraus.eu>
Cc: rg <at> raghavgururajan.name, 69949-done <at> debbugs.gnu.org, guix-patches <at> gnu.org,
 liliana.prikler <at> gmail.com, maxim.cournoyer <at> gmail.com
Subject: Re: [bug#69949] [PATCH gnome-team] gnu: pango <at> 1.90: Disable failing
 test.
Date: Sun, 24 Mar 2024 10:33:21 +0000

[Message part 4 (text/plain, inline)]

Vivien Kraus via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/gtk.scm (pango-1.90) [snippet]: Disable failing test.
>
> Change-Id: Ib0f6dcd42c9475c4b543400f43836c2f3f8db16f
> ---
> Dear Guix,
>
> I don’t fully understand what’s pango 1.90, but it has an unfixed failing test
> and very few users, so maybe disabling the failing test could be OK.
>
> What do you think?

Sounds good, I've pushed this to gnome-team as
d48d0baad16b3acc393f74a9fbea358ce94f1449.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.