GNU bug report logs - #69923
[PATCH] gnu: arcan-sdl: Add missing inputs.

Previous Next

Package: guix-patches;

Reported by: David Elsing <david.elsing <at> posteo.net>

Date: Wed, 20 Mar 2024 21:38:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69923 in the body.
You can then email your comments to 69923 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#69923; Package guix-patches. (Wed, 20 Mar 2024 21:38:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to David Elsing <david.elsing <at> posteo.net>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 20 Mar 2024 21:38:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Elsing <david.elsing <at> posteo.net>
To: skyvine <at> protonmail.com,
	guix-patches <at> gnu.org
Cc: David Elsing <david.elsing <at> posteo.net>
Subject: [PATCH] gnu: arcan-sdl: Add missing inputs.
Date: Wed, 20 Mar 2024 21:34:03 +0000
* gnu/packages/arcan.scm (arcan-sdl)[inputs]: Add glu, libglvnd and mesa.
---
Hello,

I found the problem: The glu, libglvnd and mesa packages are
additionally required, now the build succeeds.

Cheers,
David
 gnu/packages/arcan.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/arcan.scm b/gnu/packages/arcan.scm
index 4ca76edbec..dfc211ae9c 100644
--- a/gnu/packages/arcan.scm
+++ b/gnu/packages/arcan.scm
@@ -171,7 +171,7 @@ (define-public arcan-sdl
     (inputs
      (modify-inputs (package-inputs arcan)
        (delete "libdrm")
-       (prepend sdl)))
+       (prepend glu libglvnd mesa sdl)))
     (arguments
      `(,@(ensure-keyword-arguments
           (package-arguments arcan)
-- 
2.41.0





Information forwarded to guix-patches <at> gnu.org:
bug#69923; Package guix-patches. (Thu, 21 Mar 2024 00:48:01 GMT) Full text and rfc822 format available.

Message #8 received at 69923 <at> debbugs.gnu.org (full text, mbox):

From: Skyler Ferris <skyvine <at> protonmail.com>
To: 69923 <at> debbugs.gnu.org, david.elsing <at> posteo.net
Subject: [PATCH] gnu: arcan-sdl: Add missing inputs.
Date: Thu, 21 Mar 2024 00:46:54 +0000
Awesome! I just checked on my machine with the patch from 69866 and it 
still builds with that patch applied. It'll be great to have another 
package working!

Also, just to clarify, I believe you mentioned on the call that you 
noticed that there was bundled source in this package which needs to be 
addressed. Is that something that you were planning on working on?

Regards,
Skyler





Information forwarded to guix-patches <at> gnu.org:
bug#69923; Package guix-patches. (Thu, 21 Mar 2024 01:37:01 GMT) Full text and rfc822 format available.

Message #11 received at 69923 <at> debbugs.gnu.org (full text, mbox):

From: Ahmad Draidi <a.r.draidi <at> redscript.org>
To: 69923 <at> debbugs.gnu.org
Subject: arcan-sdl
Date: Thu, 21 Mar 2024 05:17:03 +0400
[Message part 1 (text/plain, inline)]
Hello,

I believe arcan-sdl is built as part of the arcan package. I think I was planning to deprecate and remove it later as part of my arcan rework patches, but never got around to it.

Is there a reason to keep it around and not use arcan? Perhaps it should be converted to an output for the main package instead, if there's a good reason?

What do you think?

Thanks,
Ahmad Draidi
[Message part 2 (text/html, inline)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Fri, 22 Mar 2024 10:36:01 GMT) Full text and rfc822 format available.

Notification sent to David Elsing <david.elsing <at> posteo.net>:
bug acknowledged by developer. (Fri, 22 Mar 2024 10:36:02 GMT) Full text and rfc822 format available.

Message #16 received at 69923-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: David Elsing <david.elsing <at> posteo.net>
Cc: 69923-done <at> debbugs.gnu.org, skyvine <at> protonmail.com
Subject: Re: [bug#69923] [PATCH] gnu: arcan-sdl: Add missing inputs.
Date: Fri, 22 Mar 2024 11:34:59 +0100
Hi,

David Elsing <david.elsing <at> posteo.net> skribis:

> * gnu/packages/arcan.scm (arcan-sdl)[inputs]: Add glu, libglvnd and mesa.

Applied, thanks!

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#69923; Package guix-patches. (Fri, 22 Mar 2024 20:25:02 GMT) Full text and rfc822 format available.

Message #19 received at 69923 <at> debbugs.gnu.org (full text, mbox):

From: David Elsing <david.elsing <at> posteo.net>
To: Ahmad Draidi <a.r.draidi <at> redscript.org>
Cc: 69923 <at> debbugs.gnu.org
Subject: Re: arcan-sdl
Date: Fri, 22 Mar 2024 20:23:51 +0000
Hello,

Ahmad Draidi <a.r.draidi <at> redscript.org> writes:

> Is there a reason to keep it around and not use arcan? Perhaps it should be converted to an output for the main package instead, if
> there's a good reason?

I don't know what the motivation was to make a separate package with
SDL1 and just looked why the build failed. The main package is built
with SDL2, maybe that's the reason? Here is the original issue where
arcan was added, you should probably ask them:
https://issues.guix.gnu.org/34189.

Best,
David




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 20 Apr 2024 11:24:10 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 116 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.